Currently the framework uses fairly large "hit slop" values to disambiguate taps from drags/pans. This makes sense on touch devices where the interaction is not very precise, on mice however it can feel as if the UI is lagging. This is immediately noticeable on our infra dashboard, where it takes almost half of a grid square of drag before the actual drag kicks in.
One potential solution is to always use smaller constants depending on whether the interaction is mouse or touch based. The only reasonable choice is to use the pointer device kind and not target platform - same platform can have different input sources. This requires exposing the pointer device kind in a few new places in several of the gesture detectors, and using the enum to compute the correct hit slop from an expanded set of constants.
This almost works, however there are a few places (notably ListViews) which uses the touch hit slop as a default value in scroll physics. It does not seem like it will be easy to disambiguate a user provided scroll physics constant from the default and/or adjust it somehow - this might require significant changes to scroll physics which I have left out of this PR.
This PR does not adjust:
kTouchSlop used in scroll_physics.dart's minFlingDistance
kTouchSlop used in PrimaryPointerGestureRecognizer/LongPressGestureRecognizer
This allows us to rationalize the nullability of some of our APIs.
Prior to this we'd end up in a situation where Container assumed that
getClipPath would be non-null but Decoration was ok with return null.
* 30b829e7e Populates fuchsia node actions in semantics updates. (flutter/engine#20451)
* c2e70109f Roll Skia from 1ee21cdfb6fe to 6763a713f957 (1 revision) (flutter/engine#20982)
* 841401db8 restore FML_DCHECK removed due to a code reviewing error (flutter/engine#20953)
* 367c6dbd1 Don't use GetTaskQueueId() in rasterizer as it breaks Fuchsia (flutter/engine#20983)
* b22a8c69d Let FlutterActivity/Fragment/FragmentActivity have an app bundle path override instead of eager resolving during construction (flutter/engine#20769)
* 0f0ae681e Update test Dart code to pass the latest Dart analyzer rules (flutter/engine#20986)
* d77dd3101 Manual roll of Dart b29f228f62...016e8880f0 (flutter/engine#20967)
* c7b3d5304 Roll Fuchsia Mac SDK from gOI3W1UNU... to EN2ycWLxi... (flutter/engine#20985)
* 6a6986da4 improve sensitivity of BackdropFilter web tests (flutter/engine#20915)
* 9fc9cb2b9 Roll Dart SDK from 016e8880f0ab to 0f0cff3922ad (7 revisions) (flutter/engine#20990)
* 242d52207 [Android R] Sync keyboard animation with view insets vs Android 11/R/API 30 WindowInsetsAnimation (flutter/engine#20843)
* b4e089639 Roll Fuchsia Linux SDK from 81O8Kg_Rw... to A0PKwETay... (flutter/engine#20998)
* d77c4e540 adjust blur radius for HTML to match CanvasKit (flutter/engine#20840)
* 0628492e7 Roll Dart SDK from 0f0cff3922ad to f3a9ca88b664 (1 revision) (flutter/engine#21000)
* d1d848e84 Roll Fuchsia Mac SDK from EN2ycWLxi... to sih5f60Gt... (flutter/engine#20999)
* 5e54c707e Reland: Enable hybrid composition by default on Android (#20722) (flutter/engine#20864)
* 939871799 Roll Skia from db5582b71116 to 44e96bee4b6a (4 revisions) (flutter/engine#20908)
* 5f49a9549 Add auto plugin registration to FlutterFragmentActivity as well (flutter/engine#20865)
* c4c4f341b Wait for first frame before checking layer tree (flutter/engine#20910)
* 0773bf0bd Roll Skia from 44e96bee4b6a to 3913d3e137ed (2 revisions) (flutter/engine#20909)
* 8ec8af75a [windows] Add horizontal scroll support (flutter/engine#20668)
* 1bd9b8e85 Reset Shell::weak_factory_gpu_ on the raster thread (flutter/engine#20869)
* d67923feb Pass text input key events to the EventResponder if they do not yield characters (flutter/engine#20912)
* abe10d102 Roll Dart SDK from 84c3eacc7ba0 to 6eab35f49cbb (2 revisions) (flutter/engine#20913)
* 101316b76 [web] migrate from e2e to integration_test (flutter/engine#20914)
* 1f52ec378 Roll Dart SDK from 6eab35f49cbb to 2a5f37d25453 (1 revision) (flutter/engine#20917)
* 80190580d Default C++ wrapper templates to EncodableValue (flutter/engine#20760)
* 5f3ec38c2 Roll Fuchsia Mac SDK from sI2DAAmSI... to waj2pOhDh... (flutter/engine#20919)
* a65102097 Roll Fuchsia Linux SDK from _SVZn8uN2... to 9tLNFbjA1... (flutter/engine#20920)
* 696c2aafe Roll Skia from 3913d3e137ed to 7b46300fe4ff (4 revisions) (flutter/engine#20924)
* 95f2b7272 Create root isolate asynchronously (flutter/engine#20142)
* 58a620765 Adds fuchsia node roles to accessibility bridge updates. (flutter/engine#20385)
* a76214307 Roll Dart SDK from 2a5f37d25453 to e8e0d5a539fb (3 revisions) (flutter/engine#20928)
* 49d680532 Ensure all images are closed in FlutterImageView (flutter/engine#20842)
* d67bda725 Image.toByteData and Picture.toImage implementations (#3) (flutter/engine#20750)
* 96efe3927 Revert "Adds fuchsia node roles to accessibility bridge updates. (#20385)" (flutter/engine#20936)
* 5585ed990 Revert "Create root isolate asynchronously (#20142)" (flutter/engine#20937)
* f6270c041 Roll Dart SDK from e8e0d5a539fb to b29f228f62e2 (3 revisions) (flutter/engine#20939)
* 15bf1bbf6 [Android R] Integrate DisplayCutouts into viewportMetrics (flutter/engine#20921)
* 615e66801 Clear the GL context only after submitting the frame (flutter/engine#20931)
* ca989b8ae Roll Skia from 7b46300fe4ff to 1338a37a1add (16 revisions) (flutter/engine#20943)
* 8f3f71145 Roll Fuchsia Linux SDK from 9tLNFbjA1... to knpSoAoZq... (flutter/engine#20944)
* 873c00793 Log exception in addition to the stack trace for unhandled exceptions. (flutter/engine#20935)
* d761629cb Roll Skia from 1338a37a1add to 8fa3b4e8cde5 (6 revisions) (flutter/engine#20949)
* f6920dae5 Roll Skia from 8fa3b4e8cde5 to e9a9ad908226 (5 revisions) (flutter/engine#20952)
* 634e499bc Use hint freed specifically for image disposal (flutter/engine#20754)
* c700479db Revert external size changes to Picture (flutter/engine#20950)
* 435379757 Roll Skia from e9a9ad908226 to 3d1d636cd839 (6 revisions) (flutter/engine#20955)
* 80f4481d2 renaming e2e tests to integration (flutter/engine#20954)
* 61e057aa5 Clear GL context before Gr context (flutter/engine#20957)
* f43c3d766 Roll Fuchsia Mac SDK from waj2pOhDh... to 0r88gDzUP... (flutter/engine#20958)
* 5a2db338e Roll Skia from 3d1d636cd839 to 683beccf6776 (13 revisions) (flutter/engine#20961)
* efb339f30 Only clear GL context after changing the thread configuration (flutter/engine#20965)
* 58d5132e0 Roll Fuchsia Linux SDK from knpSoAoZq... to odFvFQV9Z... (flutter/engine#20968)
* 3729fdb79 Roll Skia from 683beccf6776 to a66a9c31a318 (4 revisions) (flutter/engine#20969)
* 40fe7f359 Roll Fuchsia Mac SDK from 0r88gDzUP... to gOI3W1UNU... (flutter/engine#20970)
* e979c29a2 Roll Skia from a66a9c31a318 to be72801f29f9 (1 revision) (flutter/engine#20971)
* 6e8930b26 Roll Skia from be72801f29f9 to f8823b572600 (1 revision) (flutter/engine#20973)
* 68b7b8401 [fuchsia] Send trace events to system tracing on all configurations (flutter/engine#20974)
* 3f05b521b Always set the callback during Rasterizer setup (flutter/engine#20976)
Currently flutter run -d web creates a server with the x-frame-options: SAMEORIGIN added by default (shelf add it's by default). This doesn't allow you to use it inside a frame.
I am trying to build an embedded simulator in vscode and it requires using an iframe.
With this PR I remove the header for debug and profile mode.
Previously, the CPU/GPU measurement using gauge happened after the
driver test is done. Now, the measurement happens within the driver
test. So we need to properly increase the delay and duration to get a
comparable reading as the old gauge measurements.
The flutter tool is currently unable to detect missing permissions in gradle/gradle.bat that would cause a gradle build to fail via process exception. Rather than crashing and exiting, we can display the exception as an error message and tool exit.
While linux/macOS are able to add the +x bit, this is not possible on windows with our current file system/OS API. These crashes represent a substantial amount of crash reporting, but are otherwise not actionable on our end.
* 5e54c707e Reland: Enable hybrid composition by default on Android (#20722) (flutter/engine#20864)
* 939871799 Roll Skia from db5582b71116 to 44e96bee4b6a (4 revisions) (flutter/engine#20908)
* 5f49a9549 Add auto plugin registration to FlutterFragmentActivity as well (flutter/engine#20865)
* c4c4f341b Wait for first frame before checking layer tree (flutter/engine#20910)
* 0773bf0bd Roll Skia from 44e96bee4b6a to 3913d3e137ed (2 revisions) (flutter/engine#20909)
* 8ec8af75a [windows] Add horizontal scroll support (flutter/engine#20668)
* 1bd9b8e85 Reset Shell::weak_factory_gpu_ on the raster thread (flutter/engine#20869)
* d67923feb Pass text input key events to the EventResponder if they do not yield characters (flutter/engine#20912)
* abe10d102 Roll Dart SDK from 84c3eacc7ba0 to 6eab35f49cbb (2 revisions) (flutter/engine#20913)
* 101316b76 [web] migrate from e2e to integration_test (flutter/engine#20914)
* 1f52ec378 Roll Dart SDK from 6eab35f49cbb to 2a5f37d25453 (1 revision) (flutter/engine#20917)
* 80190580d Default C++ wrapper templates to EncodableValue (flutter/engine#20760)
* 5f3ec38c2 Roll Fuchsia Mac SDK from sI2DAAmSI... to waj2pOhDh... (flutter/engine#20919)
* a65102097 Roll Fuchsia Linux SDK from _SVZn8uN2... to 9tLNFbjA1... (flutter/engine#20920)
* 696c2aafe Roll Skia from 3913d3e137ed to 7b46300fe4ff (4 revisions) (flutter/engine#20924)
* 95f2b7272 Create root isolate asynchronously (flutter/engine#20142)
* 58a620765 Adds fuchsia node roles to accessibility bridge updates. (flutter/engine#20385)
* a76214307 Roll Dart SDK from 2a5f37d25453 to e8e0d5a539fb (3 revisions) (flutter/engine#20928)
* 49d680532 Ensure all images are closed in FlutterImageView (flutter/engine#20842)
* d67bda725 Image.toByteData and Picture.toImage implementations (#3) (flutter/engine#20750)
* 96efe3927 Revert "Adds fuchsia node roles to accessibility bridge updates. (#20385)" (flutter/engine#20936)
* 5585ed990 Revert "Create root isolate asynchronously (#20142)" (flutter/engine#20937)
* f6270c041 Roll Dart SDK from e8e0d5a539fb to b29f228f62e2 (3 revisions) (flutter/engine#20939)
* 15bf1bbf6 [Android R] Integrate DisplayCutouts into viewportMetrics (flutter/engine#20921)
* 615e66801 Clear the GL context only after submitting the frame (flutter/engine#20931)
* ca989b8ae Roll Skia from 7b46300fe4ff to 1338a37a1add (16 revisions) (flutter/engine#20943)
* 8f3f71145 Roll Fuchsia Linux SDK from 9tLNFbjA1... to knpSoAoZq... (flutter/engine#20944)
* 873c00793 Log exception in addition to the stack trace for unhandled exceptions. (flutter/engine#20935)
* d761629cb Roll Skia from 1338a37a1add to 8fa3b4e8cde5 (6 revisions) (flutter/engine#20949)
* f6920dae5 Roll Skia from 8fa3b4e8cde5 to e9a9ad908226 (5 revisions) (flutter/engine#20952)
* 634e499bc Use hint freed specifically for image disposal (flutter/engine#20754)
* c700479db Revert external size changes to Picture (flutter/engine#20950)
* 435379757 Roll Skia from e9a9ad908226 to 3d1d636cd839 (6 revisions) (flutter/engine#20955)
* 80f4481d2 renaming e2e tests to integration (flutter/engine#20954)
* 61e057aa5 Clear GL context before Gr context (flutter/engine#20957)
* f43c3d766 Roll Fuchsia Mac SDK from waj2pOhDh... to 0r88gDzUP... (flutter/engine#20958)
* 5a2db338e Roll Skia from 3d1d636cd839 to 683beccf6776 (13 revisions) (flutter/engine#20961)
* efb339f30 Only clear GL context after changing the thread configuration (flutter/engine#20965)
* 58d5132e0 Roll Fuchsia Linux SDK from knpSoAoZq... to odFvFQV9Z... (flutter/engine#20968)
* 3729fdb79 Roll Skia from 683beccf6776 to a66a9c31a318 (4 revisions) (flutter/engine#20969)
* 40fe7f359 Roll Fuchsia Mac SDK from 0r88gDzUP... to gOI3W1UNU... (flutter/engine#20970)
* e979c29a2 Roll Skia from a66a9c31a318 to be72801f29f9 (1 revision) (flutter/engine#20971)
