development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-08-27 20:10:11 +00:00
Code Issues Packages Projects Releases Wiki Activity
37041 commits 766 branches 969 tags 1.3 GiB
Commit graph

37041 commits

This branch
This branch
All branches
Author SHA1 Message Date
Flutter GitHub Bot 260c16cfb8
Marks Linux_pixel_7pro picture_cache_perf__timeline_summary to be unflaky (#134118) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_pixel_7pro picture_cache_perf__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_pixel_7pro%20picture_cache_perf__timeline_summary%22).
This test can be marked as unflaky.
 2023-09-24 04:04:54 +00:00
engine-flutter-autoroll 713272eb61
Roll Flutter Engine from ee27600dfbe2 to 2daf5e7bb249 (1 revision) (#135371) 
ee27600dfb...2daf5e7bb2

2023-09-24 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from de4D1aoqF6LBk18Rd... to W1uZC0_FbXyoCmwJ1... (flutter/engine#46238)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from de4D1aoqF6LB to W1uZC0_FbXyo

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-24 04:03:41 +00:00
Flutter GitHub Bot 82a972bf1a
Marks Mac_ios very_long_picture_scrolling_perf_ios__e2e_summary to be unflaky (#134629) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_ios very_long_picture_scrolling_perf_ios__e2e_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20very_long_picture_scrolling_perf_ios__e2e_summary%22).
This test can be marked as unflaky.
 2023-09-24 03:52:33 +00:00
Flutter GitHub Bot 389d482aac
Marks Mac_ios animated_advanced_blend_perf_ios__timeline_summary to be unflaky (#132630) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_ios animated_advanced_blend_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20animated_advanced_blend_perf_ios__timeline_summary%22).
This test can be marked as unflaky.
 2023-09-24 02:49:37 +00:00
Flutter GitHub Bot 3ba8472a15
Marks Mac_ios static_path_tessellation_perf_ios__timeline_summary to be unflaky (#133127) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_ios static_path_tessellation_perf_ios__timeline_summary"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_ios%20static_path_tessellation_perf_ios__timeline_summary%22).
This test can be marked as unflaky.
 2023-09-24 02:49:35 +00:00
Flutter GitHub Bot 4f5c815559
Marks Linux_android platform_channels_benchmarks to be flaky (#135106) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android platform_channels_benchmarks"
}
-->
Issue link: https://github.com/flutter/flutter/issues/135105
 2023-09-23 23:07:08 +00:00
Flutter GitHub Bot 6d4a5e3d31
Marks Linux_android flutter_gallery__start_up_delayed to be flaky (#134632) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android flutter_gallery__start_up_delayed"
}
-->
Issue link: https://github.com/flutter/flutter/issues/134631
 2023-09-23 23:07:06 +00:00
Flutter GitHub Bot 6d88ade70a
Marks Linux_android opacity_peephole_grid_of_alpha_savelayers_perf__e2e_summary to be flaky (#135119) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android opacity_peephole_grid_of_alpha_savelayers_perf__e2e_summary"
}
-->
Issue link: https://github.com/flutter/flutter/issues/135118
 2023-09-23 23:03:13 +00:00
engine-flutter-autoroll 69004a896c
Roll Flutter Engine from 614859053262 to ee27600dfbe2 (1 revision) (#135364) 
6148590532...ee27600dfb

2023-09-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from PCEkaltiQ-iEKlmEj... to M-fNM9YP2Lpc8Y_Dj... (flutter/engine#46231)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from PCEkaltiQ-iE to M-fNM9YP2Lpc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-23 19:39:27 +00:00
engine-flutter-autoroll 7671627207
Roll Flutter Engine from 564480337eae to 614859053262 (7 revisions) (#135362) 
564480337e...6148590532

2023-09-23 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from M9rDyhmn7VY4iTxzQ... to de4D1aoqF6LBk18Rd... (flutter/engine#46229)
2023-09-23 ychris@google.com [ios] Fix default assets url (flutter/engine#46214)
2023-09-23 skia-flutter-autoroll@skia.org Roll Skia from 15ccdeaba011 to 983f42f4c76b (1 revision) (flutter/engine#46223)
2023-09-23 chillers@google.com Revert "[Impeller] fail if software backend is chosen and Impeller is enabled on iOS" (flutter/engine#46217)
2023-09-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from QcxgV9KlY7j3o3b4j... to PCEkaltiQ-iEKlmEj... (flutter/engine#46221)
2023-09-22 jonahwilliams@google.com [Impeller] dont treat non-rects as rects. (flutter/engine#46218)
2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from e9358f92110c to 15ccdeaba011 (1 revision) (flutter/engine#46216)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from QcxgV9KlY7j3 to PCEkaltiQ-iE
  fuchsia/sdk/core/mac-amd64 from M9rDyhmn7VY4 to de4D1aoqF6LB

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-23 18:55:34 +00:00
engine-flutter-autoroll f5d91854bb
Roll Flutter Engine from e4bfdc1a67de to 564480337eae (4 revisions) (#135341) 
e4bfdc1a67...564480337e

2023-09-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ZyajVWocCHVIuJkzM... to M9rDyhmn7VY4iTxzQ... (flutter/engine#46215)
2023-09-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 4ddff752a6b0 to 692273b46610 (1 revision) (flutter/engine#46212)
2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 78fced84372d to e9358f92110c (4 revisions) (flutter/engine#46211)
2023-09-22 bdero@google.com [Impeller] Incorporate backdrop filters in subpass coverage. (flutter/engine#46130)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from ZyajVWocCHVI to M9rDyhmn7VY4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-23 17:15:28 +00:00
Chris Bracken 6379648b72
[iOS,macOS] Clean up obsolete PlatformView warning (#135040) 
PlatformViews have been supported without a custom engine build on iOS
for quite some time now, and are nearing support for macOS. Adds a link
to the website documentation covering creation of PlatformViews for iOS
and adds a TODO to do the same once the macOS PlatformView documentation
is ready.

Related: https://github.com/flutter/website/issues/9424
 2023-09-22 17:57:21 -07:00
Zachary Anderson 70fd335041
Move some tests from staging to prod (#135333) 
This PR moves tests running on Pixel 7 Pro that use Skia from staging to prod.
 2023-09-23 00:32:16 +00:00
Polina Cherkasova 1d769955b0
Convert relative to absolute import. (#135337) 
Requested here: https://github.com/flutter/flutter/pull/133952#discussion_r1334860858
 2023-09-23 00:30:02 +00:00
engine-flutter-autoroll 57ccf3a594
Roll Flutter Engine from 954ea95be336 to e4bfdc1a67de (1 revision) (#135332) 
954ea95be3...e4bfdc1a67

2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 8a1e6e5844d7 to 78fced84372d (4 revisions) (flutter/engine#46207)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 22:30:22 +00:00
Polina Cherkasova 49e16867a3
TabController should dispatch creation in constructor. (#133952) 2023-09-22 15:27:05 -07:00
Polina Cherkasova c00e9798ff
Fix _paintAvatar in chip.dart to dispose layer. (#135228) 2023-09-22 15:26:52 -07:00
Kostia Sokolovskyi a4e3f93367
Fix memory leak in _MatchesReferenceImage (#135150) 2023-09-22 15:26:25 -07:00
Zachary Anderson 579e196073
Stop reporting new_gen_gc_count to SkiaPerf (#135324) 
Movement in this metric is mostly noise, creates many false alerts, and is neither the cause nor effect of changes in other metrics.
 2023-09-22 21:55:28 +00:00
engine-flutter-autoroll feb6d6ed3d
Roll Flutter Engine from 92be04f73d5d to 954ea95be336 (2 revisions) (#135325) 
92be04f73d...954ea95be3

2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from fe73688dc40f to 8a1e6e5844d7 (1 revision) (flutter/engine#46205)
2023-09-22 jonahwilliams@google.com [Impeller] Reland: construct text frames on UI thread. (flutter/engine#46115)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 21:17:50 +00:00
Polina Cherkasova 99ac6b8164
_RenderChip should not create OpacityLayer without disposing. (#134708) 2023-09-22 13:44:04 -07:00
flutter-pub-roller-bot 9fe6ed15f7
Roll pub packages (#135315) 
This PR was generated by `flutter update-packages --force-upgrade`.
 2023-09-22 19:28:54 +00:00
engine-flutter-autoroll a09b1e43b1
Roll Flutter Engine from ef9ceed1af08 to 92be04f73d5d (3 revisions) (#135319) 
ef9ceed1af...92be04f73d

2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 8beae2053939 to fe73688dc40f (1 revision) (flutter/engine#46202)
2023-09-22 matanlurey@users.noreply.github.com Enable checking headers with Clang Tidy. (flutter/engine#46009)
2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from f346a813ffd4 to 8beae2053939 (5 revisions) (flutter/engine#46200)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 19:25:24 +00:00
Ricardo Amador 76a938bfa6
Reenable 'Linux packages_autoroller' in prod with kms key update (#135316) 
The Github token was recreated and uploaded to GCS. I have verified a passing run with the new key here: 
bc5d1e6662/+/build.proto

And the bot is now generating pull requests: https://github.com/flutter/flutter/pull/135315

*List which issues are fixed by this PR. You must list at least one issue.*
Fixes https://github.com/flutter/flutter/issues/131968

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
 2023-09-22 18:23:14 +00:00
Bartek Pacia dbe0ccd885
Refactor "app plugin loader" Gradle Plugin so it can be applied using the declarative plugins {} block (#127897) 
This PR fixes #125009.
 2023-09-22 16:31:48 +00:00
engine-flutter-autoroll 74c6693170
Roll Packages from d0411e450a8d to 98ebcd3d9c05 (3 revisions) (#135310) 
d0411e450a...98ebcd3d9c

2023-09-22 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from 367f9ea16b to 12fccda598 (2 revisions) (flutter/packages#4976)
2023-09-21 47866232+chunhtai@users.noreply.github.com [go_router] Fixes the GoRouter.goBranch so that it doesn't reset extr… (flutter/packages#4723)
2023-09-21 maurits@vnbskm.nl [webview_flutter_wkwebview] Adds WKWebView implementation to override console log (flutter/packages#4703)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 16:02:02 +00:00
engine-flutter-autoroll 06780cb1d0
Roll Flutter Engine from e97155428ad4 to ef9ceed1af08 (1 revision) (#135308) 
e97155428a...ef9ceed1af

2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from a911bc1352f2 to f346a813ffd4 (1 revision) (flutter/engine#46195)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 15:25:37 +00:00
engine-flutter-autoroll f58163447f
Roll Flutter Engine from 9d06c176cf98 to e97155428ad4 (1 revision) (#135306) 
9d06c176cf...e97155428a

2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from d0f04adbec5c to a911bc1352f2 (1 revision) (flutter/engine#46194)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 14:39:31 +00:00
engine-flutter-autoroll 6502883a96
Roll Flutter Engine from b642e4f4dffa to 9d06c176cf98 (2 revisions) (#135304) 
b642e4f4df...9d06c176cf

2023-09-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 6bde93a6e56f to 4ddff752a6b0 (1 revision) (flutter/engine#46193)
2023-09-22 whesse@google.com Re-add package tar to DEPS (flutter/engine#46190)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 13:48:37 +00:00
engine-flutter-autoroll 99192f83a7
Roll Flutter Engine from 2fa8dec336d0 to b642e4f4dffa (1 revision) (#135295) 
2fa8dec336...b642e4f4df

2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 8752f3ac6e99 to d0f04adbec5c (1 revision) (flutter/engine#46191)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 12:06:02 +00:00
engine-flutter-autoroll 723ba03a44
Roll Flutter Engine from 3d54e44d0654 to 2fa8dec336d0 (1 revision) (#135289) 
3d54e44d06...2fa8dec336

2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 8d9e2cd32ec7 to 8752f3ac6e99 (1 revision) (flutter/engine#46186)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 10:25:26 +00:00
engine-flutter-autoroll 8de97ca1bb
Roll Flutter Engine from 3a2346ade2f2 to 3d54e44d0654 (2 revisions) (#135288) 
3a2346ade2...3d54e44d06

2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from a3480a62e438 to 8d9e2cd32ec7 (1 revision) (flutter/engine#46184)
2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 3ae3bb0d40df to a3480a62e438 (1 revision) (flutter/engine#46183)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 09:14:11 +00:00
Matheus Kirchesch 801a1c9304
Added option to disable [NavigationDrawerDestination]s (#132349) 
This PR adds a new option in the NavigationDrawerDestination api allowing it to be disabled, this is very useful for role based access control, especially in the navigation drawer which is used to lay out all the app destinations

* https://github.com/flutter/flutter/issues/132348
 2023-09-22 08:03:02 +00:00
engine-flutter-autoroll 12d761a828
Roll Flutter Engine from f8e909b88f3f to 3a2346ade2f2 (4 revisions) (#135283) 
f8e909b88f...3a2346ade2

2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 97ec4dbabd05 to 3ae3bb0d40df (1 revision) (flutter/engine#46182)
2023-09-22 leroux_bruno@yahoo.fr [iOS] Disable spelling corrections when auto correction is disabled (flutter/engine#46144)
2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 86454ab4f3de to 97ec4dbabd05 (1 revision) (flutter/engine#46181)
2023-09-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 5d33f4c85b82 to 6bde93a6e56f (1 revision) (flutter/engine#46180)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 07:36:08 +00:00
Qun Cheng 09f7d7c560
Remove extra padding if a dropdown menu entry also has a leading icon (#135004) 
Fixes #131350

This PR is to remove the extra padding in `DropdownMenuEntry` if both the text field and the dropdown menu entry have leading icons.

**After** fix:
<img width="300" alt="Screenshot 2023-09-19 at 4 35 24 PM" src="https://github.com/flutter/flutter/assets/36861262/ed7d92a5-3f96-4106-a03e-09258ea3709f">

**Before** fix:
<img width="300" alt="Screenshot 2023-09-19 at 4 37 58 PM" src="https://github.com/flutter/flutter/assets/36861262/fdbfef54-6c93-48fb-bd64-41fa31dde531">
 2023-09-22 07:34:06 +00:00
engine-flutter-autoroll f388559bdc
Roll Flutter Engine from e0fb071ead2f to f8e909b88f3f (1 revision) (#135281) 
e0fb071ead...f8e909b88f

2023-09-22 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from PXDDhlPyd9sgrWWun... to ZyajVWocCHVIuJkzM... (flutter/engine#46179)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from PXDDhlPyd9sg to ZyajVWocCHVI

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 06:40:50 +00:00
Daco Harkes 2def951924
Reland "Native assets support for Linux" (#135097) 
Reland of #134031. (Reverted in #135069.) Contains the fix for b/301051367 together with cl/567233346.

Support for FFI calls with `@Native external` functions through Native assets on Linux. This enables bundling native code without any build-system boilerplate code.

For more info see:

* https://github.com/flutter/flutter/issues/129757

### Implementation details for Linux.

Mainly follows the design of https://github.com/flutter/flutter/pull/130494.

Some differences are:

* Linux does not support cross compiling or compiling for multiple architectures, so this has not been implemented.
* Linux has no add2app.

The assets copying is done in the install-phase of the CMake build of a flutter app.
CMake requires the native assets folder to exist, so we create it also when the feature is disabled or there are no assets.

### Tests

This PR adds new tests to cover the various use cases.

* packages/flutter_tools/test/general.shard/linux/native_assets_test.dart
  * Unit tests the Linux-specific part of building native assets.

It also extends various existing tests:

* packages/flutter_tools/test/integration.shard/native_assets_test.dart
  * Runs (incl hot reload/hot restart), builds, builds frameworks for Linux and flutter-tester.
 2023-09-22 06:07:06 +00:00
Tomasz Gucio 0377e80de8
Size CupertinoTextSelectionToolbar to children (#133386) 2023-09-22 07:49:06 +02:00
engine-flutter-autoroll 85e52d4363
Roll Flutter Engine from e726798410af to e0fb071ead2f (2 revisions) (#135276) 
e726798410...e0fb071ead

2023-09-22 skia-flutter-autoroll@skia.org Roll Dart SDK from eaeca487c944 to 5d33f4c85b82 (1 revision) (flutter/engine#46176)
2023-09-22 skia-flutter-autoroll@skia.org Roll Skia from 5b2dae1a9b54 to 86454ab4f3de (1 revision) (flutter/engine#46175)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 03:34:27 +00:00
engine-flutter-autoroll 68d5c1760b
Roll Flutter Engine from 2a33fdc4be48 to e726798410af (1 revision) (#135271) 
2a33fdc4be...e726798410

2023-09-22 dnfield@google.com [Impeller] fail if software backend is chosen and Impeller is enabled on iOS (flutter/engine#46124)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 02:14:19 +00:00
engine-flutter-autoroll 5163d81489
Roll Flutter Engine from 7a9409e12fab to 2a33fdc4be48 (3 revisions) (#135270) 
7a9409e12f...2a33fdc4be

2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from 611f08987be3 to 5b2dae1a9b54 (2 revisions) (flutter/engine#46168)
2023-09-21 matanlurey@users.noreply.github.com Revert #46131, don't store `vkImage`, reset `vkComandPool` synchronously (flutter/engine#46166)
2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from a0928a46b9c8 to 611f08987be3 (2 revisions) (flutter/engine#46165)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 01:20:25 +00:00
Kostia Sokolovskyi 9d42ad84ee
Fix memory leak in NestedScrollViewState. (#135248) 2023-09-21 18:20:23 -07:00
engine-flutter-autoroll 5def6f2bab
Roll Flutter Engine from 78c1ad249b57 to 7a9409e12fab (8 revisions) (#135266) 
78c1ad249b...7a9409e12f

2023-09-21 skia-flutter-autoroll@skia.org Roll Skia from 0cf83a86c56d to a0928a46b9c8 (19 revisions) (flutter/engine#46164)
2023-09-21 john@johnmccutchan.com Re-enable HardwareBuffer backed Platform Views on Android >= 29 (flutter/engine#46071)
2023-09-21 jonahwilliams@google.com [Impeller] Use final cmd buffer to present drawable. (flutter/engine#46023)
2023-09-21 matanlurey@users.noreply.github.com More Clang Tidy --fix[es] to header files (flutter/engine#46151)
2023-09-21 dkwingsmt@users.noreply.github.com Reland: Enforce the rule of calling FlutterView.Render (#45300) (flutter/engine#45555)
2023-09-21 yjbanov@google.com Revert "[web] fix clicks on merged semantic nodes (#43620)" (flutter/engine#46067)
2023-09-21 matanlurey@users.noreply.github.com Move `git_repo_tools` and `process_fakes` outside of `clang_tidy`. (flutter/engine#46017)
2023-09-21 godofredoc@google.com Remove linux fuchsia from recipes cq. (flutter/engine#46153)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-09-22 00:00:09 +00:00
Kostia Sokolovskyi ffecedbca4
Cover more test/widgets tests with leak tracking #11 (#135231) 2023-09-21 16:30:32 -07:00
Jacob MacDonald daea6e00bf
remove field override, assign to super field instead (#135165) 
Removes an ignore about overriding fields. Instead we just assign the value to the original field in the super class.

Related to https://github.com/dart-lang/language/issues/3332 (discovered during investigations into the violation of that lint).
 2023-09-21 22:02:12 +00:00
hangyu 528a281a5c
Update alwaysNeedsCompositing in RenderParagraph (#135076) 
fix #111370

According to 

5b47fef613/packages/flutter/lib/src/rendering/box.dart (L1259)
: A [RenderBox] that uses methods on [PaintingContext] that introduce
new
/// layers should override the [alwaysNeedsCompositing] getter and set
it to
/// true.

set [alwaysNeedsCompositing] to true when RenderParagraph introduces
LeaderLayer for selection handles.



## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-09-21 14:53:22 -07:00
LongCatIsLooong 45e4a0e525
Fix a TextSpan test (#135187) 
`TextSpan.toStringDeep()` returns a string that contains a lengthy diagnostic message instead of the plain string.
 2023-09-21 19:41:58 +00:00
Yegor d0664bcd79
a few web tweaks for a11y assessment app (#134479) 
Mostly tweaks for better focus management, namely:

* Use `autofocus` throughout so the a11y focus is transferred to a logical place when overlaid content pops up (screen transitions, dialogs).
* Consolidate "enabled" and "disabled" widgets into the same screen. Otherwise, when only a disabled widget is shown, there's nothing to focus on and the screen reader is lost.
 2023-09-21 19:38:20 +00:00
Zachary Anderson 30a9f99bc8
Send analytics on 'build ios' and 'build ipa' for plist impeller value (#135193) 
This analytics event only records the value of the plist entry on
`build` commands. This will give an idea of the proportion of users who
are disabling Impeller when shipping apps.
 2023-09-21 11:49:29 -07:00
Derek Xu c627dbfbc6
Add --frontend-server-starter-path option to flutter run and flutter test (#135038) 2023-09-21 14:32:35 -04:00