Commit graph

16161 commits

Author SHA1 Message Date
Luiz França 1ea6a38fa7 Adding thumb color customisation functionality to CupertinoSlider (#42563) 2019-10-14 23:31:05 -07:00
engine-flutter-autoroll b5424ebaac
540fc977b Roll src/third_party/skia 7d7aaf46aeb4..858cf233ef71 (1 commits) (flutter/engine#13131) (#42706)
git@github.com:flutter/engine.git/compare/49a8e451b8dd...540fc977bb6b

git log 49a8e451b8dd..540fc977bb6b --no-merges --oneline
2019-10-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia 7d7aaf46aeb4..858cf233ef71 (1 commits) (flutter/engine#13131)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-15 01:21:43 -04:00
Jonah Williams e372641789
Ensure we stop the status when browser connection is complete (#42698) 2019-10-14 21:36:31 -07:00
Yegor 3bc3b323c4
Reland: fix and add painting web tests (#42689) 2019-10-14 21:22:44 -07:00
engine-flutter-autoroll adf9d6f78a
Roll engine 66bf00bca361..49a8e451b8dd (5 commits) (#42702)
git@github.com:flutter/engine.git/compare/66bf00bca361...49a8e451b8dd

git log 66bf00bca361..49a8e451b8dd --no-merges --oneline
2019-10-15 CptBlackPixel Adding deviceId to KeyEventChannel enconding method (flutter/engine#12958)
2019-10-14 47866232+chunhtai@users.noreply.github.com Enable all engine test on windows (flutter/engine#12814)
2019-10-14 devoncarew@google.com add the dart:__interceptors library to the dart sdk (flutter/engine#13125)
2019-10-14 bkonyi@google.com Roll src/third_party/dart 892fcf2c45..70a7ef3f58 (9 commits)
2019-10-14 skia-flutter-autoroll@skia.org Roll src/third_party/skia a7e1b45d9c28..7d7aaf46aeb4 (19 commits) (flutter/engine#13127)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-15 00:13:43 -04:00
Greg Spencer 134ac429cf
Optimize focus operations by caching descendants and ancestors. (#42683)
This optimizes certain paths in the FocusManager, FocusNode, and FocusScopeNode classes in order to fix a regression in stock_animation_open_first_frame_average when I added more focus nodes to the tree to do focus traversal.

Mainly I removed some remaining sync* iterators, and also started caching the computation of descendants and ancestors, since those are iterated over fairly often.

This improves stock_animation_open_first_frame_average by about 2.8% overall (so about half of a 4.9% regression, both averaged over 10 runs).

Addresses #42564
2019-10-14 18:50:38 -07:00
Greg Spencer 6b2cc85546
Disable arrow key focus navigation for text fields (#42533)
This disables the arrow key focus navigation for text fields. This was non-standard behavior for text fields, although it remains useful for other kinds of controls.

Fixes #42259
2019-10-14 18:50:05 -07:00
engine-flutter-autoroll 1d4d63ace1
Roll engine eed171ff3538..66bf00bca361 (44 commits) (#42695)
git@github.com:flutter/engine.git/compare/eed171ff3538...66bf00bca361

git log eed171ff3538..66bf00bca361 --no-merges --oneline
2019-10-14 50856934+nturgut@users.noreply.github.com refactoring chrome_installer (flutter/engine#13122)
2019-10-14 mklim@google.com Fire PlatformViewController FlutterView callbacks (flutter/engine#13015)
2019-10-14 30870216+gaaclarke@users.noreply.github.com iOS Platform View: Fixed overrelease of the observer. (flutter/engine#13093)
2019-10-14 ferhat@gmail.com [web] Add basic color per vertex drawVertices API support (flutter/engine#13066)
2019-10-14 mouad.debbar@gmail.com Support keyboard types on mobile browsers (flutter/engine#13044)
2019-10-14 liyuqian@google.com Change IO thread shader cache strategy (flutter/engine#13121)
2019-10-14 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from _GTls... to xRgq0... (flutter/engine#13115)
2019-10-14 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3838fe3c82b4..a7e1b45d9c28 (1 commits) (flutter/engine#13117)
2019-10-14 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from E3s7G... to Lk7iT... (flutter/engine#13116)
2019-10-14 bkonyi@google.com Roll src/third_party/dart 5fad012d02..892fcf2c45 (15 commits)
2019-10-14 jason-simmons@users.noreply.github.com Integrate more SkParagraph builder patches (flutter/engine#13094)
2019-10-13 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from T3Xkz... to E3s7G... (flutter/engine#13114)
2019-10-12 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from lJPDX... to _GTls... (flutter/engine#13113)
2019-10-12 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from W9PBe... to T3Xkz... (flutter/engine#13112)
2019-10-12 skia-flutter-autoroll@skia.org Roll fuchsia/clang/linux-amd64 from q4DVY... to 2EAvs... (flutter/engine#13111)
2019-10-12 skia-flutter-autoroll@skia.org Roll fuchsia/clang/mac-amd64 from zpVtV... to xTJWs... (flutter/engine#13110)
2019-10-12 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from LsxeL... to lJPDX... (flutter/engine#13109)
2019-10-12 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from ShVbh... to W9PBe... (flutter/engine#13108)
2019-10-12 bkonyi@google.com Roll src/third_party/dart 90ff37e011..5fad012d02 (6 commits)
2019-10-12 bkonyi@google.com Roll src/third_party/dart 42dcdf903c..90ff37e011 (7 commits)
2019-10-12 skia-flutter-autoroll@skia.org Roll src/third_party/skia 8c6c8b0c42e2..3838fe3c82b4 (3 commits) (flutter/engine#13105)
2019-10-12 liyuqian@google.com Analyze framework Dart code in presubmit tests (flutter/engine#13037)
2019-10-12 iska.kaushik@gmail.com [dart_aot_runner] Complete the port of dart_aot_runner (flutter/engine#13103)
2019-10-11 matthew-carroll@users.noreply.github.com Move initialization into FlutterEngine (flutter/engine#12806)
2019-10-11 ferhat@gmail.com Update felt README (flutter/engine#13097)
2019-10-11 bkonyi@google.com Roll src/third_party/dart 9f33e8da04..42dcdf903c (7 commits)
2019-10-11 iska.kaushik@gmail.com [dart_aot_runner] Generate vmservice aotsnapshots (flutter/engine#13101)
2019-10-11 dnfield@google.com ColorFilter matrix docs (flutter/engine#13100)
2019-10-11 dnfield@google.com cleanup gen_package.py (flutter/engine#13089)
2019-10-11 iska.kaushik@gmail.com [dart_aot_runner] Use the host_toolchain to build kernels (flutter/engine#13096)
2019-10-11 50856934+nturgut@users.noreply.github.com do not wrap font family name (flutter/engine#12801)
2019-10-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia df640e6d14a5..8c6c8b0c42e2 (12 commits) (flutter/engine#13098)
2019-10-11 liyuqian@google.com Remove persistent cache unittest timeout (flutter/engine#13091)
2019-10-11 matthew-carroll@users.noreply.github.com Added FlutterActivity and FlutterFragment hook to cleanUpFlutterEngine() as symmetry for configureFlutterEngine(). (#41943) (flutter/engine#12987)
2019-10-11 yjbanov@google.com use rest args for specifying test targets (flutter/engine#13088)
2019-10-11 yjbanov@google.com Snapshot the felt tool for faster start-up (flutter/engine#13090)
2019-10-11 bkonyi@google.com Roll src/third_party/dart 965b8cb1d8..9f33e8da04 (15 commits)
2019-10-11 dnfield@google.com java imports/style (flutter/engine#13082)
2019-10-11 30870216+gaaclarke@users.noreply.github.com Removed retain cycle from notification center. (flutter/engine#13073)
2019-10-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from U4IBp... to ShVbh... (flutter/engine#13092)
2019-10-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from fk6ou... to LsxeL... (flutter/engine#13083)
2019-10-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6c2b2bb02402..df640e6d14a5 (1 commits) (flutter/engine#13080)
2019-10-11 dnfield@google.com Gen package output corrected (flutter/engine#13086)
2019-10-11 dnfield@google.com Print more output when gen_package fails (flutter/engine#13085)

...
2019-10-14 21:44:27 -04:00
Jonah Williams f8a5baf359
Dont close debug connection on exit (#42655) 2019-10-14 17:29:04 -07:00
Jonah Williams 0dce0c6e30
catch appInstanceId error from dwds (#42656) 2019-10-14 17:28:28 -07:00
Ryan Macnak b7773da37b
Pass build mode-specific bytecode generation options to frontend_server. (#42471)
Fixes various Flutter framework test failures when bytecode is enabled.
2019-10-14 15:26:14 -07:00
Yegor 163be41d80
Revert "Fix and enable painting tests on the Web (#42546)" (#42687)
This reverts commit 13a1b1e3b9. It broke the build.
2019-10-14 15:14:16 -07:00
Yegor 13a1b1e3b9
Fix and enable painting tests on the Web (#42546)
fix and enable painting tests on the Web
2019-10-14 14:34:15 -07:00
Tong Mu ebde5e253f
Change modal barrier to dismissing on tap up (#42253)
* Change modal barrier to tap up

* Verify dismiss happen at release
2019-10-14 14:19:18 -07:00
Jenn Magder a62bb3d9ab
Update minimum version to Xcode 10.2 (#42254) 2019-10-14 12:45:40 -07:00
Greg Spencer e2c5fd6c24
Fix route focusing and autofocus when reparenting focus nodes. (#42554)
This fixes a problem with reparenting of focus nodes where it would remove the node from the scope's focused children when reparented, even if it was being reparented to another place under the same scope. This only occurred if the scope in question didn't have focus.

This caused nodes to not get autofocused when they were a child of another node within the scope, and were reparented, and then the scope was given focus (as when a route is pushed).

This keeps the node in the scope's child list where it was if the node is reparented under a parent within the same scope.

- Added a test that tries to autofocus a TextField when the route is pushed and there is another 
  FocusNode above the text field. This was how this was first noticed: the autofocus got ignored in 
  this configuration.

- Added a test to focus_manager_test that tests for the specific case of reparenting a node when 
  it's in the focused children of the scope.
2019-10-14 12:32:06 -07:00
Darren Austin a49470556c
Update BottomAppBar to use elevation overlays when in a dark theme (#41864)
* Updated the BottomAppBar to use elevation overlays when a dark theme is used.

* Moved the code for calculating the overlay color to a new utility
ElevationOverlay class and made it private by not including in the material package.
2019-10-14 11:02:15 -07:00
Tjong Anthony dd43da71fe Add isDismissible configuration for showModalBottomSheet (#42404)
* Allow showModalBottomSheet to present bottom sheet that is not dismissible by tapping on the scrim

* Add guards, improve styling and tests for BottomSheet
2019-10-14 10:00:00 -07:00
Mouad Debbar ba70e0e074
Print correct hostname when web server is launched (#42531) 2019-10-14 09:54:36 -07:00
Alexey Ivanov 8cc9a53ee3 Improve routers performance (#42526) 2019-10-14 09:25:00 -07:00
Shi-Hao Hong 877c6a62d0
Localization refresh (#42025)
* Refresh .arb files

* Refresh localizations
2019-10-14 09:07:06 -07:00
Jonah Williams 04e04ffa95
Deflake wildcard asset test (#42597) 2019-10-14 08:49:02 -07:00
Justin McCandless e7ffac2d67
Fix typo in docs: EdgeInserts->EdgeInsets (#42445) 2019-10-14 08:45:57 -07:00
Keshava Muraari 19899db223 Default colorScheme data in ButtonThemeData (Fix for #38655) (#39627)
* Set default colorScheme for ButtonThemeData
2019-10-14 08:40:02 -07:00
Greg Spencer dee7583908
Only dismiss dropdowns if the orientation changes, not the size. (#42482)
This changes the DropDownButton so that instead of dismissing itself when any metrics change occurs, it only dismisses itself when the orientation changes.

This gets around the fact that we can't currently have a dropdown and a text field on the same page because the keyboard disappearing when the dropdown gets focus causes a metrics change, and the dropdown immediately disappears when activated.

It still will cause the keyboard to jump up and down between controls, but that's a larger issue. At least now we can use the two together again.
2019-10-14 08:00:11 -07:00
chunhtai 9423a01204
fix flutter error report correct local widget (#41224) 2019-10-13 18:41:22 -07:00
Emmanuel Garcia 532a8fed41
Print message and log event when app isn't using AndroidX (#42548) 2019-10-12 18:58:22 -07:00
Dan Field 3fea2838df
Skip test (#42557) 2019-10-11 16:18:00 -07:00
Greg Spencer 8a2762c19e
Revert "Roll engine eed171ff3538..00f330068d3e (5 commits) (#42541)" (#42551)
This reverts commit e76160703f because it breaks the framework build.
2019-10-11 14:14:51 -07:00
Dan Field de499c2a93
Gradient transform (#42484) 2019-10-11 13:40:16 -07:00
engine-flutter-autoroll e76160703f
Roll engine eed171ff3538..00f330068d3e (5 commits) (#42541)
git@github.com:flutter/engine.git/compare/eed171ff3538...00f330068d3e

git log eed171ff3538..00f330068d3e --no-merges --oneline
2019-10-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from U4IBp... to ShVbh... (flutter/engine#13092)
2019-10-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from fk6ou... to LsxeL... (flutter/engine#13083)
2019-10-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6c2b2bb02402..df640e6d14a5 (1 commits) (flutter/engine#13080)
2019-10-11 dnfield@google.com Gen package output corrected (flutter/engine#13086)
2019-10-11 dnfield@google.com Print more output when gen_package fails (flutter/engine#13085)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-11 16:24:43 -04:00
Zachary Anderson af93b6af80
[flutter_tool] Improve yaml font map validation (#42538) 2019-10-11 12:17:37 -07:00
engine-flutter-autoroll 1ada412d1b
Roll engine 8dabfb90a110..eed171ff3538 (2 commits) (#42537)
git@github.com:flutter/engine.git/compare/8dabfb90a110...eed171ff3538

git log 8dabfb90a110..eed171ff3538 --no-merges --oneline
2019-10-11 iska.kaushik@gmail.com [dart_aot_runner] Add rules to generate dart_aot binaries (flutter/engine#13074)
2019-10-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 7fd7a8aef06c..6c2b2bb02402 (3 commits) (flutter/engine#13079)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-11 15:16:43 -04:00
Ian Hickson 08643c41d7
Always fake ProcessManager when you fake Filesystem in tests (#42369)
...because otherwise, processes that think they're manipulating your
filesystem will be doing crazy things the test is ignoring, leading to
(at best) failures and (at worst) flakes or disk corruption.
2019-10-11 11:23:12 -07:00
Ian Hickson 292519be98
Roll dart package dependencies (#42496) 2019-10-11 11:12:31 -07:00
Jason Simmons db9a035e7c
Wait for isolate start before proceeding with expression evaluation tests (#42464)
Fixes https://github.com/flutter/flutter/issues/42359
2019-10-11 11:04:39 -07:00
Tong Mu 0aafdfa55a
Redo: Rewrite MouseTracker's tracking and notifying algorithm (#42486)
* Revert "Revert "Rewrite MouseTracker's tracking and notifying algorithm (#42031)" (#42478)"

This reverts commit eede792923.

* Fix tests
2019-10-11 10:10:56 -07:00
Janice Collins 4dcf1ab828
Update dartdoc to 0.28.7 (#42136) 2019-10-11 08:47:12 -07:00
Dan Field bb7acc1346
add WAKE_LOCK back to abstract method test (#42530) 2019-10-11 08:26:53 -07:00
Jonah Williams 7ab653c6ca
Add error logging to flutter generate (#42209) 2019-10-11 07:16:11 -07:00
Lau Ching Jun 4416c4f8d6 Add Android x64 profile artifacts (#42508) 2019-10-11 06:57:45 -07:00
engine-flutter-autoroll 72d5c1c805
Roll engine a5c1c6813091..8dabfb90a110 (2 commits) (#42503)
git@github.com:flutter/engine.git/compare/a5c1c6813091...8dabfb90a110

git log a5c1c6813091..8dabfb90a110 --no-merges --oneline
2019-10-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 3GwxH... to U4IBp... (flutter/engine#13078)
2019-10-11 bkonyi@google.com Roll src/third_party/dart 48e93d3d3b..965b8cb1d8 (31 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-11 03:58:43 -04:00
engine-flutter-autoroll f3cc889e1f
Roll engine e78c3f59c1a1..a5c1c6813091 (4 commits) (#42501)
git@github.com:flutter/engine.git/compare/e78c3f59c1a1...a5c1c6813091

git log e78c3f59c1a1..a5c1c6813091 --no-merges --oneline
2019-10-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v8utw... to fk6ou... (flutter/engine#13072)
2019-10-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia b484e7ce24c9..7fd7a8aef06c (4 commits) (flutter/engine#13069)
2019-10-11 iska.kaushik@gmail.com Reland dart_aot_runner shims
2019-10-11 iska.kaushik@gmail.com Revert "[dart_aot_runner] Add support for generating dart_aot snapshots (#13071)" (flutter/engine#13075)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-11 02:46:43 -04:00
engine-flutter-autoroll 124acfb1c5
Roll engine cef6751dba87..e78c3f59c1a1 (2 commits) (#42495)
git@github.com:flutter/engine.git/compare/cef6751dba87...e78c3f59c1a1

git log cef6751dba87..e78c3f59c1a1 --no-merges --oneline
2019-10-11 iska.kaushik@gmail.com [dart_aot_runner] Add support for generating dart_aot snapshots (flutter/engine#13071)
2019-10-10 chinmaygarde@gmail.com Put Metal renderer selection behind runtime flag and plist opt-in. (flutter/engine#13056)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-11 01:38:43 -04:00
Ian Hickson 53be552ae1
Be more verbose when pub fails (#42187) 2019-10-10 19:37:01 -07:00
Michael Klimushyn 6d18d31b5c
Fix abstract_method_smoke_test flakiness (#42454)
The flake appears to be coming from the Google Maps plugin. This test
just needs a platform view plugin without the interface method
implemented in general, not Maps specifically. Update it here to avoid
the issue in Maps until that's fixed.

Create a very simple platform view implementation that exercises this
potential bug in order to create a minimal test case with less risk of
causing second order issues like depending on any kind of full package
would cause.
2019-10-10 18:23:23 -07:00
Jonah Williams eede792923
Revert "Rewrite MouseTracker's tracking and notifying algorithm (#42031)" (#42478) 2019-10-10 16:44:10 -07:00
Jonah Williams 2b635816c6
Wrap dwds in async guard, only catch known error types (#42364) 2019-10-10 16:34:27 -07:00
Jonah Williams 03a45dc383
Add support for Android x86_64 ABI to Flutter (#42401) 2019-10-10 16:34:16 -07:00
Tong Mu 53636374dc
Rewrite MouseTracker's tracking and notifying algorithm (#42031)
* Redesigns the algorithm with which MouseTracker keeps track of states and dispatches events.
2019-10-10 16:28:56 -07:00