Commit graph

3518 commits

Author SHA1 Message Date
Stanislav Baranov 63e6a7ad30
Support for building dynamic patches in AOT mode. (#27672) 2019-02-08 17:52:57 -08:00
Jonah Williams 7cdb30fba2
Revert "Lazily download artifacts (#27374)" (#27705)
This reverts commit 98971f3c64.
2019-02-08 15:50:18 -08:00
Jonah Williams 98971f3c64
Lazily download artifacts (#27374) 2019-02-08 15:24:09 -08:00
Zachary Anderson fe701c45e5
Add build_runner_core to flutter_tools BUILD.gn (#27661)
Need for roll into Fuchsia
2019-02-08 07:40:44 -08:00
Michael Klimushyn 4a9e5bc11b
Warn when gradle builds fail because of AndroidX (#27566)
Try to detect Gradle error messages that hint at AndroidX problems, and
warn in the logs about the potential problem and point to documentation
on how to fix the issue.

Unfortunately the Gradle errors based on this root issue are varied and
project dependent. It's probably better to still leave the message
intact in case the problem is unrelated.

Also filters out the plugin warning message pending in
flutter/plugins#1138. It's still valuable to add that for people on
previous versions of Flutter, but this link should override that message
for anyone on an up to date version of Flutter.

#27106
2019-02-07 17:23:35 -08:00
KyleWong 99497dc2d9 Refactor android launchable activity extractor logic (#26819) 2019-02-07 13:24:03 -08:00
Greg Spencer 2aad59314f
Add a keyboard key code generator. (#27620)
This adds a keycode generator that incorporates input from the Chromium and Android source trees, as well as some local tables, to generate static constants for the LogicalKeyboardKey and PhysicalKeyboardKey classes, as well as mappings from each of the platforms we support so far (currently only Android and Fuchsia).

This code generator parses the input files, generates an intermediate data structure (`key_data.json`) that is checked in, and then generates the Dart sources for these classes and some static maps that will also be checked in (but are not included in this PR).

The idea is that these codes don't change often, and so we don't need to generate them on every build, but we would like to be able to update them easily in the future if new data becomes available. If the existing data disappears or becomes unusable, we can maintain the checked-in data structure by hand if necessary, and still be able to generate the code.

This PR only contains the code generator, not the classes themselves. In another follow-on PR, I'll run the generator and check in the output of the generator.
2019-02-06 16:53:16 -08:00
Jonah Williams 5b943257d7
fix list devices throwing on junk input (#27615) 2019-02-06 15:41:22 -08:00
Jonah Williams c920cb7c57
Remove build runner from injection (#27607) 2019-02-06 14:38:50 -08:00
Greg Spencer da27f62337
Make a kReleaseMode constant that is public. (#27502)
Before this, we had several places where an isReleaseMode was defined, all with the same definition. This just makes it more broadly visible to allow our users to use it, as well as creating debug and profile versions, and adding a device lab test for it.

Since this is a const value, this makes it possible for a developer to easily mark blocks that can be removed at AOT compile time.
2019-02-06 14:37:17 -08:00
Jonah Williams b06a709305
Use flutter_tools to generate build_script (#27277) 2019-02-05 18:35:20 -08:00
KyleWong 7765dd4c3c Refactor logic to get plugins path for android studio in mac (#26964) 2019-02-05 16:48:14 -08:00
Dan Field 704814c67a
Use CP_REPOS_DIR if it's set (#27553)
* Allow CP_REPOS_DIR
2019-02-05 16:03:37 -08:00
xster 36c5e321a5
Print 50000$ monopoly money (#27531) 2019-02-05 15:00:51 -08:00
KyleWong 9abe4c6dfe Fix gradle verbose error. (#26938) 2019-02-05 15:00:18 -08:00
Ryan Macnak 965dc52e2e Disable usage of bare instructions in AOT (#27410)
Issue #27250
2019-02-05 13:52:59 -08:00
木士羽 9f7ab4c4a0 Support using flutter with specific version (#26840)
* Support using flutter with specific version

* Set min supported version to 1.2.1
2019-02-04 11:26:06 -08:00
Jonah Williams 8e2ea26301
Make the deviceDiscovery API overridable (#27378) 2019-01-31 18:42:30 -08:00
Alexander Aprelev 030dc3fade
Don't send accept/reject if compilation never started. (#27319)
* Don't send accept/reject if compilation never started.

Ensure that we wait for reject's response since that is async operation.

Fixes https://github.com/flutter/flutter/issues/27120.

* Fix analysis errors

* Rename flag. Ensure we raise it on first compilation too.
2019-01-31 17:43:32 -08:00
Zachary Anderson 7634a0ecbe
[flutter_tool,doctor] Fix and test gen_snapshot failure message (#27253) 2019-01-30 13:01:19 -08:00
KyleWong 7c19ec6ca8 Add2App: Fix crash resulted from hard-code module 'app' based resource copy. (#27154) 2019-01-30 10:29:29 -08:00
Michael Goderbauer 6d20ff2446
Remove all obsolete "// ignore:" (#27271) 2019-01-30 08:56:12 -08:00
Jonah Williams c219e6f3b1
Inject KernelCompiler via KernelCompilerFactory (#27211) 2019-01-30 08:34:01 -08:00
jonnyandrew 59dc909d0f Include empty config in 'flutter config' output (#25094) 2019-01-30 07:36:03 -08:00
sjindel-google 95b34d7a07 Pass --verify-entry-points in debug mode. (#27032) 2019-01-30 07:33:55 -08:00
Mohammed Salman 8cb2695a0b fix #26207 .gitignore only include project root build directory (#26388) 2019-01-30 07:33:28 -08:00
Todd Volkert c8c935cd83 Allow bundle identifier to be surrounded with quotes. (#26300)
Picked up from #22498, originally by @jugyo
2019-01-30 07:32:05 -08:00
Jonah Williams 763a8d6d9b
add support to multiroot scheme to PackageUriMapper (#27207) 2019-01-30 07:31:16 -08:00
KyleWong 60aa49e064 Let injectPlugins integrate custom pods (#26970) 2019-01-29 20:33:16 -08:00
Siva 4e68b7c752
Add support for experimental flags during hot reload. (#27252)
* Add support for experimental flags during hot reload.
2019-01-29 17:19:06 -08:00
Alexandre Ardhuin ef276ffea5
format initializer list of constructors (#27111) 2019-01-29 21:47:16 +01:00
Jonah Williams ca92efecae
Add module checking (#27122) 2019-01-29 12:26:48 -08:00
Konstantin Scheglov 4fe41abfcc
Add default values for optional parameters. (#27197) 2019-01-29 11:49:57 -08:00
Chinmay Garde e38efc890b
Add a flag to enable tracing to systrace. (#27208) 2019-01-28 19:55:01 -08:00
Dan Field c082f8d8a3
Revert f9e6242db (#26944) (#27191)
* Revert f9e6242db

* fix pubspec

* finish pubspec upgrade
2019-01-28 15:35:59 -08:00
Danny Tuppeny d5fd57cfbd
Improve unsupported text (#27186) 2019-01-28 17:51:23 +00:00
Danny Tuppeny 64a1ce011a
Change "Starting Xcode build" text to "Running xcode build" (#27181)
This status shows for the duration of the run, not just while starting. It looks kinda weird in the editors to show a progress bar for "Starting Xcode build" and then removing it once it completes.
2019-01-28 16:24:56 +00:00
Jonah Williams 91fd89e8b3
Wrap dart:convert to track utf8 decode failures (#26650) 2019-01-25 16:16:26 -08:00
Jonah Williams 2e8f173f7d
Add flutter_build package for codegen and version sync with tool (#26978) 2019-01-25 16:06:25 -08:00
Dan Field f9e6242db9
Use mDNS to discover the device port (#26944)
* Discover port over mDNS

* opt in, only for iOS for now
2019-01-25 12:12:17 -08:00
Gary Qian 06b979c4d5
Revert "Warn when building on master channel (#25007)" (#27096)
This reverts commit dd65a54628.
2019-01-25 14:27:35 -05:00
tonyzhao1 e4df6b4efc Change the required version of adb, as older versions break hot reload. (#24746) 2019-01-25 10:37:46 -08:00
Jonah Williams fa5f3da6f2
Update flutter clean to remove .dart_tool directory (#27054) 2019-01-25 09:30:11 -08:00
Chris Bracken 731221c3e8
Improve documentation on decodeSyslog (#27039)
It appears that the encoding Apple is using to ensure their syslog
conforms with the syslog requirement for seven-bit ASCII encoding (see:
RFC 5424) is `vis`.

Details: https://www.freebsd.org/cgi/man.cgi?query=vis&sektion=3
2019-01-25 06:34:30 -08:00
Gary Qian b028ee142c Revert "Experimental flags for hot reloads, fixed" (#27059)
* Revert "Make UriMapper and StdoutHandler public and add test cases (#26932)"

This reverts commit 6cf554b0c4.

* Revert "Update packages (#27046)"

This reverts commit 496c57386b.

* Revert "roll engine for TODAY bug (#27049)"

This reverts commit 5ae6346f1d.

* Revert "Warn when building on master channel (#25007)"

This reverts commit dd65a54628.

* Revert "Add experimentalBuildEnabled flag and initial shim for build_runner (#26989)"

This reverts commit 1237ee8f63.

* Revert "Experimental flags for hot reloads, fixed (#27043)"

This reverts commit 2c05d08f0c.
2019-01-24 18:37:56 -08:00
Jonah Williams 6cf554b0c4
Make UriMapper and StdoutHandler public and add test cases (#26932) 2019-01-24 16:17:04 -08:00
Dan Field 496c57386b
Update packages (#27046)
* Update packages

* Change test for isFile
2019-01-24 16:02:45 -08:00
Gary Qian dd65a54628
Warn when building on master channel (#25007) 2019-01-24 19:01:07 -05:00
Jonah Williams 1237ee8f63
Add experimentalBuildEnabled flag and initial shim for build_runner (#26989) 2019-01-24 15:59:55 -08:00
Liam Appelbe 2c05d08f0c
Experimental flags for hot reloads, fixed (#27043)
* Revert "Revert "Experimental flags for hot reloads (#26988)" (#27037)"

This reverts commit cf7441983e.

* Fix analysis failures
2019-01-24 15:58:38 -08:00
Jason Simmons 7bfbc28505
Revert "Upgrade the Gradle script to Android plugin version 3.3.0 (#26913)" (#27045)
This reverts commit 30f33d6c7d.
2019-01-24 14:29:08 -08:00
Jason Simmons 30f33d6c7d
Upgrade the Gradle script to Android plugin version 3.3.0 (#26913)
Fixes https://github.com/flutter/flutter/issues/26544
2019-01-24 12:21:11 -08:00
Dan Field cf7441983e
Revert "Experimental flags for hot reloads (#26988)" (#27037)
This reverts commit 763bf11460.
2019-01-24 10:02:38 -08:00
Liam Appelbe 763bf11460
Experimental flags for hot reloads (#26988)
* First pass at incremental exp flags

* adkfgjh
2019-01-24 09:48:10 -08:00
Jonah Williams 1b21d69de4
Support running macOS prebuilt application (#26593) 2019-01-23 16:32:50 -08:00
Dan Field 19b8d2e0a9
Detect Android SDK 28/28.0.3 (#26942)
* Detect Android SDK 28/28.0.3

* revert minimumAndroidSdkVersion const change
2019-01-23 15:56:48 -08:00
Alexandre Ardhuin 66f424f0f8
fix some bad indentations (#26921)
* fix some bad indentations

* remove suspicious line
2019-01-23 15:43:27 +01:00
Jonah Williams c1fabb9860
make FDE opt-in via the environment variable (#26898) 2019-01-22 18:40:13 -08:00
Jonah Williams f777db2b78
add uiMode to android:configChanges (#26896) 2019-01-22 10:37:22 -08:00
Dan Field 543f8924b4
Avoid calling cancel on AnsiSpinner more than once when building for iOS (#26826)
* Avoid calling cancel more than once

* add some missing checks for ansispinner
2019-01-21 22:41:35 -08:00
Dan Field 386f3466b5
Roll engine to 05fee4eeee0ff6b219b1fcc394371e5f6963cc46 (#26713)
* move flutter_assets to App.framework

* Roll engine to 05fee4eeee0ff6b219b1fcc394371e5f6963cc46

05fee4eee Update default flutter_assets path for iOS embedding (flutter/engine#7518)
02205db01 Roll src/third_party/skia 5d052dac3ac1..02738a86e5fd (4 commits) (flutter/engine#7541)
af907c074 Roll src/third_party/skia 5c7a3ac0e214..5d052dac3ac1 (7 commits) (flutter/engine#7540)
dde286673 IWYU to get SkFontMetrics (flutter/engine#7539)
2019-01-21 21:23:04 -08:00
Dan Field d8d36bc7e8
targetSdkVersion 28 (#26798) 2019-01-19 11:59:42 -08:00
Ian Hickson 31a9626c48
[O] Removing all timeouts (mark II) (#26736)
These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
2019-01-19 00:31:05 -08:00
Alexander Aprelev 07c592d901
Report early error if appropriate host local engine is not found. (#26766) 2019-01-18 11:26:54 -08:00
Jonah Williams 830c0dfe83
Allow attaching to profile builds (#26720) 2019-01-18 10:09:44 -08:00
Liam Appelbe 9eada88b3e
Experimental flags in flutter (#26715)
* exp flags in flutter

* Fix test failures
2019-01-18 09:07:14 -08:00
Jason Simmons f4c5e3eef2
[Gradle] Copy ICU data to flutter_shared only when building an AAR module (#26668)
This is based on 9880baa396
but will support building APKs with --local-engine
2019-01-17 16:33:14 -08:00
mcplectrum b4daf33807 Fix Podfile issue #24342 (#25079)
* Fix Podfile issue #24342

Sometimes base configurations  (config.base_configuration_reference) can be nil, which leads to undefined method `real_path' for nil:NilClass.

* Disable bitcode in every case
2019-01-17 15:00:51 -08:00
Stanislav Baranov eb8219edd5
Emulator support for dynamic mode on Intel architecture (#26565) 2019-01-17 14:21:35 -08:00
abykov2 3c0a74ef0f Adding a shutdown hook to HotRunnerConfig (#26604) 2019-01-17 08:49:02 -08:00
Kenzie Schmoll 33bfa6a7c5
Register hotRestart service in flutter_tools. (#26669)
* Register hot restart service in flutter_tools.
2019-01-17 08:28:54 -08:00
Danny Tuppeny 244b077bee
Give integration tests unique temp folder names (#26227)
This will help track down any that aren't cleaning up and also may help track down leaked flutter_tester processes (https://github.com/dart-lang/sdk/issues/35549).
2019-01-17 11:29:18 +00:00
Jonah Williams 83b9497c69
do not exit tool if fuchsia workflow fails (#26589) 2019-01-16 17:43:01 -08:00
Dan Field 4c99958df6
Revert "Move flutter_assets to App.framework (#26630)" (#26675)
This reverts commit d8db70af1a.
2019-01-16 16:46:37 -08:00
Luca Zuccarini 36a493602c Create an injectable factory for application packages. (#26422) 2019-01-16 14:12:47 -08:00
Dan Field d8db70af1a
Move flutter_assets to App.framework (#26630)
* move flutter_assets to App.framework

* remove flutter_assets references from all pbxproj files checked in
2019-01-16 14:02:54 -08:00
Vyacheslav Egorov 8f65ee9f53
Fix --build-shared-library on newer NDKs (#26642)
Newer NDKs switched to clang which by default uses system linker, instead
we need to force it to use appropriate toolchain linker by passing
-fuse-ld= command line flag.

Fixes #23458
2019-01-16 21:30:37 +01:00
Vyacheslav Egorov 7c434a5cf2
Revert "Add flutter_shared assets to module artifact (#23782)" (#26644)
This reverts commit 9880baa396.

Reason for revert: broke `--local-engine` command line option.
2019-01-16 21:23:18 +01:00
Igor Borges 9880baa396 Add flutter_shared assets to module artifact (#23782)
copySharedFlutterAssetsTask copies the `flutter_shared` folder assets to android's `src/main` folder of Flutter project, so that folder is bundled on the generated AAR
2019-01-15 10:23:19 -08:00
tonyzhao1 3f3a829c88 Move runner directory messages to the user messages class (#25682) 2019-01-15 10:06:44 -08:00
Dan Field 774e8c18e3
remove ignore_for_file lints (#26545)
* remove ignore_for_file lints

* update comments

* remove example
2019-01-15 08:42:47 -08:00
Dan Field 025d04ad52
remove todo (#26562) 2019-01-15 08:42:12 -08:00
Jonah Williams 3a694a6d5d
desktop workflow, devices, and test (#26511) 2019-01-15 07:45:04 -08:00
Danny Tuppeny fda193aa5d
Fix+unskip flutter test expression eval tests (#26579)
* Fix `flutter test`e xpression eval tests

We weren't passing `beforeStart` through so the breakpoints were never being set, which means the evaluations were happening while the code was running.

* Ensure we wait for breakpoints before trying to evaluate
2019-01-15 15:39:35 +00:00
Jason Simmons cf4c903144
Update compileSdkVersion in the Android app templates to Android P (#26444)
Fixes https://github.com/flutter/flutter/issues/25703
2019-01-14 16:16:12 -08:00
Alexander Aprelev 07e06171ba
Report overall and transfer timings as part of hot reload statistics, analytics. (#26537) 2019-01-14 12:23:09 -08:00
Danny Tuppeny 150079db6e
Skip flutter test expression eval tests (#26519)
See https://github.com/flutter/flutter/issues/26518.
2019-01-14 15:21:06 +00:00
Jason Simmons 8efd6c1a21
Add a manifest for profile builds that enables INTERNET permission (#26450)
Profile builds need access to sockets in order to launch the Dart
observatory server.

This permission used to be enabled by default in all build types,
but was moved to a build type specific manifest in
88b853f7eb
2019-01-11 18:19:17 -08:00
Andrei Lesnitsky 88b853f7eb move INTERNET permission to debug/AndroidManifest.xml (#22139) 2019-01-11 07:45:49 -08:00
Stanislav Baranov 585e23173a
Friendlier flutter tool messages for dynamic mode (#26378) 2019-01-10 16:07:50 -08:00
Greg Spencer dca8d36d62
Change flutter create to use master-docs.flutter.io instead of firebase URL. (#25516)
Now that we have our DNS mapping we should refer to the master docs site that way everywhere.
2019-01-10 12:55:57 -08:00
Danny Tuppeny 1a0481591d
Add some basic tests for evaluating expressions in flutter test (#24513)
* Add some basic tests for evaluating expressions in `flutter test`

* Review tweaks
2019-01-10 15:33:59 +00:00
Danny Tuppeny b16ef489e0
Add a validator to ensure NO_PROXY is set correctly if HTTP_PROXY is set (#25974)
* Add a validator to ensure NO_PROXY is set correctly if HTTP_PROXY is set

Fixes #24854.

* Fix typo

* Dummy edit to try and force update of PR desc on Cirrus
2019-01-10 07:47:29 +00:00
Dan Field e19851191a
Revert "Check for duplicative Flutter.framework emeddings when building for Xcode 10" (#26339)
* Revert "Check for duplicative Flutter.framework emeddings when building for Xcode 10 (#23188)"
2019-01-09 19:34:14 -08:00
Stanislav Baranov e2c0349157
Add logic for creating rollback dynamic patches. (#26312)
Before this change, rolling back a patch relied on deleting the patch
file from the server completely. This PR implements a more reliable
approach where developer needs to create a physical rollback patch file.
This is more robust to mistakenly taking down a patch from user devices.
2019-01-09 16:43:03 -08:00
Dan Field bc28a220c9
Check for duplicative Flutter.framework emeddings when building for Xcode 10 (#23188)
* Check for bad configuration in Xcode10
2019-01-09 14:43:49 -08:00
kongshanshan33 305ab1a35b Fix project directory has spaces lead to compile error when use 'flutter create -t module'command (#23817) 2019-01-09 11:18:40 -08:00
Sean Freiburg 0468742910 Fix flutter root error message string interpolation (#24944)
The variable isn't interpolating because it's using "${}" when ruby uses "#{}".
2019-01-09 10:57:20 -08:00
jxltom 843f26207f Do not ignore pubspec.lock in project templates (#24209)
* Remove *.lock from gitignore

* Remove pubspec.lock from gitignore
2019-01-09 10:10:38 -08:00
Jonah Williams a2fa98ebaf
Add polling module discovery for Fuchsia (#24994) 2019-01-09 09:28:31 -08:00
Jonah Williams 32041c0c9c
Reland: Switch to dev_finder (#26250) 2019-01-09 09:27:56 -08:00
KyleWong 6f1d10b71a Fix recursive link resulted flutter doctor stucking. See : #25885 and #25870 (#26017) 2019-01-09 09:04:45 -08:00
Dan Field 1407091bfb
Fix red tree (Android module) (#26270) 2019-01-08 20:40:19 -08:00
KyleWong 87d6e93c46 Improve the intergrity checking for "gradle wrapper". (#26069) 2019-01-08 18:34:58 -08:00
Jonah Williams 985ccb6d14
Revert "Replace netls and netaddr with dev_finder" (#26249)
* Revert "Replace netls and netaddr with dev_finder (#26090)"

This reverts commit eee154affb.
2019-01-08 13:45:55 -08:00
Devon Carew 322afbb160
rev the min dart sdk dep in the templates to 2.1.0 (#26235) 2019-01-08 16:20:52 -05:00
Jonah Williams eee154affb
Replace netls and netaddr with dev_finder (#26090) 2019-01-08 12:07:12 -08:00
Jonah Williams 891036c9b9
Prevent calls to view.uiIsolate.flutterExit on devices which do not support it (#26201) 2019-01-07 21:58:15 -08:00
Stanislav Baranov e54e53c13b
Better error messages for flutter tool --dynamic flag. (#26107) 2019-01-07 12:24:24 -08:00
Stanislav Baranov 4b474d61c6
Put correct VM snapshot in APK, and actually precache gen_snapshot on Mac. (#26104) 2019-01-07 12:22:55 -08:00
Alexander Aprelev 6502a1bed9
Report hot reload statistics. (#26039)
* Report hot reload statistic

* Lints

* Introduce custom dimensions identifiers to track hot reload stats
2019-01-05 07:34:02 -08:00
Stanislav Baranov acdd9206aa
Improve message when saving compilation training data. (#26084) 2019-01-04 11:57:32 -08:00
Stanislav Baranov b57499e704
Friendlier messages when using dynamic patching (#25863) 2019-01-03 16:18:36 -08:00
KyleWong 85ded44139 Optimize cocoapods logic in flutter doctor. (#25872) 2019-01-02 19:57:03 -08:00
Stanislav Baranov bacaab9795
Allow dynamic patches without a patch number. (#25796)
Unique patch numbers are mainly useful for canary and A-B testing, but otherwise complicate things and can now be omitted.
2018-12-27 11:57:16 -08:00
Alexander Aprelev 52bd2ccb8b
Report devfs stats (#25586)
* Collect devfs stats for better analytics

* Fix fields initialization

* Fix lints
2018-12-27 09:53:24 -08:00
Hans Muller 4857267e65
Updated Shrine demo (#25674) 2018-12-21 17:47:25 -08:00
Stanislav Baranov 6d6ada14a0
Friendlier flags for Dart compilation training. (#25645)
* Renamed --save-compilation-trace to flutter run --train.
* Renamed --precompile=<file> to --compilation-trace-file=<file>.
* In dynamic mode, made JIT snapshot the default, instead of kernel file.
2018-12-21 12:27:59 -08:00
Ian Hickson fb88a7bfd1
Update links for China help (#25238)
We have a page on the Web page now.
2018-12-21 10:12:49 -08:00
Pranay Airan 368cd7da8b
Adding support for android app bundle - Issue #17829 (#24440)
* adding support for android app bundle.

* removing the debug statement.

* fixing formatting and code review changes.

* Revert "fixing formatting and code review changes."

This reverts commit 2041d459f3.

* Fixing code formatting issues.

* updating review comments fixing comments and spacing.

* changing and to & to rerun the CI and tests.

* updating the comment to re-run the test

updating the comment to re-run the test

* fixing the formatting.

* updating comments to re-trigger build

updating comments to re-trigger build
2018-12-20 22:18:53 -08:00
Ian Hickson 8426910a19
Revert "[O] Remove many timeouts. (#23531)" (#25646)
This reverts commit 76f70810e4.
2018-12-20 18:46:36 -08:00
Ian Hickson 76f70810e4
[O] Remove many timeouts. (#23531)
* Remove many timeouts.

These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.

* Get the attach tests to pass.

* Apply review comments from Todd

* More review comment fixes

* Put back the extended timeouts here now that I know why we have them...
2018-12-20 17:10:40 -08:00
Stanislav Baranov eb7a59b6d7
Switch over to the new name for compilation trace native function (#25594)
* Switch over to the new name for compilation trace native function.

Also see: https://github.com/flutter/engine/pull/7256

* rename

* roll the engine
2018-12-20 16:07:36 -08:00
Dan Field 7a88fbc5fd
Default baseline build options (#25631)
* fix crash

* default baseline
2018-12-20 11:38:07 -08:00
Stanislav Baranov 41fd7a2b9d
Don't parse APK unless explicitly requested (#25595) 2018-12-20 10:08:05 -08:00
Stanislav Baranov 55f3da7afc
Flutter tool support for building dynamic updates (#25576) 2018-12-19 16:27:47 -08:00
xster b17feefc9e
Remove code signing special casing for Googlers round 2 (#24580) 2018-12-19 14:41:21 -08:00
tonyzhao1 f8ab72657e Flutter doctor error message lookup (#23889) 2018-12-19 10:10:08 -08:00
Stanislav Baranov 693fb6560e
Fix flutter tool to actually honor --build-number/--build-name flags. (#25520) 2018-12-18 12:54:26 -08:00
Stanislav Baranov 0d4f279fb8
Read correct cached VM snapshot in dynamic mode (PRODUCT vs RELEASE) (#25472) 2018-12-18 12:53:30 -08:00
Stanislav Baranov f6c1476fbb
Fix gradle local.properties tests that were never excersized. (#25484)
These tests were actually failing, but were silently ignored due overly broad exception catching logic.
2018-12-18 10:39:27 -08:00
Danny Tuppeny cbb168e7b9
Fix (probably) bad assert when running flutter test with asserts and --start-paused (#25512)
Fixes #25201.
2018-12-18 16:03:56 +00:00
Alexandre Ardhuin 32d65fef1c
fix some formatting issues (#25474) 2018-12-18 10:05:12 +01:00
Devon Carew ba71933f58
don't warn for non-matching device discoverers (#25440)
* don't warn for non-matching device discoverers

* remove an out of date test
2018-12-17 14:54:18 -08:00
Dan Field 0a798105ef
Support Java 1.8 (#25470) 2018-12-17 14:40:48 -08:00
Devon Carew 632e21b40b
fix the daemon device.getDevices call (#25443) 2018-12-17 12:38:14 -08:00
Zachary Anderson b18a2b1794
[fuchsia] Get Dart VM service ports from The Hub (#25332) 2018-12-17 11:10:47 -08:00
Danny Tuppeny c19142d8b7
Support ANDROID_SDK_ROOT in addition to ANDROID_HOME (#25221)
* Fall back to ANDROID_SDK_ROOT if ANDROID_HOME is not set

And update descriptions to use the non-deprecated ANDROID_SDK_ROOT.

Fixes #15114.

* Remove trailing whitespace

* Update dev/devicelab/lib/framework/adb.dart

Co-Authored-By: DanTup <danny@tuppeny.com>

* Reformat long line
2018-12-17 17:29:09 +00:00
Stanislav Baranov c5251cdc02
Flutter tool support for automatic saving of JIT compilation trace (#25301) 2018-12-14 16:09:17 -08:00
Jonah Williams b4f1d5a924
Add fuchsia devices to daemon command (#25344) 2018-12-14 14:37:55 -08:00
David Shuckerow 1a60b166f2
Add ipv6 and observatory port support to the attach command (#25303)
* Add ipv6 and observatory port support to the attach command.

* Remove whitespace

* Explain why a name change is useful here

* Refactor common flags out into the parent

* Add an additional test case for when observatory port is provided but debug port is not

* Remove whitespace

* Fix flag validation
2018-12-14 18:03:49 -04:00
David Shuckerow e6292c8da1
Revert "Add ipv6 and observatory port support to the attach command." (#25288)
* Revert "e5195ee47 Remove unnecessary includes of Ganesh headers (flutter/engine#7189) (#25282)"

This reverts commit f198d66332.

* Revert "Validate style in TextField (#24587)"

This reverts commit 9a8e2f0c4b.

* Revert "Allow snippets tool to be run from arbitrary CWDs (#25243)"

This reverts commit 4a110b6227.

* Revert "Make doctor output consistent between VS Code/IntelliJ/Android Studio when plugins are missing (#25269)"

This reverts commit e29b023a6b.

* Revert "Add ipv6 and observatory port support to the attach command. (#24537)"

This reverts commit 9150b3f031.
2018-12-12 16:56:50 -04:00
Danny Tuppeny e29b023a6b
Make doctor output consistent between VS Code/IntelliJ/Android Studio when plugins are missing (#25269)
* Update VS Code validator to match Android Studio

- Now shows a tick (instead of partial) if installed
- Now shows a cross (instead of dot) if extension is not installed

Fixes #22931.
2018-12-12 17:36:42 +00:00
David Shuckerow 9150b3f031 Add ipv6 and observatory port support to the attach command. (#24537) 2018-12-12 08:28:02 -08:00
Danny Tuppeny 2994d3562a
Add some a basic debug stepping tests (#24515) 2018-12-12 10:56:54 +00:00
Jonah Williams c461e93363
Revert "Ensure that cache dirs and files have appropriate permissions" (#25240) 2018-12-11 15:33:57 -08:00
Jonah Williams b080a476c8
Fuchsia multiple devices and target (#24953) 2018-12-11 09:18:21 -08:00
Danny Tuppeny 3f1c308e58
Don't require the AVD folder to exist in order to run flutter emulators (#25154)
Fixes #24750.
2018-12-11 15:27:25 +00:00
Jonah Williams 61291aeeaf
ensure lastBuildTimestamp is set before early return (#25058) 2018-12-10 15:57:52 -08:00
Todd Volkert 243222c00d
Include error message in crash reports (#24632)
This modifies our flutter_tools crash reports to include the error
message. This error message may contain personally identifying
information (PII), such as a file system path on the developer's
local machine that may contain user names, project code names,
etc. To disable crash reporting, the developer can run the
following command:

    flutter config --no-analytics

For more information on what gets reported during crashes of the
flutter tool, see:

https://github.com/flutter/flutter/wiki/Flutter-CLI-crash-reporting
2018-12-10 13:59:47 -08:00
Todd Volkert 74ab1bfbbd
Ensure that cache dirs and files have appropriate permissions (#24669)
Fixes https://github.com/flutter/flutter/issues/24413
2018-12-10 13:39:50 -08:00
Jonah Williams a226c0f0d9
Add a flutter-attach entry point for fuchsia (#24878) 2018-11-30 16:18:18 -08:00
Tim Sneath 06ec8d3b41
Updating readme templates for newly created projects (#24725)
We hypothesize that many first-time users creating a new project will look at the README.md as a starting point for "what next". As we've updated our documentation particularly for new users, having better links to our codelabs and cookbooks will help them be productive.
2018-11-28 15:56:58 -08:00
Dan Field 03a4f4bedb
Quote framework_dir in xcode_backend.sh (#24591) 2018-11-20 18:42:27 -08:00
Jonah Williams f5b02e3c05
Bump minimum ios_deploy version (#24550) 2018-11-20 07:49:29 -08:00
Victor Florintsev 16b9a80ccd added definition for hardware (#24502)
This is the hardware used in the Samsung Galaxy J7
2018-11-19 14:18:01 -08:00
Hans Muller ec4f22c17b
Revert "Restore Flutter Gallery Shrine Demo, again (round 3) (#24531)" (#24538)
This reverts commit 4ec8883b83.
2018-11-19 13:02:18 -08:00
Hans Muller 4ec8883b83
Restore Flutter Gallery Shrine Demo, again (round 3) (#24531) 2018-11-19 12:21:49 -08:00
Todd Volkert c793d43ee0
Slight doc change (#24526) 2018-11-19 09:11:40 -08:00
Alexandre Ardhuin 79b5e5bc8a
Add missing lints (#24381)
* update lint list

* enable sort_pub_dependencies

* enable avoid_returning_null_for_void

* enable flutter_style_todos
2018-11-19 10:37:55 +01:00
Danny Tuppeny 15e3df25c5
Refactor Test Driver in preparation for flutter test integration tests (#24060)
* Refactor Test Driver in preperation for `flutter test` integration tests

* Fix indent
2018-11-19 08:25:42 +00:00
Danny Tuppeny 113f8f1a8d
Make FlutterTestDriver.stop() safe to call if it didn't spawn a process (#24393)
This means we can just always add it to test teardowns without having to add try/catches if there are any tests that don't spawn a process.
2018-11-19 07:16:32 +00:00
Danny Tuppeny 08e7f26510
Remove timeout waiting for app to start (#24336) 2018-11-19 07:15:52 +00:00
Jonah Williams 938dd5a4aa
Revert "Update driver script to execute test through test_core" (#24401)
* Revert "Add dashing config file for generating docset from flutter docs (#24374)"

This reverts commit ec8ca8606c.

* Revert "Update driver script to execute test through test_core (#24168)"

This reverts commit 6c62cf337f.
2018-11-15 11:17:00 -08:00
Jonah Williams 6c62cf337f
Update driver script to execute test through test_core (#24168) 2018-11-15 10:50:25 -08:00
Dan Field 091b73ab6f
fix variable check in xcode_backend.sh (#24368)
* fix test in xcode_backend.sh

* -n

* fix devicelab test

* uncomment good code, check for \"\"
2018-11-14 18:54:51 -08:00
Alexander Aprelev 64a8d44764
Fix test so it doesn't leak frontend_server process (#24360)
* Fix test so it doesn't leak frontend_server process

* Stop FlutterTestDriver even if expectation is not met
2018-11-14 18:50:18 -08:00
Greg Spencer eb35f8923b
Reland: Make the 'time to update' message depend up on the channel. (#24173) (#24321)
Fixes #24158
Re-lands #24173
2018-11-14 16:51:12 -08:00
stevemessick ff25edd3ad
Update idea template files (#24311)
* Update IntelliJ project template files

* Add ignored file

* Fix test

* Restore comma
2018-11-14 13:45:07 -08:00
Alexander Aprelev 0b940a4473
Flush write to disk with intent of reducing flakiness of the test. (#24144) 2018-11-14 13:26:24 -08:00
Alexander Aprelev 3b7942c444
Fix multi-step build handling process. (#24310)
* Fix multi-step build handling process.

Stop listening for new step updates after 'all done.' log message. Make sure that we don't delete file too soon, until listener had a chance to process the 'all done' message.

Fixes https://github.com/flutter/flutter/issues/18750

* Emit 'all output' explicitly when build process is done.
2018-11-14 08:54:13 -08:00
Brian Wilkerson 29d5210d8b Use constant durations in more places (#24306) 2018-11-14 08:16:12 -08:00
Greg Spencer a2ed3ecb64
Revert "Make the 'time to update' message depend up on the channel. (#24173)" (#24320)
This reverts commit 97e03104a0.

Landing on red to hopefully make less red on the board.

TBR=@goderbauer
2018-11-13 17:18:06 -08:00
Greg Spencer 97e03104a0
Make the 'time to update' message depend up on the channel. (#24173)
Fixes #24158
2018-11-13 09:53:56 -08:00
Jonah Williams aa65fa2fa1
Remove await for syntax from fuchsia log scanner (#24263) 2018-11-12 23:47:16 -08:00
Jonah Williams 2e33d08dae
communicate fuchsia error states to developers (#24191) 2018-11-12 23:46:14 -08:00
Jonah Williams 70c6fb1fbb
Remove package:collection dependency usage from flutter_goldens (#24218) 2018-11-11 10:57:41 -08:00
Jonah Williams 5839710859
Throw a better error when old test versions are loaded. (#24217) 2018-11-10 19:32:35 -08:00
Jonah Williams a871d59164
Apply basic log filtering and formatting to fuchsia logs. (#24143) 2018-11-10 17:02:32 -08:00
Dan Field 2729385758
Make host app test actually test host app (#24131)
* Make host app test actually test host app

* mark updated test as flaky
2018-11-09 19:09:56 -08:00
Jonah Williams 26a6fd92d8
do not compute dart deps for fuchsia_entrypoint (#24134) 2018-11-09 15:41:13 -08:00
Jonah Williams c11633e84e
Separate hot reload and hot restart capabilities. (#24122) 2018-11-09 10:33:22 -08:00
Jonah Williams ae2b215efe
make sure we dont use test (#24146) 2018-11-09 00:40:29 -08:00
Todd Volkert 95c9ae451e
Update packages --force-upgrade (#24126) 2018-11-08 22:31:22 -08:00
Ian Hickson 6bfd9bb996 Fix a race condition in vmservice_test.dart (#23835)
Fixes https://github.com/flutter/flutter/issues/19273
2018-11-08 20:54:06 -08:00
Danny Tuppeny 2d5ed986e1
Update integration tests to use vm_service_lib (#23937)
* Move integration tests to use vm_service_lib
* Turn off debug logging that was accidentally committed
* Run update-packages --force to fix checksum for new dev dependency
* Trim trailing whitespace
2018-11-08 07:55:54 +00:00
Jonah Williams d04fa1a670
only pass packages once (#24074) 2018-11-07 21:57:00 -08:00
Dan Field 9d53d7f848
Update pubspec template docs for module/plugin (#24081)
* Document module pubspec

* update doc on plugin template

* clarify language
2018-11-07 17:20:18 -08:00
Ian Hickson f9374fe071
Update the URL to the recommend bug report (#23708)
We have templates now.
2018-11-07 17:12:35 -08:00
jslavitz 5dac7a2347
Removes check for Homebrew if all necessary packages are present. (#23844)
* Removes need for homebrew installation if all other packages are installed. Modifies test to work with this new functionality.
2018-11-07 15:21:05 -08:00
Jonah Williams 00c07266c1
add frontend server as a non dart dep of fuchsia_tool (#24075) 2018-11-07 15:14:35 -08:00
Ryan Macnak d92d175bcb Opt into deterministic snapshots.
Also, remove old flags.
2018-11-07 14:44:20 -08:00
jslavitz 50fb729609
Includes frameworkVersion in JSON version output (#23891)
* Include framework version in JSON output and adds test
2018-11-07 12:28:22 -08:00
Jonah Williams 6c88b2e9fb
restore compileExpressionService (#24063) 2018-11-07 12:04:05 -08:00
Dan Field 028087d0fc
fix identifier for release.xcconfig in module template (#23978) 2018-11-06 22:44:01 -08:00
Jonah Williams 2fc2581be4
unpin mockito (#24021) 2018-11-06 17:24:39 -08:00
jslavitz 34fa90b062
Improves SDK Search Error Messages (#23884)
* Improves error message and adds test.
2018-11-06 15:13:35 -08:00
Jonah Williams 81c7af342d
Add fuchsia specific entrypoint (#23916) 2018-11-06 14:36:35 -08:00
Jonah Williams e862580518
move file back (#24014) 2018-11-06 11:09:57 -08:00
xster 7be8562202
Add cupertino_icons dependency to module pubspec template (#23961) 2018-11-06 10:52:00 -08:00