Commit graph

16209 commits

Author SHA1 Message Date
Jonah Williams 1982a5c3ec
Revert "Clean up test infrastructure (#41880)" (#42982)
This reverts commit 1781d5c9bb.
2019-10-17 19:47:16 -07:00
Ian Hickson be7937965c
Reenable the dartdocs benchmark tracking (#42882) 2019-10-17 19:32:31 -07:00
Ian Hickson 1781d5c9bb
Clean up test infrastructure (#41880) 2019-10-17 19:22:47 -07:00
Jonah Williams 863fb2f2cc
Remove linux-x64 unpack logic (#42962) 2019-10-17 19:22:03 -07:00
Jonah Williams b80e6bba6a
re-enable some linux devicelab tests (#42971) 2019-10-17 19:21:52 -07:00
Jonah Williams f53b32eb23
refactor depfile usage and update linux rule (#42487) 2019-10-17 17:42:40 -07:00
Ryan Macnak 315471bfb0
Do not produce an error when encountering a new type in a service response. (#42972)
Flutter tool's service client library tries to "upgrade" sub-components of service responses with higher level model objects. It does this for all members of the response, rather than only those documented in the version it targets, and it errors out when encountering a new type. This causes it to fail when a new field is introduced with a new typed. Clients are required to ignore this.
2019-10-17 16:56:57 -07:00
Michael Goderbauer ddca78b4b7
Fix memory leak in TransitionRoute (#42777) 2019-10-17 15:51:45 -07:00
Jaumard 1faf6a9a89 create gesture recognizers on attach and dispose on detach to avoid leaks (#42076) 2019-10-17 15:48:20 -07:00
Jenn Magder b194f93541
Remove use_modular_headers from Podfiles using libraries (#42872)
* Remove use_modular_headers from Podfiles using libraries

* Remove @imports
2019-10-17 15:26:10 -07:00
Jonah Williams bc396d1b5c
Add onVisible callback to snackbar. (#42344) 2019-10-17 15:12:25 -07:00
Greg Spencer a7aa66164e
Re-implement hardware keyboard text selection. (#42879)
This re-implements keyboard text selection so that it will work on platforms other than Android (e.g. macOS, Linux, etc.).

Also, fixed a number of bugs in editing selection via a hardware keyboard (unable to select backwards, incorrect conversion to ASCII when cutting to clipboard, lack of support for CTRL-SHIFT-ARROW word selection, etc.).

Did not address the keyboard locale issues that remain, or add platform specific switches for the bindings. All that will need some more design work before implementing them.

Related Issues
Fixes #31951
2019-10-17 15:11:44 -07:00
Ferhat f7ce5ae3fc
[web] Update web runner message with flutter.dev/web (#42676)
* Update web runner message with flutter.dev/web

* Update spoopy test to use Warning instead
2019-10-17 15:08:15 -07:00
Shi-Hao Hong 3dc8898e10
Revert "Default colorScheme data in ButtonThemeData (Fix for #38655) (#39627)" (#42854)
This reverts commit 19899db223.
2019-10-17 15:07:42 -07:00
Hans Muller 0a7e605632
Support AppBars with jumbo titles (#42936) 2019-10-17 15:01:41 -07:00
Greg Spencer 3afdd08af4
This disables the up/down arrow focus navigation in text fields in a different way. (#42790)
In #42533, I disabled the up/down arrows for focus navigation in text fields, but we thought of a better way to do it, so this is that better way.

This change reverts the other change, and instead it tests the context of the node in the action to see if it's an EditableText node. If so, then it doesn't do the navigation action.
2019-10-17 15:01:22 -07:00
engine-flutter-autoroll e007720a16
508146f0d Add a task runner for the Win32 embedding (flutter/engine#13043) (#42898)
git@github.com:flutter/engine.git/compare/3a357afc0372...508146f0defb

git log 3a357afc0372..508146f0defb --no-merges --oneline
2019-10-17 stuartmorgan@google.com Add a task runner for the Win32 embedding (flutter/engine#13043)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-17 13:31:06 -04:00
engine-flutter-autoroll a4d5266b76
Roll engine 9660eddaa588..3a357afc0372 (6 commits) (#42895)
git@github.com:flutter/engine.git/compare/9660eddaa588...3a357afc0372

git log 9660eddaa588..3a357afc0372 --no-merges --oneline
2019-10-17 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1dfc77cc08ee..f29cb70281d5 (1 commits) (flutter/engine#13195)
2019-10-17 bkonyi@google.com Roll src/third_party/dart b28b9ae8fc..f020ce5d23 (14 commits)
2019-10-17 chinmaygarde@google.com Remove incomplete static thread safety annotations. (flutter/engine#13151)
2019-10-16 garyq@google.com Add utils to disable on mac/windows, disable invalid LibLxt tests on mac (flutter/engine#13189)
2019-10-16 liyuqian@google.com Update timeout_microseconds to timeout in docs (flutter/engine#13179)
2019-10-16 chinmaygarde@google.com Use the fixtures mechanism for txt unit-tests and benchmarks. (flutter/engine#13180)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-17 01:13:06 -04:00
Emmanuel Garcia 08c645b3b2
Test the Android embedding v2 (#42708)
* Test the Android embedding v2

* Update integration tests

* Split into shards
2019-10-16 21:26:10 -07:00
engine-flutter-autoroll 3917e585c9
Roll engine d4be9c1637cf..9660eddaa588 (5 commits) (#42883)
git@github.com:flutter/engine.git/compare/d4be9c1637cf...9660eddaa588

git log d4be9c1637cf..9660eddaa588 --no-merges --oneline
2019-10-16 bkonyi@google.com Roll src/third_party/dart ed1e0e199e..b28b9ae8fc (3 commits)
2019-10-16 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from oTVah... to ek5iQ... (flutter/engine#13186)
2019-10-16 jason-simmons@users.noreply.github.com Remove redundant call to updateEditingState in sendKeyEvent (flutter/engine#13175)
2019-10-16 hterkelsen@users.noreply.github.com If we get a 'down' event, add that device to the active devices. (flutter/engine#13182)
2019-10-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4e11526e3d7e..1dfc77cc08ee (9 commits) (flutter/engine#13183)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-17 00:23:06 -04:00
engine-flutter-autoroll 45002c5b7a
d4be9c163 Roll fuchsia/sdk/core/mac-amd64 from KVDL4... to 6j3Gw... (flutter/engine#13184) (#42876)
git@github.com:flutter/engine.git/compare/43b33d743aa8...d4be9c1637cf

git log 43b33d743aa8..d4be9c1637cf --no-merges --oneline
2019-10-16 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from KVDL4... to 6j3Gw... (flutter/engine#13184)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-16 20:19:06 -04:00
engine-flutter-autoroll 4033157531
Roll engine bb78551a0a3d..43b33d743aa8 (4 commits) (#42874)
git@github.com:flutter/engine.git/compare/bb78551a0a3d...43b33d743aa8

git log bb78551a0a3d..43b33d743aa8 --no-merges --oneline
2019-10-16 liyuqian@google.com Revert "Update compiler to Clang 10. (#13177)" (flutter/engine#13181)
2019-10-16 chinmaygarde@google.com Update compiler to Clang 10. (flutter/engine#13177)
2019-10-16 chinmaygarde@google.com Document //flutter/runtime/dart_isolate.h (flutter/engine#13162)
2019-10-16 jason-simmons@users.noreply.github.com Fix an output file path for the frontend server package_incremental script (flutter/engine#13154)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-16 19:13:06 -04:00
Jonah Williams cb518c4219
Fix progress indicators for release/profile builds of web. (#42857) 2019-10-16 16:10:06 -07:00
Jonah Williams 01f779e97a
Fix NPE in Chrome Device (#42813) 2019-10-16 15:46:07 -07:00
engine-flutter-autoroll fbbc4fa868
Roll engine 5e6c005ef1f9..bb78551a0a3d (3 commits) (#42866)
git@github.com:flutter/engine.git/compare/5e6c005ef1f9...bb78551a0a3d

git log 5e6c005ef1f9..bb78551a0a3d --no-merges --oneline
2019-10-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia 59e72b71b5cf..4e11526e3d7e (10 commits) (flutter/engine#13174)
2019-10-16 hterkelsen@users.noreply.github.com Fix type error in SkVertices (flutter/engine#13157)
2019-10-16 bkonyi@google.com Roll src/third_party/dart 41b65b27c2..ed1e0e199e (18 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-16 17:17:06 -04:00
Gary Qian 3bbf54d79f
Reland "Expose API for resizing image caches #41415" (#42785) 2019-10-16 14:15:13 -07:00
Ray Rischpater, KF6GPE 430f4c13fa
Use Cirrus credits for billing. (#42867) 2019-10-16 13:33:31 -07:00
Emmanuel Garcia 0a93f4eb75
Remove isNewAndroidEmbeddingEnabled flag when reading an existing pro… (#42684) 2019-10-16 12:47:04 -07:00
engine-flutter-autoroll 1dc09e4c72
Roll engine 540fc977bb6b..5e6c005ef1f9 (33 commits) (#42853)
git@github.com:flutter/engine.git/compare/540fc977bb6b...5e6c005ef1f9

git log 540fc977bb6b..5e6c005ef1f9 --no-merges --oneline
2019-10-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia 083a75d6762c..59e72b71b5cf (1 commits) (flutter/engine#13169)
2019-10-16 a-siva@users.noreply.github.com Roll src/third_party/dart 4131d3d7c4...41b65b27c2 (28 commits) (flutter/engine#13163)
2019-10-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia 7274850f96f2..083a75d6762c (1 commits) (flutter/engine#13168)
2019-10-16 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from 5I4Iw... to oTVah... (flutter/engine#13167)
2019-10-16 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from qpzUe... to KVDL4... (flutter/engine#13166)
2019-10-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia 634d15032d37..7274850f96f2 (3 commits) (flutter/engine#13165)
2019-10-16 yjbanov@google.com Move surface-based SceneBuilder implementation under surface/ (flutter/engine#13159)
2019-10-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia ba8752f37dab..634d15032d37 (2 commits) (flutter/engine#13164)
2019-10-16 chinmaygarde@gmail.com Revert "Issue 13238: on iOS, force an orientation change when the current orientation is not allowed" (flutter/engine#13160)
2019-10-15 chinmaygarde@google.com Roll buildroot to pull in static thread safety analysis options. (flutter/engine#13155)
2019-10-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia fb6a1abe4567..ba8752f37dab (8 commits) (flutter/engine#13156)
2019-10-15 chinmaygarde@google.com Make the Dart isolate constructor private. (flutter/engine#13153)
2019-10-15 iska.kaushik@gmail.com Revert "Upgrades the ICU version to 64.2 (#13123)" (flutter/engine#13146)
2019-10-15 1541038+josh-ksr@users.noreply.github.com Issue 13238: on iOS, force an orientation change when the current orientation is not allowed (flutter/engine#12295)
2019-10-15 chinmaygarde@google.com Allow embedders to specify a render task runner description. (flutter/engine#13124)
2019-10-15 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from Jv4XM... to 5I4Iw... (flutter/engine#13150)
2019-10-15 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from i5xD1... to qpzUe... (flutter/engine#13149)
2019-10-15 bkonyi@google.com Roll src/third_party/dart fc933312f7..4131d3d7c4 (3 commits)
2019-10-15 chinmaygarde@google.com Document //flutter/runtime/dart_vm (flutter/engine#13144)
2019-10-15 iska.kaushik@gmail.com Revert "Enable/tweak web sdk source maps (#13141)" (flutter/engine#13148)
2019-10-15 jason-simmons@users.noreply.github.com Merge the Fuchsia frontend_server build script into the new flutter_frontend_server target (flutter/engine#13145)
2019-10-15 iska.kaushik@gmail.com Add `flutter_tester` binary to the CIPD package (flutter/engine#13143)
2019-10-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia f22c57ddcc8c..fb6a1abe4567 (2 commits) (flutter/engine#13142)
2019-10-15 vsm@google.com Enable/tweak web sdk source maps (flutter/engine#13141)
2019-10-15 filmil@gmail.com Upgrades the ICU version to 64.2 (flutter/engine#13123)
2019-10-15 rmacnak@google.com [frontend_server] Include bytecode generation in the training run. (flutter/engine#13126)
2019-10-15 wvvwwvw@gmail.com Support empty strings and vectors in standard codec (flutter/engine#12974)
2019-10-15 bkonyi@google.com Roll src/third_party/dart 50f7ae9c5d..fc933312f7 (2 commits)
2019-10-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia 55f9cba6e2e7..f22c57ddcc8c (1 commits) (flutter/engine#13136)
2019-10-15 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from xRgq0... to Jv4XM... (flutter/engine#13135)
2019-10-15 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Lk7iT... to i5xD1... (flutter/engine#13134)
2019-10-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia 858cf233ef71..55f9cba6e2e7 (3 commits) (flutter/engine#13133)
2019-10-15 bkonyi@google.com Roll src/third_party/dart 70a7ef3f58..50f7ae9c5d (18 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
...
2019-10-16 15:43:08 -04:00
Yegor 86f069f1c0
Add most of the widget tests; add more web test shards (#42807) 2019-10-16 09:18:44 -07:00
creativecreatorormaybenot a665393a0d Fix Tooltip implementation of PopupMenuButton (#42613)
* Fix tooltip not showing when PopupMenuButton.child was non-null
2019-10-16 09:01:24 -07:00
Jenn Magder b9817b4f59
Run flutter pub get before pod install in platform_view_ios__start_up test (#42808) 2019-10-15 17:36:34 -07:00
Jenn Magder 357d02c87b
Always embed Flutter.framework build mode version from Xcode configuration (#42029) 2019-10-15 15:33:55 -07:00
Jonah Williams ad1d67e0a1
serve correct content type from debug server (#42701) 2019-10-15 15:25:57 -07:00
Yegor 21a18fbe16
enable rendering rests on the Web (#42773) 2019-10-15 15:25:47 -07:00
Jonah Williams 68e768dbcf
fix type error in manifest asset bundle (#42791) 2019-10-15 15:25:33 -07:00
liyuqian 31cb44825c
Add --cache-sksl flag to drive and run (#42353)
So we can test SkSL precompile using the command line tools.
See https://github.com/flutter/engine/pull/12412.
2019-10-15 14:28:55 -07:00
Jacob MacDonald 3f1f22c26e
dont precompile dependencies when building the flutter tool (#42771) 2019-10-15 13:34:04 -07:00
Jonah Williams e22d4aa140
Add debugging option to write vmservice address to file after starting (#41583) 2019-10-15 13:05:47 -07:00
Christopher Fujino 428d7d7f2d
dispose devices on cleanupAtFinish() for run_cold.dart (#42668) 2019-10-15 12:50:44 -07:00
Jonah Williams daa7143c08
Unpin test and update packages (#42699) 2019-10-15 12:50:10 -07:00
Jenn Magder dda74a1993
Increase template Swift version from 4 to 5 (#41882) 2019-10-15 12:37:13 -07:00
Jenn Magder 649cf82018
use_modular_headers (#42204) 2019-10-15 12:36:50 -07:00
Janice Collins 13a054f76e
Update dartdoc to 0.28.8 (#42686) 2019-10-15 12:32:10 -07:00
Jason Simmons fb33b7a1b8
Use placeholder dimensions that reflect the final text layout (#42558)
The _computeChildren[Width/Height]With[Min/Max]Intrinsics methods in
RenderParagraph overwrite the text painter's placeholder dimensions
in order to compute potential widths and heights for the paragraph.

The placeholder dimensions should be restored to the values computed by
_layoutChildren before painting the text.
2019-10-15 10:17:52 -07:00
Shi-Hao Hong 0821b759f5
Typo fixes (#42688) 2019-10-15 10:06:50 -07:00
Jonah Williams 7f8e89b5dc
Revert "Expose API for custom image decode and cache sizes (#41415)" (#42764) 2019-10-15 08:42:55 -07:00
Gary Qian b857632306
Expose API for custom image decode and cache sizes (#41415) 2019-10-15 00:07:32 -07:00
Luiz França 1ea6a38fa7 Adding thumb color customisation functionality to CupertinoSlider (#42563) 2019-10-14 23:31:05 -07:00
engine-flutter-autoroll b5424ebaac
540fc977b Roll src/third_party/skia 7d7aaf46aeb4..858cf233ef71 (1 commits) (flutter/engine#13131) (#42706)
git@github.com:flutter/engine.git/compare/49a8e451b8dd...540fc977bb6b

git log 49a8e451b8dd..540fc977bb6b --no-merges --oneline
2019-10-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia 7d7aaf46aeb4..858cf233ef71 (1 commits) (flutter/engine#13131)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2019-10-15 01:21:43 -04:00