Commit graph

9433 commits

Author SHA1 Message Date
Jonah Williams 2e8f173f7d
Add flutter_build package for codegen and version sync with tool (#26978) 2019-01-25 16:06:25 -08:00
Michael Goderbauer b8190446b6
Typo fixes for notched_shapes.dart (#27097) 2019-01-25 12:18:13 -08:00
Dan Field f9e6242db9
Use mDNS to discover the device port (#26944)
* Discover port over mDNS

* opt in, only for iOS for now
2019-01-25 12:12:17 -08:00
Gary Qian 06b979c4d5
Revert "Warn when building on master channel (#25007)" (#27096)
This reverts commit dd65a54628.
2019-01-25 14:27:35 -05:00
Gary Qian d0595f6bbd
Explain font platform inconsistency (#26996) 2019-01-25 13:40:05 -05:00
tonyzhao1 e4df6b4efc Change the required version of adb, as older versions break hot reload. (#24746) 2019-01-25 10:37:46 -08:00
Jonah Williams fa5f3da6f2
Update flutter clean to remove .dart_tool directory (#27054) 2019-01-25 09:30:11 -08:00
Chris Bracken 731221c3e8
Improve documentation on decodeSyslog (#27039)
It appears that the encoding Apple is using to ensure their syslog
conforms with the syslog requirement for seven-bit ASCII encoding (see:
RFC 5424) is `vis`.

Details: https://www.freebsd.org/cgi/man.cgi?query=vis&sektion=3
2019-01-25 06:34:30 -08:00
Gary Qian b028ee142c Revert "Experimental flags for hot reloads, fixed" (#27059)
* Revert "Make UriMapper and StdoutHandler public and add test cases (#26932)"

This reverts commit 6cf554b0c4.

* Revert "Update packages (#27046)"

This reverts commit 496c57386b.

* Revert "roll engine for TODAY bug (#27049)"

This reverts commit 5ae6346f1d.

* Revert "Warn when building on master channel (#25007)"

This reverts commit dd65a54628.

* Revert "Add experimentalBuildEnabled flag and initial shim for build_runner (#26989)"

This reverts commit 1237ee8f63.

* Revert "Experimental flags for hot reloads, fixed (#27043)"

This reverts commit 2c05d08f0c.
2019-01-24 18:37:56 -08:00
Jonah Williams 6cf554b0c4
Make UriMapper and StdoutHandler public and add test cases (#26932) 2019-01-24 16:17:04 -08:00
Dan Field 496c57386b
Update packages (#27046)
* Update packages

* Change test for isFile
2019-01-24 16:02:45 -08:00
Gary Qian dd65a54628
Warn when building on master channel (#25007) 2019-01-24 19:01:07 -05:00
Jonah Williams 1237ee8f63
Add experimentalBuildEnabled flag and initial shim for build_runner (#26989) 2019-01-24 15:59:55 -08:00
Liam Appelbe 2c05d08f0c
Experimental flags for hot reloads, fixed (#27043)
* Revert "Revert "Experimental flags for hot reloads (#26988)" (#27037)"

This reverts commit cf7441983e.

* Fix analysis failures
2019-01-24 15:58:38 -08:00
Jason Simmons 7bfbc28505
Revert "Upgrade the Gradle script to Android plugin version 3.3.0 (#26913)" (#27045)
This reverts commit 30f33d6c7d.
2019-01-24 14:29:08 -08:00
Jason Simmons 30f33d6c7d
Upgrade the Gradle script to Android plugin version 3.3.0 (#26913)
Fixes https://github.com/flutter/flutter/issues/26544
2019-01-24 12:21:11 -08:00
Dan Field cf7441983e
Revert "Experimental flags for hot reloads (#26988)" (#27037)
This reverts commit 763bf11460.
2019-01-24 10:02:38 -08:00
Liam Appelbe 763bf11460
Experimental flags for hot reloads (#26988)
* First pass at incremental exp flags

* adkfgjh
2019-01-24 09:48:10 -08:00
Frederik Schweiger d1bde2edde Add reverse functionality to repeat() of AnimationController (#25125) 2019-01-24 09:30:45 -08:00
Will Larche c362d8da07 [Material] Theme data type for cards (#26796)
This change adds a CardTheme and tests for it.

Golden is here:
ec26eeebb4/packages/flutter/test/material/card_theme.custom_shape.png

From commit:
ec26eeebb4 (diff-7564b206413654283ddc5cb59ecd64d4)
2019-01-24 11:01:21 -05:00
Jonah Williams 1b21d69de4
Support running macOS prebuilt application (#26593) 2019-01-23 16:32:50 -08:00
Chris Bracken 65a70bc7d3
Re-enable use of ParagraphConstrains const ctor (#26990)
All embedders of Flutter within Google have all been updated to an
engine version that includes the const constructor added in
flutter/engine#7346 and rolled into the framework in
flutter/flutter#26252.

This reverts commit 88b77a7d0f.

This fixes https://github.com/flutter/flutter/issues/26390.
2019-01-23 16:32:23 -08:00
Dan Field ded49cda27
Assert when calling a method that tries to use the ticker unsafely after dispose (#26991) 2019-01-23 16:30:41 -08:00
Dan Field 19b8d2e0a9
Detect Android SDK 28/28.0.3 (#26942)
* Detect Android SDK 28/28.0.3

* revert minimumAndroidSdkVersion const change
2019-01-23 15:56:48 -08:00
Alexandre Ardhuin 66f424f0f8
fix some bad indentations (#26921)
* fix some bad indentations

* remove suspicious line
2019-01-23 15:43:27 +01:00
Jonah Williams c1fabb9860
make FDE opt-in via the environment variable (#26898) 2019-01-22 18:40:13 -08:00
Hans Muller 7619c68655
Add Dismissible.confirmDismiss callback (#26901) 2019-01-22 16:39:09 -08:00
Hans Muller c37b7c535c
Dismissible not dismissable (#26911) 2019-01-22 15:06:56 -08:00
jslavitz cf4fc966f4
Transition Curve Fix (#25488)
* Changes Cupertino page transition curves to make paging animations more similar to those of native iOS
2019-01-22 12:46:39 -08:00
Kartik Sharma 5b3e933c7f Added Sample code for Stack widget (#26586) 2019-01-22 12:31:10 -08:00
xster 890085e9b0
Add another test to ImageStream (#26693) 2019-01-22 11:29:00 -08:00
xster 8098b5e63e
Fill editable_text.dart test coverage (#26793) 2019-01-22 10:51:39 -08:00
Andrew Davies 33cd720db6
[frdp] Adds paths for find and ls for Fuchsia execution. (#26680)
Adds full path for `find` and `ls` commands.
2019-01-22 10:49:17 -08:00
Jonah Williams f777db2b78
add uiMode to android:configChanges (#26896) 2019-01-22 10:37:22 -08:00
rami-a af0758e67d
[Material] Implement App Bar Theme (#26597)
This change creates an `AppBarTheme` to be used with `AppBar` widgets. This allows for users to theme their AppBars separately from their overall Theme if they choose.
2019-01-22 09:39:58 -05:00
sjindel-google 4881777203
Fix behavior of handleDrawFrame() in benchmark mode. (#25049) 2019-01-22 11:46:14 +01:00
Dan Field 543f8924b4
Avoid calling cancel on AnsiSpinner more than once when building for iOS (#26826)
* Avoid calling cancel more than once

* add some missing checks for ansispinner
2019-01-21 22:41:35 -08:00
Dan Field 386f3466b5
Roll engine to 05fee4eeee0ff6b219b1fcc394371e5f6963cc46 (#26713)
* move flutter_assets to App.framework

* Roll engine to 05fee4eeee0ff6b219b1fcc394371e5f6963cc46

05fee4eee Update default flutter_assets path for iOS embedding (flutter/engine#7518)
02205db01 Roll src/third_party/skia 5d052dac3ac1..02738a86e5fd (4 commits) (flutter/engine#7541)
af907c074 Roll src/third_party/skia 5c7a3ac0e214..5d052dac3ac1 (7 commits) (flutter/engine#7540)
dde286673 IWYU to get SkFontMetrics (flutter/engine#7539)
2019-01-21 21:23:04 -08:00
Dan Field d8d36bc7e8
targetSdkVersion 28 (#26798) 2019-01-19 11:59:42 -08:00
Mehmet Fidanboylu c8379ad54f
Better ListTile leading/trailing widget alignment (#26778) 2019-01-19 11:55:05 -08:00
Ian Hickson 31a9626c48
[O] Removing all timeouts (mark II) (#26736)
These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
2019-01-19 00:31:05 -08:00
jslavitz 7751144c23
Revert switch drag behavior (#26770) 2019-01-18 13:13:35 -08:00
rami-a 1b0f2015a2
Fix lerp in textTheme to allow for null parameters (#26764)
There's no reason to disallow this as TextStyle can handle lerping between null parameters just fine. This change also adds tests to ensure the correct behavior
2019-01-18 14:28:30 -05:00
Alexander Aprelev 07c592d901
Report early error if appropriate host local engine is not found. (#26766) 2019-01-18 11:26:54 -08:00
MH Johnson 5d0c1b86ee
[Material] Inline the single Theme.of(context) call in BAB (#26765) 2019-01-18 14:13:14 -05:00
Jonah Williams 8c5a41113e
Add support for reverse to ReorderableListView (#26203) 2019-01-18 10:10:44 -08:00
Jonah Williams 830c0dfe83
Allow attaching to profile builds (#26720) 2019-01-18 10:09:44 -08:00
Greg Spencer 179fa90489
Fix some doc references (#26441) 2019-01-18 10:07:55 -08:00
Liam Appelbe 9eada88b3e
Experimental flags in flutter (#26715)
* exp flags in flutter

* Fix test failures
2019-01-18 09:07:14 -08:00
jslavitz 4fe79442c8 Reverts default DragStartBehavior to DragStartBehavior.down (#26734) 2019-01-17 19:36:48 -08:00
Jason Simmons f4c5e3eef2
[Gradle] Copy ICU data to flutter_shared only when building an AAR module (#26668)
This is based on 9880baa396
but will support building APKs with --local-engine
2019-01-17 16:33:14 -08:00
MH Johnson 6c07863f8d
[Material] Refactor _build<Widget> methods in BottomNavBar (#26722) 2019-01-17 19:02:34 -05:00
Konstantin Pozin 29fb6159db [flutter_localizations] Add BUILD.gn for flutter_localizations (#26440) 2019-01-17 15:47:57 -08:00
mcplectrum b4daf33807 Fix Podfile issue #24342 (#25079)
* Fix Podfile issue #24342

Sometimes base configurations  (config.base_configuration_reference) can be nil, which leads to undefined method `real_path' for nil:NilClass.

* Disable bitcode in every case
2019-01-17 15:00:51 -08:00
Michael Goderbauer 45a70efa8a
Respect EditableText.keyboardAppearance (#26721) 2019-01-17 14:54:35 -08:00
Will Larche 60e9c5856d
[FAB] Adding FAB as class in tests. (#26192)
* [FAB] Adding FAB as class in tests.

* [Material] FAB theme tests corrected. Also deeper into Material for elevation testing.

* [Material] Comment clarification.

* [Material] TODO formatting.

* [Material] Formatting.

* [Material] Comment correction.

* [Material] Updated values.

* [Material] Removing comment, low-level check, and adding safety.
2019-01-17 14:39:22 -08:00
Stanislav Baranov eb8219edd5
Emulator support for dynamic mode on Intel architecture (#26565) 2019-01-17 14:21:35 -08:00
David Shuckerow 9e4c964072
Add animation tests for changes to the FloatingActionButtonLocation (#23677)
* Add more animation tests for rotation

* Test animation progress

* Progress on the tests

* Everything 'works'

* We don't need to guarantee the rotation of the fab as it exits.

* Remove print statement

* Cleanup extra lines

* Remove whitespace
2019-01-17 14:48:28 -06:00
Michael Goderbauer 975ea595e9
Fix missing const analyzer warning (#26716)
Introduced by merging an old PR (https://github.com/flutter/flutter/pull/21157).
2019-01-17 12:23:55 -08:00
Remi Rousselet 649f49d4bf Swap scope with gesture (#21157) 2019-01-17 11:11:35 -08:00
Michael Goderbauer 56039b4ba7
Make getOffsetToReveal work with nested Viewports (#26663)
Fixes #20893, the most-upvoted bug for framework.

A detailed analysis explaining the cause of the bug has been posted at #20893 (comment).
2019-01-17 11:03:07 -08:00
Gazihan Alankus 7e22b5f2c5 Doc fix: SliverChildBuilderDelegate is the lazy one (#26690) 2019-01-17 09:51:50 -08:00
Jonah Williams fb2467d0af
Add documentation for how to use annotated region (#24989) 2019-01-17 09:30:05 -08:00
abykov2 3c0a74ef0f Adding a shutdown hook to HotRunnerConfig (#26604) 2019-01-17 08:49:02 -08:00
Kenzie Schmoll 33bfa6a7c5
Register hotRestart service in flutter_tools. (#26669)
* Register hot restart service in flutter_tools.
2019-01-17 08:28:54 -08:00
Danny Tuppeny 244b077bee
Give integration tests unique temp folder names (#26227)
This will help track down any that aren't cleaning up and also may help track down leaked flutter_tester processes (https://github.com/dart-lang/sdk/issues/35549).
2019-01-17 11:29:18 +00:00
Jonah Williams 83b9497c69
do not exit tool if fuchsia workflow fails (#26589) 2019-01-16 17:43:01 -08:00
Ian Hickson 800a6e1670 Quick fix for tap-to-show-keyboard regression (#26629)
* Fixes Android keyboard bug
2019-01-16 17:30:26 -08:00
Dan Field 4c99958df6
Revert "Move flutter_assets to App.framework (#26630)" (#26675)
This reverts commit d8db70af1a.
2019-01-16 16:46:37 -08:00
Luca Zuccarini 36a493602c Create an injectable factory for application packages. (#26422) 2019-01-16 14:12:47 -08:00
Dan Field d8db70af1a
Move flutter_assets to App.framework (#26630)
* move flutter_assets to App.framework

* remove flutter_assets references from all pbxproj files checked in
2019-01-16 14:02:54 -08:00
Vyacheslav Egorov 8f65ee9f53
Fix --build-shared-library on newer NDKs (#26642)
Newer NDKs switched to clang which by default uses system linker, instead
we need to force it to use appropriate toolchain linker by passing
-fuse-ld= command line flag.

Fixes #23458
2019-01-16 21:30:37 +01:00
Kenzie Schmoll a172de0159
Send ServiceExtensionToggled event when service extension is set to a value. (#26426) 2019-01-16 12:29:20 -08:00
Vyacheslav Egorov 7c434a5cf2
Revert "Add flutter_shared assets to module artifact (#23782)" (#26644)
This reverts commit 9880baa396.

Reason for revert: broke `--local-engine` command line option.
2019-01-16 21:23:18 +01:00
Kyrel Jerome a0f58c5e7a Grammatical fix: "places" to "placed" (#26482) 2019-01-16 10:43:29 -08:00
Chris Bracken 9a7b1a73bd
Replace platform check with swtich (#24752)
Generally, we should always use default-less switches for
platform-specific behaviour so we're forced to make a conscious decision
on each instance of such behaviour any time we add support for a new
platform.
2019-01-16 10:31:44 -08:00
MH Johnson 5e8e39723d
[Material] TabBarTheme text style parameters (#26533)
* Add labelStyle + unselectedLabelStyle to TabBarTheme
2019-01-16 13:30:21 -05:00
Michael Goderbauer e4c8f1b993
3D SemanticsTree (#25670) 2019-01-16 10:29:00 -08:00
Justin McCandless 14faa8d935
Fix rounding error in build tests (#26652) 2019-01-16 09:48:04 -08:00
Michael Goderbauer b4e9d0a440
Add tests for getOffsetToReveal on RenderSlivers (#26598) 2019-01-16 08:47:37 -08:00
rami-a f22043e25f
Prevent crash when calling lerp for IconThemeData with null arguments (#26592)
The lerp method for IconThemeData was not doing anything to prevent exceptions when null arguments are used. This change fixes that and adds a test for it.
2019-01-16 11:42:29 -05:00
Hans Muller 14f486685e
Updated AlertDialog content doc (#26613) 2019-01-16 08:35:51 -08:00
Hans Muller fbedd97682
IconButton backgroundColor doc sample (#26611) 2019-01-16 08:35:34 -08:00
Justin McCandless 105026cd68
Fix descenders cutoff in TextField (#26309)
* Include caret gaps in position calculation to avoid descender cutoff

* Calculate caret offset instead of exposing it

* Test that textfields scroll vertically by full line height

* Only add offset to end of caret to avoid going above 0.0

* Fix and test horizontal vs. vertical scrolling

* CR: docs and top caret offset logic

* Take max instead of assuming caretRect.top is always a full line down

* Always subtract caretOffset from caretTop since caretRect.top can be negative
2019-01-16 08:13:00 -08:00
Chris Bracken 584ef083c7
Replace Android-specific check with switch (#24754)
Generally, we should always use default-less switches for
platform-specific behaviour so we're forced to make a conscious decision
on each instance of such behaviour any time we add support for a new
platform.
2019-01-15 19:42:55 -08:00
Seth Westphal 71a15896d8 Fix error message and other typos (#25126) 2019-01-15 19:22:32 -08:00
Michael Goderbauer f3f2d5a1bd
Remove TODO, reduce tech debt (#26612)
I fixed this TODO a while ago during my a11y work.
2019-01-15 19:06:07 -08:00
Michael Goderbauer e8bfa81b70
Roll engine to 5983e34a3c0e1217da7e8bbe9f2fe685048fe259 (#26596) 2019-01-15 19:00:05 -08:00
Gary Qian fc779c69a7
Add Golden test for background painting order. (#25988) 2019-01-15 19:40:39 -05:00
Ian Hickson 29928a46ed
Support setting the elevation of disabled floating action buttons (#24728)
Previously, a disabled floating action button always had zero
elevation, which looks dumb.

This also fixes the issue whereby highlightElevation was not honoured
on floating action buttons.

This also fixes an issue I found during testing whereby setState was
being called during build when onHighlightChanged fired due to
onPressed becoming null while a gesture is ongoing (which triggers an
onTapCancel synchronously during build).
2019-01-15 15:06:29 -08:00
Chris Bracken d7458e3da4
Add asserts for @required parameters (#26449)
Adds asserts on required constructor parameters to a transition widgets.
This improves debuggability for those who aren't developing with live
analysis. e.g. when `turns` is not specified in a RotationTransition
constructor:

  package:flutter/src/widgets/transitions.dart: Failed assertion: line 43 pos 15: 'listenable != null': is not true.

becomes:

  package:flutter/src/widgets/transitions.dart': Failed assertion: line 259 pos 15: 'turns != null': is not true.
2019-01-15 10:24:06 -08:00
Igor Borges 9880baa396 Add flutter_shared assets to module artifact (#23782)
copySharedFlutterAssetsTask copies the `flutter_shared` folder assets to android's `src/main` folder of Flutter project, so that folder is bundled on the generated AAR
2019-01-15 10:23:19 -08:00
Amir Hardon cbff7ca43c
Cleanup temporary catchError. (#26454)
This was added to make sure we don't crash before the engine is rolled
with the system channel API addition and is no longer needed.
2019-01-15 10:13:48 -08:00
tonyzhao1 3f3a829c88 Move runner directory messages to the user messages class (#25682) 2019-01-15 10:06:44 -08:00
Dan Field f0620f4776
add type parameter back to PageRouteFactory (#26559) 2019-01-15 10:01:37 -08:00
Dan Field 774e8c18e3
remove ignore_for_file lints (#26545)
* remove ignore_for_file lints

* update comments

* remove example
2019-01-15 08:42:47 -08:00
Dan Field 025d04ad52
remove todo (#26562) 2019-01-15 08:42:12 -08:00
Hans Muller a152a2097c
Deprecate Scaffold resizeToAvoidBottomPadding, now resizeToAvoidBottomInset (#26259) 2019-01-15 08:16:49 -08:00
Jonah Williams 3a694a6d5d
desktop workflow, devices, and test (#26511) 2019-01-15 07:45:04 -08:00
Danny Tuppeny fda193aa5d
Fix+unskip flutter test expression eval tests (#26579)
* Fix `flutter test`e xpression eval tests

We weren't passing `beforeStart` through so the breakpoints were never being set, which means the evaluations were happening while the code was running.

* Ensure we wait for breakpoints before trying to evaluate
2019-01-15 15:39:35 +00:00