development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-10-14 04:02:56 +00:00
Code Issues Packages Projects Releases Wiki Activity
13075 commits 770 branches 974 tags 1.7 GiB
Commit graph

9433 commits

Author SHA1 Message Date
jslavitz e4fb4fe279
Revert "Teach drag start behaviors to DragGestureRecognizer (#23424)" (#26209) 
This reverts commit 08538f91f0.
 2019-01-07 17:59:03 -08:00
Hans Muller cccddf8a03
Fix tristate checkbox false to null transition, test ALL transitions (#26199) 2019-01-07 17:33:56 -08:00
Mary 56ade3d14f Clarify doc for AnimatedContainer (#25790) 2019-01-07 16:21:57 -08:00
jslavitz 08538f91f0
Teach drag start behaviors to DragGestureRecognizer (#23424) 
* Adds start behavior option to the drag gesture recognizer and makes it the default option when a drag gesture recognizer is created. Also fixes all the tests to work correctly with the new default behavior.
 2019-01-07 15:11:12 -08:00
Alexandre Ardhuin 868ff42821
fix doc-comment snippets (#25579) 2019-01-07 21:44:16 +01:00
Stanislav Baranov e54e53c13b
Better error messages for flutter tool --dynamic flag. (#26107) 2019-01-07 12:24:24 -08:00
Stanislav Baranov 4b474d61c6
Put correct VM snapshot in APK, and actually precache gen_snapshot on Mac. (#26104) 2019-01-07 12:22:55 -08:00
Florian Huonder 25af27734f Clearing pendingImages when the cache is cleared or evicted. (#23860) 2019-01-07 09:49:27 -08:00
Michael Goderbauer d8b57c2ab2
Fix SliverAppBar title opacity and test all cases (#26021) 2019-01-07 09:42:35 -08:00
Hans Muller 4ad3d99b20
Fix a floating snapping SliverAppBar crash (#26101) 2019-01-07 09:04:55 -08:00
Jonah Williams 2e883f8552
Skip formatters if text has not changed (#24779) 2019-01-06 16:38:13 -08:00
liyuqian d06e4325d8
Explain that BoxDecoration doesn't do clip. (#26089) 
Fixes https://github.com/flutter/flutter/issues/22370
 2019-01-06 07:20:36 +08:00
Alexander Aprelev 6502a1bed9
Report hot reload statistics. (#26039) 
* Report hot reload statistic

* Lints

* Introduce custom dimensions identifiers to track hot reload stats
 2019-01-05 07:34:02 -08:00
Hans Muller dae7e7b9f2
Fix typos introduced with the TextField.onTap PR, udpated debugFillProperties (#26088) 2019-01-04 14:52:36 -08:00
Hans Muller 0d667859c8
Update material spec references in BottomSheet et al., Scaffold (#26042) 2019-01-04 11:59:25 -08:00
Stanislav Baranov acdd9206aa
Improve message when saving compilation training data. (#26084) 2019-01-04 11:57:32 -08:00
xster 31ed3e5f81
Simplify ImageStream(Completer).removeListener (#25994) 2019-01-04 11:07:18 -08:00
Stanislav Baranov b57499e704
Friendlier messages when using dynamic patching (#25863) 2019-01-03 16:18:36 -08:00
Jonah Williams d84879d910
Ensure all errors thrown by image providers can be caught by developers. (#25980) 
* Ensure all errors thrown by image providers can be caught by developers.

Add an `onError` parameter to the ImageCache.putIfAbsent method.
In the event that an error is thrown when resolving an image, catch if
this parameter is provided. Use the onError parameter to ensure that all
errors thrown are forwarded to the ImageStream error channel instead of
directly into the void.
 2019-01-03 12:55:16 -08:00
Kenzie Schmoll 52e5cd24dc
Add didSendFirstFrameEvent service extension. (#25977) 
* Add didSendFirstFrameEvent service extension.
 2019-01-03 10:38:06 -08:00
Gary Qian 7de513dec3
Add docs to TextStyle for fontFamilyFallback/Custom font fallback (#25992) 2019-01-03 13:03:14 -05:00
TruongSinh Tran-Nguyen 53727866e6 fix #25143 Successive calls to precacheImage() throw an exception (#25159) 2019-01-02 21:05:53 -08:00
KyleWong 85ded44139 Optimize cocoapods logic in flutter doctor. (#25872) 2019-01-02 19:57:03 -08:00
Chema Molins 4b87e334d7 Setting icon color to first ListTile in ExpansionTile. Fixes #23053 (#23118) 2019-01-02 10:49:59 -08:00
Michael Goderbauer 28907c7950
Make LicensePage respect the notch (#25799) 2019-01-02 10:01:39 -08:00
Stanislav Baranov bacaab9795
Allow dynamic patches without a patch number. (#25796) 
Unique patch numbers are mainly useful for canary and A-B testing, but otherwise complicate things and can now be omitted.
 2018-12-27 11:57:16 -08:00
Alexander Aprelev 52bd2ccb8b
Report devfs stats (#25586) 
* Collect devfs stats for better analytics

* Fix fields initialization

* Fix lints
 2018-12-27 09:53:24 -08:00
Amir Hardon 50f9b88395
Actively reject UiKitView gestures. (#25792) 
flutter/engine#7307 changes the engine side of embedded UIView to only
reject gestures when the framework sends a `rejectGesture` message, so
that gesture resolution can done after a touch sequence has ended (see
PR description for flutter/engine#7307 for more details).

This change makes the framework send a `rejectGesture` message to the
engine when a UiKitView rejects a gesture.

I'm planning to land this PR before the engine side change, so right now
it swallows the exception thrown if there is no engine implementation
for `rejectGesture` (which keeps us with the current behavior). After
this change lands I'll land the engine PR, and then clean up the part
that swallows the exception.
 2018-12-26 19:34:53 -08:00
Justin McCandless 9161ec42cb
Include cursor in textfield intrinsic width measurement (#25055) 
* Include cursor in textfield intrinsic width measurement

* Add cursorWidth assertion, add comment about assumed cursor width, and test null stepWidth
 2018-12-26 08:56:02 -08:00
Ian Hickson 1e78c47bc4
Provide some more locations for the FAB. (#24736) 
Top left and top right for big FABs, and top left for mini FABs.
 2018-12-24 15:22:13 -08:00
Ian Hickson d05fa45fb2
Undeprecated BigInteger support, but document what it actually does. (#24511) 
Also, some code cleanup.
 2018-12-23 15:21:43 -08:00
Ian Hickson e239872561
ClipPath.shape and related fixes (#24816) 2018-12-23 15:21:11 -08:00
Ian Hickson c5ad1067b7
Handle errors in compute() by propagating them to the Future. (#24848) 2018-12-23 15:20:45 -08:00
Ian Hickson 273364e2bc
Fix merge conflict. (#25718) 2018-12-23 11:13:53 -08:00
Ian Hickson c0b20a76de
Some minor tweaks to InputDecoration (mainly docs). (#24643) 2018-12-23 10:12:42 -08:00
Gary Qian 2e2f19d3e9
Expose font fallback API in TextStyle, Roll engine 54a3577c0139..215ca1560088 (8 commits) (#25585) 2018-12-21 19:07:01 -08:00
Hans Muller 4857267e65
Updated Shrine demo (#25674) 2018-12-21 17:47:25 -08:00
Stanislav Baranov 6d6ada14a0
Friendlier flags for Dart compilation training. (#25645) 
* Renamed --save-compilation-trace to flutter run --train.
* Renamed --precompile=<file> to --compilation-trace-file=<file>.
* In dynamic mode, made JIT snapshot the default, instead of kernel file.
 2018-12-21 12:27:59 -08:00
Alexandre Ardhuin 19ce65eec9
no period after an alone link in see also section (#25604) 2018-12-21 19:23:42 +01:00
Ian Hickson fb88a7bfd1
Update links for China help (#25238) 
We have a page on the Web page now.
 2018-12-21 10:12:49 -08:00
Pranay Airan 368cd7da8b
Adding support for android app bundle - Issue #17829 (#24440) 
* adding support for android app bundle.

* removing the debug statement.

* fixing formatting and code review changes.

* Revert "fixing formatting and code review changes."

This reverts commit 2041d459f3.

* Fixing code formatting issues.

* updating review comments fixing comments and spacing.

* changing and to & to rerun the CI and tests.

* updating the comment to re-run the test

updating the comment to re-run the test

* fixing the formatting.

* updating comments to re-trigger build

updating comments to re-trigger build
 2018-12-20 22:18:53 -08:00
Ian Hickson 8426910a19
Revert "[O] Remove many timeouts. (#23531)" (#25646) 
This reverts commit 76f70810e4.
 2018-12-20 18:46:36 -08:00
Ian Hickson 76f70810e4
[O] Remove many timeouts. (#23531) 
* Remove many timeouts.

These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.

* Get the attach tests to pass.

* Apply review comments from Todd

* More review comment fixes

* Put back the extended timeouts here now that I know why we have them...
 2018-12-20 17:10:40 -08:00
xster b3b764c9d3
Revise Android and iOS gestures on Material TextField (#24457) 2018-12-20 16:54:19 -08:00
Stanislav Baranov eb7a59b6d7
Switch over to the new name for compilation trace native function (#25594) 
* Switch over to the new name for compilation trace native function.

Also see: https://github.com/flutter/engine/pull/7256

* rename

* roll the engine
 2018-12-20 16:07:36 -08:00
xster b6248e26b3
Fix material reference in CupertinoPicker doc (#25584) 2018-12-20 16:07:12 -08:00
xster d1ec126a3c
Let CupertinoTabScaffold handle keyboard insets too (#25593) 2018-12-20 15:02:53 -08:00
Dan Field 7a88fbc5fd
Default baseline build options (#25631) 
* fix crash

* default baseline
 2018-12-20 11:38:07 -08:00
Justin McCandless ca8ba58b02
Right aligned backspace bug (#25229) 
* Fix bug in calculation of downstream text distance when aligned: right

* After having affinity explained to me, match getOffset and tests to
expected behavior

* Clean up test formatting and fix analyze errors

* Improve test comments and reorganize a bit

* Specify logical pixels
 2018-12-20 11:03:51 -08:00
Stanislav Baranov 41fd7a2b9d
Don't parse APK unless explicitly requested (#25595) 2018-12-20 10:08:05 -08:00
Hans Muller ee3571c946
Update DayPicker,DatePicker doc "see also" sections (#25573) 2018-12-20 08:18:54 -08:00
jslavitz 3d8aec2b99
Adds force press gesture detector and recognizer (#24554) 
* adds Force Press gesture detector and recognizer
 2018-12-19 20:09:07 -08:00
Stanislav Baranov 55f3da7afc
Flutter tool support for building dynamic updates (#25576) 2018-12-19 16:27:47 -08:00
Gary Qian a282058d69
Use full textspan tree instead of top level textspan (#25574) 2018-12-19 15:43:53 -08:00
xster b17feefc9e
Remove code signing special casing for Googlers round 2 (#24580) 2018-12-19 14:41:21 -08:00
Alexandre Ardhuin 316d74f62d
fix indentation in doc comments (#25521) 2018-12-19 21:12:49 +01:00
MH Johnson 6e15572867
[Material] Theme-able TextStyles for AlertDialog (#25339) 
* Themable elevation on dialogs.

* AlertDialogs Title/Content text styles

* Themable elevation on dialogs.

AlertDialogs Title/Content text styles

* finish merging change

* fixing tests

* Docs fixes

* Change const to final to fix analyzer errors

* Fix analyzer errors

* Remove dart:ui import

* Hans Comments
 2018-12-19 13:52:10 -05:00
tonyzhao1 f8ab72657e Flutter doctor error message lookup (#23889) 2018-12-19 10:10:08 -08:00
xster b8a035a3d4
Adds CupertinoTheme (#23759) 2018-12-18 20:36:35 -08:00
Stanislav Baranov 693fb6560e
Fix flutter tool to actually honor --build-number/--build-name flags. (#25520) 2018-12-18 12:54:26 -08:00
Stanislav Baranov 0d4f279fb8
Read correct cached VM snapshot in dynamic mode (PRODUCT vs RELEASE) (#25472) 2018-12-18 12:53:30 -08:00
Alexandre Ardhuin e41f1463cd
make see also sections uniform (#25513) 2018-12-18 21:45:20 +01:00
Hans Muller 324f275981
TransitionRoute.canTransitionFrom,To() doc update (#25477) 2018-12-18 11:38:16 -08:00
Stanislav Baranov f6c1476fbb
Fix gradle local.properties tests that were never excersized. (#25484) 
These tests were actually failing, but were silently ignored due overly broad exception catching logic.
 2018-12-18 10:39:27 -08:00
Gary Qian a3dd2eee98
Fix typo (#25237) 2018-12-18 10:25:11 -08:00
Gary Qian f8964ae250
Iterate through potential grapheme cluster lengths in text painter (#24797) 2018-12-18 10:21:04 -08:00
Michael Goderbauer 21c6dda1a1
assert(elevation >= 0.0) and doc clarifications (#25345) 2018-12-18 10:18:48 -08:00
Justin McCandless 89fa4cc502
Add InputDecoration alignLabelWithHint parameter (#24993) 
* InputDecorator param for alignment of label

* Put baseline/center code in the right place where label is layed out

* Fix existing test

* Test top label positioning

* Rename to alignLabelWithHint, and make it a bool

* Test for TextField with and without alignLabelWithHint set

* alignLabelWithHint in theme as well

* debugFillProperties addition and test

* Small style fixes for review

* Fix analyze const error
 2018-12-18 10:04:20 -08:00
Hans Muller 9b6229ab56
TextField.onChanged() doc update (#25473) 2018-12-18 09:03:57 -08:00
Danny Tuppeny cbb168e7b9
Fix (probably) bad assert when running flutter test with asserts and --start-paused (#25512) 
Fixes #25201.
 2018-12-18 16:03:56 +00:00
Alexandre Ardhuin 32d65fef1c
fix some formatting issues (#25474) 2018-12-18 10:05:12 +01:00
Devon Carew ba71933f58
don't warn for non-matching device discoverers (#25440) 
* don't warn for non-matching device discoverers

* remove an out of date test
 2018-12-17 14:54:18 -08:00
Dan Field 0a798105ef
Support Java 1.8 (#25470) 2018-12-17 14:40:48 -08:00
Devon Carew 632e21b40b
fix the daemon device.getDevices call (#25443) 2018-12-17 12:38:14 -08:00
Justin McCandless a039b2ca8c
Revert "Revert "obscureText and enableInteractiveSelection defaults"" (#25342) 
* Revert "Add imports section to sample code templates, and more docs. (#25184)"

This reverts commit 95b0124785.

* Revert "Use stderr instead of stdout to contain errors in flutter attach test (#25305)"

This reverts commit 2b819dd257.

* Revert "Allow detection of taps on TabBar (#23919)"

This reverts commit 01694ab62d.

* Revert "a549981da Roll src/third_party/skia a69b10312977..5eb29448dfbd (1 commits) (flutter/engine#7211) (#25333)"

This reverts commit a37099f3b1.

* Revert "Revert "obscureText and enableInteractiveSelection defaults (#24527)" (#25335)"

This reverts commit c5457068df.

* Password fields are no longer selectable nor copiable
 2018-12-17 11:15:27 -08:00
Zachary Anderson b18a2b1794
[fuchsia] Get Dart VM service ports from The Hub (#25332) 2018-12-17 11:10:47 -08:00
Hans Muller 9619b53d06
Update localizations (#25394) 2018-12-17 10:23:21 -08:00
Danny Tuppeny c19142d8b7
Support ANDROID_SDK_ROOT in addition to ANDROID_HOME (#25221) 
* Fall back to ANDROID_SDK_ROOT if ANDROID_HOME is not set

And update descriptions to use the non-deprecated ANDROID_SDK_ROOT.

Fixes #15114.

* Remove trailing whitespace

* Update dev/devicelab/lib/framework/adb.dart

Co-Authored-By: DanTup <danny@tuppeny.com>

* Reformat long line
 2018-12-17 17:29:09 +00:00
Michael Goderbauer 59bfab157e
Reland "Call mark* methods before attaching child (#25239)" (#25395) 
This reverts commit ea7d086e11.

The revert did not fix the flakiness.
 2018-12-15 13:29:54 -08:00
Stanislav Baranov c5251cdc02
Flutter tool support for automatic saving of JIT compilation trace (#25301) 2018-12-14 16:09:17 -08:00
Hans Muller 30fb97be42
Fixed Typography null factory constructor (#24932) 2018-12-14 16:01:17 -08:00
jslavitz ad2e3eb3b5
Adds support for floating cursor (#25384) 
* Adds support for floating cursor.
 2018-12-14 15:17:33 -08:00
Jonah Williams b4f1d5a924
Add fuchsia devices to daemon command (#25344) 2018-12-14 14:37:55 -08:00
S McDowall 4c24bcc862 Remove TextField.noMaxLength, use maxLength = -1 instead (#24999) 2018-12-14 14:18:35 -08:00
David Shuckerow 1a60b166f2
Add ipv6 and observatory port support to the attach command (#25303) 
* Add ipv6 and observatory port support to the attach command.

* Remove whitespace

* Explain why a name change is useful here

* Refactor common flags out into the parent

* Add an additional test case for when observatory port is provided but debug port is not

* Remove whitespace

* Fix flag validation
 2018-12-14 18:03:49 -04:00
Jonah Williams a0efb78640
Revert "drop/restore focus when app becomes invisible/visible" (#25390) 2018-12-14 12:45:07 -08:00
Hans Muller 8c439fd39f
IntrinsicWidth stepWidth or stepHeight == 0.0 (#25228) 2018-12-14 12:30:01 -08:00
Jonah Williams ff97e255b5
drop/restore focus when app becomes invisible/visible (#24744) 2018-12-14 12:15:52 -08:00
Michael Goderbauer ea7d086e11
Revert "Call mark* methods before attaching child (#25239)" (#25382) 
This reverts commit 5c1f1d7618.

Reverting to see if that fixes flakiness of flutter_gallery__transition_perf_with_semantics in devicelab.
 2018-12-14 10:30:49 -08:00
Jonah Williams 4cd87705b7
Revert "Adds support for floating cursor (#24761)" (#25352) 
This reverts commit 46878d8485.
 2018-12-13 20:36:08 -08:00
jslavitz 46878d8485
Adds support for floating cursor (#24761) 
* Adds support for floating cursor!
 2018-12-13 20:14:27 -08:00
Jasper van Riet 01694ab62d Allow detection of taps on TabBar (#23919) 2018-12-13 13:01:34 -08:00
Justin McCandless c5457068df
Revert "obscureText and enableInteractiveSelection defaults (#24527)" (#25335) 
This reverts commit f8f5953d80.
 2018-12-13 11:58:37 -08:00
Justin McCandless f8f5953d80
obscureText and enableInteractiveSelection defaults (#24527) 
* obscureText true defaults to disabling selection

* Tests and comments for selectable text field

* Improve selection docs

* Refactor so that all enableInteractiveSelection params are null by default, delegate to selectionEnabled

* Fix selection param macros
 2018-12-13 11:09:13 -08:00
Justin McCandless 952d24bf1e
Text field style merge (#24449) 
* Merge TextField style with global style so that style changes don't override unspecified fields

* Test that a style param is merged with the theme

* Test a few more style properties

* Analysis fix
 2018-12-13 08:32:55 -08:00
MH Johnson 92efec3998
[Material] Theme-able elevation on dialogs. (#24169) 
* Themable elevation on dialogs.

* Added `BackgroundColor` in widget + theme

* Addressing Comments

* Fix test name

* Add debugFillProperties test
 2018-12-13 09:11:01 -05:00
Michael Goderbauer 5c1f1d7618
Call mark* methods before attaching child (#25239) 2018-12-12 16:45:51 -08:00
David Shuckerow e6292c8da1
Revert "Add ipv6 and observatory port support to the attach command." (#25288) 
* Revert "e5195ee47 Remove unnecessary includes of Ganesh headers (flutter/engine#7189) (#25282)"

This reverts commit f198d66332.

* Revert "Validate style in TextField (#24587)"

This reverts commit 9a8e2f0c4b.

* Revert "Allow snippets tool to be run from arbitrary CWDs (#25243)"

This reverts commit 4a110b6227.

* Revert "Make doctor output consistent between VS Code/IntelliJ/Android Studio when plugins are missing (#25269)"

This reverts commit e29b023a6b.

* Revert "Add ipv6 and observatory port support to the attach command. (#24537)"

This reverts commit 9150b3f031.
 2018-12-12 16:56:50 -04:00
Jonah Williams f30029bae1
Run flutter tests through mini test engine when run directly (flutter run -t test_file) (#24930) 2018-12-12 12:51:16 -08:00
Justin McCandless 9a8e2f0c4b
Validate style in TextField (#24587) 
* Validate style in TextField

* Fix analyze problems

* Use assert and move to top

* Simplified assertion
 2018-12-12 09:44:43 -08:00
Danny Tuppeny e29b023a6b
Make doctor output consistent between VS Code/IntelliJ/Android Studio when plugins are missing (#25269) 
* Update VS Code validator to match Android Studio

- Now shows a tick (instead of partial) if installed
- Now shows a cross (instead of dot) if extension is not installed

Fixes #22931.
 2018-12-12 17:36:42 +00:00
David Shuckerow 9150b3f031 Add ipv6 and observatory port support to the attach command. (#24537) 2018-12-12 08:28:02 -08:00
Danny Tuppeny 2994d3562a
Add some a basic debug stepping tests (#24515) 2018-12-12 10:56:54 +00:00
Trevor Wang 114335dff0 Support TextField multi-line hint text #20941 (#24976) 2018-12-11 22:46:05 -08:00
xster 65df90d8b5
Add navigatorKey to CupertinoTabView (#25183) 2018-12-11 19:29:13 -08:00
Michael Goderbauer 8ca8dbf062
Do not fade out text for pinned & floating AppBar (#25051) 2018-12-11 19:24:00 -08:00
Jonah Williams c461e93363
Revert "Ensure that cache dirs and files have appropriate permissions" (#25240) 2018-12-11 15:33:57 -08:00
Hans Muller 234855ca3d
Handle a TabBarView special case: last tab deleted before animation ends (#24892) 2018-12-11 14:22:27 -08:00
Jimmy Casey 3cca1a2ec3 Fixed Spelling. (#25217) 2018-12-11 10:50:51 -08:00
Justin McCandless 6901cd4625
TextFormField cursor params (#24635) 
* cursor fields on textformfield

* Test pass-through of cursor properties
 2018-12-11 10:42:10 -08:00
Hans Muller f14055529b
Fixed an InheritedWidget doc typo (#25168) 2018-12-11 09:53:45 -08:00
Jonah Williams b080a476c8
Fuchsia multiple devices and target (#24953) 2018-12-11 09:18:21 -08:00
Hans Muller f8a7abb6b8
Add a check for build methods that return context.widget (#25046) 2018-12-11 08:59:28 -08:00
Danny Tuppeny 3f1c308e58
Don't require the AVD folder to exist in order to run flutter emulators (#25154) 
Fixes #24750.
 2018-12-11 15:27:25 +00:00
Michael Goderbauer 7120dab553
Don't crash if pinned & floating AppBar has less than minExtent remainingPaintExtent (#25048) 
Fixes https://github.com/flutter/flutter/issues/21887
 2018-12-11 07:18:53 -08:00
Michael Goderbauer b023a57483
Fix debugPrint(null) to not crash (#24942) 2018-12-11 00:16:43 -08:00
Michael Goderbauer 46599167d5
Remove offstage wording from KeepAlive (#24881) 
What KeepAlive does is different from the Offstage widget. Let's not confuse these two and be more speicific in the wording for KeepAlive.
 2018-12-10 22:37:46 -08:00
Jonah Williams 61291aeeaf
ensure lastBuildTimestamp is set before early return (#25058) 2018-12-10 15:57:52 -08:00
Todd Volkert 243222c00d
Include error message in crash reports (#24632) 
This modifies our flutter_tools crash reports to include the error
message. This error message may contain personally identifying
information (PII), such as a file system path on the developer's
local machine that may contain user names, project code names,
etc. To disable crash reporting, the developer can run the
following command:

    flutter config --no-analytics

For more information on what gets reported during crashes of the
flutter tool, see:

https://github.com/flutter/flutter/wiki/Flutter-CLI-crash-reporting
 2018-12-10 13:59:47 -08:00
Todd Volkert 74ab1bfbbd
Ensure that cache dirs and files have appropriate permissions (#24669) 
Fixes https://github.com/flutter/flutter/issues/24413
 2018-12-10 13:39:50 -08:00
Hans Muller e7a4e7c3b6
Update Switch doc: disabled state (#24941) 2018-12-10 11:21:28 -08:00
Patrice Chalin ab36f05474 Replace deprecated link in docs (#25120) 
Followup to https://github.com/flutter/website/pull/1949, as requested by @Hixie in https://github.com/flutter/website/issues/1634.

cc @kwalrath
 2018-12-10 10:51:41 -08:00
liyuqian 06ffbbfd4a
Change network image URL in doc (#25096) 
This fixes https://github.com/flutter/flutter/issues/25092
 2018-12-10 09:55:07 -08:00
Michael Goderbauer 8d249c25ea
Fix semantics compiler for offstage children (#24862) 
Fixes #20313.
 2018-12-10 08:58:14 -08:00
Michael Goderbauer d74b1c2051
Add animations to SliverAppBar doc (#25091) 2018-12-07 14:19:09 -08:00
Gary Qian 27c8ffa06c
Fix typo in documentation (#25003) 2018-12-05 14:50:59 -08:00
Jonah Williams a226c0f0d9
Add a flutter-attach entry point for fuchsia (#24878) 2018-11-30 16:18:18 -08:00
Ian Hickson 5391447fae Clarify dart:ui dependencies in foundation library (#24868) 2018-11-29 19:41:26 -08:00
Tim Sneath 06ec8d3b41
Updating readme templates for newly created projects (#24725) 
We hypothesize that many first-time users creating a new project will look at the README.md as a starting point for "what next". As we've updated our documentation particularly for new users, having better links to our codelabs and cookbooks will help them be productive.
 2018-11-28 15:56:58 -08:00
Ian Hickson f683e4c4b4
Improve CircleAvatar documentation (#24729) 2018-11-27 11:29:00 -08:00
Ian Hickson c00a794f56
Some more documentation around WidgetBuilder and close friends. (#24731) 2018-11-27 11:28:31 -08:00
Ian Hickson aae968cd45
Improve StreamBuilder documentation (#23713) 2018-11-26 12:17:57 -08:00
Dan Field 03a4f4bedb
Quote framework_dir in xcode_backend.sh (#24591) 2018-11-20 18:42:27 -08:00
liyuqian d9ad220bbb
Explain why Opacity could be slow (#24255) 2018-11-20 15:27:21 -08:00
Hans Muller 5251306886
Updated an obsolete l10n/README reference to MaterialTextGeometry (#24556) 2018-11-20 10:21:36 -08:00
Hans Muller b9400f9a6f
Added support for the Tamil language, locale ta_IN (#24553) 2018-11-20 10:20:18 -08:00
Jonah Williams f5b02e3c05
Bump minimum ios_deploy version (#24550) 2018-11-20 07:49:29 -08:00
Dan Field 19b97ae515
Doc clarifications for semantics properties (#24544) 
* update semantics properties doc
 2018-11-19 23:14:04 -08:00
Hans Muller 94dab8fe91
Added TextField.onTap() (#24536) 2018-11-19 18:06:44 -08:00
Gary Qian d3377c4ab9
Fix documentation for supportedLocales (#24547) 2018-11-19 17:26:31 -08:00
Victor Florintsev 16b9a80ccd added definition for hardware (#24502) 
This is the hardware used in the Samsung Galaxy J7
 2018-11-19 14:18:01 -08:00
Noor Dawod 9d2037e9a8 Check for empty and null preferredLocales before passing to 'localeResolutionCallback'. (#24481) 2018-11-19 14:17:47 -08:00
Hans Muller ec4f22c17b
Revert "Restore Flutter Gallery Shrine Demo, again (round 3) (#24531)" (#24538) 
This reverts commit 4ec8883b83.
 2018-11-19 13:02:18 -08:00
Hans Muller 4ec8883b83
Restore Flutter Gallery Shrine Demo, again (round 3) (#24531) 2018-11-19 12:21:49 -08:00
jslavitz 743960df27
Cupertino picker null color fix (#24529) 
*null fix and test
 2018-11-19 12:00:21 -08:00
Jonah Williams 9d81c67a3f
Pass correct physics instance to Scrollable semantics (#24416) 2018-11-19 10:31:02 -08:00
Todd Volkert c793d43ee0
Slight doc change (#24526) 2018-11-19 09:11:40 -08:00
Alexandre Ardhuin 79b5e5bc8a
Add missing lints (#24381) 
* update lint list

* enable sort_pub_dependencies

* enable avoid_returning_null_for_void

* enable flutter_style_todos
 2018-11-19 10:37:55 +01:00
Danny Tuppeny 15e3df25c5
Refactor Test Driver in preparation for flutter test integration tests (#24060) 
* Refactor Test Driver in preperation for `flutter test` integration tests

* Fix indent
 2018-11-19 08:25:42 +00:00
Danny Tuppeny 113f8f1a8d
Make FlutterTestDriver.stop() safe to call if it didn't spawn a process (#24393) 
This means we can just always add it to test teardowns without having to add try/catches if there are any tests that don't spawn a process.
 2018-11-19 07:16:32 +00:00
Danny Tuppeny 08e7f26510
Remove timeout waiting for app to start (#24336) 2018-11-19 07:15:52 +00:00
jslavitz 5385132c6b
Separate keep alive logic from SliverMultiBox classes (#24192) 
* sliver separation and test
 2018-11-16 16:53:59 -08:00
Justin McCandless a8552ca7ec
Switch list tile adaptive (#24437) 
* SwitchListTile.adaptive for wrapping an adaptive Switch

* Test SwitchListTile.adaptive same as Switch.adaptive

* Remove TODO

* Comment and switch statement cleanup
 2018-11-16 14:50:17 -08:00
jslavitz 265485033b
Fixes navigation page back drag area for iPhone X (#24375) 
* nav fix and test
 2018-11-16 12:47:50 -08:00
jslavitz b3d9fb4dee
Scaffold Drawer pull out area fix for notched devices (#24367) 
* Adds fix and test
 2018-11-16 12:47:34 -08:00
Justin McCandless c8ff617fd8
Text field border radius bug fix (#24414) 
* Fix radius glitch by carrying over border when lerping outline borders

* Test that border doesn't change

* Regression comment
 2018-11-16 09:32:24 -08:00
xster 988bfc166d
iOS tap handling on CupertinoTextField (#24034) 2018-11-15 18:07:17 -08:00
Dan Field 77237c0ed1
add missing entry to material_mr.arb (#24410) 
* add missing entry to material_mr.arb
 2018-11-15 16:37:14 -08:00
Dan Field 78c5bb2a8e
Make progress indicators accessible (#24275) 
* Make progress indicators accessible
 2018-11-15 15:54:56 -08:00
Justin McCandless f9bccb0280
Handle a missing ListView separator as an error (#24312) 
* Handle a missing ListView separator as an error

* Handle missing item, and errors in itemBuilder and separatorBuilder

* CR fixes and move error handling into sliver.dart to handle all ListView constructors

* Only show an error for null separatorBuilder value in debug mode
 2018-11-15 14:40:13 -08:00
Jonah Williams 938dd5a4aa
Revert "Update driver script to execute test through test_core" (#24401) 
* Revert "Add dashing config file for generating docset from flutter docs (#24374)"

This reverts commit ec8ca8606c.

* Revert "Update driver script to execute test through test_core (#24168)"

This reverts commit 6c62cf337f.
 2018-11-15 11:17:00 -08:00
Jonah Williams 6c62cf337f
Update driver script to execute test through test_core (#24168) 2018-11-15 10:50:25 -08:00
Diego Tori 9447be7370 Added support for passing in velocity and offset into Draggable.onDragCompleted (#22267) 
* Added support for passing in velocity and offset into Draggable.onDragCompleted.

* Fixed documentation of DragCompletedCallback.

* Spun off previous onDragCompleted breaking changes into new callback called Draggable.onDragEnd.

* Revert "Fixed documentation of DragCompletedCallback."

This reverts commit 069051f5be.

* Revert "Added support for passing in velocity and offset into Draggable.onDragCompleted."

This reverts commit 7ef744aa56.

* DraggableDetails constructor is now declared first as per Flutter code style.

* Draggable.onDragEnd will only call back if its widget is currently mounted to the tree.

* Moved "});" in DraggableDetails constructor to new line, vertically aligned with the constructor name, as per Flutter code style.

* Added space between if statement in drag_target.dart.

* widget.onDragEnd call is now formated as per flutter code style.

* Added more details to DraggableDetails documentation.

* Added brackets to if statement block as per Flutter code style.

* Fixed minor nits in DraggableDetails documentation.

* Made DraggableDetails constructor public. Also added documentation for its constructor.
 2018-11-15 09:11:04 -08:00
Dan Field 091b73ab6f
fix variable check in xcode_backend.sh (#24368) 
* fix test in xcode_backend.sh

* -n

* fix devicelab test

* uncomment good code, check for \"\"
 2018-11-14 18:54:51 -08:00
Alexander Aprelev 64a8d44764
Fix test so it doesn't leak frontend_server process (#24360) 
* Fix test so it doesn't leak frontend_server process

* Stop FlutterTestDriver even if expectation is not met
 2018-11-14 18:50:18 -08:00
Yegor 9c3754d92f
FlutterDriver: allow customizing timeouts using a multiplier (#24066) 
FlutterDriver: allow customizing timeouts using a multiplier
 2018-11-14 17:15:00 -08:00
Greg Spencer eb35f8923b
Reland: Make the 'time to update' message depend up on the channel. (#24173) (#24321) 
Fixes #24158
Re-lands #24173
 2018-11-14 16:51:12 -08:00
S McDowall 87156df6d9 Optionally show the text field length but not the max (#24183) 
If maxLength is set to TextField.noMaxLength then continue to show the character counter but do not display the max input length value.
 2018-11-14 16:04:39 -08:00
Hans Muller 70d83cc7ac
Add support for the Marathi language, locale mr_IN (#24353) 2018-11-14 15:42:51 -08:00
liyuqian ba635a643a
Add golden tests for Opacity with offset (#24253) 
See https://github.com/flutter/flutter/issues/23890
 2018-11-14 15:00:39 -08:00
James D. Lin 91cfc1fe31
Fix a few typos in comments (#24249) 2018-11-14 14:25:05 -08:00
Michael Goderbauer e71eb9a474
Make Link clickable in DartDocs (#24358) 2018-11-14 14:08:04 -08:00
Jason Simmons 9f28aefa9c
Call BorderRadiusGeometry.lerp where applicable in ShapeBorder subclasses (#24262) 
Fixes https://github.com/flutter/flutter/issues/24257
 2018-11-14 13:47:48 -08:00
stevemessick ff25edd3ad
Update idea template files (#24311) 
* Update IntelliJ project template files

* Add ignored file

* Fix test

* Restore comma
 2018-11-14 13:45:07 -08:00
Alexander Aprelev 0b940a4473
Flush write to disk with intent of reducing flakiness of the test. (#24144) 2018-11-14 13:26:24 -08:00
Alexander Aprelev 3b7942c444
Fix multi-step build handling process. (#24310) 
* Fix multi-step build handling process.

Stop listening for new step updates after 'all done.' log message. Make sure that we don't delete file too soon, until listener had a chance to process the 'all done' message.

Fixes https://github.com/flutter/flutter/issues/18750

* Emit 'all output' explicitly when build process is done.
 2018-11-14 08:54:13 -08:00
Brian Wilkerson 29d5210d8b Use constant durations in more places (#24306) 2018-11-14 08:16:12 -08:00
Michael Goderbauer e5f0457261
Another typo fix (#24316) 2018-11-13 23:03:11 -08:00
Greg Spencer a2ed3ecb64
Revert "Make the 'time to update' message depend up on the channel. (#24173)" (#24320) 
This reverts commit 97e03104a0.

Landing on red to hopefully make less red on the board.

TBR=@goderbauer
 2018-11-13 17:18:06 -08:00
Michael Goderbauer f4af41e20e
type fix (#24297) 2018-11-13 10:31:22 -08:00
Greg Spencer 97e03104a0
Make the 'time to update' message depend up on the channel. (#24173) 
Fixes #24158
 2018-11-13 09:53:56 -08:00
Justin McCandless 1fde4d0366
Docs clarification for how RTL/LTR locale affects ButtonBar (#24264) 2018-11-13 09:46:04 -08:00
Jonah Williams aa65fa2fa1
Remove await for syntax from fuchsia log scanner (#24263) 2018-11-12 23:47:16 -08:00
Jonah Williams 2e33d08dae
communicate fuchsia error states to developers (#24191) 2018-11-12 23:46:14 -08:00
jslavitz 931c037919
Release Candidate (#24248) 2018-11-12 10:35:11 -08:00
Greg Spencer 665fff00c7
Update Scaffold docs and example code (#24159) 
Upgraded Scaffold example to an application example.
 2018-11-12 08:54:08 -08:00
Jonah Williams 70c6fb1fbb
Remove package:collection dependency usage from flutter_goldens (#24218) 2018-11-11 10:57:41 -08:00
Gary Qian f16a569e24
Supported locales docs to explain proper scriptCode usage. (#24184) 2018-11-11 03:43:16 -08:00
Jonah Williams 5839710859
Throw a better error when old test versions are loaded. (#24217) 2018-11-10 19:32:35 -08:00
Jonah Williams a871d59164
Apply basic log filtering and formatting to fuchsia logs. (#24143) 2018-11-10 17:02:32 -08:00
Amir Hardon 72bf075e8d
Escape objective c method brackets in dartdoc (#24199) 2018-11-09 20:36:17 -08:00
Dan Field 2729385758
Make host app test actually test host app (#24131) 
* Make host app test actually test host app

* mark updated test as flaky
 2018-11-09 19:09:56 -08:00
Amir Hardon 563ceac8d4
Remove the WIP comment for UiKitView. (#24170) 
Adds a note mentioning that this is still a release preview.
 2018-11-09 16:14:44 -08:00
jslavitz 6a8c393f4c
Allows for the CupertinoPicker to have a non white background color (#24085) 
* fixes wheel gradient and adds test
 2018-11-09 15:58:21 -08:00
Jonah Williams 26a6fd92d8
do not compute dart deps for fuchsia_entrypoint (#24134) 2018-11-09 15:41:13 -08:00
Stanislav Baranov e32cd85446
Clean up PointerEvent documentation. (#24002) 2018-11-09 14:26:21 -08:00
Gary Qian dfd0229560
New locale resolution algorithm to use full preferred locale list, include scriptCode in Locale. (#23583) 2018-11-09 11:33:42 -08:00
Gary Qian 5071657e8e
Add docs to explain cursor drawing behavior. (#24135) 2018-11-09 11:32:46 -08:00
Jonah Williams c11633e84e
Separate hot reload and hot restart capabilities. (#24122) 2018-11-09 10:33:22 -08:00
Jonah Williams 9ecb4ce9a6
remove deprecated testing members (#24115) 2018-11-09 10:05:11 -08:00
Jonah Williams ae2b215efe
make sure we dont use test (#24146) 2018-11-09 00:40:29 -08:00
Todd Volkert 95c9ae451e
Update packages --force-upgrade (#24126) 2018-11-08 22:31:22 -08:00
Ian Hickson 6bfd9bb996 Fix a race condition in vmservice_test.dart (#23835) 
Fixes https://github.com/flutter/flutter/issues/19273
 2018-11-08 20:54:06 -08:00
TL Lee 94d0b2ffc2 [Material] Add API for an unpainted input border (#21289) 
* Introduce a rounded InputBorder with no paint

* Update documentation for API

* Change name of Widget to NoStrokeInputBorder and updated documentation

* [FilledInputBorder] PR feedback.

* [FilledInputBorder] typo correction.

* [FilledInputBorder] Removing news.

* [FilledInputBorder] PR feedback.

* [FilledInputBorder] Removing use of borderSide.

* [FilledInputBorder] Adding tests for hashcode.

* [FilledInputBorder] Comments.

* [TextFields] Input decoration feature parity.

* [TextFields] Making floating of placeholder optional.

* [TextFields] Cleanup

* [TextFields] Removing unused isAnimated.

* [TextFields] Cleanup.

* [TextFields] Correcting border.

* [TextFields] Correcting comment.

* [TextFields] Comment.

* [TextFields] Corrections for tests.

* [TextFields] Cleanup.

* [TextFields] Cleanup.

* [TextFields] Tests.

* [TextFields] Cleanup.

* [TextFields] Cleanup.

* [TextFields] Formatting.

* [TextFields] PR feedback.

* [TextFields] PR feedback.

* [TextFields] PR feedback.
 2018-11-08 22:00:50 -05:00
Amir Hardon 903c5f8d29
Add DartDoc for UiKitViewController#acceptGesture (#24127) 2018-11-08 16:16:24 -08:00
jslavitz 75ca39f8c3
Animate user account drawer header arrow (#24023) 
* Adds user account header arrow animation and test
 2018-11-08 12:16:09 -08:00
Amir Hardon dc4bf652cc
Make UiKitViews participate in gesture arenas (#24027) 2018-11-08 12:11:57 -08:00
Dan Field 9430906e77
clarify widgetsapp docs (#24090) 
* clarify widgetsapp docs

* Rename shadowed param, update doc

* pageContentBuilder
 2018-11-08 10:46:11 -08:00
Gary Qian aab9244791
scriptCode support in gen_localizations and strip scriptCodes for date l10n. (#23853) 2018-11-08 10:43:40 -08:00
Danny Tuppeny 2d5ed986e1
Update integration tests to use vm_service_lib (#23937) 
* Move integration tests to use vm_service_lib
* Turn off debug logging that was accidentally committed
* Run update-packages --force to fix checksum for new dev dependency
* Trim trailing whitespace
 2018-11-08 07:55:54 +00:00
Jonah Williams d04fa1a670
only pass packages once (#24074) 2018-11-07 21:57:00 -08:00
Greg Spencer a6e901130e
Convert existing '## Sample code' samples to '{@tool sample}...{@end-tool}' form. (#24077) 
This converts existing ## Sample code samples to {@tool sample}...{@end-tool} form.

Also:
1. Fixed a minor bug in analyze-sample-code.dart
2. Made the snippet tool only insert descriptions if the description is non-empty.
3. Moved the Card diagram to before the code sample.
 2018-11-07 20:35:10 -08:00
Dan Field 9d53d7f848
Update pubspec template docs for module/plugin (#24081) 
* Document module pubspec

* update doc on plugin template

* clarify language
 2018-11-07 17:20:18 -08:00
Ian Hickson f9374fe071
Update the URL to the recommend bug report (#23708) 
We have templates now.
 2018-11-07 17:12:35 -08:00
jslavitz 5dac7a2347
Removes check for Homebrew if all necessary packages are present. (#23844) 
* Removes need for homebrew installation if all other packages are installed. Modifies test to work with this new functionality.
 2018-11-07 15:21:05 -08:00
Jonah Williams 00c07266c1
add frontend server as a non dart dep of fuchsia_tool (#24075) 2018-11-07 15:14:35 -08:00
Ryan Macnak d92d175bcb Opt into deterministic snapshots. 
Also, remove old flags.
 2018-11-07 14:44:20 -08:00
Hans Muller 4bb62b4348
Stop TextFields from wobbling within scrollables (#24015) 2018-11-07 14:27:25 -08:00
jslavitz 50fb729609
Includes frameworkVersion in JSON version output (#23891) 
* Include framework version in JSON output and adds test
 2018-11-07 12:28:22 -08:00
jslavitz 7342816084
Adds fix for double comparison error (#24026) 
* adds fix for rounding error
 2018-11-07 12:27:08 -08:00
Dan Field 3d01e89e7a
Unbreak WidgetsApp when only a builder specified (#23976) 
* update assert add test

* update docs
 2018-11-07 12:16:35 -08:00
Jonah Williams 6c88b2e9fb
restore compileExpressionService (#24063) 2018-11-07 12:04:05 -08:00
Michael Beckler 9abce96e8e BottomNavigationBar: bug fix for dealing with animations with shifting tabs (#22264) 
Should fix #22226.

Code introduced in #20890 caused a regression that broke color flooding animations in a BottomNavigationBar that has BottomNavigationBarType.shifting.

The original issue (#19653) dealt with background color changes not occurring until another tab was selected. The result is that the background color instantly changes whenever the state changes and when the widget changes, instead of allowing a new widget to animate the background color change.
 2018-11-07 09:20:27 -08:00
Dan Field 220cceedb5
Fix heroes transition when initial route is not '/' (#24039) 
* early return for initialRoute + test
 2018-11-07 00:06:34 -08:00
Dan Field 028087d0fc
fix identifier for release.xcconfig in module template (#23978) 2018-11-06 22:44:01 -08:00
Jonah Williams 2fc2581be4
unpin mockito (#24021) 2018-11-06 17:24:39 -08:00
jslavitz 34fa90b062
Improves SDK Search Error Messages (#23884) 
* Improves error message and adds test.
 2018-11-06 15:13:35 -08:00
Jonah Williams 81c7af342d
Add fuchsia specific entrypoint (#23916) 2018-11-06 14:36:35 -08:00
Jonah Williams ab2d0323a7
cleanup accessibility test skips in gallery (#23977) 2018-11-06 13:29:23 -08:00
Jonah Williams e862580518
move file back (#24014) 2018-11-06 11:09:57 -08:00
xster 7be8562202
Add cupertino_icons dependency to module pubspec template (#23961) 2018-11-06 10:52:00 -08:00
Jonah Williams a43e3a4a2f
Retry remove package:test from flutter (#24007) 2018-11-06 10:48:34 -08:00
Jonah Williams 23a7535a39
Revert "Remove package:test dependency from flutter_test (#23755)" (#24004) 
This reverts commit 71e9bd6f25.
 2018-11-06 09:12:48 -08:00
Jonah Williams 71e9bd6f25
Remove package:test dependency from flutter_test (#23755) 2018-11-06 08:39:27 -08:00
Jonah Williams 9b66fea2ea
Follow up to https://github.com/flutter/flutter/pull/23436 (#23876) 2018-11-06 08:37:53 -08:00
Todd Volkert 07d1ba87e0
Update doctor instructions for libimobiledevice installation (#23946) 
https://github.com/flutter/flutter/issues/22595
 2018-11-05 15:10:13 -08:00
mattijsf 54becbf3bf Ignore unreachable iOS devices in IOSDevice.getAttachedDevices (#23776) 2018-11-05 15:09:39 -08:00
Stanislav Baranov ba4cf054bd
Propagate positions of secondary pointers in UP events on Android (#23797) 2018-11-05 12:43:00 -08:00
Hans Muller 7245c4a6f6
Warn about supported locales that lack localizations (#23850) 2018-11-05 12:39:31 -08:00
Florian Huonder 02355d4c19 Added the DialogTheme to the material exports so that it is accessible. (#23858) 2018-11-05 09:34:05 -08:00
Dan Field 212374f0b7
Fix tests for ANSI terminals (#23906) 2018-11-05 07:56:30 -08:00
Alexandre Ardhuin 344ebe02ff
avoid returning null for Future (#23784) 2018-11-05 16:38:23 +01:00
Greg Spencer 202b045b50
Rewrite the analyze-sample-code script to also analyze snippets (#23893) 
This rewrites the sample code analysis script to be a little less of a hack (but still not pretty), and to handle snippets as well.

It also changes the semantics of how sample code is handled: the namespace for the sample code is now limited to the file that it appears in, so some additional "Examples can assume:" blocks were added. The upside of this is that there will be far fewer name collisions.

I fixed the output too: no longer will you get 4000 lines of numbered output with the error at the top and have to grep for the actual problem. It gives the filename and line number of the original location of the code (in the comment in the tree), and prints out the source code on the line that caused the problem along with the error.

For snippets, it prints out the location of the start of the snippet and the source code line that causes the problem. It can't print out the original line, because snippets get formatted when they are written, so the line might not be in the same place.
 2018-11-05 07:31:35 -08:00
Alexander Aprelev 34bc1e3c8c
Fix hanging of flutter run when running on more than one simulator. (#23932) 
This stops reading from pipe-to-file log after the build is completed. Attempting to read from pipe-to-file keeps open blocked because nobody is going to write into that pipe.
 2018-11-05 07:29:37 -08:00
Danny Tuppeny 8e7c8048de
Don't search in %LocalAppData% if it's not set (#23933) 
It's not usual for this not to be set, but it affected at least one user (#23909) and there are a non-zero number of people online saying it's not set. It's better that we don't crash.

Fixes #23909.
 2018-11-05 08:57:49 +00:00
sjindel-google db9fe3f827
Fix text field clipping when erasing rapidly. (#23894) 
`RenderEditable.paint` assumes that if the length of the text fits within the
visible region, then the text will be rendered at the start of the region and be
completely visible. This is not always true, since the text may still be
rendered at an offset if an animation is ongoing when the text begins to fit.

This fixes #22288 and #14121
 2018-11-04 03:20:44 +01:00
jslavitz a4a0ff9ab4
Makes FlexibleSpaceBarSettings public (#23803) 
* Makes FlexibleSpaceSettingsPublic and adds a test
 2018-11-02 17:38:38 -07:00
Yegor f03b00706f
code readability: fix awkward variable shadowing (#23886) 2018-11-02 17:07:00 -07:00
Hans Muller dd30efa190
Revert "Restore "Flutter gallery: updated Shrine demo" (#23878)" (#23888) 
This reverts commit 76a1abd4c7.
 2018-11-02 15:32:02 -07:00
Hans Muller 76a1abd4c7
Restore "Flutter gallery: updated Shrine demo" (#23878) 2018-11-02 14:33:10 -07:00