development/flutter
development/flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter synced 2024-09-20 00:32:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
39582 commits 768 branches 973 tags 1.4 GiB
Commit graph

39582 commits

This branch
This branch
All branches
Author SHA1 Message Date
Qun Cheng 0d8eafb006
Reland "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2" (#144273) 2024-02-28 13:55:50 -08:00
Tomasz Gucio 88f75712d7
Remove irrelevant comment in TextPainter (#144308) 
This PR removes an irrelevant comment in `TextPainter` for `_computePaintOffsetFraction`. Also some typos are corrected and missing spaces/newlines added.

test-exempt: no functional change
 2024-02-28 21:47:06 +00:00
engine-flutter-autoroll d00bfe820e
Roll Flutter Engine from c9381fb8ef4c to 455c814fe5de (1 revision) (#144340) 
c9381fb8ef...455c814fe5

2024-02-28 zanderso@users.noreply.github.com Revert to goma on mac_clang_tidy builder (flutter/engine#51060)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 21:42:20 +00:00
engine-flutter-autoroll 82034b9a6c
Roll Flutter Engine from 91898e397261 to c9381fb8ef4c (11 revisions) (#144338) 
91898e3972...c9381fb8ef

2024-02-28 dnfield@google.com Revert "Bump everything to Android 21" (flutter/engine#51056)
2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from 0c294ee206e8 to 93f245da0097 (2 revisions) (flutter/engine#51055)
2024-02-28 jonahwilliams@google.com [Android] update fallback and rendering state to combine impeller + android backend. (flutter/engine#51008)
2024-02-28 bdero@google.com [Impeller] Fix GL depth state. (flutter/engine#51040)
2024-02-28 chris@bracken.jp Roll buildroot to 7b537de78ac2239982ace130d1845374e5dcf113 (flutter/engine#51053)
2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from d935943bedcd to 0c294ee206e8 (3 revisions) (flutter/engine#51051)
2024-02-28 zanderso@users.noreply.github.com When run_tests.py is in --quiet mode, write verbose logs to a file (flutter/engine#51029)
2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from fe34002ee826 to d935943bedcd (1 revision) (flutter/engine#51049)
2024-02-28 dnfield@google.com Bump everything to Android 21 (flutter/engine#51032)
2024-02-28 jiahaog@users.noreply.github.com Add flutter prefix to import (flutter/engine#51042)
2024-02-28 skia-flutter-autoroll@skia.org Roll Skia from d591703635b0 to fe34002ee826 (1 revision) (flutter/engine#51048)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-28 20:44:56 +00:00
Victoria Ashworth 39a13539e0
Reland "Add FlutterMacOS.xcframework artifact (#143244)" (#144275) 
Reland https://github.com/flutter/flutter/pull/143244. It was reverted due to https://github.com/flutter/flutter/issues/144251, which is fixed by https://github.com/flutter/engine/pull/51023.
 2024-02-28 20:09:54 +00:00
Christopher Fujino f89b4f151e
[flutter_tools] Catch rpc error in render frame with raster stats (#144190) 
Fixes https://github.com/flutter/flutter/issues/143010. This is intended to be cherrypicked into the 3.19 and 3.20 releases.

Long-term, we should deprecate this feature: https://github.com/flutter/flutter/issues/144191
 2024-02-28 18:54:18 +00:00
Alex Li 47b0ef8127
🛡️ Guard Flutter Android app by disallow task affinity by default (#144018) 
Partial resolution for #63559

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
 2024-02-28 10:31:36 -08:00
Zachary Anderson d675807052
Manual roll Flutter Engine 8acc96d405d0 to 91898e397261 (#144316) 
91898e3972 Process FlutterMacOS.framework before creating xcframework
(https://github.com/flutter/engine/pull/51023)
c873ade1f1 Roll Skia from a55a65d65378 to d591703635b0 (1 revision)
(https://github.com/flutter/engine/pull/51046)
3feed45f0b Roll Skia from cce35b54379c to a55a65d65378 (3 revisions)
(https://github.com/flutter/engine/pull/51045)
886ff23042 Roll Dart SDK from 44af84628b90 to 7896a944fe67 (1 revision)
(https://github.com/flutter/engine/pull/51043)
fa691b8cee Roll Skia from a673ab63fccc to cce35b54379c (3 revisions)
(https://github.com/flutter/engine/pull/51036)
 2024-02-28 09:19:08 -08:00
Zachary Anderson 82ffde7ddf
Manual roll Flutter Engine 64a375de9c8f to 8acc96d405d0 (#144296) 
8acc96d405 Roll Dart SDK from 1e6b559fae88 to 44af84628b90 (1 revision) (https://github.com/flutter/engine/pull/51035)
632f9d742d Roll Skia from 84c60d70fbbd to a673ab63fccc (1 revision) (https://github.com/flutter/engine/pull/51034)
5c09604bd6 Null-assert the value given to a Completer expecting a non-null value (https://github.com/flutter/engine/pull/49053)
055ede728c Roll Dart SDK from a0e3c16eea3e to 1e6b559fae88 (1 revision) (https://github.com/flutter/engine/pull/51025)
d6bca2a382 [Windows] Reduce log level of unsupported accessibility event message (https://github.com/flutter/engine/pull/51024)
8fa1141b46 Roll Skia from c8703c91675e to 84c60d70fbbd (4 revisions) (https://github.com/flutter/engine/pull/51021)
 2024-02-28 07:39:21 +00:00
Zachary Anderson 95fdcbb814
Manual roll Flutter Engine c79117b706e9 to 64a375de9c8f (#144293) 
64a375de9c [Windows] Make the engine own a map of views (https://github.com/flutter/engine/pull/51017)
73480bf11d Rename some classes in the engine_build_configs package (https://github.com/flutter/engine/pull/51016)
2756f14a46 Remove rewrapper prefix from compiler commands for clang-tidy (https://github.com/flutter/engine/pull/51001)
0f727a5b31 Improve, test, and fix a bug related to `adb logcat` filtering. (https://github.com/flutter/engine/pull/51012)
ab4d6db3f1 Move vulkan-deps to //flutter/third_party/vulkan-deps (https://github.com/flutter/engine/pull/51013)
 2024-02-28 06:42:08 +00:00
auto-submit[bot] 450506868d
Reverts "Cache FocusNode.enclosingScope, clean up descendantsAreFocusable (#144207)" (#144292) 
Reverts flutter/flutter#144207

Initiated by: CaseyHillers

Reason for reverting: b/327301206 - Breaking a customer test

Original PR Author: LongCatIsLooong

Reviewed By: {gspencergoog}

This change reverts the following previous change:
Original Description:
`FocusNode.canRequestFocus` was doing a double traversal if no ancestor disallows focus. The last for loop only has to reach as far as the enclosing scope.

Also this caches the `FocusNode.enclosingScope` since the getter access happens much more frequently than node reparenting.
 2024-02-28 05:06:47 +00:00
Zachary Anderson 96a390a9e9
Manual roll Flutter Engine 2461280c38b7 to c79117b706e9 (#144290) 
c79117b706 [Windows] Remove TODONE (https://github.com/flutter/engine/pull/51005)
24c7b03ef0 [Windows] Introduce an accessibility plugin (https://github.com/flutter/engine/pull/50975)
c805e43957 Roll Skia from 1beae57ea0dd to c8703c91675e (1 revision) (https://github.com/flutter/engine/pull/51014)
17dff87ef3 [Impeller] various StC fixes for GPU -> CPU readback plus BufferBindingGLES error (https://github.com/flutter/engine/pull/50951)
8457d10473 Roll Dart SDK from be6be2b9ba6e to a0e3c16eea3e (3 revisions) (https://github.com/flutter/engine/pull/51015)
 2024-02-28 04:51:10 +00:00
Zachary Anderson fa322eb295
Manual roll Flutter Engine 5e0d9ba35dd5 to 2461280c38b7 (#144288) 
2461280c38 Roll Fuchsia Linux SDK from JCdhkDSFXzHyPuP4I... to T1xAi_ww_mWEiDkVN... (https://github.com/flutter/engine/pull/51011)
8940ea0887 Code consistency fixes in FlScrollingManager (https://github.com/flutter/engine/pull/50959)
21474ee4a4 [macOS] Use CVDisplayLink to drive repaint (https://github.com/flutter/engine/pull/49159)
6f7b939568 Fail lazily when 1+ Skia gold comparions fail. (https://github.com/flutter/engine/pull/51010)
249daf5512 Adjust Android emulator test timeouts (https://github.com/flutter/engine/pull/51004)
 2024-02-28 04:01:36 +00:00
Zachary Anderson 1a435d9539
Manual roll Flutter Engine fe7ea6d9c34f to 5e0d9ba35dd5 (#144285) 
5e0d9ba35d Roll Skia from 636e136b0da9 to 1beae57ea0dd (3 revisions)
(https://github.com/flutter/engine/pull/51007)
63b6117514 [skwasm] Clip pictures if they go beyond the bounds of the
window. (https://github.com/flutter/engine/pull/50887)
cd57dc9b4c GLES for scenario_app tests using Impeller
(https://github.com/flutter/engine/pull/51000)
ef4c205239 Roll Skia from d5ca52bc7739 to 636e136b0da9 (8 revisions)
(https://github.com/flutter/engine/pull/51006)
8b240244ef [Fuchsia] Use shared gn-sdk from chromium
(https://github.com/flutter/engine/pull/50855)
 2024-02-27 19:15:37 -08:00
Zachary Anderson 71fd015d05
Manual roll Flutter Engine 0bc21ea7bc92 to fe7ea6d9c34f (#144283) 
fe7ea6d9c3 Reland "Implement Frame Timing callbacks in Skwasm" (#50987)
1a5c26421b Move protobuf to //flutter/third_party (#50997)
1f9224056c Roll Skia from 2f2a718b27f7 to d5ca52bc7739 (3 revisions)
(#51003)
5403c24990 Roll Dart SDK from 67b2a250747b to be6be2b9ba6e (1 revision)
(#51002)
4addb6a07c Actually use Impeller in scenario_app tests (#50977)
 2024-02-27 18:26:59 -08:00
Polina Cherkasova 42b02d0a3a
Use const route for notAnnounced. (#144050) 2024-02-27 16:17:59 -08:00
Taha Tesser 551731697e
Add tabs_utils.dart class (#143937) 
This a test utility class for `tabs_test.dart` to prepare the class for Material 3 tests updates.

More info in https://github.com/flutter/flutter/issues/139076
 2024-02-28 00:17:20 +00:00
Qun Cheng e707f0de69
Remove bottomAppBarColor from ThemeData (#144080) 
This PR is to remove deprecated ThemeData.bottomAppBarColor.

These parameters are made obsolete in https://github.com/flutter/flutter/pull/110162.
Part of https://github.com/flutter/flutter/pull/111080
 2024-02-28 00:07:51 +00:00
ufolux d0fb2929df
fix: unexpected chinese punctuation (#143678) 
*Fixed the issue with abnormal Chinese punctuation marks.*
 2024-02-27 23:47:22 +00:00
Elias Yishak d3b60d4649
Clean up lint ignores (#144229) 
Fixes:
- https://github.com/dart-lang/tools/issues/234

Bumps the version for package:unified_analytics and removes TODOs and lint ignores
 2024-02-27 23:21:03 +00:00
hangyu fdb17ab069
Reland [a11y] Add isEnabled semantics flag to text field (#143601) 
Reland #143334
 2024-02-27 22:49:13 +00:00
LongCatIsLooong 2c2fed1dfb
Remove deprecated CupertinoContextMenu.previewBuilder (#143990) 
It was deprecated in https://github.com/flutter/flutter/pull/110616.

Deprecated in https://github.com/flutter/flutter/pull/110616
 2024-02-27 22:49:10 +00:00
Chris Bracken 2e4bbb7503
[iOS] Fix naming in platform_view example (#144247) 
This applies minor cosmetic cleanups noticed while landing fix/tests in another patch. Renames `incrementLabel` to `countLabel` and `setIncrementLabel` to `updateCountLabel`, since it's not setting it to a specific value but rather updating itself based on the current state of the `count` ivar.

No tests since this patch introduces no semantic changes.

Related: https://github.com/flutter/flutter/pull/132028
 2024-02-27 22:49:09 +00:00
auto-submit[bot] 2eee0b5750
Reverts "Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (#144001)" (#144262) 
Reverts flutter/flutter#144001

Initiated by: Piinks

Reason for reverting: Failing goldens at the tip of tree

Original PR Author: QuncCccccc

Reviewed By: {HansMuller}

This change reverts the following previous change:
Original Description:
Reverts flutter/flutter#143973

This is a reland for #138521 with an updated g3fix(cl/605555997). Local test: cl/609608958.
 2024-02-27 22:04:18 +00:00
auto-submit[bot] 7f2b238c55
Reverts "Add FlutterMacOS.xcframework artifact (#143244)" (#144253) 
Reverts flutter/flutter#143244

Initiated by: vashworth

Reason for reverting: Increased `flutter_framework_uncompressed_bytes` - see https://github.com/flutter/flutter/issues/144251

Original PR Author: vashworth

Reviewed By: {jmagman}

This change reverts the following previous change:
Original Description:
Replace `FlutterMacOS.framework` cached artifact with `FlutterMacOS.xcframework`. Also, update usage of `FlutterMacOS.framework` to use `FlutterMacOS.xcframework`.

Part of https://github.com/flutter/flutter/issues/126016.
 2024-02-27 20:47:26 +00:00
Martin Kustermann 616a0260fe
[web] Make flutter web profile builds always keep wasm symbols (#144130) 
So far `flutter build web --wasm` was always stripping wasm symbols
except if `--no-strip-wasm` is passed.

=> Ensure that in profile mode we also keep the symbols
 2024-02-27 21:21:42 +01:00
Qun Cheng 871d59221c
Reland - Introduce tone-based surfaces and accent color add-ons - Part 2 (#144001) 
Reverts flutter/flutter#143973

This is a reland for #138521 with an updated g3fix(cl/605555997). Local test: cl/609608958.
 2024-02-27 20:21:14 +00:00
Roger 609d30fe58
bind missing add icon in platform_view example (#132028) 
In the `examples/platform_view` example, which demonstrates
transitioning from a Flutter view to a general iOS UIView and back, as
well as using channels to communicate between the two, the Flutter view
renders correctly, but in the iOS UIView, the FAB equivalent button in
the lower-right corner is rendered without the '+' icon. This is because
no binding as declared for the add icon in the storyboard. This adds the
missing binding.

Further, this eliminates the use of the deprecated
[UIButtonTypeRoundedRect](https://developer.apple.com/documentation/uikit/uibuttontype/uibuttontyperoundedrect?language=objc),
falling back to the default instead.

---------

Co-authored-by: Chris Bracken <chris@bracken.jp>
 2024-02-27 11:19:52 -08:00
LongCatIsLooong c353cb0123
Cache FocusNode.enclosingScope, clean up descendantsAreFocusable (#144207) 
`FocusNode.canRequestFocus` was doing a double traversal if no ancestor disallows focus. The last for loop only has to reach as far as the enclosing scope.

Also this caches the `FocusNode.enclosingScope` since the getter access happens much more frequently than node reparenting.
 2024-02-27 19:16:06 +00:00
LongCatIsLooong a23c81333f
Remove strut migration flag from TextPainter (#144242) 
Fixes https://github.com/flutter/flutter/issues/142969.

G3fix: cl/610790040
 2024-02-27 19:13:58 +00:00
Victoria Ashworth d1d9605974
Remove force Xcode debug workflow (#144185) 
Now that all tests are on Xcode 15 and iOS 17, we no longer need to force test Xcode debug workflow.

Related https://github.com/flutter/flutter/issues/144020.
 2024-02-27 18:18:07 +00:00
keyonghan d319625329
Mark two other firebase targets as bringup: true (#144234) 
https://github.com/flutter/flutter/issues/144183
 2024-02-27 17:51:24 +00:00
Victoria Ashworth 42252cd4c6
Add FlutterMacOS.xcframework artifact (#143244) 
Replace `FlutterMacOS.framework` cached artifact with `FlutterMacOS.xcframework`. Also, update usage of `FlutterMacOS.framework` to use `FlutterMacOS.xcframework`.

Part of https://github.com/flutter/flutter/issues/126016.
 2024-02-27 16:47:53 +00:00
Jonah Williams b2a3075fa5
Re-enable Impeller goldens blocking. (#144210) 
The issues in flutter/flutter#144115 should be fixed with the removal of the incorrect render pass caching behavior in https://github.com/flutter/engine/pull/50976
 2024-02-27 16:20:19 +00:00
Jia Hao c30f998eb5
[flutter_tools] Fix missing stack trace from daemon (#144113) 
When the daemon throws an exception, the receiving client is unable to surface stack traces from the daemon.

This is because it is sent with the `trace` key here:

1e8dd1e4d6/packages/flutter_tools/lib/src/daemon.dart (L308)

But the client tries to read it with the `stackTrace` key here:

1e8dd1e4d6/packages/flutter_tools/lib/src/daemon.dart (L343)

Thanks to @mraleph for spotting this!

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

b/326825892
 2024-02-27 08:39:49 +00:00
engine-flutter-autoroll 331769f397
Roll Flutter Engine from 04ff2868ce80 to 0bc21ea7bc92 (21 revisions) (#144208) 
04ff2868ce...0bc21ea7bc

2024-02-27 matanlurey@users.noreply.github.com Respect SIGINT (Ctrl-C) for Android scenario_app. (flutter/engine#50989)
2024-02-27 skia-flutter-autoroll@skia.org Roll Skia from aa28c3a30a98 to 2f2a718b27f7 (1 revision) (flutter/engine#50998)
2024-02-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 2876f5684ced to 67b2a250747b (1 revision) (flutter/engine#50996)
2024-02-27 matanlurey@users.noreply.github.com Fix usage of `--out-dir` with a relative path. (flutter/engine#50992)
2024-02-27 jason-simmons@users.noreply.github.com Roll buildroot to 21b1b9f2645fada701885108e86aefbcb3b1cca0 (flutter/engine#50991)
2024-02-27 skia-flutter-autoroll@skia.org Roll Skia from ba3ed5998af3 to aa28c3a30a98 (12 revisions) (flutter/engine#50994)
2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Migrate Android `scenario_app` to the `SurfaceProducer` API (#50993)" (flutter/engine#50995)
2024-02-27 matanlurey@users.noreply.github.com Migrate Android `scenario_app` to the `SurfaceProducer` API (flutter/engine#50993)
2024-02-27 dkwingsmt@users.noreply.github.com Revert "Reland 4: Multiview pipeline (#50931)" (flutter/engine#50985)
2024-02-26 matanlurey@users.noreply.github.com Refactor args parsing/environment constructor for `scenario_app` (flutter/engine#50980)
2024-02-26 jonahwilliams@google.com [scenario] trigger firstFrameLatch on exception. (flutter/engine#50981)
2024-02-26 jason-simmons@users.noreply.github.com [Impeller] Fix a misspelling and name mismatch in a shader test fixture (flutter/engine#50983)
2024-02-26 skia-flutter-autoroll@skia.org Roll Dart SDK from c479735adcf9 to 2876f5684ced (2 revisions) (flutter/engine#50979)
2024-02-26 zanderso@users.noreply.github.com Run engine unit tests on mac host_debug_unopt_arm64 (flutter/engine#50327)
2024-02-26 jonahwilliams@google.com [Impeller] disble render pass caches. (flutter/engine#50976)
2024-02-26 john@johnmccutchan.com Update Surface reference after resizing render target in VirtualDisplay based platform views (flutter/engine#50971)
2024-02-26 jason-simmons@users.noreply.github.com [Impeller] Fix a race that can abort the process if the Vulkan context is destroyed while pipeline creation tasks are pending (flutter/engine#50883)
2024-02-26 matanlurey@users.noreply.github.com Better filtering for Android `scenario_app` runner. (flutter/engine#50937)
2024-02-26 jacksongardner@google.com Make sure to call `setHeightOverride` as well on TextStyle and StrutStyle (flutter/engine#50920)
2024-02-26 jacksongardner@google.com Correctly offset the cull rect of the opacity layer. (flutter/engine#50928)
2024-02-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kLvCWEgbL1VTRW69e... to JCdhkDSFXzHyPuP4I... (flutter/engine#50970)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from kLvCWEgbL1VT to JCdhkDSFXzHy

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-27 04:50:40 +00:00
Polina Cherkasova 523b0c4d84
Move debugShowWidgetInspectorOverride (#144029) 
Contributes to https://github.com/dart-lang/leak_tracker/issues/218
 2024-02-26 23:55:52 +00:00
Nate 7b5ec588d1
Allow Listenable.merge() to use any iterable (#143675) 
This is a very small change that fixes #143664.
 2024-02-26 23:52:23 +00:00
keyonghan c82ca469a3
Mark firebase_release_smoke_test as bringup: true (#144186) 
https://github.com/flutter/flutter/issues/144183
 2024-02-26 15:47:17 -08:00
Gustl22 b4f925e85a
refactor: Differentiate pubspec and resolution errors for plugins (#142035) 
Part of #137040 and #80374

- Differentiate pubspec and resolution errors
- Rename platform to platformKey
- Add TODO for rework logic of flag [throwOnPluginPubspecError]
- Swap for loop: handle by platform and then by plugin
 2024-02-26 19:45:18 +00:00
engine-flutter-autoroll 9d5380889d
Roll Flutter Engine from 34a8b9bdaaac to 04ff2868ce80 (1 revision) (#144159) 
34a8b9bdaa...04ff2868ce

2024-02-26 zanderso@users.noreply.github.com [et] Improve the logger for the ninja build, adds a spinner (flutter/engine#50952)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-26 19:08:29 +00:00
Nate 60d28ad913
Implementing switch expressions in rendering/ (#143812) 
This pull request is part of the effort to solve issue #136139.

The previous [`switch` expressions PR](https://github.com/flutter/flutter/pull/143496) was comprised of many simple changes throughout `flutter/lib/src/`, but due to some more in-depth refactoring in `flutter/lib/src/rendering/`, I decided to submit the changes to this directory as a separate pull request.

There was really just one function that I changed significantly; I'll add a comment for explanation.
 2024-02-26 17:36:21 +00:00
engine-flutter-autoroll 469a2338ad
Roll Flutter Engine from 7a573c21a4ad to 34a8b9bdaaac (1 revision) (#144147) 
7a573c21a4...34a8b9bdaa

2024-02-26 109111084+yaakovschectman@users.noreply.github.com Add Platform View Manager to Windows shell (flutter/engine#50598)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-26 17:15:26 +00:00
engine-flutter-autoroll 96dc989308
Roll Flutter Engine from a15326b2c439 to 7a573c21a4ad (1 revision) (#144145) 
a15326b2c4...7a573c21a4

2024-02-26 skia-flutter-autoroll@skia.org Roll Skia from cb2a47da08b7 to ba3ed5998af3 (2 revisions) (flutter/engine#50966)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-26 16:29:36 +00:00
Victoria Ashworth 45c8881eb2
Update copyDirectory to allow links to not be followed (#144040) 
In other words, copy links within a directory as links rather than copying them as files/directories. 

Fixes https://github.com/flutter/flutter/issues/144032.
 2024-02-26 16:07:22 +00:00
engine-flutter-autoroll d05eaf4a98
Roll Packages from 7df2085c80e2 to 353086c9a61e (7 revisions) (#144144) 
7df2085c80...353086c9a6

2024-02-26 stuartmorgan@google.com [google_map_flutter] Add style to widget - platform interface (flutter/packages#6197)
2024-02-26 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.4 to 3.24.5 (flutter/packages#6204)
2024-02-25 engine-flutter-autoroll@skia.org Roll Flutter from f6c10820fa to 1e8dd1e4d6 (3 revisions) (flutter/packages#6203)
2024-02-24 engine-flutter-autoroll@skia.org Roll Flutter from 39585e66c1 to f6c10820fa (20 revisions) (flutter/packages#6200)
2024-02-23 engine-flutter-autoroll@skia.org Roll Flutter from 41581c9a1b to 39585e66c1 (31 revisions) (flutter/packages#6194)
2024-02-23 43054281+camsim99@users.noreply.github.com [camera] Document -1 return value for `getExposureOffsetStepSize` (flutter/packages#6182)
2024-02-23 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.3 to 3.24.4 (flutter/packages#6184)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-26 15:52:14 +00:00
engine-flutter-autoroll b77560e92a
Roll Flutter Engine from 32d7f9f0f546 to a15326b2c439 (1 revision) (#144143) 
32d7f9f0f5...a15326b2c4

2024-02-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 8a2ca37c39e2 to c479735adcf9 (1 revision) (flutter/engine#50965)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-26 15:30:25 +00:00
Taha Tesser 41b1aea281
Fix Scrollbar.thickness property is ignored when the Scrollbar is hovered (#144012) 
fixes [`Scrollbar.thickness` property is ignored when the `Scrollbar` is hovered](https://github.com/flutter/flutter/issues/143881)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    final ScrollController scrollController = ScrollController();

    return MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Material(
        child: ScrollConfiguration(
          behavior: const NoScrollbarBehavior(),
          child: ScrollbarTheme(
            data: ScrollbarThemeData(
              thickness: MaterialStateProperty.all(25.0),
              showTrackOnHover: true,
            ),
            child: Scrollbar(
              thickness: 50.0,
              thumbVisibility: true,
              radius: const Radius.circular(3.0),
              controller: scrollController,
              child: SingleChildScrollView(
                controller: scrollController,
                child: const SizedBox(width: 4000.0, height: 4000.0),
              ),
            ),
          ),
        ),
      ),
    );
  }
}

class NoScrollbarBehavior extends ScrollBehavior {
  const NoScrollbarBehavior();

  @override
  Widget buildScrollbar(
          BuildContext context, Widget child, ScrollableDetails details) =>
      child;
}
```

</details>

### Preview

| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/flutter/flutter/assets/48603081/3537d60d-a5b2-488d-aa99-4c36c3721657"  /> | <img src="https://github.com/flutter/flutter/assets/48603081/cfd02095-a327-4b16-8ece-0d1c9e6813ce" /> |
 2024-02-26 10:34:27 +00:00
engine-flutter-autoroll f58f108792
Roll Flutter Engine from 168cc5c0a195 to 32d7f9f0f546 (1 revision) (#144128) 
168cc5c0a1...32d7f9f0f5

2024-02-26 skia-flutter-autoroll@skia.org Roll Skia from a79c52feafa4 to cb2a47da08b7 (3 revisions) (flutter/engine#50962)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-26 10:24:24 +00:00
engine-flutter-autoroll 9027dc9a38
Roll Flutter Engine from 330e743203b0 to 168cc5c0a195 (1 revision) (#144125) 
330e743203...168cc5c0a1

2024-02-26 zanderso@users.noreply.github.com Move linux_android_emulator_skia builder to prod (flutter/engine#50956)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-02-26 08:50:23 +00:00