Mairramer
29dd03c56b
Fixes column text width calculation in CupertinoDatePicker ( #151128 )
...
Fixes #138305 , #110319
2024-09-28 20:21:48 +00:00
engine-flutter-autoroll
a9b648f750
Roll Flutter Engine from 380fd814448c to ff4541712df4 (1 revision) ( #155886 )
...
380fd81444...ff4541712dchris@bracken.jp Improved description for ios_debug_sim_unopt_arm64 (flutter/engine#55498 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-28 20:08:35 +00:00
Taha Tesser
9f88de930b
Optimize Overlay sample to avoid overflow ( #155861 )
...
Fixes [Optimize official `Overlay` sample to avoid overflowing.](https://github.com/flutter/flutter/issues/155860 )
When checking https://main-api.flutter.dev/flutter/widgets/Overlay-class.html on a laptop screen it overflows as the layout uses Row instead of more robust widget for spacing `Wrap`
Quick Friday night fix. :)
| Before | After |
| --------------- | --------------- |
| <img src="https://github.com/user-attachments/assets/eea6f1d9-e860-4ebd-8d16-2d8f4141e1ec " /> | <img src="https://github.com/user-attachments/assets/9f8426ba-d541-44a6-8ea6-2e34636b7e82 " /> |
2024-09-28 09:20:32 +00:00
engine-flutter-autoroll
71fd800e7e
Roll Flutter Engine from f3b11bcd9c37 to 380fd814448c (1 revision) ( #155876 )
...
f3b11bcd9c...380fd81444skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hMFizUI--VpyjP3ht... to yX_hiCzoio2mYXAA8... (flutter/engine#55505 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from hMFizUI--Vpy to yX_hiCzoio2m
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-28 08:52:33 +00:00
engine-flutter-autoroll
10fe74a151
Roll Flutter Engine from 9c8e5cb226e4 to f3b11bcd9c37 (3 revisions) ( #155865 )
...
9c8e5cb226...f3b11bcd9c1961493+harryterkelsen@users.noreply.github.com Revert "Reland "[canvaskit] Further improve overlay optimization by splitting pictures"" (flutter/engine#55501 )
2024-09-28 matanlurey@users.noreply.github.com Migrate `try/finally` calls to `addTearDown`. (flutter/engine#55499 )
2024-09-27 chris@bracken.jp iOS: Migrate FlutterAppDelegate to ARC (flutter/engine#55472 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-28 02:21:25 +00:00
engine-flutter-autoroll
9928ba8bd0
Roll Flutter Engine from f9e4ed28f103 to 9c8e5cb226e4 (1 revision) ( #155857 )
...
f9e4ed28f1...9c8e5cb226jason-simmons@users.noreply.github.com [Impeller] Apply some recent color filter fixes to BlendFilterContents::CreateForegroundAdvancedBlend (flutter/engine#55470 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-28 00:09:24 +00:00
engine-flutter-autoroll
3e4a57fa50
Roll Flutter Engine from f21f2b232b8a to f9e4ed28f103 (2 revisions) ( #155855 )
...
f21f2b232b...f9e4ed28f130870216+gaaclarke@users.noreply.github.com updated Color docstring to address equality (flutter/engine#55496 )
2024-09-27 chris@bracken.jp Make arm64 iOS simulator local engine build unopt (flutter/engine#55493 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-27 23:13:21 +00:00
RamonFarizel
1290ab42d1
Add magnificationScale to CupertinoMagnifier for Zoom Effect ( #155276 )
...
Add `magnificationScale `to `CupertinoMagnifier` for Zoom Effect
The CupertinoMagnifier widget is not displaying the expected zoom effect.
This issue arises because the widget internally wraps the RawMagnifier, which has its magnificationScale attribute set to the default value of 1. As a result, no magnification is applied, and the zoom effect is absent.
Fixes #155275
2024-09-27 23:13:19 +00:00
Jonathan Steele
96291fc0c4
Fix typo on theme_data ( #155644 )
...
Fix one typo on theme_data
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-09-27 14:33:09 -07:00
engine-flutter-autoroll
2dbd73dbb9
Roll Flutter Engine from 7c603de2dca7 to f21f2b232b8a (6 revisions) ( #155843 )
...
7c603de2dc...f21f2b232b1083941774@qq.com [docs] Fix broken links in docs/ (flutter/engine#55350 )
2024-09-27 skia-flutter-autoroll@skia.org Roll Skia from e77818421e91 to 7efc11f2ea9e (6 revisions) (flutter/engine#55489 )
2024-09-27 jason-simmons@users.noreply.github.com Listen for uncaught exceptions during loading of a web test suite in Chrome (flutter/engine#55166 )
2024-09-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] hash even less stuff per frame. (#55092 )" (flutter/engine#55491 )
2024-09-27 mdebbar@google.com [web] Update builder json generator to reflect recent changes (flutter/engine#55307 )
2024-09-27 jonahwilliams@google.com [Impeller] hash even less stuff per frame. (flutter/engine#55092 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-27 19:59:32 +00:00
Gray Mackall
dec2091c03
Turn the packages roller bot back on ( #155842 )
...
Turns the roller bot back on, as it should have been fixed by https://github.com/flutter/flutter/pull/155794/ .
2024-09-27 19:43:37 +00:00
engine-flutter-autoroll
180f40108b
Roll Packages from f38b780f530f to 0321757447bf (4 revisions) ( #155832 )
...
f38b780f53...0321757447engine-flutter-autoroll@skia.org Roll Flutter from 538e7424d0fa402c8057flutter/packages#7713 )
2024-09-26 hosam.hasan.ramadan@gmail.com [flutter_markdown] remove backgroundColor from code text theme to enable code selection highlight (flutter/packages#7090 )
2024-09-26 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds internal wrapper for iOS native `IMAFriendlyObstruction` (flutter/packages#7696 )
2024-09-26 matanlurey@users.noreply.github.com Add a `@SuppressWarnings` in advance (flutter/packages#7712 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-27 18:11:06 +00:00
Martin Kustermann
ead6b0d17c
Remove left-over traces of "link-dry-run" - which isn't used anywhere in flutter ( #155820 )
...
The "link-dry-run" functionality was never used in flutter (even before
the recent refactoring).
I think we can remove this "link-dry-run" concept everywhere.
PR to remove this in dart-lang/native:
https://github.com/dart-lang/native/pull/1613
2024-09-27 16:45:35 +02:00
engine-flutter-autoroll
9be22b58c4
Roll Flutter Engine from e57b440ec4ee to 7c603de2dca7 (5 revisions) ( #155811 )
...
e57b440ec4...7c603de2dcskia-flutter-autoroll@skia.org Roll Skia from 9ebb7c3640a1 to e77818421e91 (4 revisions) (flutter/engine#55479 )
2024-09-27 jonahwilliams@google.com [ci] make opengles impeller scenario app non-bringup (flutter/engine#55474 )
2024-09-27 jonahwilliams@google.com [Impeller] dont use blend shader for simple drawAtlas calls. (flutter/engine#55420 )
2024-09-27 valentin.haloiu@gmail.com Add `format` field to EGL surface backing store (flutter/engine#54499 )
2024-09-26 jonahwilliams@google.com [Impeller] avoid reading font while parsing sktextblob. (flutter/engine#55442 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-27 08:22:24 +00:00
Bruno Leroux
9ee3fb813f
Fix DropdownMenu rendered behind AppBar ( #155539 )
...
## Description
This PR changes the `MenuAnchor` implementation in order to always show the menu on the root overlay. Doing so menus can't be hidden by other widgets especially when using go_router.
See [[go_router] DropdownMenu behind NavigationBar](https://github.com/flutter/flutter/issues/155034 ) where the DropdownMenu menu was displayed behind the navigation bar.
I did not make this configurable for the moment to avoid introducing a new parameter until there is a clear use case for it.
## Related Issue
Fixes [[go_router] DropdownMenu behind NavigationBar](https://github.com/flutter/flutter/issues/155034 ).
## Tests
Adds 1 test.
2024-09-27 07:18:35 +00:00
engine-flutter-autoroll
7bb9352911
Roll Flutter Engine from 53517772a5b0 to e57b440ec4ee (8 revisions) ( #155799 )
...
53517772a5...e57b440ec41961493+harryterkelsen@users.noreply.github.com Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55464 )
2024-09-26 jonahwilliams@google.com [Impeller] remove entity pass and re-combine canvas implementations. (flutter/engine#55019 )
2024-09-26 skia-flutter-autoroll@skia.org Roll Skia from e986bd33fb33 to 9ebb7c3640a1 (3 revisions) (flutter/engine#55466 )
2024-09-26 skia-flutter-autoroll@skia.org Roll Skia from 5f6ea5ff8401 to e986bd33fb33 (1 revision) (flutter/engine#55465 )
2024-09-26 matanlurey@users.noreply.github.com Remove and inline dependencies on `build_root` for a constant. (flutter/engine#55441 )
2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (#55418 )" (#55450 )" (flutter/engine#55463 )
2024-09-26 chris@bracken.jp cipd: add mobileprovision CIPD package (flutter/engine#55449 )
2024-09-26 skia-flutter-autoroll@skia.org Roll Skia from b2c5f640cb44 to 5f6ea5ff8401 (1 revision) (flutter/engine#55462 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-27 01:23:28 +00:00
David Iglesias
f9a76aea87
Throw StateError when implicitView is null on wrapWithDefaultView. ( #155734 )
...
This PR tweaks `wrapWithDefaultView` (used by `runApp`) to raise a StateError with a legible error message when the `platformDispatcher.implicitView` is missing (for example, when enabling multi-view embedding on the web), instead of crashing with an unexpected `nullCheck` a few lines below.
* Before:
<img width="619" alt="Screenshot 2024-09-25 at 7 33 47â¯PM" src="https://github.com/user-attachments/assets/4897dd3c-bdd0-4217-9f23-7eee9fab4999 ">
* After:
<img width="613" alt="Screenshot 2024-09-26 at 5 01 49â¯PM" src="https://github.com/user-attachments/assets/3febb91d-a8c3-41b6-bf34-c2c8743b637c ">
## Issues
* Fixes https://github.com/flutter/flutter/issues/153198
## Tests
Added a test to ensure the assertion is thrown when the `implicitView` is missing. Had to hack a little because I couldn't find any clean way of overriding the `implicitView`. The problem is that the flutter_test bindings [use `runApp` internally](8925e1ffdf/packages/flutter_test/lib/src/binding.dart (L1020)
2024-09-27 00:55:31 +00:00
Gray Mackall
cad7418f0a
Roll packages manually ( #155786 )
...
*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-09-27 00:49:08 +00:00
Renzo Olivares
799cf16aeb
fix: SelectableText should handle focus changes ( #155771 )
...
This change updates the behavior of `SelectableText`, to clear its selection when it loses focus and the application is currently running. This fixes the behavior where you may have multiple active highlights if you have `SelectableText` along with other "selectable" widgets such as `TextField`, or `Text` widgets under a `SelectionArea`.
If the application is in the background, for example when another window is focused, the selection should be retained so when a user returns to the application it is still there.
This change also updates the behavior of selection on macOS, single tap up, previously it was selecting the word edge closest to the tapped position, the correct behavior on native is to select the precise position. This was causing `onSelectionChanged` to be called twice, once for tap down (sets the precise tapped position, handled by logic in `TextSelectionGestureDetector`), and a second time for single tap up (moves the cursor to closest word edge, handled by logic in `_SelectableTextSelectionGestureDetectorBuilder`). This type of selection inconsistency is related to this issue https://github.com/flutter/flutter/issues/129726 , I plan to look into this further in a separate PR.
Fixes #117573
Fixes #103725
2024-09-27 00:17:05 +00:00
Gray Mackall
5b32f33271
Use flutter from in same repo (not path) in generate_gradle_lockfiles.dart (again) ( #155794 )
...
Fixes another invocation of `flutter`. Follow up to https://github.com/flutter/flutter/pull/155790/ .
Checked that this is the only other one (and also the only use of `exec()` left that is relying on the path and shouldn't be (one other use uses git from the path, which is fine, and the other one uses an absolute path).
2024-09-27 00:13:27 +00:00
Gray Mackall
2c0a4f2d44
Use flutter from in same repo (not path) in generate_gradle_lockfiles.dart ( #155790 )
...
Should hopefully fix https://github.com/flutter/flutter/issues/155704 ð
2024-09-26 22:58:06 +00:00
Renzo Olivares
9a64920bb9
RenderParagraph should invalidate its _SelectableFragments cached rects on window size updates (#155719 )
...
Fixes #155143
Fixes #120578
2024-09-26 22:51:59 +00:00
zhengzeqin
7f663fc1d8
Fix broken text field with set hint and min and max lines( #153183 ) ( #153235 )
...
Fix https://github.com/flutter/flutter/issues/153183
Fix https://github.com/flutter/flutter/issues/52008
Pre-launch Checklist
2024-09-26 22:08:05 +00:00
engine-flutter-autoroll
feb9c59284
Roll Flutter Engine from 9e6133e8d906 to 53517772a5b0 (1 revision) ( #155772 )
...
9e6133e8d9...53517772a530870216+gaaclarke@users.noreply.github.com fixes color filter + advanced blends (flutter/engine#55448 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-26 18:32:18 +00:00
Ian Hickson
20bc0a9cb8
Fix line-wrapping in flutter create error message. ( #150325 )
2024-09-26 17:04:03 +00:00
Christopher Fujino
a0e75cd309
remove fujino from CODEOWNERS ( #155369 )
...
Every time someone tries to merge stable into master, I get pinged. It's not worth the distraction. I initially added myself as CODEOWNER because I wanted to make sure people weren't adding unneccessary dependencies to the tool, but I give up.
2024-09-26 17:02:24 +00:00
engine-flutter-autoroll
fa402c8057
Roll Flutter Engine from 6328a0597b68 to 9e6133e8d906 (1 revision) ( #155762 )
...
6328a0597b...9e6133e8d9skia-flutter-autoroll@skia.org Roll Skia from 5c9f28d05afe to b2c5f640cb44 (1 revision) (flutter/engine#55461 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-26 16:37:17 +00:00
engine-flutter-autoroll
7ec6083bed
Roll Packages from 7da2374fd818 to f38b780f530f (2 revisions) ( #155760 )
...
7da2374fd8...f38b780f53devoncarew@google.com [package:flutter_lints] update the dep on `package:lints` to 5.0.0 and the sdk dependency to 3.5.0 (flutter/packages#7704 )
2024-09-25 engine-flutter-autoroll@skia.org Roll Flutter from 4ca51a1de5538e7424d0flutter/packages#7705 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-26 15:39:06 +00:00
dependabot[bot]
49873fd236
Bump codecov/codecov-action from 4.4.1 to 4.5.0 ( #150229 )
2024-09-26 14:53:36 +00:00
engine-flutter-autoroll
f7b363929d
Roll Flutter Engine from 08f935236e45 to 6328a0597b68 (1 revision) ( #155750 )
...
08f935236e...6328a0597bskia-flutter-autoroll@skia.org Roll Skia from dcb270abc4e7 to 5c9f28d05afe (2 revisions) (flutter/engine#55460 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-26 12:04:29 +00:00
engine-flutter-autoroll
a9853d6e21
Roll Flutter Engine from 3a520a2a4399 to 08f935236e45 (1 revision) ( #155748 )
...
3a520a2a43...08f935236eskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from T0BbBnkQd0GfMnGQc... to hMFizUI--VpyjP3ht... (flutter/engine#55458 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from T0BbBnkQd0Gf to hMFizUI--Vpy
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-26 11:03:36 +00:00
Martin Kustermann
abcba1fa7e
Reland "[flutter_tools] Cleanup of native asset related code (removes around 50% of the native asset related code) ( #155430 )" ( #155745 )
...
Changes to original CL: The code that issues an error on unsupported
operating system in the dry-run case was missing a case for iOS and
Android
Original CL description
tl;dr Removes 50% (>1650 locs) of native asset related code in
`packages/flutter_tools`
Before this PR the invocation of dart build/link/dry-run was implemented
per OS. This lead to very large code duplication of almost identical,
but slightly different code. It also led to similarly duplicated test
code.
Almost the entire dart build/link/dry-run implementation is identical
across OSes. There's small variations:
- configuration of the build (e.g. android/macos/ios version, ios sdk,
...)
- determining target locations & copying the final shared libraries
This PR unifies the implementation by reducing the code to basically two
main functions:
* `runFlutterSpecificDartBuild` which is responsible for
- obtain flutter configuration
- perform dart build (& link)
- determine target location & install binaries
* `runFlutterSpecificDartDryRunOnPlatforms` which is responsible for a
similar (but not same):
- obtain flutter configuration
- perform dart dry run
- determine target location
these two functions will call out to helpers for the OS specific
functionality:
* `_assetTargetLocationsForOS` for determining the location of the code
assets
* `_copyNativeCodeAssetsForOS` for copying the code assets (and possibly
overriting the install name, etc)
=> Since we get rid of the code duplication across OSes and have only a
single code path for the build/link/dry-run, we can also remove the
duplicated tests that were pretty much identical across OSes.
We also harden the building code by adding asserts, e.g.
* the dry fun functionality should never be used by `flutter test`
* the `build/native_assets/<os>/native_assets.yaml` should only be used
by `flutter test` and the dry-run of `flutter run`
=> We change the tests to also comply with these invariants (so the
tests are not testing things that cannot happen in reality)
We also rename `{,Flutter}NativeAssetsBuildRunner` to disambiguate it
from the `package:native_asset_builder`'s `NativeAssetsBuildRunner`.
2024-09-26 12:21:29 +02:00
engine-flutter-autoroll
a5c7b068f8
Roll Flutter Engine from 896208ee5828 to 3a520a2a4399 (1 revision) ( #155744 )
...
896208ee58...3a520a2a43skia-flutter-autoroll@skia.org Roll Skia from d804bdf62b5e to dcb270abc4e7 (1 revision) (flutter/engine#55457 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-26 09:26:25 +00:00
engine-flutter-autoroll
5b1eb26da9
Roll Flutter Engine from fc6c85292b57 to 896208ee5828 (2 revisions) ( #155743 )
...
fc6c85292b...896208ee58skia-flutter-autoroll@skia.org Roll Skia from e5ce4ecbcf7b to d804bdf62b5e (1 revision) (flutter/engine#55455 )
2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (#55402 )" (flutter/engine#55456 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-26 08:23:47 +00:00
engine-flutter-autoroll
010b7393aa
Roll Flutter Engine from 3719454a879f to fc6c85292b57 (1 revision) ( #155738 )
...
3719454a87...fc6c85292bjonahwilliams@google.com [iOS] remove clear color hack. (flutter/engine#54451 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-26 06:21:10 +00:00
Sikandar Sadaqat
cc0ca11ee4
added ability to configure shadow in banner ( #155296 )
...
Added ability to configure shadow in banner
Issues: https://github.com/flutter/flutter/issues/154505
Before:
After:
2024-09-26 04:04:24 +00:00
engine-flutter-autoroll
1dc2108a0b
Roll Flutter Engine from d4850c1ae648 to 3719454a879f (1 revision) ( #155736 )
...
d4850c1ae6...3719454a87skia-flutter-autoroll@skia.org Roll Skia from 9f3b32b7b772 to e5ce4ecbcf7b (1 revision) (flutter/engine#55452 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-26 03:48:37 +00:00
engine-flutter-autoroll
a75e98de91
Roll Flutter Engine from d6d5fdba6ae1 to d4850c1ae648 (18 revisions) ( #155733 )
...
d6d5fdba6a...d4850c1ae6#55444 )" (flutter/engine#55454 )
2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (#55418 )" (flutter/engine#55450 )
2024-09-25 1961493+harryterkelsen@users.noreply.github.com Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55402 )
2024-09-25 matanlurey@users.noreply.github.com Move lint suppression from `baseline.xml` to `@SuppressLint`. (flutter/engine#55447 )
2024-09-25 jonahwilliams@google.com [engine] set platform thread name to ui. (flutter/engine#55362 )
2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter/engine#55444 )
2024-09-25 jonahwilliams@google.com [Impeller] actually fix external texture for GLES. (flutter/engine#55414 )
2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from e623a37de332 to 9f3b32b7b772 (2 revisions) (flutter/engine#55443 )
2024-09-25 jessiewong401@gmail.com Remove usages of WindowManager's getDefaultDisplay (flutter/engine#55002 )
2024-09-25 30870216+gaaclarke@users.noreply.github.com Fixes blend + color filter (flutter/engine#55411 )
2024-09-25 matanlurey@users.noreply.github.com Add a boolean that exposes rotation/crop metadata capability. (flutter/engine#55434 )
2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 9af762100cf1 to e623a37de332 (1 revision) (flutter/engine#55439 )
2024-09-25 jonahwilliams@google.com [scenario_app] delete get bitmap activity. (flutter/engine#55436 )
2024-09-25 bdero@google.com [Flutter GPU] Use vm.Vector4 for clear color instead of ui.Color. (flutter/engine#55416 )
2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from dd73afd20be5 to c2728b947e46 (1 revision) (flutter/engine#55437 )
2024-09-25 30870216+gaaclarke@users.noreply.github.com adds more tasks to the engine workspace (flutter/engine#55435 )
2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 79e652aad7a9 to 9af762100cf1 (2 revisions) (flutter/engine#55433 )
2024-09-25 matanlurey@users.noreply.github.com Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter/engine#55418 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-26 02:58:28 +00:00
Robert Ancell
8925e1ffdf
Move the Linux runner into a subdirectory ( #153812 )
...
Fixes https://github.com/flutter/flutter/issues/60213
2024-09-26 11:52:53 +12:00
dependabot[bot]
6458fd9233
Bump actions/checkout from 4.1.7 to 4.2.0 ( #155711 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.7 to 4.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases ">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.2.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Add Ref and Commit outputs by <a href="https://github.com/lucacome "><code>@âlucacome</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1180 ">actions/checkout#1180</a></li>
<li>Dependabot updates in <a href="https://redirect.github.com/actions/checkout/pull/1777 ">actions/checkout#1777</a> & <a href="https://redirect.github.com/actions/checkout/pull/1872 ">actions/checkout#1872</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/yasonk "><code>@âyasonk</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1869 ">actions/checkout#1869</a></li>
<li><a href="https://github.com/lucacome "><code>@âlucacome</code></a> made their first contribution in <a href="https://redirect.github.com/actions/checkout/pull/1180 ">actions/checkout#1180</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.1.7...v4.2.0 ">https://github.com/actions/checkout/compare/v4.1.7...v4.2.0 </a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/blob/main/CHANGELOG.md ">actions/checkout's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<h2>v4.2.0</h2>
<ul>
<li>Add Ref and Commit outputs by <a href="https://github.com/lucacome "><code>@âlucacome</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1180 ">actions/checkout#1180</a></li>
<li>Dependency updates by <a href="https://github.com/dependabot "><code>@âdependabot</code></a>- <a href="https://redirect.github.com/actions/checkout/pull/1777 ">actions/checkout#1777</a>, <a href="https://redirect.github.com/actions/checkout/pull/1872 ">actions/checkout#1872</a></li>
</ul>
<h2>v4.1.7</h2>
<ul>
<li>Bump the minor-npm-dependencies group across 1 directory with 4 updates by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1739 ">actions/checkout#1739</a></li>
<li>Bump actions/checkout from 3 to 4 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1697 ">actions/checkout#1697</a></li>
<li>Check out other refs/* by commit by <a href="https://github.com/orhantoy "><code>@âorhantoy</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1774 ">actions/checkout#1774</a></li>
<li>Pin actions/checkout's own workflows to a known, good, stable version. by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1776 ">actions/checkout#1776</a></li>
</ul>
<h2>v4.1.6</h2>
<ul>
<li>Check platform to set archive extension appropriately by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1732 ">actions/checkout#1732</a></li>
</ul>
<h2>v4.1.5</h2>
<ul>
<li>Update NPM dependencies by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1703 ">actions/checkout#1703</a></li>
<li>Bump github/codeql-action from 2 to 3 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1694 ">actions/checkout#1694</a></li>
<li>Bump actions/setup-node from 1 to 4 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1696 ">actions/checkout#1696</a></li>
<li>Bump actions/upload-artifact from 2 to 4 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1695 ">actions/checkout#1695</a></li>
<li>README: Suggest <code>user.email</code> to be <code>41898282+github-actions[bot]@users.noreply.github.com</code> by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1707 ">actions/checkout#1707</a></li>
</ul>
<h2>v4.1.4</h2>
<ul>
<li>Disable <code>extensions.worktreeConfig</code> when disabling <code>sparse-checkout</code> by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1692 ">actions/checkout#1692</a></li>
<li>Add dependabot config by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1688 ">actions/checkout#1688</a></li>
<li>Bump the minor-actions-dependencies group with 2 updates by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1693 ">actions/checkout#1693</a></li>
<li>Bump word-wrap from 1.2.3 to 1.2.5 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1643 ">actions/checkout#1643</a></li>
</ul>
<h2>v4.1.3</h2>
<ul>
<li>Check git version before attempting to disable <code>sparse-checkout</code> by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1656 ">actions/checkout#1656</a></li>
<li>Add SSH user parameter by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1685 ">actions/checkout#1685</a></li>
<li>Update <code>actions/checkout</code> version in <code>update-main-version.yml</code> by <a href="https://github.com/jww3 "><code>@âjww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1650 ">actions/checkout#1650</a></li>
</ul>
<h2>v4.1.2</h2>
<ul>
<li>Fix: Disable sparse checkout whenever <code>sparse-checkout</code> option is not present <a href="https://github.com/dscho "><code>@âdscho</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1598 ">actions/checkout#1598</a></li>
</ul>
<h2>v4.1.1</h2>
<ul>
<li>Correct link to GitHub Docs by <a href="https://github.com/peterbe "><code>@âpeterbe</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1511 ">actions/checkout#1511</a></li>
<li>Link to release page from what's new section by <a href="https://github.com/cory-miller "><code>@âcory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1514 ">actions/checkout#1514</a></li>
</ul>
<h2>v4.1.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1396 ">Add support for partial checkout filters</a></li>
</ul>
<h2>v4.0.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1067 ">Support fetching without the --progress option</a></li>
<li><a href="https://redirect.github.com/actions/checkout/pull/1436 ">Update to node20</a></li>
</ul>
<h2>v3.6.0</h2>
<ul>
<li><a href="https://redirect.github.com/actions/checkout/pull/1377 ">Fix: Mark test scripts with Bash'isms to be run via Bash</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="d632683dd7https://redirect.github.com/actions/checkout/issues/1878 ">#1878</a>)</li>
<li><a href="6d193bf280https://redirect.github.com/actions/checkout/issues/1777 ">#1777</a>)</li>
<li><a href="db0cee9a51https://redirect.github.com/actions/checkout/issues/1872 ">#1872</a>)</li>
<li><a href="b684943689https://redirect.github.com/actions/checkout/issues/1180 ">#1180</a>)</li>
<li><a href="2d7d9f7ff5https://redirect.github.com/actions/checkout/issues/1869 ">#1869</a>)</li>
<li><a href="9a9194f871https://redirect.github.com/actions/checkout/issues/1832 ">#1832</a>)</li>
<li><a href="dd960bd3c3https://redirect.github.com/actions/checkout/issues/1831 ">#1831</a>)</li>
<li>See full diff in <a href="692973e3d9...d632683dd7https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=4.1.7&new-version=4.2.0 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-09-25 22:08:16 +00:00
auto-submit[bot]
4dfa688ec4
Reverts "[flutter_tools] Cleanup of native asset related code (removes around 50% of the native asset related code) ( #155430 )" ( #155713 )
...
Reverts: flutter/flutter#155430
Initiated by: eyebrowsoffire
Reason for reverting: Postsubmit failures closing the tree. See the following examples:
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20native_assets_ios/5738/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64_mokey%20native_assets_android/583/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20native_assets_android/4075/overview
https://ci.chromium.org/u
Original PR Author: mkustermann
Reviewed By: {bkonyi, dcharkes}
This change reverts the following previous change:
tl;dr Removes 50% (>1650 locs) of native asset related code in `packages/flutter_tools`
Before this PR the invocation of dart build/link/dry-run was implemented per OS. This lead to very large code duplication of almost identical, but sligthly different code. It also led to similarly duplicated test code.
Almost the entire dart build/link/dry-run implementation is identical across OSes. There's small variations:
- configuration of the build (e.g. android/macos/ios version, ios sdk, ...)
- determining target locations & copying the final shared libraries
This PR unifies the implementation by reducing the code to basically two main functions:
* `runFlutterSpecificDartBuild` which is responsible for
- obtain flutter configuration
- perform dart build (& link)
- determine target location & install binaries
* `runFlutterSpecificDartDryRunOnPlatforms` which is responsible for a similar (but not same):
- obtain flutter configuration
- perform dart dry run
- determine target location
these two functions will call out to helpers for the OS specific functionality:
* `_assetTargetLocationsForOS` for determining the location of the code assets
* `_copyNativeCodeAssetsForOS` for copying the code assets (and possibly overriting the install name, etc)
=> Since we get rid of the code duplication across OSes and have only a single code path for the build/link/dry-run, we can also remove the duplicated tests that were pretty much identical across OSes.
We also harden the building code by adding asserts, e.g.
* the dry fun functionality should never be used by `flutter test`
* the `build/native_assets/<os>/native_assets.yaml` should only be used by `flutter test` and the dry-run of `flutter run`
=> We change the tests to also comply with these invariants (so the tests are not testing things that cannot happen in reality)
We also rename `{,Flutter}NativeAssetsBuildRunner` to disambiguate it from the `package:native_asset_builder`'s `NativeAssetsBuildRunner`.
We also reorganize the main code to make it readable from top-down and make members private where they can be.
2024-09-25 21:46:22 +00:00
Martin Kustermann
621e7ef951
[flutter_tools] Cleanup of native asset related code (removes around 50% of the native asset related code) ( #155430 )
...
tl;dr Removes 50% (>1650 locs) of native asset related code in
`packages/flutter_tools`
Before this PR the invocation of dart build/link/dry-run was implemented
per OS. This lead to very large code duplication of almost identical,
but slightly different code. It also led to similarly duplicated test
code.
Almost the entire dart build/link/dry-run implementation is identical
across OSes. There's small variations:
- configuration of the build (e.g. android/macos/ios version, ios sdk, ...)
- determining target locations & copying the final shared libraries
This PR unifies the implementation by reducing the code to basically two
main functions:
* `runFlutterSpecificDartBuild` which is responsible for
- obtain flutter configuration
- perform dart build (& link)
- determine target location & install binaries
* `runFlutterSpecificDartDryRunOnPlatforms` which is responsible for a
similar (but not same):
- obtain flutter configuration
- perform dart dry run
- determine target location
these two functions will call out to helpers for the OS specific
functionality:
* `_assetTargetLocationsForOS` for determining the location of the code
assets
* `_copyNativeCodeAssetsForOS` for copying the code assets (and possibly
overriting the install name, etc)
=> Since we get rid of the code duplication across OSes and have only a
single code path for the build/link/dry-run, we can also remove the
duplicated tests that were pretty much identical across OSes.
We also harden the building code by adding asserts, e.g.
* the dry fun functionality should never be used by `flutter test`
* the `build/native_assets/<os>/native_assets.yaml` should only be used
by `flutter test` and the dry-run of `flutter run`
=> We change the tests to also comply with these invariants (so the
tests are not testing things that cannot happen in reality)
We also rename `{,Flutter}NativeAssetsBuildRunner` to disambiguate it
from the `package:native_asset_builder`'s `NativeAssetsBuildRunner`.
2024-09-25 22:50:43 +02:00
Mohellebi abdessalem
936cfb8edc
reduce warnings inside flutter.groovy file #2 ( #155628 )
...
follow up for : [#152073 ](https://github.com/flutter/flutter/pull/152073 )
2024-09-25 19:41:20 +00:00
Camille Simon
146ea07abd
[Android] Update SystemUiMode and setSystemChromeEnabledSystemUIMode docs to note targeting Android 15+ change ( #153466 )
...
Updates `SystemUiMode` and `setSystemChromeEnabledSystemUIMode` documentation to reflect that edge-to-edge mode is used by default if the Flutter app targets Android 15.
Part of https://github.com/flutter/flutter/issues/150367 and framework counterpart to https://github.com/flutter/engine/pull/54560 .
2024-09-25 19:41:18 +00:00
Christopher Fujino
eb42a01302
mark linux packages autoroller bringup: true ( #155705 )
...
Unblock the tree while I investigate
https://github.com/flutter/flutter/issues/155704
2024-09-25 12:38:19 -07:00
Flutter GitHub Bot
538e7424d0
Marks Linux build_aar_module_test to be unflaky ( #155349 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux build_aar_module_test"
}
-->
The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20build_aar_module_test%22 ).
This test can be marked as unflaky.
2024-09-25 18:44:07 +00:00
engine-flutter-autoroll
2764a31423
Roll Packages from 4926c0f8bd99 to 7da2374fd818 (3 revisions) ( #155701 )
...
4926c0f8bd...7da2374fd8chingjun@google.com Update test to not depend on `Color.toString()` (flutter/packages#7701 )
2024-09-25 devoncarew@google.com [flutter_lints] remove prefer_const_constructors, prefer_const_declarations, prefer_const_literals_to_create_immutables (flutter/packages#7688 )
2024-09-24 tobias@leafnode.se [go_router] Fixed TabView swiping in custom stateful shell route example (flutter/packages#7583 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-09-25 18:44:05 +00:00
auto-submit[bot]
1c9607fc9c
Reverts "Normalize TabBarTheme ( #155476 )" ( #155698 )
...
Reverts: flutter/flutter#155476
Initiated by: eyebrowsoffire
Reason for reverting: The newly added tests are failing in postsubmit. See https://ci.chromium.org/ui/p/flutter/builders/prod/Windows%20framework_tests_libraries/19062/overview
Original PR Author: QuncCccccc
Reviewed By: {TahaTesser}
This change reverts the following previous change:
This PR is to make preparations to make `TabBarTheme` conform to Flutter's conventions for component themes:
* Added a `TabBarThemeData` class which defines overrides for the defaults for `TabBar` properties.
* Added 2 `TabBarTheme` constructor parameters: `TabBarThemeData? data` and `Widget? child`. This is now the preferred way to configure a `TabBarTheme`:
```
TabBarTheme(
data: TabBarThemeData(labelColor: xxx, indicatorColor: xxx, ...),
child: TabBar(...)
)
```
These two properties are made nullable to not break existing apps which has customized `ThemeData.tabBarTheme`.
* Changed the type of component theme defaults from `TabBarTheme` to `TabBarThemeData`.
TODO:
* Fix internal failures.
* Change the type of `ThemeData.tabBarTheme` from `TabBarTheme` to `TabBarThemeData`. This may cause breaking changes, a migration guide will be created.
Addresses the "theme normalization" sub project within https://github.com/flutter/flutter/issues/91772
2024-09-25 17:50:18 +00:00
Qun Cheng
f310625bc6
Normalize TabBarTheme ( #155476 )
...
This PR is to make preparations to make `TabBarTheme` conform to Flutter's conventions for component themes:
* Added a `TabBarThemeData` class which defines overrides for the defaults for `TabBar` properties.
* Added 2 `TabBarTheme` constructor parameters: `TabBarThemeData? data` and `Widget? child`. This is now the preferred way to configure a `TabBarTheme`:
```
TabBarTheme(
data: TabBarThemeData(labelColor: xxx, indicatorColor: xxx, ...),
child: TabBar(...)
)
```
These two properties are made nullable to not break existing apps which has customized `ThemeData.tabBarTheme`.
* Changed the type of component theme defaults from `TabBarTheme` to `TabBarThemeData`.
TODO:
* Fix internal failures.
* Change the type of `ThemeData.tabBarTheme` from `TabBarTheme` to `TabBarThemeData`. This may cause breaking changes, a migration guide will be created.
Addresses the "theme normalization" sub project within https://github.com/flutter/flutter/issues/91772
2024-09-25 17:19:00 +00:00
Christopher Fujino
3d14246cee
increase both linux & windows tool integration test shards ( #155631 )
...
Fixes both:
- https://github.com/flutter/flutter/issues/155621
- https://github.com/flutter/flutter/issues/155317
2024-09-25 17:15:14 +00:00
