auto-submit[bot]
706f39b0a0
Reverts "Implement computeDryBaseline for RenderWrap ( #146260 )" ( #147692 )
...
Reverts: flutter/flutter#146260
Initiated by: chingjun
Reason for reverting: Broke internal tests. See b/338308016
Original PR Author: LongCatIsLooong
Reviewed By: {goderbauer}
This change reverts the following previous change:
2024-05-02 02:26:28 +00:00
engine-flutter-autoroll
8025af0aa6
Roll Flutter Engine from f56c20c6ac67 to 3087ec1adddd (2 revisions) ( #147688 )
...
f56c20c6ac...3087ec1addjacksongardner@google.com [skwasm] Don't mark the backend texture as mipmapped, since it isn't. (flutter/engine#52501 )
2024-05-01 skia-flutter-autoroll@skia.org Roll Skia from 36ec16922dad to 81ccf3ab27ee (1 revision) (flutter/engine#52504 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 01:55:14 +00:00
Greg Spencer
2e78ed0ff9
Allow explicit exclusion of packages from pinned packages in flutter update-packages --force-update ( #147679 )
...
## Description
This introduces a list of packages that we will explicitly not pin. It is to be used for things where the package isn't actually published, but is a transitive dependency of another package included in the SDK. This happens with the `macros` package, for instance, which depends on the private, unpublished, `_macros` package where the SDK does some tricky things to depend on it (it depends on "any", but ships it as part of the SDK).
Also ran `flutter update-packages --force-update` to update all of the pubspec files.
## Related Issues
- Fixes #147656
## Tests
- Added a test that makes sure that explicitly unpinned packages don't show up in the pinned list.
2024-05-02 01:16:54 +00:00
LongCatIsLooong
ab8ecd5e74
Implement getDryBaseline for Stack and Overlay ( #146253 )
2024-05-02 00:31:12 +00:00
engine-flutter-autoroll
603416233c
Roll Flutter Engine from 2d73fa207927 to f56c20c6ac67 (2 revisions) ( #147681 )
...
2d73fa2079...f56c20c6acskia-flutter-autoroll@skia.org Roll Dart SDK from f5a429107c87 to 04d373e0a99d (2 revisions) (flutter/engine#52503 )
2024-05-01 skia-flutter-autoroll@skia.org Roll Skia from 553b6e2eddc5 to 36ec16922dad (2 revisions) (flutter/engine#52502 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-02 00:18:22 +00:00
Polina Cherkasova
5eb1807464
Update selectable_text_test.dart ( #147677 )
...
Fix leak introduced by https://github.com/flutter/flutter/pull/147341
2024-05-02 00:03:15 +00:00
engine-flutter-autoroll
7203af3e2f
Roll Flutter Engine from c536a14052e5 to 2d73fa207927 (2 revisions) ( #147678 )
...
c536a14052...2d73fa2079magder@google.com Migrate PlatformMessageHandlerIos to ARC (flutter/engine#52226 )
2024-05-01 47866232+chunhtai@users.noreply.github.com macOS fluttertextinputplugin drops selector called if no client (flutter/engine#52495 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-01 23:24:41 +00:00
LongCatIsLooong
88ffd89685
Implement computeDryBaseline for RenderWrap ( #146260 )
2024-05-01 22:39:08 +00:00
engine-flutter-autoroll
730167eb38
Roll Flutter Engine from 842cf254ec58 to c536a14052e5 (1 revision) ( #147675 )
...
842cf254ec...c536a14052skia-flutter-autoroll@skia.org Roll Skia from 0b31f64bd8d8 to 553b6e2eddc5 (5 revisions) (flutter/engine#52500 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-01 22:37:15 +00:00
dependabot[bot]
ffbeb5a39c
Bump codecov/codecov-action from 4.3.0 to 4.3.1 ( #147674 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 4.3.0 to 4.3.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases ">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v4.3.1</h2>
<h2>What's Changed</h2>
<ul>
<li>build(deps-dev): bump typescript from 5.4.4 to 5.4.5 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1370 ">codecov/codecov-action#1370</a></li>
<li>fix: more verbose log message when failing to import pgp key by <a href="https://github.com/ReenigneArcher "><code>@âReenigneArcher</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1371 ">codecov/codecov-action#1371</a></li>
<li>build(deps-dev): bump <code>@âtypescript-eslint/eslint-plugin</code> from 7.6.0 to 7.7.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1374 ">codecov/codecov-action#1374</a></li>
<li>build(deps-dev): bump <code>@âtypescript-eslint/parser</code> from 7.6.0 to 7.7.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1375 ">codecov/codecov-action#1375</a></li>
<li>build(deps): bump actions/checkout from 4.1.2 to 4.1.3 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1382 ">codecov/codecov-action#1382</a></li>
<li>build(deps): bump github/codeql-action from 3.24.10 to 3.25.1 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1381 ">codecov/codecov-action#1381</a></li>
<li>build(deps): bump actions/upload-artifact from 4.3.1 to 4.3.2 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1380 ">codecov/codecov-action#1380</a></li>
<li>build(deps-dev): bump <code>@âtypescript-eslint/parser</code> from 7.7.0 to 7.7.1 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1384 ">codecov/codecov-action#1384</a></li>
<li>build(deps-dev): bump <code>@âtypescript-eslint/eslint-plugin</code> from 7.7.0 to 7.7.1 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1383 ">codecov/codecov-action#1383</a></li>
<li>Update README.md to point to docs about tokenless by <a href="https://github.com/rohan-at-sentry "><code>@ârohan-at-sentry</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1395 ">codecov/codecov-action#1395</a></li>
<li>build(deps): bump actions/upload-artifact from 4.3.2 to 4.3.3 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1393 ">codecov/codecov-action#1393</a></li>
<li>build(deps): bump actions/checkout from 4.1.3 to 4.1.4 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1392 ">codecov/codecov-action#1392</a></li>
<li>build(deps): bump github/codeql-action from 3.25.1 to 3.25.3 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1391 ">codecov/codecov-action#1391</a></li>
<li>style: Node Packages by <a href="https://github.com/marcobiedermann "><code>@âmarcobiedermann</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1394 ">codecov/codecov-action#1394</a></li>
<li>build(deps-dev): bump <code>@âtypescript-eslint/eslint-plugin</code> from 7.7.1 to 7.8.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1402 ">codecov/codecov-action#1402</a></li>
<li>build(deps-dev): bump <code>@âtypescript-eslint/parser</code> from 7.7.1 to 7.8.0 by <a href="https://github.com/dependabot "><code>@âdependabot</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1401 ">codecov/codecov-action#1401</a></li>
<li>docs: Type Annotations by <a href="https://github.com/marcobiedermann "><code>@âmarcobiedermann</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1397 ">codecov/codecov-action#1397</a></li>
<li>docs: main branch by <a href="https://github.com/marcobiedermann "><code>@âmarcobiedermann</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1396 ">codecov/codecov-action#1396</a></li>
<li>fix: bypass token checks for forks and OIDC by <a href="https://github.com/thomasrockhu-codecov "><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1404 ">codecov/codecov-action#1404</a></li>
<li>chore(release): 4.3.1. by <a href="https://github.com/thomasrockhu-codecov "><code>@âthomasrockhu-codecov</code></a> in <a href="https://redirect.github.com/codecov/codecov-action/pull/1405 ">codecov/codecov-action#1405</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/ReenigneArcher "><code>@âReenigneArcher</code></a> made their first contribution in <a href="https://redirect.github.com/codecov/codecov-action/pull/1371 ">codecov/codecov-action#1371</a></li>
<li><a href="https://github.com/rohan-at-sentry "><code>@ârohan-at-sentry</code></a> made their first contribution in <a href="https://redirect.github.com/codecov/codecov-action/pull/1395 ">codecov/codecov-action#1395</a></li>
<li><a href="https://github.com/marcobiedermann "><code>@âmarcobiedermann</code></a> made their first contribution in <a href="https://redirect.github.com/codecov/codecov-action/pull/1394 ">codecov/codecov-action#1394</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/codecov/codecov-action/compare/v4.3.0...v4.3.1 ">https://github.com/codecov/codecov-action/compare/v4.3.0...v4.3.1 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="5ecb98a3c6https://redirect.github.com/codecov/codecov-action/issues/1405 ">#1405</a>)</li>
<li><a href="5a299d1127https://redirect.github.com/codecov/codecov-action/issues/1404 ">#1404</a>)</li>
<li><a href="dad251dcafhttps://redirect.github.com/codecov/codecov-action/issues/1396 ">#1396</a>)</li>
<li><a href="e8bbe5fc01https://redirect.github.com/codecov/codecov-action/issues/1397 ">#1397</a>)</li>
<li><a href="a6fd87fc19https://redirect.github.com/codecov/codecov-action/issues/1401 ">#1401</a>)</li>
<li><a href="76c8cd61631290bddc88https://redirect.github.com/codecov/codecov-action/issues/1394 ">#1394</a>)</li>
<li><a href="951ef79006https://redirect.github.com/codecov/codecov-action/issues/1391 ">#1391</a>)</li>
<li><a href="bb71c1ba2fhttps://redirect.github.com/codecov/codecov-action/issues/1392 ">#1392</a>)</li>
<li><a href="acc5d43cadhttps://redirect.github.com/codecov/codecov-action/issues/1393 ">#1393</a>)</li>
<li>Additional commits viewable in <a href="84508663e9...5ecb98a3c6https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=codecov/codecov-action&package-manager=github_actions&previous-version=4.3.0&new-version=4.3.1 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2024-05-01 22:19:20 +00:00
Ian Hickson
db4dfa0dde
Remove obsolete performance analysis tools. ( #147663 )
...
We're unlikely to support these reliably going forward.
2024-05-01 22:05:02 +00:00
engine-flutter-autoroll
74771f12af
Roll Flutter Engine from 5129b4919434 to 842cf254ec58 (3 revisions) ( #147670 )
...
5129b49194...842cf254ecchinmaygarde@google.com [Impeller] Wire up hardware buffer backed swapchains on Android. (flutter/engine#52087 )
2024-05-01 skia-flutter-autoroll@skia.org Roll Skia from bfbd738fb97b to 0b31f64bd8d8 (3 revisions) (flutter/engine#52492 )
2024-05-01 skia-flutter-autoroll@skia.org Roll Dart SDK from d946408c559a to f5a429107c87 (2 revisions) (flutter/engine#52487 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-01 21:42:24 +00:00
PurplePolyhedron
68f8b536e2
fix DropdownMenu overflow ( #147233 )
...
fix `DropdownMenu` overflow issue in https://github.com/flutter/flutter/issues/147076 and https://github.com/flutter/flutter/issues/147173
However I believe the the menu placement issue in https://github.com/flutter/flutter/issues/147076 is a separate issue. It is not fixed here.
fixes https://github.com/flutter/flutter/issues/147173
2024-05-01 21:24:58 +00:00
Yegor
f256f68831
[web] remove platform_messages_integration test ( #147654 )
...
This functionality is already fully covered by https://github.com/flutter/engine/blob/main/lib/web_ui/test/engine/platform_views/message_handler_test.dart
This might help with https://github.com/flutter/flutter/issues/146189 a little.
2024-05-01 21:12:01 +00:00
Renzo Olivares
5181086fac
Fix TextField horizontal drag conflicts ( #147341 )
...
Currently on iOS `TextField` horizontal drag gestures will have precedence over parent horizontal drag gestures when competing with each other because the default `touchSlop` value used by `TextField` to calculate whether the threshold for a drag has been met is the same as the one used by parent horizontal drag gestures like `PageView`, and other `Scrollable`s. The default value is `18.0`, and because the `TextField` receives the `PointerEvent` first in this scenario, it always declares victory before any parent horizontal drag gestures has the chance to.
Native iOS behavior: The parent horizontal drag gestures will always win unless the drag originated on the cursor (collapsed selection), in that case the TextField cursor drag gestures will win.
This change:
* Introduces `BaseTapAndDragGestureRecognizer.eagerVictoryOnDrag` which can be used to configure the recognizer to declare victory immediately when it detects a drag, or when disabled it will wait until it is the last recognizer in the arena before declaring victory. The default behavior is that it declares victory immediately when the drag is detected.
* Eliminates the iOS cursor drag logic from `TextSelectionGestureDetector`, this logic is now delegated to the selection handle overlay which already had this logic in place.
* Enables iOS cursor to always beat other drag gestures by setting the touch slop lower.
* Disables `eagerVictoryOnDrag` for iOS to allow for parent drag gestures to win and match native behavior.
Fixes #124421 , Fixes #130198 , Fixes #142624 , Fixes #142447 , Fixes #127017
2024-05-01 20:51:54 +00:00
Nate
586e1fce1b
flutter/lib/src/: refactoring if-chains into switch expressions (#147472 )
...
Cleans up some code by porting if chains to switch statements.
2024-05-01 12:58:35 -07:00
auto-submit[bot]
5a41e1edac
Reverts "Draggable feedback positioning ( #145647 )" ( #147658 )
...
Reverts: flutter/flutter#145647
Initiated by: jmagman
Reason for reverting: Failing draggable_test in post-submit.
Original PR Author: timcreatedit
Reviewed By: {justinmc, goderbauer}
This change reverts the following previous change:
We changed the coordinates used to position the `Draggable` feedback by transforming them into the `Overlay`s coordinate space. This has no influence on any untransformed `Overlay`, most Flutter apps should be not affected.
This PR fixes the positioning of the feedback in transformed context (see #145639 for before video):
https://github.com/flutter/flutter/assets/42270125/df34e198-0667-453d-a27a-a79b2e2825a1
- fixes #145639
2024-05-01 18:26:27 +00:00
engine-flutter-autoroll
71a29452c0
Roll Flutter Engine from 0014e0353aa9 to 5129b4919434 (1 revision) ( #147655 )
...
0014e0353a...5129b4919430870216+gaaclarke@users.noreply.github.com [Impeller] Implements retry for `Picture.toImage` (flutter/engine#52470 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-01 17:35:06 +00:00
Yegor
ba6302e2d5
add lang attribute to the a11y_assessments app ( #147586 )
...
Since the app is used to assess Flutter's overall accessibility, the app
should follow at many guidelines as possible, including setting the
`lang` attribute.
Fixes b/338044851
2024-05-01 10:29:17 -07:00
Tim Lehmann
5f9e069111
Draggable feedback positioning ( #145647 )
...
Fixes a calculation in Draggable that was previously wrong when the target was transformed.
2024-05-01 09:56:23 -07:00
engine-flutter-autoroll
b974dcb490
Roll Flutter Engine from 0ce67714ce4c to 0014e0353aa9 (13 revisions) ( #147649 )
...
0ce67714ce...0014e0353ajohn@johnmccutchan.com Fix et run (flutter/engine#52477 )
2024-05-01 skia-flutter-autoroll@skia.org Roll Skia from 5f4ebd628994 to bfbd738fb97b (2 revisions) (flutter/engine#52479 )
2024-05-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from HP2saK9sVOtKvpquC... to PIHl-e41i3mzbriG1... (flutter/engine#52480 )
2024-05-01 skia-flutter-autoroll@skia.org Roll Skia from a6bc04f984d2 to 5f4ebd628994 (1 revision) (flutter/engine#52478 )
2024-05-01 skia-flutter-autoroll@skia.org Roll Dart SDK from c88854d4282c to d946408c559a (1 revision) (flutter/engine#52476 )
2024-05-01 chinmaygarde@google.com [Impeller] Document the EGL toolkit. (flutter/engine#52469 )
2024-05-01 jacksongardner@google.com [skwasm] Change default `FilterQuality` to `None` for image shaders. (flutter/engine#52468 )
2024-05-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 3f649c97a08c to c88854d4282c (1 revision) (flutter/engine#52475 )
2024-04-30 skia-flutter-autoroll@skia.org Roll Skia from 30aaaef0390d to a6bc04f984d2 (1 revision) (flutter/engine#52471 )
2024-04-30 skia-flutter-autoroll@skia.org Roll Skia from 85ec65ecd5ec to 30aaaef0390d (4 revisions) (flutter/engine#52466 )
2024-04-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 7a517de88964 to 3f649c97a08c (1 revision) (flutter/engine#52465 )
2024-04-30 skia-flutter-autoroll@skia.org Roll Skia from 77350e051f71 to 85ec65ecd5ec (2 revisions) (flutter/engine#52464 )
2024-04-30 skia-flutter-autoroll@skia.org Roll Skia from 8f2d039e1190 to 77350e051f71 (1 revision) (flutter/engine#52460 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from HP2saK9sVOtK to PIHl-e41i3mz
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-01 16:41:22 +00:00
Kostia Sokolovskyi
32ea4b3c46
Add test for animated_fractionally_sized_box.0.dart API example. ( #146721 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds `examples/api/test/widgets/implicit_animations/animated_fractionally_sized_box.0_test.dart` test
2024-05-01 16:03:12 +00:00
engine-flutter-autoroll
a1cb040511
Roll Packages from cc47b06b438d to aea93d2a515c (5 revisions) ( #147647 )
...
cc47b06b43...aea93d2a5115619084+vashworth@users.noreply.github.com Skip podspec Swift Search Path validation if only swift file is Package.swift (flutter/packages#6627 )
2024-04-30 ditman@gmail.com [go_router_builder] Tweaks for latest analyzer-6.5.0 (flutter/packages#6632 )
2024-04-30 engine-flutter-autoroll@skia.org Roll Flutter from db8c475cacb597dd24cbflutter/packages#6631 )
2024-04-30 44902066+waleedf112@users.noreply.github.com [flutter_adaptive_scaffold] use `MediaQuery.sizeOf` instead of `MediaQuery.of` to prevent unnecessary rebuilds (flutter/packages#6544 )
2024-04-30 34871572+gmackall@users.noreply.github.com [image_picker] Update documentation to note that Photo Picker use is non-optional on Android 13+ (flutter/packages#6569 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-05-01 16:03:09 +00:00
Ellet
8bf614f181
Update reorderable_list.dart to use Dart 3 return switch statement for consistency ( #147505 )
...
*Update `reorderable_list.dart` from `widgets` to use Dart 3 return switch statement syntax for consistency.*
This just a syntax change to match the rest of the functions in this file
2024-05-01 16:03:08 +00:00
Kostia Sokolovskyi
d33bb8fa5e
Add tests for single_activator.0.dart API example. ( #147426 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Fixes name of the `examples/api/lib/widgets/shortcuts/single_activator.single_activator.0.dart`
- Adds tests for `examples/api/lib/widgets/shortcuts/single_activator.0.dart`
2024-05-01 14:52:57 +00:00
Kishan Dhankecha
2867ac7885
Added missing code block language in docs ( #147481 )
...
- added language for all code blocks
- replaced `bash` or `shell` with `sh` for consistency.
- added `sh` and `console` in the GitHub template link generator.
- updated test for GitHub template.
2024-05-01 14:44:27 +00:00
Zachary Anderson
cb2197e9b3
Move docs_test and docs_publish to bringup ( #147645 )
...
For https://github.com/flutter/flutter/issues/147609 to unblock the
tree.
@gspencergoog @jason-simmons
2024-05-01 07:41:55 -07:00
auto-submit[bot]
abbaaea8a1
Reverts "Fix memory leak in TabPageSelector ( #147403 )" ( #147622 )
...
Reverts: flutter/flutter#147403
Initiated by: chingjun
Reason for reverting: Causing an internal test to fail, see b/338159496 for details
Original PR Author: ValentinVignal
Reviewed By: {polina-c}
This change reverts the following previous change:
Part of https://github.com/flutter/flutter/issues/141198
2024-05-01 05:32:19 +00:00
chunhtai
3e399c1578
Revert "add a new PopScope.onPopWithResultInvoke widget to replace Po… ( #147597 )
...
…pScope.onPopInvoke (#147016 )"
This reverts commit 8031a3e30chttps://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-04-30 13:25:24 -07:00
Andrew Kolos
ce822ec8bb
include exception details in tool exit displayed when adb call fails ( #147498 )
...
Fixes #125971
2024-04-30 17:38:21 +00:00
Valentin Vignal
af270935bb
Fix memory leak in TabPageSelector ( #147403 )
2024-04-30 10:35:22 -07:00
engine-flutter-autoroll
b597dd24cb
Roll Flutter Engine from 2c1517bbf555 to 0ce67714ce4c (1 revision) ( #147585 )
...
2c1517bbf5...0ce67714ceskia-flutter-autoroll@skia.org Roll Skia from 459555f490bf to 8f2d039e1190 (1 revision) (flutter/engine#52458 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 17:26:16 +00:00
engine-flutter-autoroll
456f0101fd
Roll Packages from 87a7c51cc633 to cc47b06b438d (5 revisions) ( #147580 )
...
87a7c51cc6...cc47b06b43joonas.kerttula@codemate.com [google_maps_flutter_web] Add marker clustering support (flutter/packages#6187 )
2024-04-30 joonas.kerttula@codemate.com [google_maps_flutter_android] Add marker clustering support (flutter/packages#6185 )
2024-04-29 32538273+ValentinVignal@users.noreply.github.com [go_router] Don't log if `hierarchicalLoggingEnabled` is `true` (flutter/packages#6019 )
2024-04-29 43054281+camsim99@users.noreply.github.com [file_selector_android] Update `LICENSE` file to include newly added licensed code (flutter/packages#6626 )
2024-04-29 43054281+camsim99@users.noreply.github.com [file_selector_android] Modifies `getDirectoryPath`, `openFile`, `openFiles` to return file/directory paths instead of URIs (flutter/packages#6438 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 16:04:09 +00:00
engine-flutter-autoroll
d840390f61
Roll Flutter Engine from 1a6ef9957b24 to 2c1517bbf555 (1 revision) ( #147579 )
...
1a6ef9957b...2c1517bbf5skia-flutter-autoroll@skia.org Roll Dart SDK from 4144af4e4704 to 7a517de88964 (1 revision) (flutter/engine#52456 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 15:48:05 +00:00
engine-flutter-autoroll
12ad41ca9e
Roll Flutter Engine from 64877c08661d to 1a6ef9957b24 (1 revision) ( #147576 )
...
64877c0866...1a6ef9957bskia-flutter-autoroll@skia.org Roll Skia from b20651c1aad4 to 459555f490bf (1 revision) (flutter/engine#52455 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 13:52:24 +00:00
engine-flutter-autoroll
3d9d3ea12b
Roll Flutter Engine from 1d62704cb3d2 to 64877c08661d (1 revision) ( #147567 )
...
1d62704cb3...64877c0866skia-flutter-autoroll@skia.org Roll Skia from 0b22a72dffeb to b20651c1aad4 (3 revisions) (flutter/engine#52454 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 09:22:41 +00:00
engine-flutter-autoroll
3b1d9b5e98
Roll Flutter Engine from aace42365fc7 to 1d62704cb3d2 (2 revisions) ( #147566 )
...
aace42365f...1d62704cb3flutter/engine#52453 )
2024-04-30 skia-flutter-autoroll@skia.org Roll Skia from e9d3faf63fce to 0b22a72dffeb (1 revision) (flutter/engine#52451 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 08:36:26 +00:00
engine-flutter-autoroll
abf796e9cb
Roll Flutter Engine from ea6343846c62 to aace42365fc7 (2 revisions) ( #147563 )
...
ea6343846c...aace42365fskia-flutter-autoroll@skia.org Roll Dart SDK from 9eb838fa00af to 4144af4e4704 (4 revisions) (flutter/engine#52450 )
2024-04-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from TFm2_qWC2xpkzk8QS... to HP2saK9sVOtKvpquC... (flutter/engine#52449 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from TFm2_qWC2xpk to HP2saK9sVOtK
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 07:35:32 +00:00
engine-flutter-autoroll
0c5f9c2c05
Roll Flutter Engine from c519e9dd182b to ea6343846c62 (1 revision) ( #147560 )
...
c519e9dd18...ea6343846cjohn@johnmccutchan.com Workaround HardwareRenderer breakage in Android 14 (flutter/engine#52370 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 06:53:35 +00:00
engine-flutter-autoroll
2da8633fca
Roll Flutter Engine from 27bb23221305 to c519e9dd182b (1 revision) ( #147557 )
...
27bb232213...c519e9dd18skia-flutter-autoroll@skia.org Roll Skia from 29a483abf358 to e9d3faf63fce (1 revision) (flutter/engine#52444 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 02:19:22 +00:00
engine-flutter-autoroll
3b2bfc740f
Roll Flutter Engine from 93ccb9ab2cda to 27bb23221305 (2 revisions) ( #147556 )
...
93ccb9ab2c...27bb232213zanderso@users.noreply.github.com Add commands to rbe.md (flutter/engine#52442 )
2024-04-29 chinmaygarde@google.com Add a host_debug_unopt_arm64 macOS configuration. (flutter/engine#52443 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 01:16:11 +00:00
engine-flutter-autoroll
4ef2bb96e2
Roll Flutter Engine from c093562677fa to 93ccb9ab2cda (1 revision) ( #147553 )
...
c093562677...93ccb9ab2cskia-flutter-autoroll@skia.org Roll Skia from 9ffb18cccf2a to 29a483abf358 (2 revisions) (flutter/engine#52441 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-30 00:28:34 +00:00
Elliott Brooks
c1c7898b96
Bump dependencies in Flutter ( #147546 )
2024-04-29 15:53:25 -07:00
Amir Panahandeh
b176bce22b
Add configurable hitTestBehavior to Scrollable ( #146403 )
...
This PR adds `hitTestBehavior` to Scrollable as a configurable member.
- https://github.com/flutter/flutter/issues/146401
2024-04-29 22:46:06 +00:00
Taha Tesser
7ff31a4f7a
Fix wide DatePicker input mode button padding for Material 3 ( #147236 )
...
fixes [Wide `DatePickerDialog` "Switch to input" button has no margin from dialog side](https://github.com/flutter/flutter/issues/141338 )
### Description
Currently, there is no material design token for the input mode button padding. This PR fixes the padding by taking date picker side padding values into account.
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
home: Scaffold(
body: Center(
child: Builder(builder: (BuildContext context) {
return ElevatedButton(
onPressed: () {
showDatePicker(
context: context,
initialDate: DateTime.now(),
firstDate: DateTime.utc(2010),
lastDate: DateTime.utc(2030),
);
},
child: const Text('Show Date Picker'),
);
}),
),
),
);
}
}
```
</details>
### Before
### After
2024-04-29 22:14:01 +00:00
engine-flutter-autoroll
d5baa33b0d
Roll Flutter Engine from 13c7ac9376a5 to c093562677fa (1 revision) ( #147547 )
...
13c7ac9376...c093562677skia-flutter-autoroll@skia.org Roll Skia from 953589c71b4a to 9ffb18cccf2a (4 revisions) (flutter/engine#52438 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-29 22:08:52 +00:00
engine-flutter-autoroll
28b81dc575
Roll Flutter Engine from 5165c711771c to 13c7ac9376a5 (1 revision) ( #147542 )
...
5165c71177...13c7ac9376skia-flutter-autoroll@skia.org Roll Skia from f7bfa8eef5b5 to 953589c71b4a (6 revisions) (flutter/engine#52437 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-29 20:25:20 +00:00
engine-flutter-autoroll
a53e89aad8
Roll Packages from dd01140f470e to 87a7c51cc633 (2 revisions) ( #147539 )
...
dd01140f47...87a7c51cc6engine-flutter-autoroll@skia.org Roll Flutter from f9933b6994db8c475cacflutter/packages#6622 )
2024-04-27 engine-flutter-autoroll@skia.org Roll Flutter from 2e806700b9f9933b6994flutter/packages#6620 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-29 19:17:10 +00:00
engine-flutter-autoroll
07db2c4d55
Roll Flutter Engine from 399837d38807 to 5165c711771c (2 revisions) ( #147537 )
...
399837d388...5165c71177zanderso@users.noreply.github.com Remove references to goma (flutter/engine#52411 )
2024-04-29 kjlubick@users.noreply.github.com Make SkUnicode explicitly instead of relying on SkParagraph to make it for us (flutter/engine#52086 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-29 19:05:37 +00:00
zhengzeqin
aabe53ca36
[Fix]: showDateRangePicker with "large" helpText cutoffs the save button ( #146049 )
...
Fix https://github.com/flutter/flutter/issues/146039
Pre-launch Checklist
2024-04-29 18:18:06 +00:00
