Commit graph

8708 commits

Author SHA1 Message Date
Ed Santiago 409d07a181 System tests: add environment, volume tests
Tests for #7094, in which symlinks in a volume would
cause chown errors and nonrunnable containers.

Tests for environment variable precedence, now
include --env-host and proxy settings

Fix a bug caught by covscan in helpers.t ('source'
path would fail if path included spaces).

Fix podman-run man page: it was incorrect in stating
precedence between in-image environment and --env-host.

Fixes: #7099

Signed-off-by: Ed Santiago <santiago@redhat.com>
2020-07-28 09:22:22 -06:00
OpenShift Merge Robot 288ebec6e7
Merge pull request #6909 from rhatdan/podman
Switch all references to github.com/containers/libpod -> podman
2020-07-28 10:12:55 -04:00
OpenShift Merge Robot 6ed9868a34
Merge pull request #7098 from asottile/newline_on_error
add newline to output in error message
2020-07-28 09:23:19 -04:00
OpenShift Merge Robot ec69497b18
Merge pull request #7105 from AkihiroSuda/fix-cgroupversion-string
compat/info.go: TrimPrefix(CGroupsVersion, "v")
2020-07-28 15:01:37 +02:00
OpenShift Merge Robot 14f8085016
Merge pull request #7079 from rhatdan/tuturial
update configuration for rootless podman
2020-07-28 14:58:52 +02:00
OpenShift Merge Robot ecd84781d8
Merge pull request #7101 from AkihiroSuda/rootlesskit-010
Bump github.com/rootless-containers/rootlesskit from 0.9.5 to 0.10.0
2020-07-28 14:56:10 +02:00
Daniel J Walsh a5e37ad280
Switch all references to github.com/containers/libpod -> podman
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-07-28 08:23:45 -04:00
OpenShift Merge Robot 91c92d10fc
Merge pull request #7085 from rhatdan/cmount
Cleanup handling of podman mount/unmount
2020-07-28 14:03:22 +02:00
Akihiro Suda f657e5551e
compat/info.go: TrimPrefix(CGroupsVersion, "v")
For compatibility with Docker: 846b7e24ba/api/swagger.yaml (L4528-L4534)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2020-07-28 18:17:13 +09:00
OpenShift Merge Robot d463715ce7
Merge pull request #7095 from Melykuti/master
Corrects typo in the name of the Linux package shadow-utils.
2020-07-28 09:36:39 +02:00
Akihiro Suda 3c333e7a93
Bump github.com/rootless-containers/rootlesskit from 0.9.5 to 0.10.0
Fix #7016 via https://github.com/rootless-containers/rootlesskit/pull/157

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2020-07-28 16:35:05 +09:00
Anthony Sottile 7b248d9e3a add newline to output in error message
Signed-off-by: Anthony Sottile <asottile@umich.edu>
2020-07-27 16:12:58 -07:00
Daniel J Walsh 8f7ed50cb2
Cleanup handling of podman mount/unmount
We should default to the user name unmount rather then the internal
name of umount.

Also User namespace was not being handled correctly. We want to inform
the user that if they do a mount when in rootless mode that they have
to be first in the podman unshare state.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-07-27 16:53:02 -04:00
OpenShift Merge Robot 2b7bc9b101
Merge pull request #7094 from rhatdan/volume
When chowning we should not follow symbolic link
2020-07-27 21:42:38 +02:00
Melykuti 909f989c41 Corrects typo in the name of the Linux package shadow-utils.
Signed-off-by: Bence Mélykúti <bence.melykuti@gmail.com>
2020-07-27 21:17:30 +02:00
OpenShift Merge Robot 956caf303a
Merge pull request #7070 from edsantiago/ci_fixes
CI - various fixes
2020-07-27 20:56:17 +02:00
OpenShift Merge Robot bf92ec5234
Merge pull request #7092 from mheon/update_docs
[CI:DOCS] Update transfer doc
2020-07-27 20:00:20 +02:00
Daniel J Walsh e1ab449e21
When chowning we should not follow symbolic link
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-07-27 13:33:31 -04:00
Matthew Heon 23554d5300 Update transfer doc
We now support `podman network` and `podman volume` commands, so
we shouldn't include them in the `missing commands` section.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-07-27 13:17:56 -04:00
OpenShift Merge Robot 5e9b54f954
Merge pull request #7027 from ldelossa/louis/refactor-container-config
TODO: Refactor container config
2020-07-27 16:35:20 +02:00
OpenShift Merge Robot 55a7faf2b8
Merge pull request #7088 from vrothberg/fix-7078
API events: fix parsing error
2020-07-27 15:10:27 +02:00
OpenShift Merge Robot 71f7150490
Merge pull request #7083 from Luap99/fix-template-escaping
replace the html/template package with text/template
2020-07-27 12:52:51 +02:00
Valentin Rothberg 724a09e40e test/apiv2: add a simple events test
Add a simple test to exercise the events API without the "filters"
parameter.  Prevents regressing on #7078.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-07-27 11:51:48 +02:00
Valentin Rothberg 5ee35ca783 API events: fix parsing error
Fix an error where an absent "filters" parameter led to JSON parsing
errors.

Fixes: #7078
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-07-27 10:02:55 +02:00
OpenShift Merge Robot 11e8e65568
Merge pull request #7084 from TomSweeneyRedHat/dev/tsweeney/exp_api
Remove 'experimental' from API doc
2020-07-26 13:19:36 +02:00
Ed Santiago 9fad55c87f CI - various fixes
Primary purpose: upgrade crun to 0.14 on f31, in hopes of
eliminating the 'cgroups.freeze' flake that is plaguing CI.

While I'm at it:
- remove a no-longer-needed dnf upgrade that was running in CI
  itself (not image building, in each actual CI run). The purpose
  was to upgrade conmon, but that was added a long time ago and
  the required conmon is now in stable. The effect of this
  dnf upgrade today was simply to cause flakes when fedora
  repos were offline.

- remove a no-longer-needed check for varlink.

- networking.sh : add a timeout! 'openssl s_client' will happily
  hang forever if a host is unreachable, which means we waste
  two hours waiting for Cirrus to time out.

- timestamp.awk : include date (not just time) in START/END msgs.
  There are times when I'm looking at a CI log and it is ultra
  important to know if it is from yesterday or today.

- add progress messages in some places where I've previously
  struggled to understand context in logs; and improve some
  unlikely error messages to include script name.

...then, after all that, wrote a new README about how to to
all this. Hope it helps someone.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2020-07-25 12:32:53 -06:00
TomSweeneyRedHat ba6a182155 Remove 'experimental' from API doc
The v2.0 reference [page](http://docs.podman.io/en/latest/Reference.html)
lists the API as experimental.  Removed that word and reworked the first
paragraph a bit based on verbiage that @mheon put together for the
API intro blog.

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2020-07-25 13:57:40 -04:00
Paul Holzinger 8a45703f79 replace the html/template package with text/template
Currently some commands use the html/template package.
This can lead to invalid output.
e.g. `system df --verbose` will print `&lt;none&gt;`
instead of `<none>` with an untaged image.

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
2020-07-25 15:03:35 +02:00
Daniel J Walsh 7d0a5fc0da
update configuration for rootless podman
I updated the configuration part of the tutorial on rootless podman. I added the
 order in which configuration files are read in and a hint, how users can create
 default configuration in the home directories.

Closes #6777

Signed-off-by: Niklas Netter <niknett@gmail.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-07-25 05:41:31 -04:00
OpenShift Merge Robot c2deeff101
Merge pull request #7068 from mheon/start_attach_no_ctrid
The `podman start --attach` command should not print ID
2020-07-24 17:07:14 +02:00
OpenShift Merge Robot 417cc41398
Merge pull request #6742 from maybe-sybr/maybe/apiv2/fix-container-create-with-volumes
APIv2:fix: Get volumes from `Binds` when creating
2020-07-24 17:04:26 +02:00
OpenShift Merge Robot 22b1483902
Merge pull request #6938 from jwhonce/wip/n-connection
Refactor podman system connection
2020-07-24 17:01:40 +02:00
OpenShift Merge Robot d9244761e4
Merge pull request #7041 from jkonowitch/reset-docs
Improve Docs for `podman system reset`
2020-07-24 11:00:50 +02:00
OpenShift Merge Robot 197825d2ab
Merge pull request #7072 from eriksjolund/doc_fix_podman_run
[CI:DOCS] Fix exit code example in podman-run.1.md
2020-07-23 21:37:17 +02:00
OpenShift Merge Robot d4b5a18182
Merge pull request #7071 from mheon/bump_master_to_203
[CI:DOCS] Update release notes and README on master for v2.0.3
2020-07-23 21:34:26 +02:00
Erik Sjölund c10d5a5ebe
Fix exit code example in podman-run.1.md
Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2020-07-23 20:51:37 +02:00
Matthew Heon d46b7d7f1c Update release notes and README on master for v2.0.3
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-07-23 14:12:57 -04:00
OpenShift Merge Robot 961fa6a608
Merge pull request #7063 from containers/dependabot/go_modules/github.com/containers/common-0.17.1
Bump github.com/containers/common from 0.17.0 to 0.17.1
2020-07-23 19:42:54 +02:00
OpenShift Merge Robot 5b67f8108a
Merge pull request #7066 from lpmitchell/patch-1
Fix typos on documentation 'What is Podman' page
2020-07-23 19:33:05 +02:00
OpenShift Merge Robot 6ff1501287
Merge pull request #7064 from edsantiago/fix_rootless_perms
CI: fix rootless permission error
2020-07-23 19:30:07 +02:00
Jeffrey Konowitch 65bcc2ba5f Update system.rst
Signed-off-by: Jeffrey Konowitch <jeff.konowitch@onepeloton.com>

Update podman-system-reset.1.md

Signed-off-by: Jeffrey Konowitch <jeff.konowitch@onepeloton.com>

PR feedback

Signed-off-by: Jeffrey Konowitch <jeff.konowitch@onepeloton.com>

remove errant punctuation

Signed-off-by: Jeffrey Konowitch <jeff.konowitch@onepeloton.com>
2020-07-23 12:38:24 -04:00
Matthew Heon 099649ac1b The podman start --attach command should not print ID
Somewhere in the Podman v2 rewrite, we allowed
`podman start --attach` to print the container ID of the started
container after exiting from the attach session (via detach key
or the container exiting naturally). We should never print the ID
when `--attach` is given, which makes the fix simple - make the
print statement conditional on `--attach` not being present.

Wierdly, this only happened with `--interactive` was given to
`podman start`. I don't know why that is, but this resolves the
issue without having to dig any deeper, so I'm content.

Fixes #7055

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-07-23 12:02:28 -04:00
louis 10c4ab1149 Refactor container config
This commit handle the TODO task of breaking the Container
config into smaller sub-configs

Signed-off-by: ldelossa <ldelossa@redhat.com>
2020-07-23 10:18:14 -04:00
Luke Mitchell 9db4c031ef
Fix typos on documentation 'What is Podman' page
- Added a space between 'containers' and 'this' in the opening paragraph
- comming -> coming
- 'looking our' -> 'looking at our'

Signed-off-by: Luke Mitchell <luke@lpmitchell.com>
2020-07-23 15:13:05 +01:00
Ed Santiago 81115243ef CI: fix rootless permission error
CI runs are failing in special_testing_rootless:

    mkdir /var/tmp/go/pkg: permission denied

Probable cause: #6822, which universally set GOPATH.

Solution: in rootless setup, chown -R GOPATH as well
as GOSRC (the latter was already being chowned).

Signed-off-by: Ed Santiago <santiago@redhat.com>
2020-07-23 06:17:22 -06:00
dependabot-preview[bot] 87f60bbfaa
Bump github.com/containers/common from 0.17.0 to 0.18.0
Bumps [github.com/containers/common](https://github.com/containers/common) from 0.17.0 to 0.18.0.
- [Release notes](https://github.com/containers/common/releases)
- [Commits](https://github.com/containers/common/compare/v0.17.0...v0.18.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-07-23 05:05:26 -04:00
Jhon Honce 964d3300c6 [WIP] Refactor podman system connection
* Add support to manage multiple connections
  * Add connection
  * Remove connection
  * Rename connection
  * Set connection as default
  * Add markdown/man pages
* Fix recursion in hack/xref-helpmsgs-manpages

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-07-22 15:25:44 -07:00
OpenShift Merge Robot 1aac197f79
Merge pull request #7042 from rhatdan/remote
Enable --remote flag
2020-07-22 23:14:47 +02:00
OpenShift Merge Robot 9223b721b3
Merge pull request #7053 from ashley-cui/kubeip
Publish IP from YAML (podman play kube)
2020-07-22 22:45:05 +02:00
OpenShift Merge Robot d493374eb4
Merge pull request #7050 from edsantiago/logformat_trim_remote
logformatter: handle podman-remote
2020-07-22 20:53:51 +02:00