Commit graph

4764 commits

Author SHA1 Message Date
OpenShift Merge Robot 2ca7861b8e
Merge pull request #3650 from cevich/fix_clone_depth
Cirrus: Remove fixed clone depth
2019-07-29 16:24:58 +02:00
OpenShift Merge Robot 2c98bd5398
Merge pull request #3654 from TomSweeneyRedHat/dev/tsweeney/commandpause
Update pause/unpause video links and demo
2019-07-28 17:06:17 +02:00
TomSweeneyRedHat 1bedf04416 Update pause/unpause video links and demo
Update the links for the asciinema casts and the demo for the
`podman pause` and `podman unpause` commands on the commands.md
page.

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
2019-07-26 17:04:23 -04:00
Chris Evich 6146a3ad0f
Cirrus: Remove fixed clone depth
It's been observed on several occasions, some tests fail in git clones
with a "cannot find ref" type error.  Especially in the depth=1 cases.
Since there's really only one place where limiting the depth makes sense
(build-each-commit), simply remove all the other limits.

Signed-off-by: Chris Evich <cevich@redhat.com>
2019-07-26 11:50:44 -04:00
OpenShift Merge Robot 0c4dfcfe57
Merge pull request #3639 from giuseppe/user-ns-container
podman: support --userns=ns|container
2019-07-26 15:06:06 +02:00
OpenShift Merge Robot b212daa92f
Merge pull request #3632 from cevich/small_cirrus_fixes
Small cirrus and image-build fixes
2019-07-26 14:55:12 +02:00
OpenShift Merge Robot eca157fb54
Merge pull request #3627 from ashley-cui/rmdocs
Documenation & make tar.gz for remote
2019-07-26 11:37:10 +02:00
OpenShift Merge Robot 1910d68e4d
Merge pull request #3645 from mheon/systemd_ubuntu
Use systemd cgroups for Ubuntu
2019-07-26 10:41:04 +02:00
OpenShift Merge Robot 4674d00f46
Merge pull request #3580 from samc24/hook
Improved hooks monitoring
2019-07-26 10:25:05 +02:00
Giuseppe Scrivano 1d72f651e4
podman: support --userns=ns|container
allow to join the user namespace of another container.

Closes: https://github.com/containers/libpod/issues/3629

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-07-25 23:04:55 +02:00
Giuseppe Scrivano ba5741e398
pods: do not to join a userns if there is not any
do not attempt to join the user namespace if the pod is running in the
host user namespace.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2019-07-25 23:04:54 +02:00
Ashley Cui ce0132a45e Documenation & build automation for remote darwin
Created shell script to automatically compile remote-only docs & rename
Added make brew-pkg to automatically package files needed for homebrew
Add missing docs

Signed-off-by: Ashley Cui <ashleycui16@gmail.com>
2019-07-25 15:36:39 -04:00
Chris Evich ac5ad9acbf
Cirrus: Bypass release during image-building
Signed-off-by: Chris Evich <cevich@redhat.com>
2019-07-25 15:20:57 -04:00
Matthew Heon 0934949220 Use systemd cgroups for Ubuntu
It seems like our VM images now support systemd CGroups with the
Ubuntu LTS images. No reason to keep testing CGroupfs as such,
systemd is much less racy (and CGroupfs on systemd-enabled
systems can be iffy).

Signed-off-by: Matthew Heon <mheon@redhat.com>
2019-07-25 14:57:58 -04:00
Chris Evich 07b1e331c2
Cirrus: Ubuntu: Set + Test for $RUNC_BINARY
Signed-off-by: Chris Evich <cevich@redhat.com>
2019-07-25 14:02:12 -04:00
Chris Evich f55288c96f
Cirrus: Simplify evil-unit check in image
Signed-off-by: Chris Evich <cevich@redhat.com>
2019-07-25 13:51:33 -04:00
Chris Evich ceb3d76298
Cirrus: Silence systemd-banish noise
It's somewhat hard to predict which units are certinly present
for any given base-image.  Therefore, at image-build time, it's
distracting and unhelpful to see all the errors about units that
don't exist, on every platform.  Simply ignore them and rely on
the `check_image.sh` test to confirm none are enabled.

Signed-off-by: Chris Evich <cevich@redhat.com>
2019-07-25 13:51:33 -04:00
Chris Evich e3082762fe
Cirrus: Fix image build metadata update
Signed-off-by: Chris Evich <cevich@redhat.com>
2019-07-25 13:51:33 -04:00
Chris Evich 6942d3275d
Cirrus: Fix missing -n on CentOS
Signed-off-by: Chris Evich <cevich@redhat.com>
2019-07-25 13:51:33 -04:00
Chris Evich 23722e644e
Cirrus: Remove disused COMMIT variables
Signed-off-by: Chris Evich <cevich@redhat.com>
2019-07-25 13:51:33 -04:00
OpenShift Merge Robot dff82d940e
Merge pull request #3643 from openSUSE/history-panic
Fix possible runtime panic if image history len is zero
2019-07-25 19:26:47 +02:00
OpenShift Merge Robot 5763618ce5
Merge pull request #3631 from TristanCacqueray/master
Document SELinux label requirements for the rootfs argument
2019-07-25 18:03:35 +02:00
OpenShift Merge Robot 1b95ed9a71
Merge pull request #3622 from QiWang19/checkurl
fix import not ignoring url path
2019-07-25 17:49:08 +02:00
samc24 d6ea4b4139 Improved hooks monitoring
...to work for specific edge cases with a simpler solution.
Re-reads hooks directories after any changes are detected by the watchers.
Added monitoring test for adding a different invalid hook to primary directory.
Some issues with prior code:
- ReadDir would stop when it encounters an invalid hook, rather than registering an error but continuing to read the valid hook.
- Wouldn’t account for Rename and Chmod events.
- After doing a mv of the hooks file instead of rm, it would still think the hooks file is in the directory, but it has been moved to another location.
- If a hook file was renamed, it would register the renamed file as a separate hook and not delete the original, so it would then execute the hook twice - once for the renamed file, and once for the original name which it did not delete.

Signed-off-by: samc24 <sam.chaturvedi24@gmail.com>
2019-07-25 09:52:45 -04:00
Sascha Grunert 7630f1b52e
Fix possible runtime panic if image history len is zero
We now return an empty string for the `Comment` field if an OCI v1 image
contains no history.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
2019-07-25 12:45:08 +02:00
OpenShift Merge Robot 7c9095ea1d
Merge pull request #3641 from mheon/no_fuzzy_volume_lookup
When retrieving volumes, only use exact names
2019-07-25 11:24:29 +02:00
Matthew Heon f747a06d53 When retrieving volumes, only use exact names
We should not be fuzzy matching on volume names. Docker doesn't
do  it, and it doesn't make much sense. Everything requires exact
matches for names - only IDs allow partial matches.

Fixes #3635

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-07-24 22:30:16 -04:00
Qi Wang a328e873c6 fix import not ignoring url path
fix #3609
Podman import used to check filename to only allow tarball path as a file. It should also allow an url as the doc mentioned. This PR allows the program to continue if the input is a valid URL

Signed-off-by: Qi Wang <qiwan@redhat.com>
2019-07-24 11:41:48 -04:00
OpenShift Merge Robot 2283471f8d
Merge pull request #3626 from mheon/fix_ps_segfault
Fix a segfault on Podman no-store commands with refresh
2019-07-24 14:45:01 +02:00
Tristan Cacqueray e2067836a4 Document SELinux label requirements for the rootfs argument
When using the rootfs argument, SELinux systems fails silently
when the files are not properly labeled.

Related #3628

Signed-off-by: Tristan Cacqueray <tdecacqu@redhat.com>
2019-07-24 08:25:36 -04:00
OpenShift Merge Robot 091778354e
Merge pull request #3615 from vrothberg/build-tags
install.md: mention all build tags
2019-07-24 13:47:41 +02:00
OpenShift Merge Robot eae9a009b2
Merge pull request #3624 from haircommander/conmon-exec-with-remote-exec
Add remote exec
2019-07-24 13:16:21 +02:00
OpenShift Merge Robot 0d441f57d6
Merge pull request #3633 from QiWang19/network
fix build --network=container
2019-07-24 12:47:29 +02:00
OpenShift Merge Robot 0e85b82741
Merge pull request #3638 from hooksie1/issue-#3577
Fixes issue #3577.
2019-07-24 12:36:26 +02:00
John Hooks 777cce20ca Fixes issue #3577.
Fix punctuation and wording in some places.

Signed-off-by: John Hooks <hooksie11@gmail.com>
2019-07-23 22:52:24 -04:00
OpenShift Merge Robot 3c6b111789
Merge pull request #3634 from mheon/fix_32bit
Re-add int64 casts for ctime to fix 32-bit build
2019-07-24 03:59:23 +02:00
Peter Hunt 01a8483a59 refactor to reduce duplicated error parsing
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-07-23 16:49:04 -04:00
Peter Hunt 82dce36fb6 remove debug prints
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-07-23 16:49:04 -04:00
Matthew Heon 7a85317ccb Re-add int64 casts for ctime
The variables here are 64-bit on 64-bit builds, so the linter
recommends stripping them. Unfortunately, they're 32-bit on
32-bit builds, so stripping them breaks that. Readd with a nolint
to convince it to not break.

Signed-off-by: Matthew Heon <mheon@redhat.com>
2019-07-23 15:43:40 -04:00
Qi Wang 8c9b78e8bc fix build --network=container
Signed-off-by: Qi Wang <qiwan@redhat.com>
2019-07-23 15:11:42 -04:00
OpenShift Merge Robot 7dbc6d8f36
Merge pull request #3619 from cevich/workaround_missing_iamge
Cirrus: Temp. workaround missing imgprune image
2019-07-23 19:40:52 +02:00
Matthew Heon 5fb4feb36a Fix a segfault on Podman no-store commands with refresh
When a command (like `ps`) requests no store be created, but also
requires a refresh be performed, we have to ignore its request
and initialize the store anyways to prevent segfaults. This work
was done in #3532, but that missed one thing - initializing a
storage service. Without the storage service, Podman will still
segfault. Fix that oversight here.

Fixes #3625

Signed-off-by: Matthew Heon <mheon@redhat.com>
2019-07-23 13:30:30 -04:00
Peter Hunt d59f083637 always send generic error in case io fails
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-07-23 13:30:15 -04:00
Peter Hunt 9e69285704 only use stdin if specified
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-07-23 13:30:15 -04:00
Peter Hunt 74ab273e91 buffer errChan
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-07-23 13:30:15 -04:00
Peter Hunt a4041dafae move handleTerminalAttach to generic build
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-07-23 13:30:14 -04:00
Peter Hunt 638b73a046 remove unnecessary conversions
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-07-23 13:29:33 -04:00
Peter Hunt 5bf99a82ff add detach keys support for remote
Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-07-23 13:29:33 -04:00
Peter Hunt 479eeac62c move editing of exitCode to runtime
There's no way to get the error if we successfully get an exit code (as it's just printed to stderr instead).
instead of relying on the error to be passed to podman, and edit based on the error code, process it on the varlink side instead

Also move error codes to define package

Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-07-23 13:29:33 -04:00
Peter Hunt 35ba77e040 Update e2e tests for remote exec
including changing -l to the container id
and separating a case of setting the env that remote can't handle

Signed-off-by: Peter Hunt <pehunt@redhat.com>
2019-07-23 13:29:33 -04:00