From 7c1878f0e4486365fba4c5bfe11fb55f23c51360 Mon Sep 17 00:00:00 2001 From: Victor Song Date: Fri, 30 Sep 2022 23:20:01 -0400 Subject: [PATCH] Fix borrowing code smells --- src/fs/file.rs | 6 +++--- src/output/details.rs | 2 +- src/output/grid_details.rs | 2 +- src/output/time.rs | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/fs/file.rs b/src/fs/file.rs index 81eee3d6..bccc6550 100644 --- a/src/fs/file.rs +++ b/src/fs/file.rs @@ -221,13 +221,13 @@ impl<'dir> File<'dir> { path.to_path_buf() } else if let Some(dir) = self.parent_dir { - dir.join(&*path) + dir.join(path) } else if let Some(parent) = self.path.parent() { - parent.join(&*path) + parent.join(path) } else { - self.path.join(&*path) + self.path.join(path) } } diff --git a/src/output/details.rs b/src/output/details.rs index f86a202a..b729ceb4 100644 --- a/src/output/details.rs +++ b/src/output/details.rs @@ -161,7 +161,7 @@ impl<'a> Render<'a> { (None, _) => {/* Keep Git how it is */}, } - let mut table = Table::new(table, self.git, &self.theme); + let mut table = Table::new(table, self.git, self.theme); if self.opts.header { let header = table.header_row(); diff --git a/src/output/grid_details.rs b/src/output/grid_details.rs index 94c1b79d..f277f3e4 100644 --- a/src/output/grid_details.rs +++ b/src/output/grid_details.rs @@ -202,7 +202,7 @@ impl<'a> Render<'a> { (None, _) => {/* Keep Git how it is */}, } - let mut table = Table::new(options, self.git, &self.theme); + let mut table = Table::new(options, self.git, self.theme); let mut rows = Vec::new(); if self.details.header { diff --git a/src/output/time.rs b/src/output/time.rs index bb3ee612..081333f1 100644 --- a/src/output/time.rs +++ b/src/output/time.rs @@ -87,7 +87,7 @@ fn default_zoned(time: SystemTime, zone: &TimeZone) -> String { } fn get_dateformat(date: &LocalDateTime) -> &'static DateFormat<'static> { - match (is_recent(&date), *MAXIMUM_MONTH_WIDTH) { + match (is_recent(date), *MAXIMUM_MONTH_WIDTH) { (true, 4) => &FOUR_WIDE_DATE_TIME, (true, 5) => &FIVE_WIDE_DATE_TIME, (true, _) => &OTHER_WIDE_DATE_TIME,