Commit graph

2064 commits

Author SHA1 Message Date
Kirill Chibisov 7312f33f67
Fix font.glyph_offset not live reloading
Fixes #5944.
2022-03-11 12:34:15 +03:00
Christian Duerr 0965773657
Fix crash when searching during reset
This fixes a crash which occurs when the terminal is reset while
searching, due to the vi mode cursor being outside of the visible area.

This also fixes an issue where the search state reset would incorrectly
clamp the vi mode cursor to the grid, rather than the absolute viewport
position.

While this fix does resolve all crashes when searching while running
`cat /dev/urandom`, it does raise the question if manually clamping the
vi mode cursor in every location where it is modified is the right
choice.

A follow-up to provide a safer API which guarantees correct modification
of the vi mode cursor location is probably a good idea.

Fixes #5942.
2022-03-10 22:45:20 +03:00
Kirill Chibisov a69c3c408f
Fix line indicator damage computation
The starting point of damage should be computed from the right side
of the terminal, not from the starting point of line indicator.
2022-03-10 15:25:01 +03:00
Kirill Chibisov dbccd7e30f
Use round instead of ceil for line position
Ceiling line position results in strikeout line being lower than
it should.
2022-03-06 19:34:12 +03:00
Kirill Chibisov d8113dc2b6
Fix gap calculation for dashed underline 2022-03-02 22:35:19 +03:00
Kirill Chibisov 1880522b64
Add fallback GLES2 renderer
Currently Alacritty only works on hardware which supports OpenGL 3.3 or
more, which can become problematic with older devices. This patch adds a
new GLES2 renderer, since it is much more widely supported, especially
on weaker hardware like phones or a Raspberry Pi.

While the GLES2 renderer is slower than the OpenGL 3.3+ version, it is
still significantly faster than software rendering. However because of
this performance difference it is only used when necessary and there
should be no difference for machines supporting OpenGL 3.3+.

The two renderers are largely independent and separated in the
`renderer/text/glsl3` and `renderer/text/gles2` modules. Separate
shaders are also required for text rendering. The rectangle rendering
for underlines and the visual bell works identically for both versions,
but does have some version-specific shader code.

Fixes #128.

Co-authored-by: Christian Duerr <contact@christianduerr.com>
2022-03-02 10:05:12 +00:00
Chris Copeland 00383ae967
Add ToggleMaximized key binding action 2022-02-27 18:35:23 +00:00
Christian Duerr 13b6248dd9
Add version 0.10.1 to changelog 2022-02-24 07:17:25 +03:00
nibon7 8ea6c3bc52
Omit git version hash when git command fails 2022-02-22 13:08:49 +00:00
Kirill Chibisov 36e981ad4b
Don't use 'origin_upper_left' in rect shaders 2022-02-22 13:57:04 +03:00
Kirill Chibisov 4734b2b850
Don't load font twice during display creation
This commit finishes the effort from a64553b to avoid reloading font
twice during startup, since the original issue is with getting font
metrics without building the glyph cache.
2022-02-18 01:27:10 +03:00
mahkoh aaab88c5c5
Account for absolute WAYLAND_DISPLAY paths
If WAYLAND_DISPLAY contains a '/', we have to replace with with another
character before using WAYLAND_DISPLAY as a path component.
2022-02-16 21:15:50 +00:00
Greg Depoire--Ferrer a64553bbaf
Reuse Rasterizer in Display::new
Instead of creating a `Rasterizer` to guess the window dimensions,
dropping it and then creating a new one for the glyph cache, reuse the
same `Rasterizer`.

This prevents the font from being loaded twice during startup.
2022-02-16 20:57:46 +00:00
Kirill Chibisov ed5dbc1118
Add support for dashed and dotted underlines
This finishes implementation of underline styles provided by
`CSI 4 : [1-5] m` escape sequence.
2022-02-14 19:10:13 +03:00
Kirill Chibisov 774eb03f4f
Clear damage rects right after drawing
Since we could queue damage before we get into the actual rendering
we should clear it after drawing not before.
2022-02-11 02:04:50 +03:00
Kirill Chibisov 933030efd4
Fix terminal not being damage when only font size changed
If font size changes however the cells stay the same the terminal won't
be damaged, since it wasn't resized, however the visual change happened,
thus the entire screen should be damaged.
2022-02-10 23:42:33 +03:00
Kirill Chibisov c35ccaf9b5
Make undercurls thickness close to underlines
Fixes #5873.
2022-02-10 15:29:03 +03:00
Christian Duerr eefce4e9af
Add note about publishing RCs to crates.io
We've been testing out the pre-release feature of crates.io and there
haven't been any major issues. So this updates the documentation to
recommend publishing to crates.io even before the official release.
2022-02-10 11:09:23 +00:00
Christian Duerr d1608dd03e
Add version to info log 2022-02-09 23:41:54 +03:00
Kirill Chibisov 8afeb2c602
Fix warnings when building only with Wayland feature
This commit also makes our CI fail hard when warning encountered when
building only for either Wayland or X11.
2022-02-09 19:25:36 +03:00
Kirill Chibisov 59f16f6b15
Fix alpha when using colors.transparent_background_colors
The alpha is expected to be premultiplied from the text shader, so
we should apply it to the background color.
2022-02-09 17:41:57 +03:00
Kirill Chibisov 73c3dd8628
Add support for drawing undercurls
Fixes #1628.
2022-02-08 20:47:31 +03:00
sckzor 7263d223bf
Add instructions for building without X11/Wayland 2022-02-08 11:43:27 +00:00
Kirill Chibisov c2959f45ec
Fix alacritty_terminal not emitting damage on color change 2022-02-07 22:18:51 +03:00
Thomas Churchman 998250f3c3
Fix renderable_cursor method documentation
This method no longer returns an `Option` since #5773.

Co-authored-by: Kirill Chibisov <contact@kchibisov.com>
2022-02-03 12:04:46 +00:00
Kirill Chibisov d22cd7409c
Fix builtin font block elements going invisible 2022-02-03 03:22:28 +03:00
Christian Duerr 4bf8f375ef
Fix repeated permission requests on M1 macs
This adds a codesign step to our makefile build which should
automatically sign the application and resolve the issues on M1 macs
where Alacritty constantly requests permissions.

Since self-signing does still seem to fix this issue after sharing the
resulting `Alacritty.app` with other M1 macs, the binary produced by our
release build should also be fixed automatically.

Fixes #5840.
2022-02-02 19:23:29 +00:00
Kirill Chibisov 40b5e179a3
Fix terminal damage after leaving Vi mode
This fixes an issue when search results were not damaged when leaving Vi
mode.
2022-02-02 20:20:14 +03:00
Kirill Chibisov 8f1abe13e6
Add damage tracking and reporting to compatible compositors
This allows compositors to only process damaged (that is, updated)
regions of our window buffer, which for larger window sizes (think 4k)
should significantly reduce compositing workload under compositors that
support/honor it, which is good for performance, battery life and lower
latency over remote connections like VNC.

On Wayland, clients are expected to always report correct damage, so
this makes us a good citizen there. It can also aid remote desktop
(waypipe, rdp, vnc, ...) and other types of screencopy by having damage
bubble up correctly.

Fixes #3186.
2022-02-02 00:12:58 +03:00
oxalica d58dff18ef
Clean up and abstract shader creation code
Co-authored-by: Christian Duerr <contact@christianduerr.com>
2022-01-30 23:57:25 +03:00
Kirill Chibisov 5459492eae
Use cell width to compute builtin font thickness
While using underline thickness could sound logical to draw other
lines most fonts don't make underlines thick compared to cell bounding
box if you increase font size. So instead we're using cell width to
scale builtin font nicely.

This commit also adjusts arcs drawing and alignment.

Fixes #5826.
Fixes #5821.
2022-01-30 15:46:02 +03:00
Kirill Chibisov efae2cc80c
Log used display server on Linux/BSD
This also fixes a bug where the welcome log message wasn't logged.
2022-01-30 06:36:35 +00:00
Kirill Chibisov f6651a997b
Account for font.offset and glyph.offset in built-in font
This commit takes into account `font.offset` and `font.glyph_offset`
when generating built-in font.
2022-01-29 23:06:44 +03:00
zandr 094c2c9269
Add option to control built-in box drawing chars
This commit adds the config `font.builtin_box_drawing` option to
control built-in font, which is enabled by default.
2022-01-29 22:50:44 +03:00
Christian Duerr d1deff9fae
Remove outdated changelog URLs
Alacritty's website (https://alacritty.org) is now advertised publicly
on the GitHub page. Since that includes the old 0.3.0 and 0.5.0
changelogs, it's not necessary to point them out separately anymore.
2022-01-23 14:22:23 +00:00
Christian Duerr 9f6b49ca8f
Fix logfile overwriting existing files 2022-01-22 22:48:44 +00:00
Ömer Sinan Ağacan 4e91e99de3
Fix typo in SizeInfo padding_y rustdoc 2022-01-21 13:45:37 +00:00
Kirill Chibisov 14c22b172f
Reset cursor blinking on ToggleViMode
Fixes #4468.
2022-01-21 12:48:15 +03:00
DaftMouse c4d610d5bf
Fix OSC 104 with empty second parameter
This fixes a bug where using OSC 104 without parameters but
with a trailling semicolon (e.g. '\e]104;\e\\') would not be handled.

Fixes #5542.
2022-01-20 23:57:58 +00:00
DaftMouse 60ef17e8e9
Add ´?´ support to OSC 4 2022-01-15 03:35:05 +00:00
Christian Duerr e38f51c6bd
Remove time dependency
In 7398e9f a regression was introduced which causes Alacritty to crash
on startup since wayland has a keyboard repeat rate thread started
before our logger is initialized.

Since the latest version of time was rather inconvenient to use anyway
and there is no nice solution for this issue other than downgrading the
`time` version again, the time since startup is now logged instead of
the local time.

This should still provide all the relevant information, while getting
rid of an unnecessary dependency. While it would be possible to also
print the delta between log messages, this can be trivially computed so
it has been omitted to skip adding another `Mutex` to the `Logger`
struct.
2022-01-13 08:36:22 +03:00
Christian Duerr 7398e9f8d1
Fix macOS release CI
Since the CI machine is amd64, it is not possible to just execute the
aarch64 binary to test the application. So instead of running `cargo
test`, we just use `cargo build` instead.

Building on the non-release CI instead of just checking also allows us
to make sure linking works properly before a release fails due to it.
2022-01-13 02:23:37 +00:00
James McCoy 1c9fa73165
Update time crate to 0.3.5
Due to unsoundness issues (c.f., time-rs/time#380 and time-rs/time#293),
determining the local timezone can only happen while single-threaded.

Determine the timezone early in startup and apply the offset to the UTC
timestamp before formatting.
2022-01-13 01:53:03 +00:00
Kirill Chibisov fd7573d5d1
Don't blink when cursor is hidden
This prevents unnecessary redraws when the terminal is idle, cursor is
hidden and blinking is enabled.
2022-01-11 23:58:50 +03:00
Kirill Chibisov 01c1cc1278
Use with_position instead of set_outer_position
This uses `with_position` method on a `WindowBuilder` instead of setting
window position on the created window later on.
2022-01-11 20:41:57 +00:00
Kirill Chibisov a8c8c57907
Fix use-after-free when formatting Wayland protocol error 2022-01-11 16:22:30 +03:00
Kirill Chibisov 5e39ea9f9f
Fix block selection expansion with Ctrl + RMB
When 'ExpandSelection' binding was added only default binding for
RightClick was added, however to expand block selection holding control
when doing a click is required, so this commit adds a binding for
'RMB + Control'.
2022-01-11 00:56:49 +03:00
Christian Duerr ed35d033ae
Fix fullwidth char regex search infinite loop
This resolves an issue where the regex search could loop indefinitely
when the end point was defined in a location containing a fullwidth
character, thus skipping over the end before termination.

Fixes #5753.
2022-01-08 20:24:42 +00:00
a5ob7r 5aa8046c7f
Fix last column block selection
This fixes a regression introduced in 8e584099, where block selections
containing the last cell would have the trailing newline stripped and be
joined into one long line on copy.
2022-01-07 09:03:15 +00:00
David 50c7c2b469
Fix macOS IME regression
Fixes 5669.
2022-01-06 03:31:45 +00:00