mirror of
https://github.com/alacritty/alacritty
synced 2024-10-02 22:14:28 +00:00
Fix crash when writing wide char in last column
This resolves an issue where trying to write a fullwidth character in the last column would crash Alacritty, if linewrapping was disabled. Instead of assuming that the linewrap put after the linewrapping spacer was successful, the character writing is now skipped completely when trying to put a wide character in the last column.
This commit is contained in:
parent
922f48e52c
commit
395fee2b01
|
@ -43,6 +43,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
|
|||
- Fix escapes prematurely terminated by terminators in unicode glyphs
|
||||
- Incorrect location when clicking inside an unfocused window on macOS
|
||||
- Startup mode `Maximized` on Windows
|
||||
- Crash when writing a fullwidth character in the last column with auto-wrap mode disabled
|
||||
|
||||
## 0.4.2
|
||||
|
||||
|
|
|
@ -1462,10 +1462,16 @@ impl<T: EventListener> Handler for Term<T> {
|
|||
if width == 1 {
|
||||
self.write_at_cursor(c);
|
||||
} else {
|
||||
// Insert extra placeholder before wide char if glyph doesn't fit in this row anymore.
|
||||
if self.cursor.point.col + 1 >= num_cols {
|
||||
if self.mode.contains(TermMode::LINE_WRAP) {
|
||||
// Insert placeholder before wide char if glyph does not fit in this row.
|
||||
self.write_at_cursor(' ').flags.insert(Flags::WIDE_CHAR_SPACER);
|
||||
self.wrapline();
|
||||
} else {
|
||||
// Prevent out of bounds crash when linewrapping is disabled.
|
||||
self.input_needs_wrap = true;
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
||||
// Write full width glyph to current cursor cell.
|
||||
|
|
Loading…
Reference in a new issue