From 8427dc3804126fdd26eb375642187996d601e692 Mon Sep 17 00:00:00 2001 From: morganamilo Date: Thu, 19 Jul 2018 18:48:46 +0100 Subject: [PATCH] Move passToFoo() functions to their own file --- cmd.go | 70 -------------------------------------------------- exec.go | 75 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ install.go | 1 - 3 files changed, 75 insertions(+), 71 deletions(-) create mode 100644 exec.go diff --git a/cmd.go b/cmd.go index 6300fd51..63614c64 100644 --- a/cmd.go +++ b/cmd.go @@ -2,12 +2,10 @@ package main import ( "bufio" - "bytes" "fmt" "os" "os/exec" "strconv" - "strings" "time" ) @@ -578,71 +576,3 @@ func numberMenu(pkgS []string, flags []string) (err error) { return err } - -func show(cmd *exec.Cmd) error { - cmd.Stdin, cmd.Stdout, cmd.Stderr = os.Stdin, os.Stdout, os.Stderr - err := cmd.Run() - if err != nil { - return fmt.Errorf("") - } - return nil -} - -func capture(cmd *exec.Cmd) (string, string, error) { - var outbuf, errbuf bytes.Buffer - - cmd.Stdout = &outbuf - cmd.Stderr = &errbuf - err := cmd.Run() - stdout := outbuf.String() - stderr := errbuf.String() - - return stdout, stderr, err -} - -// passToPacman outsources execution to pacman binary without modifications. -func passToPacman(args *arguments) *exec.Cmd { - argArr := make([]string, 0) - - if args.needRoot() { - argArr = append(argArr, "sudo") - } - - argArr = append(argArr, config.PacmanBin) - argArr = append(argArr, cmdArgs.formatGlobals()...) - argArr = append(argArr, args.formatArgs()...) - if config.NoConfirm { - argArr = append(argArr, "--noconfirm") - } - - argArr = append(argArr, "--") - - argArr = append(argArr, args.targets...) - - return exec.Command(argArr[0], argArr[1:]...) -} - -// passToMakepkg outsources execution to makepkg binary without modifications. -func passToMakepkg(dir string, args ...string) *exec.Cmd { - if config.NoConfirm { - args = append(args) - } - - mflags := strings.Fields(config.MFlags) - args = append(args, mflags...) - - cmd := exec.Command(config.MakepkgBin, args...) - cmd.Dir = dir - return cmd -} - -func passToGit(dir string, _args ...string) *exec.Cmd { - gitflags := strings.Fields(config.GitFlags) - args := []string{"-C", dir} - args = append(args, gitflags...) - args = append(args, _args...) - - cmd := exec.Command(config.GitBin, args...) - cmd.Stdin, cmd.Stdout, cmd.Stderr = os.Stdin, os.Stdout, os.Stderr - return cmd -} diff --git a/exec.go b/exec.go new file mode 100644 index 00000000..f97cbab9 --- /dev/null +++ b/exec.go @@ -0,0 +1,75 @@ +package main + +import ( + "bytes" + "fmt" + "os" + "os/exec" + "strings" +) + +func show(cmd *exec.Cmd) error { + cmd.Stdin, cmd.Stdout, cmd.Stderr = os.Stdin, os.Stdout, os.Stderr + err := cmd.Run() + if err != nil { + return fmt.Errorf("") + } + return nil +} + +func capture(cmd *exec.Cmd) (string, string, error) { + var outbuf, errbuf bytes.Buffer + + cmd.Stdout = &outbuf + cmd.Stderr = &errbuf + err := cmd.Run() + stdout := outbuf.String() + stderr := errbuf.String() + + return stdout, stderr, err +} + +func passToPacman(args *arguments) *exec.Cmd { + argArr := make([]string, 0) + + if args.needRoot() { + argArr = append(argArr, "sudo") + } + + argArr = append(argArr, config.PacmanBin) + argArr = append(argArr, cmdArgs.formatGlobals()...) + argArr = append(argArr, args.formatArgs()...) + if config.NoConfirm { + argArr = append(argArr, "--noconfirm") + } + + argArr = append(argArr, "--") + + argArr = append(argArr, args.targets...) + + return exec.Command(argArr[0], argArr[1:]...) +} + +func passToMakepkg(dir string, args ...string) *exec.Cmd { + if config.NoConfirm { + args = append(args) + } + + mflags := strings.Fields(config.MFlags) + args = append(args, mflags...) + + cmd := exec.Command(config.MakepkgBin, args...) + cmd.Dir = dir + return cmd +} + +func passToGit(dir string, _args ...string) *exec.Cmd { + gitflags := strings.Fields(config.GitFlags) + args := []string{"-C", dir} + args = append(args, gitflags...) + args = append(args, _args...) + + cmd := exec.Command(config.GitBin, args...) + cmd.Stdin, cmd.Stdout, cmd.Stderr = os.Stdin, os.Stdout, os.Stderr + return cmd +} diff --git a/install.go b/install.go index c7a3842d..62ab6338 100644 --- a/install.go +++ b/install.go @@ -978,7 +978,6 @@ func buildInstallPkgBuilds(dp *depPool, do *depOrder, srcinfos map[string]*gosrc return err } - for _, pkg := range do.Bases[pkg.PackageBase] { updateVCSData(pkg.Name, srcinfo.Source) }