From 4a515c44623e15719f794bca01b5bc797d894120 Mon Sep 17 00:00:00 2001 From: jguer Date: Tue, 3 Aug 2021 18:54:25 +0200 Subject: [PATCH] test(downloads): remove non reproducible tests --- pkg/download/abs_test.go | 23 ----------------------- pkg/download/aur_test.go | 23 ----------------------- 2 files changed, 46 deletions(-) diff --git a/pkg/download/abs_test.go b/pkg/download/abs_test.go index a7a36dac..388773ca 100644 --- a/pkg/download/abs_test.go +++ b/pkg/download/abs_test.go @@ -205,29 +205,6 @@ func TestABSPKGBUILDRepo(t *testing.T) { assert.NoError(t, err) } -// GIVEN a previous existing folder without permissions -// WHEN ABSPKGBUILDRepo is called -// THEN a clone command should be formed -func TestABSPKGBUILDRepoExistsNoPerms(t *testing.T) { - dir, _ := ioutil.TempDir("/tmp/", "yay-test") - defer os.RemoveAll(dir) - - os.MkdirAll(filepath.Join(dir, "linux", ".git"), 0o600) - - cmdRunner := &testRunner{} - cmdBuilder := &testGitBuilder{ - index: 0, - test: t, - parentBuilder: &exe.CmdBuilder{ - GitBin: "/usr/local/bin/git", - GitFlags: []string{"--no-replace-objects"}, - }, - } - err := ABSPKGBUILDRepo(cmdRunner, cmdBuilder, "core", "linux", dir, false) - assert.Error(t, err) - assert.Contains(t, err.Error(), "error fetching linux: error reading") -} - // GIVEN a previous existing folder with permissions // WHEN ABSPKGBUILDRepo is called // THEN a pull command should be formed diff --git a/pkg/download/aur_test.go b/pkg/download/aur_test.go index baba488a..c13ed876 100644 --- a/pkg/download/aur_test.go +++ b/pkg/download/aur_test.go @@ -88,29 +88,6 @@ func TestAURPKGBUILDRepo(t *testing.T) { assert.NoError(t, err) } -// GIVEN a previous existing folder without permissions -// WHEN AURPKGBUILDRepo is called -// THEN a clone command should be formed -func TestAURPKGBUILDRepoExistsNoPerms(t *testing.T) { - dir, _ := ioutil.TempDir("/tmp/", "yay-test") - defer os.RemoveAll(dir) - - os.MkdirAll(filepath.Join(dir, "yay-bin", ".git"), 0o600) - - cmdRunner := &testRunner{} - cmdBuilder := &testGitBuilder{ - index: 0, - test: t, - parentBuilder: &exe.CmdBuilder{ - GitBin: "/usr/local/bin/git", - GitFlags: []string{"--no-replace-objects"}, - }, - } - err := AURPKGBUILDRepo(cmdRunner, cmdBuilder, "https://aur.archlinux.org", "yay-bin", dir, false) - assert.Error(t, err) - assert.Contains(t, err.Error(), "error fetching yay-bin: error reading") -} - // GIVEN a previous existing folder with permissions // WHEN AURPKGBUILDRepo is called // THEN a pull command should be formed