mirror of
git://source.winehq.org/git/wine.git
synced 2024-11-05 18:01:34 +00:00
52a83ffe4e
Since struct _IAVIStreamImpl has a pointer to a WAVEFORMATEX,
GCC 12.2 emits warning when dereferencing that pointer when
the block has been allocated with sizeof(PCMWAVEFORMAT).
The warning is fixed by always allocating with sizeof(WAVEFORMATEX).
This will overallocate in case of a PCM stream.
The alternative would have been to store in struct _IAVIStreamImpl
a pointer to PCMWAVEFORMAT instead, and add the casting to a
WAVEFORMATEX when needed. That would clutter the code IMO since most
of the ACM APIs expect a LPWAVEFORMATEX.
/home/eric/work/wine/dlls/avifil32/acmstream.c: In function 'AVIFILE_OpenCompressor':
/home/eric/work/wine/dlls/avifil32/acmstream.c:105:24: warning: array subscript 'struct tWAVEFORMATEX[0]' is partly outside array bounds of 'unsigned char[16]' [-Warray-bounds]
105 | This->lpOutFormat->wFormatTag = WAVE_FORMAT_PCM;
| ^~
/home/eric/work/wine/dlls/avifil32/acmstream.c:101:27: note: object of size 16 allocated by 'HeapAlloc'
101 | This->lpOutFormat = HeapAlloc(GetProcessHeap(), 0, This->cbOutFormat);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
|
||
|---|---|---|
| .. | ||
| tests | ||
| acmstream.c | ||
| api.c | ||
| avifil32.idl | ||
| avifil32.rc | ||
| avifil32.spec | ||
| avifile.c | ||
| avifile.rgs | ||
| avifile_private.h | ||
| editstream.c | ||
| extrachunk.c | ||
| extrachunk.h | ||
| factory.c | ||
| getframe.c | ||
| icmstream.c | ||
| Makefile.in | ||
| tmpfile.c | ||
| wavfile.c | ||