system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-10-31 12:54:13 +00:00
Code Issues Projects Releases Packages Wiki Activity
168115 commits 3 branches 785 tags 324 MiB
Commit graph

924 commits

Author SHA1 Message Date
Hugh McMaster
7cd90766bb regedit/tests: Add tests for values with embedded null characters. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2018-04-19 17:38:09 +02:00
Hugh McMaster
6bca0abb68 regedit: Use the correct window class name. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2018-04-19 17:38:07 +02:00
Zebediah Figura
80ec0bc4b2 regedit: Fix updating the scrollbar in the hex edit dialog. 
The scrollbar should be updated every time the line width is recalculated.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2018-03-12 18:03:08 +01:00
Zebediah Figura
c52cfd3129 regedit: Make hexedit dialog a little larger. 
Both in the interest of having an even 8 bytes per line, and of having more
than two lines visible at once.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2018-03-12 18:03:04 +01:00
Zebediah Figura
ce94f686d5 regedit: Also display the byte offset in the hex edit dialog. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2018-03-12 18:02:53 +01:00
Zebediah Figura
31e41a942e regedit: Use monospace font for hex edit dialog. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2018-03-12 18:02:45 +01:00
Alexandre Julliard
d5f316bf0a makefiles: Disable binary installation in the individual makefiles on Wow64. 
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2018-02-22 14:16:33 +01:00
Michael Stefaniuc
505a9e0283 regedit: Use the global HeapAlloc() wrappers. 
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2018-02-07 10:06:12 +01:00
Alexandre Julliard
6c5deaa474 regedit/tests: Get rid of version check. 
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2018-01-02 15:52:22 +01:00
Zebediah Figura
0875bf8974 regedit/tests: Skip tests if running as non-elevated admin. 
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-12-22 16:59:27 +01:00
Austin English
79f2a7815b regedit: Move WineHQ URLs to https. 
Signed-off-by: Austin English <austinenglish@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-12-01 10:05:25 +01:00
Hugh McMaster
4339f40154 regedit: Do not abort if the /m switch is used. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-11-23 21:17:14 +01:00
Hugh McMaster
8a8a2c9bb9 regedit: Correctly export REG_DWORD values with no data. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-11-10 13:46:31 +01:00
Hugh McMaster
aabdc271f8 regedit: Correctly export hex values with no data. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-11-10 13:46:25 +01:00
Alexandre Julliard
7344ac9b72 regedit: Use WINAPIV calling convention for variadic functions. 
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-11-02 10:21:53 +01:00
Zebediah Figura
25c78b61de regedit: Always start the GUI as 64-bit when on a 64-bit prefix. 
Same as we do with winecfg. This should help to eliminate some confusion
with users who may want to edit keys with WOW64 redirection (e.g.
Software\\Wine\\Drives).

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-11-01 23:16:07 +01:00
Hugh McMaster
84dda23536 regedit: Correctly import hex values with no data. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-10-16 15:26:33 +02:00
Hugh McMaster
33f9093f6d regedit/tests: Add more export tests. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-10-13 12:57:34 +02:00
Hugh McMaster
8ecc0d41ca regedit/tests: Add REG_NONE to the empty hex data import tests. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-10-13 12:57:30 +02:00
Hugh McMaster
a5de10a207 regedit/tests: Delete the export file before returning from compare_export(). 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-10-13 12:57:27 +02:00
Hugh McMaster
1baa026bc3 regedit/tests: Use a helper function to open registry keys. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-10-13 12:57:25 +02:00
Hugh McMaster
c751b69f88 regedit/tests: Print an error code when CreateFile fails. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-10-13 12:57:22 +02:00
Hugh McMaster
1e6bf7d996 regedit/tests: Add REG_BINARY to the empty hex data import tests. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-10-09 19:50:40 +02:00
Hugh McMaster
52f686e054 regedit/tests: Test the importing of hex values with no data. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-10-05 19:33:09 +02:00
Fabian Maurer
8e9a469e9c regedit: Don't crash if REG_SZ is empty. 
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-10-02 10:14:13 +02:00
Hugh McMaster
326fa95eab regedit/tests: Use a helper function to delete registry values. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-09-25 22:21:42 +02:00
Hugh McMaster
03a9bf4f5c regedit/tests: Test registry export against order of data creation. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-09-25 22:21:42 +02:00
Hugh McMaster
73bb1f66a3 regedit/tests: Test registry export with a complex data structure. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-09-25 22:21:42 +02:00
Hugh McMaster
b3032b425e regedit/tests: Test registry export with a simple data structure. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-09-25 22:21:42 +02:00
Hugh McMaster
fd4ce9a0ef regedit/tests: Test registry export with an empty key. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-09-25 22:21:42 +02:00
Hugh McMaster
cca0147fcf regedit/tests: Use a helper function to delete registry keys. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-09-25 22:21:42 +02:00
Hugh McMaster
0ab54e4a64 regedit: Export Unicode registry files by default. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-09-18 15:23:04 +02:00
Hugh McMaster
ee11f6fff5 regedit/tests: Combine and rename the r_exec_import_*str functions. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-09-18 15:22:58 +02:00
Hugh McMaster
7744204962 regedit/tests: Use a helper function to write registry files. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-09-18 15:22:53 +02:00
Hugh McMaster
e9daef47e1 regedit: Null-terminate incomplete REG_EXPAND_SZ and REG_MULTI_SZ Unicode data. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-08-28 14:57:10 +02:00
Hugh McMaster
60e771e686 regedit: Close any open registry keys before starting the key deletion process. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-08-25 08:07:57 +02:00
Hugh McMaster
484f88080d regedit/tests: Add some mixed key creation and deletion tests. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-08-25 08:07:50 +02:00
Hugh McMaster
d78767b63c regedit/tests: Add Unicode tests for importing invalid registry data. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-08-24 16:59:59 +02:00
Hugh McMaster
cbe95347fc regedit/tests: Add Unicode tests for value deletion. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-08-24 16:59:57 +02:00
Hugh McMaster
0eab4519c0 regedit/tests: Add Unicode tests for registry key creation and deletion. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-08-24 16:59:55 +02:00
Hugh McMaster
634156b10a regedit/tests: Add Unicode tests for importing registry data with whitespace. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-08-24 16:59:53 +02:00
Hugh McMaster
13cbc36690 regedit/tests: Add Unicode tests for importing registry data with inter-mixed comments. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-08-24 16:59:51 +02:00
Hugh McMaster
b46b698e82 regedit/tests: Delete the test registry key before starting each test. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-08-24 16:59:49 +02:00
Hugh McMaster
d8cdafcc6f regedit/tests: Add Unicode import tests and remove the WCHAR support check. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-08-24 08:42:21 +09:00
Hugh McMaster
3f0ebaeebb regedit: Return a valid pointer in the QUOTED_VALUE_NAME state if REGPROC_unescape_string() returns FALSE. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-08-20 09:24:49 +09:00
Hugh McMaster
efb8d0b497 regedit: Allow editing of all hex data types. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-08-08 20:13:56 +09:00
Hugh McMaster
fc5bd1b438 regedit: Replace a HeapAlloc() HEAP_ZERO_MEMORY call in framewnd.c. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-08-02 20:19:43 +02:00
Hugh McMaster
4c25f6497e regedit: Use the heap_*() functions in hexedit.c where possible. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-08-02 20:18:50 +02:00
Hugh McMaster
744d538509 regedit: Pass memcpy() the correct destination address. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-31 15:05:01 +02:00
Hugh McMaster
5d9a4c4dbd regedit: Store the data from a listview subitem in a valid memory address. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-28 15:42:20 +02:00
Hugh McMaster
793ddc992c regedit: Use the heap_*() functions in treeview.c where possible. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-28 15:42:18 +02:00
Hugh McMaster
e0a527ab43 regedit: Use the heap_*() functions in listview.c where possible. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-28 15:42:16 +02:00
Hugh McMaster
792e7046a6 regedit: Remove commented code from resize_frame_rect(). 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-27 17:04:05 +02:00
Hugh McMaster
9be3c53701 regedit: Use the heap_*() functions in regedit.c where possible. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-27 17:04:04 +02:00
Hugh McMaster
a3e043b82e regedit: Use the heap_*() functions in framewnd.c where possible. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-27 17:04:04 +02:00
Hugh McMaster
6238cd46f2 regedit: Use the heap_*() functions in edit.c where possible. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-27 17:04:04 +02:00
Hugh McMaster
c193bffb3e regedit: Use the heap_*() functions in childwnd.c where possible. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-27 17:04:04 +02:00
Hugh McMaster
1b3afb27c7 regedit: Use heap_xrealloc() for consistency. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-27 17:04:04 +02:00
Hugh McMaster
f7bdf34029 regedit: Use a helper function to free allocated memory. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-27 17:04:04 +02:00
Hugh McMaster
79ff4148c2 regedit: Use a helper function to allocate memory and check for a valid pointer. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-27 17:04:04 +02:00
Hugh McMaster
976c2aa649 regedit: Prevent out-of-bounds reads when unescaping a string (Valgrind). 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-26 22:14:00 +02:00
Hugh McMaster
5bd636dc16 regedit: Check for a valid subkey pointer before attempting to delete a registry key (Coverity). 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-24 18:58:31 +02:00
Hugh McMaster
b501b2388d regedit: Free the value name buffer from the default value name parser state if necessary (Valgrind). 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-24 18:58:31 +02:00
Hugh McMaster
d62fb29866 regedit: Re-size the data export buffer using the required size instead of doubling it. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-20 16:27:05 +02:00
Hugh McMaster
9d23db6b12 regedit: Remove unused header includes from regproc.c. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-20 16:27:04 +02:00
Hugh McMaster
cc1d2525c4 regedit: Remove an unused #define. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-20 16:27:04 +02:00
Hugh McMaster
6effc48365 regedit: Export value names from the export_data() function. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-19 19:13:29 +02:00
Hugh McMaster
97383a14f7 regedit: Append a newline to the end of the export file. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-19 19:13:29 +02:00
Hugh McMaster
37b5607ff6 regedit: Export REG_SZ data via the export_data() function. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-19 19:13:29 +02:00
Hugh McMaster
6515837ada regedit: Use a helper function to export hex data and REG_DWORD data. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-19 19:13:29 +02:00
Hugh McMaster
bb147fbaa7 regedit: Export REG_DWORD data from a separate function. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-19 18:52:08 +02:00
Hugh McMaster
40ce665836 regedit: Export value names from a separate function. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-19 18:51:57 +02:00
Hugh McMaster
c189effeb3 regedit: Read registry value information before exporting. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-19 10:50:04 +02:00
Hugh McMaster
efe3bc87e7 regedit: Re-implement some parts of the export operation. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-19 10:47:36 +02:00
Nikolay Sivov
cbd6e05e68 regedit: Simplify double-click listview handler. 
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-14 10:51:58 +02:00
Hugh McMaster
5a391e18cb regedit: Use UpdateStatusBar() instead of updating the text manually. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-13 18:34:54 +02:00
Hugh McMaster
683b9992f6 regedit: Remove the listview's sub-class and move its messages to childwnd.c. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-12 19:51:55 +02:00
Hugh McMaster
aa42d81e6d regedit: Move treeview notify messages to a separate function. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-12 19:51:55 +02:00
Hugh McMaster
9e1278dd47 regedit: Remove the unused _CmdWndProc callback function from listview.c. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-12 19:51:55 +02:00
Hugh McMaster
c4a06a3034 regedit: Update string resources associated with key deletion. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-12 19:51:54 +02:00
Hugh McMaster
66dcf0a87d regedit: Update some resource strings associated with key parsing. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-12 19:51:54 +02:00
Hugh McMaster
ae147a5bf6 regedit: Output an error message and exit with error code zero instead of calling exit(1). 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-12 19:51:53 +02:00
Hugh McMaster
7d0f2deca3 regedit: Update the listview path when renaming a treeview node. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-12 19:51:53 +02:00
Hugh McMaster
182b6fb545 regedit: Update the status bar text when a treeview node is renamed. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-12 19:51:53 +02:00
Hugh McMaster
7f11a24fee regedit: Null-terminate REG_EXPAND_SZ and REG_MULTI_SZ hex data during concatenation if we reach EOF. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-10 20:51:11 +02:00
Michael Stefaniuc
a9987fa11a regedit: Remove a redundant NULL check before HeapFree(). 
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-07 19:48:32 +02:00
Hugh McMaster
e2ae9e3c58 regedit: Use a function to free the parser data. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-07 19:48:32 +02:00
Hugh McMaster
6f24426692 regedit/tests: Test the effects of EOF on hex data during concatenation. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-07 19:48:32 +02:00
Hugh McMaster
3908296237 regedit: Null-terminate REG_EXPAND_SZ and REG_MULTI_SZ data if the parsed hex data does not end in a null-terminating character. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-06 18:50:48 +02:00
Hugh McMaster
7b95ddcb04 regedit: Hex data lines may be terminated by a semicolon. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-06 18:50:48 +02:00
Hugh McMaster
23c93d3026 regedit/tests: Add some more tests for importing hex data. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-06 18:50:48 +02:00
Hugh McMaster
3afa0e42c8 regedit/tests: Add another test for "0x" prefixes in the hex data type. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-06 18:50:47 +02:00
Hugh McMaster
499733f400 regedit/tests: Check if regedit.exe has elevated privileges before starting some tests. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-06 18:50:47 +02:00
Hugh McMaster
b811b16694 regedit: Do not import the line if a hex data type has a "0x" prefix. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-05 18:21:37 +02:00
Hugh McMaster
1a4c3e5d28 regedit: Check if any hex data exists before attempting to parse it. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-05 18:21:18 +02:00
Hugh McMaster
5cc1b227b7 regedit: Do not remove lines beginning with a semicolon from the read buffer. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-05 18:21:10 +02:00
Nikolay Sivov
d2697467b2 regedit: Remove commented out block. 
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-05 18:21:06 +02:00
Hugh McMaster
5d8a1283f2 regedit: Do not remove lines beginning with '#' from the read buffer. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-04 19:49:57 +02:00
Hugh McMaster
e336c86359 regedit: Skip blank and whitespace-only lines during hex data concatenation. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-04 19:49:49 +02:00
Hugh McMaster
6ffa89ebd3 regedit: Skip lines that do not begin with a hexadecimal character during hex data concatenation. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-04 19:49:42 +02:00
Hugh McMaster
50caf838b6 regedit: Simplify a while loop for skipping whitespace. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-04 19:49:32 +02:00
Hugh McMaster
50fee455c4 regedit/tests: Test whether the "0x" prefix is valid when importing hex data. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-04 19:49:25 +02:00
Hugh McMaster
506d4fd052 regedit/tests: Test whether registry keys ending with trailing backslashes are imported and created. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-04 19:49:21 +02:00
Hugh McMaster
032d32f940 regedit: Improve the parsing of multiline hex data during the registry import operation. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-03 15:57:44 +02:00
Hugh McMaster
c750c2a98d regedit: Remove un-necessary parser state assignment if we are returning to the same state. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-03 15:57:44 +02:00
Hugh McMaster
2db2a7aeef regedit/tests: Test the effect of whitespace-only lines during hex data concatenation. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-03 15:57:44 +02:00
Hugh McMaster
55d43d13e4 regedit/tests: Fix another incorrectly named registry key. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-07-03 15:57:44 +02:00
Hugh McMaster
817cd2ac59 regedit/tests: Correct out of sequence test numbering. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-29 18:32:06 +02:00
Hugh McMaster
a905b4d6ba regedit/tests: Test comma placement when parsing hex data. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-29 18:32:06 +02:00
Nikolay Sivov
f4e98d813f regedit: Remove explicit iIndent field initialization. 
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-28 18:24:14 +02:00
Nikolay Sivov
b84f228805 regedit: Use notification message to clean up item data. 
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-28 18:24:11 +02:00
Hugh McMaster
b25337e6d6 regedit: Free the binary data buffer after saving the new value (Coverity). 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-28 18:23:04 +02:00
Hugh McMaster
ec0043f083 regedit/tests: Test whether EOF invalidates a hex data line ending in a backslash. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-27 19:13:54 +02:00
Hugh McMaster
82d3be8094 regedit/tests: Test whether a forward slash can be used as a concatenation marker. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-27 19:13:50 +02:00
Hugh McMaster
81fa517436 regedit/tests: Test the effects of comments and new lines that appear between valid hex data lines. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-27 19:13:48 +02:00
Hugh McMaster
a9726d0b90 regedit/tests: Test whether a line beginning with a backslash can follow a line ending in a backslash. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-27 19:13:44 +02:00
Hugh McMaster
a31f070ada regedit/tests: Test line concatenation with comments, new lines and comma variations before a new default registry value. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-27 19:13:41 +02:00
Hugh McMaster
db9e4199e0 regedit/tests: Test line concatenation with comments, new lines and comma variations before a new registry value. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-27 19:13:38 +02:00
Hugh McMaster
82263293f6 regedit/tests: Test line concatenation with a new registry key on the next line. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-27 19:13:34 +02:00
Hugh McMaster
6b36ce329d regedit/tests: Test backslashes with whitespace variations and comma placement. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-27 19:13:32 +02:00
Hugh McMaster
73af2479c7 regedit/tests: Use the verify_key*() functions where possible. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-26 18:19:34 +02:00
Hugh McMaster
f0e21863c9 regedit/tests: Use verify_key() for consistency with the verify_reg*() functions. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-26 18:19:32 +02:00
Hugh McMaster
758340a6e1 regedit: Free the buffer and reset data information on error and after setting the value. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-26 18:19:09 +02:00
Hugh McMaster
a76ce84fce regedit/tests: Add tests to determine the effects of backslashes in hex data. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-23 15:19:36 +02:00
Hugh McMaster
a1b35b3bc4 regedit/tests: Add tests for parsing hex data. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-22 19:25:16 +02:00
Hugh McMaster
4a70d33552 regedit: Display data for all values in the GUI. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-21 19:15:12 +02:00
Hugh McMaster
878a0a4e14 regedit: Display all registry data types in the GUI. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-21 19:15:12 +02:00
Hugh McMaster
8803b9616b regedit: Fail when parsing any hex data type that is greater than ULONG_MAX on Windows. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-21 19:15:12 +02:00
Hugh McMaster
e3234f6ede regedit: Use a generic data type to correctly process all data types. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-20 18:43:30 +02:00
Hugh McMaster
cb563dbac6 regedit: Re-insert the default value item after deleting its data. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-16 15:25:38 +02:00
Hugh McMaster
7f76cf6c26 regedit: Use the correct mask flags with LVM_GETNEXTITEM. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-16 15:25:38 +02:00
Hugh McMaster
1f08ee2453 regedit: Allow the deletion of registry keys beginning with a lowercase 'H'. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-16 15:25:38 +02:00
Hugh McMaster
f535341d2b regedit: Use a case insensitive comparison when parsing registry classes from registry file versions 4 and 5. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-16 15:25:37 +02:00
Hugh McMaster
8504a1563d regedit: Free the memory used by the REG_DWORD and hex data types after saving the registry value. 
We use a BOOL to handle all hex types, including those that are undefined (e.g.0x100).

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-16 15:25:37 +02:00
Hugh McMaster
a1924ae2da regedit: Export hex data types without warning about unsupported data types. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-16 15:25:37 +02:00
Hugh McMaster
300df08e70 regedit: Remove an unused #define. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-16 15:22:07 +02:00
Hugh McMaster
191b81dbd3 regedit: Add data parsing operations to the state machine. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-15 21:54:38 +02:00
Hugh McMaster
d60c31eadb regedit: Perform value name operations in the state machine. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-15 18:51:08 +02:00
Hugh McMaster
ca98e23451 regedit: Perform key operations in the state machine. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-15 18:51:08 +02:00
Hugh McMaster
ec87800856 regedit: Introduce a partial state machine for importing registry data. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-15 18:51:08 +02:00
Hugh McMaster
b1e48fb469 regedit: Free the stringValueData buffer before using it again (Coverity). 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-15 15:02:14 +02:00
Hugh McMaster
06b0a6d94d regedit/tests: Test whether "" is interpreted as the default registry value. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-15 15:02:10 +02:00
Hugh McMaster
c414b2b570 regedit/tests: Output "(Default)" when referring to the default registry value. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-15 15:02:07 +02:00
Hugh McMaster
a726343fa5 regedit: Add status bar text for the 'Expand'/'Collapse' menu item. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-13 20:56:20 +02:00
Hugh McMaster
5058fa70a3 regedit/tests: Test the accepted range of the hex-based data types. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-13 20:56:19 +02:00
Hugh McMaster
955766a13b regedit/tests: Test case sensitivity when creating and deleting registry keys. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-13 20:56:19 +02:00
Hugh McMaster
8096e23798 regedit/tests: Remove an un-needed tab character from a key in the key deletion tests. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-09 09:18:53 +02:00
Hugh McMaster
afde1624ca regedit: Do not use REG_NONE as the default data type if strtoulW() fails. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-08 16:44:58 +02:00
Hugh McMaster
5669282e1d regedit: Do not create registry keys that end without a closing bracket. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-08 16:44:58 +02:00
Hugh McMaster
eca563e9ce regedit/tests: Add tests for value deletion. 
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2017-06-08 16:44:58 +02:00