Commit graph

8992 commits

Author SHA1 Message Date
Eric Pouech
f2ca35bd80 cmd: Use OEM code page when reading a file.
Calling GetConsoleCP() when ReadConsoleW() fails (potentially indicating
that cmd.exe's instance isn't attached to a console) makes no sense.

In details, since GetConsoleCP() returns 0 when not attached to a console
to indicate error, we're in fact using CP_ACP.

So fallback explicitely to OEM CP (which is the default for CUI programs).

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-11-25 18:09:57 +01:00
Rémi Bernon
1c30f7803c winepath: Free wine_get_(dos|unix)_file_name memory with HeapFree. 2022-11-25 18:09:57 +01:00
Paul Gofman
eec6aea10a wmic: Support array of BSTRs in convert_to_bstr(). 2022-11-24 22:20:20 +01:00
Paul Gofman
e3d7a3e3f6 wmic: Add nicconfig alias. 2022-11-24 22:20:20 +01:00
Paul Gofman
97b9d8ddbe wmic: Handle VariantChangeType() failures.
wmic currently crashes on, e. g., VT_EMPTY or VT_ARRAY types returned.
2022-11-24 22:20:20 +01:00
Paul Gofman
85b84a949c wmic: Call _BeginEnumeration() before iterating class object.
Otherwise enumeration fails on Windows.
2022-11-24 22:20:20 +01:00
Paul Gofman
6412b3dc3a wmic: Don't set WBEM_FLAG_FORWARD_ONLY flag on query.
The result access is not forward only.
2022-11-24 22:20:20 +01:00
Rémi Bernon
f810a57590 rpcss: Use I_Rpc(Free|Allocate) in MIDL_user_(allocate|free).
In ept_map, rpcss uses TowerConstruct to allocate tower array elements.

The array is later released by the generated stub code, and each element
is ultimately freed using MIDL_user_free.

TowerConstruct always allocate memory using I_RpcAllocate, we must use
I_RpcFree to free it.
2022-11-23 17:59:47 +01:00
Alex Henrie
dab61cdcd1 explorer: Put the calling convention inside the function pointer parentheses.
As required by MSVC.
2022-11-22 18:27:30 +01:00
Zhiyi Zhang
8459a5272a explorer: Use a valid taskbar position when the taskbar is hidden.
Some applications use FindWindowA() with class Shell_TrayWnd to find the taskbar window on Windows.
Then GetWindowRect() is called to get the taskbar window rectangle. Finally, the taskbar window
rectangle is subtracted from the primary screen rectangle to calculate the work area. Without a
valid taskbar window position, these applications end up getting an incorrect work area and going
down the wrong path. So use the same position and size as the host system panel for explorer taskbar
when it's hidden.
2022-11-17 10:00:24 +01:00
Zhiyi Zhang
b6818e2c20 explorer/tests: Add taskbar tests. 2022-11-17 10:00:24 +01:00
Eric Pouech
8f1febc430 cmd: Don't write outside of variable array.
GCC 12.2 rightfully complains about an out-of-founds array access.
This can possibly happen for unsupported variable names.

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-11-14 13:13:02 +01:00
Eric Pouech
41221452c8 winedbg: Don't use invalid address mode in exception prolog.
Removes a GCC 12.2 warning about printing NULL string.

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-11-14 13:13:02 +01:00
Arkadiusz Hiler
92e4cad8e0 cmd/tests: Make sure for /f doesn't loop infinitely on NULs. 2022-11-10 09:48:30 +01:00
Eric Pouech
e1c37c21da cmd: Use CRT file I/O function inside 'for /F' handling.
This allows:
- to mimic native behavior when a stray '\0' is present in file
  (in 'FOR /F' execution, it's interpreted as an EOF marker)
  (prevents an infinite loop)
- supports (with /USEBACKQ) unicode output (if BOM is present)

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53386
2022-11-10 09:48:23 +01:00
Alex Henrie
08ec06da54 uuid: Add propkey.h.
Needed to compile Tera Term.
2022-11-08 20:07:51 +01:00
Mohamad Al-Jaf
21ae94d437 certutil: Add stub program.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53086
2022-11-07 21:16:10 +01:00
Mohamad Al-Jaf
82e8d6036f setx: Add stub program.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53755
2022-11-07 21:16:10 +01:00
Alex Henrie
212e319dce cmd: Use the wcsrev function instead of reimplementing it. 2022-11-04 19:23:55 +01:00
Alex Henrie
6ee8f819cf cmd: Remove inapplicable comment from WCMD_getfileowner. 2022-11-04 19:23:55 +01:00
Zhiyi Zhang
957dfccb14 winecfg: Adjust top-level window rectangles after theme changes.
Manual tests show that calling EnableTheming() in uxtheme.dll doesn't update window sizes. So
it seems more appropriate to do it in winecfg.exe.
2022-11-02 17:19:44 +01:00
Zhiyi Zhang
982c9974a7 winecfg: Use SM_CYSIZE to set and get caption height.
After applying a theme with CaptionBarHeight set, caption height from SPI_GETNONCLIENTMETRICS is set
to the specified size. However in refresh_sysparams(), the caption height is refreshed and the value
from SM_CXSIZE is used and ends up overwriting the theme specified caption height. SM_CYSIZE is the
correct index instead of SM_CXSIZE.

You may need to turn a theme off and on for the correct caption height to take effect after the fix.
2022-11-02 17:19:42 +01:00
Eric Pouech
9317a331f1 conhost/tests: Fix some conditions on tty test termination.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-11-01 20:46:23 +01:00
Alexandre Julliard
6a91264918 makefiles: Store PE objects in subdirectories in the build tree.
This will make it possible to build multiple PE architectures.
2022-10-26 15:03:05 +02:00
Eric Pouech
5a8350120c conhost/tests: Fix some tests on input sequences.
Correctly handling keyboards (French, German...) which report right-alt
as ctrl+alt in VkKeyScan().

Splitting escape_test input tests into pure virtual keys on one hand,
and modified char key on the other.
Generating the virtual codes for the later instead of hardcoding the
results (bound to generic US keyboard).

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52980
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-10-24 18:50:36 +02:00
Eric Pouech
bdad6f2c85 conhost/tests: Fix tests for some keyboard layouts.
Some keyboards (French, German and some others) report the right alt key
(which is some cases the right-shift one) as ctrl+alt.
Add proper handling for ctrl+alt return from VkKeyScan().

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52980
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-10-24 18:50:29 +02:00
Francois Gouget
75e8f4edb7 winetest: Let the get_subtests() caller report errors.
The caller already analyses get_subtests() errors and provides
a detailed error message in the information section of the report
so the report(R_ERROR) pop up / stderr message is redundant.
2022-10-20 18:29:59 +02:00
Alexandre Julliard
46f307073e ngen: Add version resource.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53773
2022-10-11 18:40:37 +02:00
Eric Pouech
c19f3b620a conhost: Fix tests on ReadConsole with CONSOLE_READCONSOLE_CONTROL.
It should fix the errors around line 1370 in conhost/tests/tty.c, but
it doesn't fix other errors around line 1530 and 1550 which are
completly unrelated to this change.  So failures to be expected on the
latter.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52648
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-10-10 11:22:23 +02:00
Hugh McMaster
627f2b3557 kernelbase: Return full title length from GetConsoleTitle(). 2022-10-10 11:19:44 +02:00
Eric Pouech
001665d735 winedbg: Enhance printing of variables or fields.
Prints 'int a[10]' (instead of 'int[10] a').
Ditto for variables/fields of type function pointer.

And for pure type printing, no longer prints --none-- for
arrays and function pointers.

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-09-30 21:20:28 +02:00
Rémi Bernon
4c60f67f00 regedit: Add a direct import for shcore.
For CommandLineToArgvW.
2022-09-30 18:34:22 +02:00
Rémi Bernon
99b3862e67 regedit: Call InitCommonControls after command-line has been processed.
Avoid triggering the load of comctl32 early.
2022-09-30 18:34:20 +02:00
Jacob Czekalla
377481180e notepad: Show goto dialog box. 2022-09-23 15:16:48 +02:00
Jacob Czekalla
799c24aa81 notepad: Track and display line number and column. 2022-09-14 22:38:34 +02:00
Jacob Czekalla
dd3fa4e9ef notepad: Show status bar. 2022-09-14 22:38:34 +02:00
Alexandre Julliard
657cdc1861 winetest: Report failure for tests that print too much output. 2022-09-14 22:38:34 +02:00
Alexandre Julliard
12bf088ac0 winetest: Don't require an email if we have a URL. 2022-09-13 16:22:21 +02:00
Nikolay Sivov
ebbdbff50e ping: Use CRT allocation functions.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2022-09-09 23:21:40 +02:00
Nikolay Sivov
470232744d msidb: Use CRT allocation functions.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2022-09-09 23:21:40 +02:00
Alexandre Julliard
0f96288080 winetest: Report success if the report has been submitted successfully. 2022-09-08 20:36:33 +02:00
Alexandre Julliard
1bc6b9622f winetest: Add extra quiet mode that only outputs data for failed tests. 2022-09-07 20:07:18 +02:00
Alexandre Julliard
4b590b212d winetest: Add helper functions for temp file handling. 2022-09-07 20:07:18 +02:00
Alexandre Julliard
dbb55ed91a makefiles: Add install-test target to install winetest.exe. 2022-09-07 20:07:18 +02:00
Alexandre Julliard
5fabd968d4 winetest: Exit with error 3 when there are test failures. 2022-08-16 22:27:50 +02:00
Alexandre Julliard
3deabed43d winetest: Disable the crash dialog in non-interactive mode. 2022-08-16 17:41:53 +02:00
Alexandre Julliard
6ae99e4da0 winetest: Support loading the list of tests from a file. 2022-08-16 17:41:53 +02:00
Alexandre Julliard
22aceb44e7 winetest: Use CRT allocation functions. 2022-08-16 11:57:39 +02:00
Eric Pouech
16bcc3bc29 winedbg: Synthetize pointer to type when not available.
This ensures that we always have a type as pointer to a known <type>
(either because it exists in <type>'s module, or it's synthetized inside
debugger).

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-07-29 18:55:32 +02:00
Eric Pouech
dd977e4a85 winedbg: Store result of types_get_info(TI_GET_TYPE) in dbg_type.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-07-29 18:55:30 +02:00