These parts were supposed to contain a solid fill background without a border. If BorderSize is not
set, they will use the border size of 1 from the inherited progress class.
These parts only contain simple images that can be achieved with border fill backgrounds as well.
So visually, this change is a no-op. The reason for using image file backgrounds is that I tend
to use the same background type as the theme files for Windows. However, drawing border fill
background is much more efficient.
Pro Evolution Soccer 2008 demo is buggy and generates ~570,000 WM_PAINT messages for the progress
control. On Windows, it's ~1,140,000 WM_PAINT messages. DrawThemeBackground() on Wine is 10x more
expensive than that of Windows and I found little room for optimization. 60% of the time in
DrawThemeBackground() is spend for CreateCompatibleDC() and other 30% for actually drawing. So I
decided to change light.msstyles instead.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54728
Fix invisible disabled menu item text in Subtitle Workshop Classic 6.1.4. The application happens to
use 0xF0F0F0 as the menu background and the inactive caption color to draw disabled menu item text.
In Light theme, the inactive caption color is very close to 0xF0F0F0, thus causing the invisible
text. So use a darker color for inactive captions to avoid this issue. The inactive caption text
color is also adjusted accordingly.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53575
Fix DTS Master Audio Suite save file button can not be clicked. The application queries for Vista+
Menu class because Wine's default system version is set to Windows 7.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52667
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
The Classic Blue theme has only system colors and doesn't contain bitmaps. Such classic themes
should be stored in a .theme file instead of a .msstyles file. While it looks mostly alright when
using the theme, some applications fail to draw elements because they consider theming active as
IsThemeActive() returns TRUE but OpenThemeData() fails.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
Some window procedures don't actually erase background when WM_ERASEBKGND is received. So when drawing
transparent buttons on such windows, there may be left over content from buttons of different states.
This commit adds a white background to all the button parts that shouldn't be transparent.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52433
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
Themed scroll bar width and height are 17 pixels on XP. Fix that Light theme scroll bar arrow glyphs look off by 1
pixel. The combo button glyphs also have to be moved by 1 pixel because it was designed against the old scroll bar
arrow button width and height.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
Scroll bar arrow button background within its sizing margins is all white, using stretch instead of
tile has no visual difference and is more efficient. On Windows, stretch sizing type is also used
for this part.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
Fix Nokia SDK 2.0 for Java installer showing artifacts on its progress bar. The application queries
for these Vista+ progress bar parts because Wine's default system version is set to Windows 7.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
Set all transition duration to 100ms for different states and 0ms for the same state.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
Fix a bug that scrollbar width and height don't change when activating
Light theme. For example, when theming is inactive, change scrollbar
width from the default 16 pixels to 32 pixels, then activate Light theme.
Then scrollbar width should be changed to the theme specified scrollbar width.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
When SizingType property value is TrueSize, theme part images are scaled only when
TrueSizeScalingType property value is DPI or Size.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
