Commit graph

768 commits

Author SHA1 Message Date
Alex Henrie
14158bb57f comdlg32/tests: Use CRT allocation functions. 2023-11-28 22:58:42 +01:00
Alistair Leslie-Hughes
6fd308cd98 comdlg32: Remove DECLSPEC_HIDDEN usage. 2023-11-10 00:03:44 +01:00
Owen Rudge
1ee2681394 comdlg32: Perform case-insensitive comparison of extension in file dialog. 2023-11-03 18:05:01 +01:00
Alexandre Julliard
7ccb5df0fc makefiles: Always use the global SOURCES variable for .rc files. 2023-11-01 22:43:56 +01:00
Alexandre Julliard
2205218b24 makefiles: Always use the global SOURCES variable for .svg files. 2023-10-14 13:47:59 +02:00
Alexandre Julliard
786dc0808b comdlg32/tests: Use nameless unions/structs. 2023-07-19 12:17:07 +02:00
Jacob Czekalla
186d949703 comdlg32: Add parent folder button to IFileDialog. 2023-07-17 12:14:04 +02:00
Alexandre Julliard
c86bb60640 comdlg32: Use nameless unions/structs. 2023-07-10 21:15:55 +02:00
Vladislav Timonin
a0534afab0 comdlg32: Enable visual styles when showing IFileDialog. 2023-07-04 20:47:39 +02:00
Vladislav Timonin
5bc5d36065 comdlg32: Return E_UNEXPECTED if IFileDialog is already shown. 2023-07-04 20:47:39 +02:00
Alex Henrie
15c00627ee comdlg32: Don't use GetProcAddress for SHSimpleIDListFromPath.
The function is exported by name from shell32 and declared in a public
header.
2023-06-19 13:18:01 +02:00
Bernhard Übelacker
345ca7e061 comdlg32: Avoid crash in RemoveControlItem.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51640
2023-06-05 21:48:00 +02:00
Jactry Zeng
3a59a4d1cd comdlg32: Set a size for toolbar buttons of the file access dialog.
The default size is too small for HiDPI, so set the same height as
the look-in combo box to it. And since in owner draw mode, the height
of combo box is calculated and updated when drawing items, this patch
set button height for toolbar from FILEDLG95_LOOKIN_DrawItem() too.
2023-05-23 22:19:30 +02:00
Jactry Zeng
80b332c050 comdlg32: Calculate button height of toolbar with DPI for item dialog. 2023-05-23 22:19:30 +02:00
Florian Will
4e167e7e1e comdlg32/tests: Fix itemdlg tests on Windows.
The wine testbot runs tests with C:\Users\Public\Documents as the
working directory. Itemdlg tests create test files in the working
directory and then try to select them for opening in an IFileOpenDialog.
The dialog has its SetFolder method called to point it to the current
working directory before showing the dialog, in order for the test code
to find the test files it had created there just before opening the
dialog.

On Windows, this failed because calling the dialog's SetFolder method
with C:\Users\Public\Documents doesn't work as expected. The dialog
points to the C:\Users\[CURRENT_USER]\Documents directory instead.
Subsequently, the test would be unable to select the test file because
it doesn't exist in that directory. So the dialog wouldn't accept the
file and close itself to finish the test, but show an error message
instead, resulting in a test timeout.

To fix this, set the current working directory to the temporary
directory before calling individual itemdlg test_* functions.
2023-03-13 21:31:55 +01:00
Alexandre Julliard
1250131b0a comdlg32: Use standard va_list instead of __ms_va_list. 2023-02-17 11:25:20 +01:00
Alexandre Julliard
83a378f1d1 include: Use proper dllimports for comdlg32 functions. 2022-12-07 13:51:37 +01:00
Rémi Bernon
6ffef221a1 comdlg32: Call GlobalReAlloc with GMEM_MOVEABLE flag.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53474
2022-11-22 18:27:31 +01:00
Alex Henrie
cad9446567 comdlg32: Use standard C functions for memory allocation in printdlg.c.
The big win here is getting rid of the reimplementation of wcsdup.
2022-11-16 10:11:24 +01:00
Eric Pouech
2df8ad9d39 comdlg32: Use I width modifier instead of casting to LONG.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-04-06 23:07:20 +02:00
Eric Pouech
e240aeb757 comdlg32/tests: Enable compilation with long types.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-02-23 10:17:25 +01:00
Eric Pouech
05fef74867 comdlg32: Enable compilation with long types.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-02-09 18:37:32 +01:00
Eric Pouech
0c0f80a333 comdlg32: Removed useless casts to long.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-02-01 18:23:19 +01:00
Alexandre Julliard
f0cd33c69e include: Add support for defining Win32 types as 'long' where possible.
Add -DWINE_NO_LONG_TYPES to modules that still have compilation
warnings with long types.

Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-01-27 20:38:22 +01:00
Eric Pouech
d55aad928b comdlg32: Use correct integral type.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-01-27 11:12:58 +01:00
Fabian Maurer
c5c5da6249 comdlg32/tests: Avoid "misleading indentation" warnings.
Signed-off-by: Fabian Maurer <dark.shadow4@web.de>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-01-26 21:53:17 +01:00
Alexandre Julliard
38d2aa4e92 comdlg32: Return INT_PTR instead of LRESULT in dialog procedures.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-10-19 11:33:05 +02:00
Alexandre Julliard
088a787a2c makefiles: Make -mno-cygwin the default.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-09-20 22:45:48 +02:00
Alexandre Julliard
c8e2802391 comdlg32: Fix path validation of UNC paths in the file dialog.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-09-13 19:57:28 +02:00
Alexandre Julliard
5d82baf974 winecrt0: Add a default implementation DllRegisterServer()/DllUnregisterServer().
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-30 22:59:50 +02:00
Zhiyi Zhang
665fa81a51 comdlg32: Fix a memory leak.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-03-01 10:10:35 +01:00
Akihiro Sagawa
89ded8c8e1 comdlg32: Set DEFAULT_CHARSET if CF_NOSCRIPTSEL is set.
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-01-25 21:09:46 +01:00
Akihiro Sagawa
ee3a315385 comdlg32/tests: Add a test for CF_NOSCRIPTSEL.
Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-01-25 21:09:42 +01:00
Michael Stefaniuc
b97542cef7 comdlg32: Use wide-char string literals.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-11-23 12:37:23 +01:00
Jeff Smith
4273004e65 comdlg32: Set background to transparent for font dialog sample text.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50034
Signed-off-by: Jeff Smith <whydoubt@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-10-23 20:23:38 +02:00
Alex Henrie
1a0470443d comdlg32: Fix error precedence in IFileDialog2_SetFileTypes.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-09-10 22:08:03 +02:00
Jacek Caban
a16b9ff583 comdlg32: Improve error handling in get_config_key_string.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-05-08 20:52:14 +02:00
Mas Ahmad Muhammad
cf8a6eb276 comdlg32: Enlarge list area in CHOOSE_FONT window.
Signed-off-by: Mas Ahmad Muhammad <m.charly81@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-04-29 21:10:18 +02:00
Zebediah Figura
9024549fe1 comdlg32/tests: Use GetTempPathA() instead of the current directory in test_extension().
For some reason, a previous test sets the current directory to
C:\windows\system32\ on my Windows 10 machine, which prompts message boxes as
the path is not writable.

Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-01-15 22:03:36 +01:00
Vijay Kiran Kamuju
a9c4b309f6 comdlg32: Use the new colordlg.h file and update the resources.
Signed-off-by: Vijay Kiran Kamuju <infyquest@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-11-19 23:15:05 +01:00
Nikolay Sivov
3dc3d4998e comdlg32/tests: Use win_skip() instead when appropriate.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-10-21 17:11:43 +02:00
Alexandre Julliard
2cfe907584 comdlg32: Build with msvcrt.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-05-29 11:38:38 +02:00
Michael Stefaniuc
773e1788ce comdlg32: Avoid using the comma operator.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-03-22 19:50:13 +01:00
Alistair Leslie-Hughes
211fd67ace comdlg32: Improve Printer Setup dialog.
Reset the tab order to be more like Windows, add Help button.

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-02-13 21:08:30 +01:00
Alistair Leslie-Hughes
0bee07ec57 comdlg32: Improve PRINT32 dialog.
Correct TAB order, and move Help button to bottom right.

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-02-05 11:03:27 +01:00
Dmitry Timoshkov
5a622342d9 comdlg32: When FOS_PICKFOLDERS is specified item selection box should contain full path name.
Otherwise when selecting a folder using IFileOpenDialog interface
the caller instead of C:\Temp receives C:\Temp\Temp. This matches
both an old GetOpenFileName behaviour and what IFileOpenDialog returns
under Windows.

Signed-off-by: Dmitry Timoshkov <dmitry@baikal.ru>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-20 15:34:45 +01:00
Alex Henrie
fedd1cb3d3 comdlg32: Turn several variables into static constants.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-12-04 16:13:10 +01:00
Zhiyi Zhang
d07f31e376 comdlg32/tests: Fix failures on newer Windows 10.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-18 20:59:38 +02:00
Zhiyi Zhang
616e5fa733 comdlg32: Check invalid options in IFileDialog::SetOptions.
Fix Steam chat unable to select files.

Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-18 20:59:38 +02:00
Zhiyi Zhang
b89e0e70e0 comdlg32/tests: Fix crashes.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-09-18 20:59:38 +02:00