Commit graph

8938 commits

Author SHA1 Message Date
Hugh McMaster
93199da8c3 regedit: Use zero as a default for REG_DWORD and REG_QWORD values. 2022-07-27 23:07:06 +02:00
Brendan Shanks
d3b72d0ff1 winedbg: Implement GDB qGetTIBAddr query. 2022-07-27 22:36:31 +02:00
Hugh McMaster
57f45013d8 regedit: Free temporary buffer when working with REG_DWORD and REG_QWORD values. 2022-07-26 22:37:48 +02:00
Hugh McMaster
6901f3ccfc regedit: Update the listview item without reloading the value data. 2022-07-25 17:01:33 +02:00
Hugh McMaster
d1bc3623e8 regedit: Set the dlgproc value name via a function, not a global. 2022-07-25 17:01:33 +02:00
Hugh McMaster
5e2c3dd537 regedit: Update binary data via update_registry_value(). 2022-07-25 17:01:33 +02:00
Eric Pouech
890e3baaba winedbg: Use CRT allocation functions.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-07-25 11:22:18 +02:00
Eric Pouech
674ef559e0 winedbg: Do proper error management when reallocating memory.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-07-25 11:22:12 +02:00
Hugh McMaster
97f10736db regedit: Use 'struct edit_params' with read_value().
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-21 23:03:29 +02:00
Hugh McMaster
becf11084f regedit: Pass updated REG_MULTI_SZ data via 'struct edit_params'.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-21 23:03:29 +02:00
Hugh McMaster
72fced0236 regedit: Pass updated REG_SZ and REG_EXPAND_SZ data via 'struct edit_params'.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-21 23:03:29 +02:00
Hugh McMaster
b00a4b66b9 regedit: Use a separate dialog proc function for string data types.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-21 23:03:29 +02:00
Zhiyi Zhang
c03409e9d7 shell32: Implement SHOpenFolderAndSelectItems().
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=39987
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
2022-07-15 20:01:05 +02:00
Zhiyi Zhang
975b11be9c winefile: Use 10 DLUs for check box height.
10 DLUs is the recommended height for check boxes on Windows.

Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
2022-07-15 11:32:54 +02:00
Zhiyi Zhang
24836f73b4 winecfg: Use 10 DLUs for check box height.
10 DLUs is the recommended height for check boxes on Windows. 8 DLUs is not enough and may cause
shrinking in HiDPI settings.

Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
2022-07-15 11:32:53 +02:00
Zhiyi Zhang
9a98ad709f explorer: Fix memory leaks.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
2022-07-14 21:00:54 +02:00
Hugh McMaster
a6063f8367 regedit: Replace heap_x*() functions with malloc(), realloc() and free().
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-07 19:11:38 +02:00
Hugh McMaster
97a3802093 regedit: Directly use RegQueryValueExW() instead of a helper function.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-07-06 20:32:39 +02:00
Hugh McMaster
101fe51b25 regedit: Correctly calculate REG_MULTI_SZ size before reading from the buffer.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-06 20:32:39 +02:00
Hugh McMaster
159f3699ec regedit: Remove unneeded valueDataLen override for DWORD values.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-06 20:32:39 +02:00
Nikolay Sivov
a2f8f5f93f wmic: Handle properly list for GET verb.
Instead of querying all properties and then matching to requested one,
first check if all requested properties are supported by given class.
Then select just that subset.

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2022-07-05 19:06:12 +02:00
Nikolay Sivov
f059013a41 winemsibuilder: Use CRT allocation functions.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2022-07-05 12:34:03 +02:00
Nikolay Sivov
5675994602 winepath: Use CRT allocation functions.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2022-07-05 12:34:03 +02:00
Nikolay Sivov
ee1f96ebfb wordpad: Use CRT allocation functions.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2022-07-05 12:34:03 +02:00
Nikolay Sivov
a0bef9f322 wscript: Use CRT memory allocation functions.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2022-07-05 12:34:03 +02:00
Nikolay Sivov
201ed0858f rpcss: Use CRT memory allocation functions.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2022-07-05 12:34:03 +02:00
Hugh McMaster
ab03ecf7bc regedit: Allow renaming of values in root keys.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-06-30 19:02:17 +02:00
Hugh McMaster
e06a62049e regedit: Use correct printf specifier for UINT64 (QWORD) values.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-06-29 23:23:41 +02:00
Hugh McMaster
9c30f3d97a regedit: Pass correct data size when adding a new value via the GUI.
This bug was exposed by 3b1faf59f6

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-06-29 23:23:41 +02:00
Eric Pouech
f8d3c2b203 winedbg: No longer hide current WineDbg process from 'info proc'.
We used to hide current WineDbg instance when displaying processes' list
(command 'info proc'). This can potentially generate some "dangling"
processes in the hierarchy (related to this WineDbg instance):
- conhost.exe
- start.exe (when launched from unix shell without full path
  to winedbg.exe)

Also, print a more comprehensive error message when trying to attach to
itself (now that debugger's PID is more easily available).

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-06-29 23:23:41 +02:00
Stefan Dösinger
021eefdee0 winecfg: Support color profiles larger than MAX_PATH chars.
Signed-off-by: Stefan Dösinger <stefan@codeweavers.com>
2022-06-28 18:44:48 +02:00
Nikolay Sivov
4e39188c63 reg: Add REG_QWORD support to 'add'.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-06-27 22:58:21 +02:00
Jinoh Kang
f815c2642e winedbg: Clarify options specific to GDB proxy mode.
Signed-off-by: Jinoh Kang <jinoh.kang.kr@gmail.com>
2022-06-24 22:38:47 +02:00
Nikolay Sivov
208f631cee regedit: Remove unnecessary string conversion when modifying REG_DWORD value.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2022-06-24 10:41:27 +02:00
Nikolay Sivov
3b1faf59f6 regedit: Add support for REG_QWORD type.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2022-06-24 10:41:27 +02:00
Jinoh Kang
beee5160a8 winedbg: Fix typos in manpage.
Signed-off-by: Jinoh Kang <jinoh.kang.kr@gmail.com>
2022-06-20 10:37:59 +02:00
Rémi Bernon
e2f7f01ac8 notepad: Avoid using pointer value after free.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
2022-06-15 11:53:29 +02:00
Hugh McMaster
577258a981 conhost: Update debug output and comments when loading/saving settings.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-06-09 20:55:20 +02:00
Hugh McMaster
1c9c1ebc80 conhost: Show caret immediately after reshaping.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-06-09 20:55:20 +02:00
Jacek Caban
d8a74e5cf9 explorer: Create clipboard manager thread when creating a desktop.
Based on winex11.drv. Drivers that don't implement ClipboardWindowProc entry point will disable it by failing to create the window.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
2022-05-31 22:52:45 +02:00
Hugh McMaster
25f012edcb conhost: Don't prompt the user to save their app-specific settings.
On Windows, app-specific console settings are always saved to the
registry unless the user cancels the console properties dialog.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-05-30 22:07:42 +02:00
Hugh McMaster
bb2b1d0ed1 conhost: Only save app-specific settings that differ from the defaults.
On Windows, app-specific subkeys of HKCU\Console only hold console
settings that differ from the global defaults.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-05-30 22:07:42 +02:00
Hugh McMaster
37bcbe6bca conhost: Save console settings as global defaults on first run.
On Windows, HKCU\Console holds global default settings, while subkeys
hold any app-specific settings that differ from the defaults.

Wine's conhost.exe implementation currently saves all console settings
to an app-specific subkey on the first run, while global defaults are
only saved to HKCU\Console if the user selects 'Set Defaults' from the
pop-up menu and saves new settings. This is the opposite of console
behaviour on Windows.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-05-30 22:07:42 +02:00
Hugh McMaster
303f8042f9 conhost: Set correct face name when the specified font is not available.
conhost.exe currently copies the user-specified face name from the
LOGFONT structure. This results in an invalid face name when the
specified font is not available.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-05-24 21:25:02 +02:00
Eric Pouech
30313d23a3 winedbg: Remove FORCE_DEREF expressions.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-05-24 20:09:59 +02:00
Eric Pouech
5020371eab winedbg: Extend 'print' command to work with types.
'print struct foo' will show all fields of structure
'print enum bar' will show all definitions inside of enum (and their value)
'print /d <type>' will show the type size (in bytes)

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-05-24 20:09:51 +02:00
Eric Pouech
73770ce573 winedbg: Do type / id discrimination when parsing.
- Get rid of struct type_expr_t
- Enable back typecasts (and rewrite the typecast to fit the type parsing scheme)

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-05-24 20:09:17 +02:00
Eric Pouech
af0c59bcc8 winedbg: Use data model for basic type on input.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-05-24 20:09:14 +02:00
Eric Pouech
2d8b709021 winedbg: Redefine internal types with predefined sizes.
This will help mapping a name to a basic type.

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-05-24 20:09:07 +02:00
Eric Pouech
685126e857 winedbg: Fix retrieving integral values.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-05-24 20:09:04 +02:00