Commit graph

83 commits

Author SHA1 Message Date
Alistair Leslie-Hughes af45d28625 msdasql/tests: Add missing carriage returns. 2023-12-20 22:20:49 +01:00
Alistair Leslie-Hughes 311cf13a1c msdasql: Check rowset pointer before assignment in ICommandText::Execute. 2023-11-22 20:02:59 +01:00
Zhiyi Zhang f0bad1ec37 msdasql: Return all initialization properties if no property ID is specified in dbprops_GetProperties(). 2023-11-22 10:08:44 +01:00
Zhiyi Zhang fd2a2d3842 msdasql/tests: Add more IDBProperties::GetProperties() tests. 2023-11-22 10:08:44 +01:00
Zhiyi Zhang b54e1ec604 msdasql/tests: Fix memory leaks. 2023-11-22 10:08:44 +01:00
Alistair Leslie-Hughes 7e1989b963 msdasql: GetAvailableColumns correct assignment of DBCOLUMN data. 2023-11-13 21:55:34 +01:00
Alistair Leslie-Hughes 2690984822 msdasql: IColumnsRowset::GetAvailableColumns return 3 meta columns to allow updating of a row. 2023-11-08 17:24:16 +01:00
Alistair Leslie-Hughes 6a6a92de14 msdasql: Use DBINITCONSTANTS to get guid values. 2023-11-06 11:51:17 +01:00
Alex Henrie 3c2ec4ef94 msdasql: Use CRT allocation functions. 2023-11-03 12:01:06 +01:00
Alexandre Julliard acad49573a makefiles: Always use the global SOURCES variable for .c files. 2023-11-01 22:44:03 +01:00
Alexandre Julliard c432eac726 makefiles: Always use the global SOURCES variable for .idl files. 2023-11-01 22:43:50 +01:00
Alistair Leslie-Hughes 90df243f8e msdasql: Remove DECLSPEC_HIDDEN usage. 2023-06-28 18:57:58 +02:00
Michael Stefaniuc b7fd8972db msdasql: Remove redundant NULL check before heap_free(). 2023-03-29 11:49:17 +02:00
Alistair Leslie-Hughes ec9610c46b msdasql: Use SQLColAttributesW to fetch statement attributes.
We need to use the ODBC v1 function SQLColAttributesW, to ensure that we
use the lowest verion available.  This ODBC function internally will call
SQLColAttribute or SQLColAttributesW depending on what the driver supports.
2023-02-17 11:19:20 +01:00
Alistair Leslie-Hughes 5b9496ade6 msdasql: Always return affected rows if required.
When using msadosql it always returns the number of records
affected or records returned by a SELECT statement.

The access database, which is what the defaults tests are using
doesn't return the number of records for a SELECT.
It's a known issue that you have to MoveLast/MoveFirst before
the correct RecordCount value is return for an Access DB.
2023-02-16 10:35:21 +01:00
Alistair Leslie-Hughes a40d67e04a msdasql: Use SQLDriverConnectW to connect to the ODBC driver. 2023-02-16 10:35:21 +01:00
Francois Gouget a00a64b9c0 msdasql: Fix a typo in the is_fixed_length() function name. 2022-10-20 20:58:06 +02:00
Alistair Leslie-Hughes 475824e709 msdasql: Implement IRowsetInfo GetProperties.
The only way to actually set these properties is via the ICommandProperties interface
found on ICommandText(eg rowset->caller).

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
2022-10-10 11:02:02 +02:00
Alistair Leslie-Hughes 3e0deb3596 msdasql: Select statements return -1 for affected rows in ICommandText Execute. 2022-09-29 15:33:02 +02:00
Alistair Leslie-Hughes d47201918c msdasql: Implement IColumnsInfo GetColumnInfo.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
2022-09-29 15:33:00 +02:00
Alistair Leslie-Hughes df72f9a870 msdasql: Implement IColumnsRowset GetAvailableColumns.
The functions returns a series of custom columns to make a row unique.
For us, it's safe to return no extra columns at this stage.

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
2022-09-20 09:22:25 +02:00
Alistair Leslie-Hughes ebf0070899 msdasql: Implement ICommandProperties SetProperties.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
2022-09-20 09:22:25 +02:00
Alistair Leslie-Hughes 323355a848 msdasql: Implement ICommandProperties GetProperties.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
2022-09-20 09:22:23 +02:00
Francois Gouget 64a7783386 msdasql: Remove a couple of unneeded NULL casts.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-02-14 21:20:42 +01:00
Alistair Leslie-Hughes 50fc9d7ddc msdasql: ICommandText Execute use ODBC to fetch results.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-02-07 10:57:26 +01:00
Alistair Leslie-Hughes bdb7bb1022 msdasql/tests: Fix printf format warnings with long types.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-02-01 20:55:09 +01:00
Alistair Leslie-Hughes 35cf06c3e1 msdasql: Add ITransaction to session interface.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-02-01 20:55:04 +01:00
Alistair Leslie-Hughes 0b97767269 msdasql: Fix printf format warnings with long types.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-02-01 20:54:46 +01:00
Alexandre Julliard f0cd33c69e include: Add support for defining Win32 types as 'long' where possible.
Add -DWINE_NO_LONG_TYPES to modules that still have compilation
warnings with long types.

Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-01-27 20:38:22 +01:00
Alistair Leslie-Hughes 7bdef00a75 msdasql: Add ITransactionJoin to session interface.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-01-26 21:53:57 +01:00
Alistair Leslie-Hughes 7491a7f13f msdasql: Implement ICommandPrepare Prepare.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-01-25 12:37:41 +01:00
Alistair Leslie-Hughes 1636530c81 msdasql: Fix logic when dumping diagnostics records.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-01-25 12:37:39 +01:00
Alistair Leslie-Hughes 513feedff7 msdasql/tests: Test for ITransaction* interfaces on a session.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-01-24 21:44:51 +01:00
Alistair Leslie-Hughes 9d1e3b3a76 msdasql: Connect to DSN in IDBInitialize Initialize.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-01-21 13:15:12 +01:00
Francois Gouget 0ed15c56d1 msdasql/tests: Fix the spelling of the command_text variable.
Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-12-07 16:19:48 +01:00
Alistair Leslie-Hughes 109db990b9 msdasql: Implement IGetDataSource GetDataSource.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-11-17 16:04:39 +01:00
Alistair Leslie-Hughes fbca126660 msdasql: Move ICommandWithParameters to the correct interface.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-11-17 16:04:33 +01:00
Alistair Leslie-Hughes 422caf2161 msdasql: Return S_OK in ICommandPrepare Un/Prepare.
These functions are to attempt to optimize the query that is about
to be run.  We can safely ignore these calls.

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-11-17 16:04:18 +01:00
Alistair Leslie-Hughes 5f8e3a0c74 msdasql: Support NULL dialect in GetCommandText.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-11-16 10:10:05 +01:00
Alistair Leslie-Hughes 0d29647f07 msdasql: Add ICommandWithParameters to command interface.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-11-16 10:10:02 +01:00
Alistair Leslie-Hughes 26c4a1edc7 msdasql: Implement IRowsetInfo GetSpecification.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-11-15 18:40:30 +01:00
Alistair Leslie-Hughes f43b312562 msdasql: IDBProperties doesn't support DBPROPSET_DATASOURCEINFO property set.
Native msado15 queries this to workout if interface IMultipleResults can
be used with CreateCommand.

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-11-10 14:05:55 +01:00
Alistair Leslie-Hughes 5cadb64695 msdasql: Fix initial query value.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-11-09 11:29:04 +01:00
Alistair Leslie-Hughes 61d1152c7c msdasql: Fixup GetCommandText wrt dialect.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-11-09 11:28:59 +01:00
Alistair Leslie-Hughes b5c4d178a0 msdasql: Fix use after free (Coverity).
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-11-08 17:35:09 +01:00
Alistair Leslie-Hughes c8b0e5b138 msdasql: Correct default dialect logic.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-11-08 17:35:04 +01:00
Alistair Leslie-Hughes 7d686c2263 msdasql: Trace session interfaces.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-11-08 17:34:53 +01:00
Alistair Leslie-Hughes 0f0d3c4859 msdasql: Implement IDBProperties SetProperties.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-11-08 17:34:38 +01:00
Alistair Leslie-Hughes 6e94e87994 msdasql: Implement IDBProperties GetProperties.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-11-05 10:24:27 +01:00
Alistair Leslie-Hughes 626f85f5f6 msdasql/tests: Add MSDASQL_ENUMERATOR tests.
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-11-03 21:06:29 +01:00