Commit graph

159916 commits

Author SHA1 Message Date
Kevin Puetz 59f39b325d rpcrt4/tests: Add tests for lifetime of IRpcChannelBuffer.
It's possible for a proxy to be released during the middle of an Invoke.
E.g. a specific case where this happened was a single-shot event sink
which, upon receiving the event it was waiting for, would immediately
call DispEventUnadvise. This removed the proxy pointing to that sink
from the connection point's list of subscribers and released the last
refcount on the proxy itself.

Therefore, all state used to complete an RPC call must be on the stack;
once NdrProxySendReceive pumps STA messages and permits reentrancy,
the proxy cannot be accessed or relied on to own anything.

Add test showing MIDL_STUB_MESSAGE::pRpcChannelBuffer owns a refcount
(to ensure it can read [out] parameters from the channel)
2022-10-11 17:13:00 +02:00
Etaash Mathamsetty 92d74369c8 ntoskrnl.exe: KeInsertQueueDpc stub. 2022-10-11 12:28:29 +02:00
Alistair Leslie-Hughes 64c930ab3e include: Add missing SP defines.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49775
2022-10-11 12:00:14 +02:00
Gabriel Ivăncescu 075f80653b shell32: Handle drive letters properly when parsing MyComputer.
Besides PathGetDriveNumber being dangerous and having a completely messed
up result with \\?\ prefix, a backslash is not required anymore on newer
Windows versions. So e.g. C: should succeed to be parsed.

Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
2022-10-11 11:47:33 +02:00
Gabriel Ivăncescu 2b2c09a01c shell32/tests: Test drive letters parsing for My Computer.
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
2022-10-11 11:47:33 +02:00
Francois Gouget 6ec99a0e91 dxgi/tests: Mark the test_swapchain_window_messages() tests failing randomly on Windows as flaky.
Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53229
2022-10-11 11:43:59 +02:00
Francois Gouget 5b10cb08a5 dxgi/tests: Mark the test_swapchain_window_styles() tests failing randomly on Windows as flaky.
Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53228
2022-10-11 11:43:57 +02:00
Paul Gofman 6b51935589 wined3d: Replace NULL device_window with focus window in swapchain desc. 2022-10-11 11:43:40 +02:00
Paul Gofman 832383f5cd d3d9/tests: Add test for NULL hDeviceWindow in presentation parameters. 2022-10-11 11:43:39 +02:00
Paul Gofman 4d4a4ff5b9 d3d8/tests: Add test for NULL hDeviceWindow in presentation parameters. 2022-10-11 11:43:39 +02:00
Paul Gofman 2c9ab24366 wintrust: Support WSS_GET_SECONDARY_SIG_COUNT in Softpub provider. 2022-10-11 11:42:42 +02:00
Paul Gofman 71f58158c1 wintrust: Load secondary signatures in SoftpubLoadSignature(). 2022-10-11 11:42:41 +02:00
Paul Gofman 2f5ad179e5 wintrust: Initialize CRYPT_PROVIDER_SIGSTATE structure in Softpub provider. 2022-10-11 11:42:41 +02:00
Paul Gofman 6071205974 wintrust/tests: Add tests for multiple PE signatures. 2022-10-11 11:42:39 +02:00
Gabriel Ivăncescu 16c6c249a5 mshtml: Enumerate document elements with name.
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
2022-10-10 21:15:29 +02:00
Gabriel Ivăncescu 6420744c57 mshtml: Split the lookup for an element with name into a separate helper.
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
2022-10-10 21:15:29 +02:00
Gabriel Ivăncescu 8de5187d1b mshtml: Do not enumerate internal dynamic props.
Props allocated with dispex_get_dprop_ref or dispex_get_dynid are purely
internal to our implementation and must not be enumerated.

Note that in case of window, the props themselves become enumerable, but the
dynamic props must still be hidden, since it's the custom prop that refers
to it that must be enumerated (i.e. the DISPID must match with the custom
prop, not the underlying dynamic prop backing it, which would violate the
former DISPID obtained for the respective name).

Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
2022-10-10 21:15:27 +02:00
Gabriel Ivăncescu 03c4a231c0 mshtml: Fix enumerating first custom prop after builtins.
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
2022-10-10 21:15:27 +02:00
Gabriel Ivăncescu 605819dcd9 jscript: Refill the props at end of enumeration in html mode and retry.
If properties were added during enumeration, for example on the prototype,
they are actually visited in mshtml scripts in any mode.

Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
2022-10-10 21:15:26 +02:00
Gabriel Ivăncescu 2a228918ef jscript: Fill the builtin props for enumeration on prototypes as well.
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
2022-10-10 21:15:25 +02:00
Erich E. Hoover 3602c676da ntdll: Implement storing DOS attributes in NtCreateFile.
Co-authored-by: Joel Holdsworth <joel@airwebreathe.org.uk>
Signed-off-by: Joel Holdsworth <joel@airwebreathe.org.uk>
2022-10-10 12:31:25 +02:00
Joel Holdsworth 0a223f17e1 ntdll: Implement retrieving DOS attributes in NtQueryInformationFile.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=9158
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=15679
Co-authored-by: Erich E. Hoover <erich.e.hoover@gmail.com>
Signed-off-by: Joel Holdsworth <joel@airwebreathe.org.uk>
2022-10-10 12:29:01 +02:00
Erich E. Hoover ba24a78c5b ntdll: Implement storing DOS attributes in NtSetInformationFile.
Co-authored-by: Joel Holdsworth <joel@airwebreathe.org.uk>
Signed-off-by: Joel Holdsworth <joel@airwebreathe.org.uk>
2022-10-10 12:27:46 +02:00
Erich E. Hoover 1cd1a28670 ntdll: Implement retrieving DOS attributes in [fd_]get_file_info().
Co-authored-by: Joel Holdsworth <joel@airwebreathe.org.uk>
Signed-off-by: Joel Holdsworth <joel@airwebreathe.org.uk>
2022-10-10 12:23:14 +02:00
Eric Pouech c19f3b620a conhost: Fix tests on ReadConsole with CONSOLE_READCONSOLE_CONTROL.
It should fix the errors around line 1370 in conhost/tests/tty.c, but
it doesn't fix other errors around line 1530 and 1550 which are
completly unrelated to this change.  So failures to be expected on the
latter.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52648
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-10-10 11:22:23 +02:00
Hugh McMaster 627f2b3557 kernelbase: Return full title length from GetConsoleTitle(). 2022-10-10 11:19:44 +02:00
Hugh McMaster e6bea0328a kernel32/tests: Add tests for GetConsoleTitle(). 2022-10-10 11:19:43 +02:00
Jacek Caban 000a7bbb5a winevulkan: Use host Vulkan structures for private thunks arguments. 2022-10-10 11:16:43 +02:00
Alex Henrie 7d223c5326 include: Fix typos in NIN_BALLOON*.
Needed to compile Tera Term.
2022-10-10 11:16:20 +02:00
Alex Henrie 9d2b879d17 include: Fix typo in LR_VGACOLOR.
Needed to compile Tera Term.
2022-10-10 11:15:52 +02:00
Eric Pouech 0d359fb8de wined3d: Use I width modifier for debug traces on DWORD_PTR.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-10-10 11:15:01 +02:00
Eric Pouech 25f6693048 wined3d: Ensure method declaration matches implementations.
wined3d_resource_ops.resource_sub_resource_map()

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-10-10 11:14:59 +02:00
Eric Pouech 414543f6ab wined3d: Ensure function declaration matches implementation.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-10-10 11:14:59 +02:00
Francois Gouget 61ee891c67 d3d9/tests: Mark the test_wndproc() tests failing randomly on Windows as flaky.
Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53281
2022-10-10 11:13:26 +02:00
Francois Gouget 42290cddc5 d3d9/tests: Mark the test_wndproc_windowed() tests failing randomly on Windows as flaky.
Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53283
2022-10-10 11:13:24 +02:00
Francois Gouget fc5bb4deef d3d9/tests: Mark the test_cursor_pos() tests failing randomly on Windows as flaky.
Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53194
2022-10-10 11:13:22 +02:00
Nikolay Sivov b3553705fd shell32: Add Active Desktop stub.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2022-10-10 11:11:44 +02:00
Nikolay Sivov c083b2edcf include: Add IActiveDesktop definition.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2022-10-10 11:11:43 +02:00
Nikolay Sivov 8957d74b99 include: Change include guard for wininet.h.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2022-10-10 11:11:43 +02:00
Eric Pouech 1bcdb17455 dbghelp: Remove symt_close_func_block() stabs's only parameter.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-10-10 11:11:21 +02:00
Eric Pouech 6f8ba8119a dbghelp: Keep compiland's address for Dwarf debug format.
Partly reverting 99eb63bd7a
(it's still needed on Dwarf for blocks with multiple
non-contiguous address ranges).

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-10-10 11:11:15 +02:00
Eric Pouech 96c3f58783 dbghelp: Silence some FIXME for SymGetTypeInfo/TI_GET_OFFSET.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-10-10 11:11:15 +02:00
Eric Pouech 106a056c99 dbghelp: No longer use wine_dbgstr_longlong.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
2022-10-10 11:11:15 +02:00
Alistair Leslie-Hughes 688ba6ae31 sapi: Implement ISpObjectToken GetId. 2022-10-10 11:10:01 +02:00
Alistair Leslie-Hughes 01b4286f82 sapi: Store the token id in ISpObjectToken SetId. 2022-10-10 11:10:01 +02:00
David Kahurani fa591d3c56 xmllite/writer: Properly validate DocType name.
Current code skips a character and goes on to run is_namechar the next
instead of the current character ultimately always running a null
string on is_namechar and therefore always returning error on
multi-character strings

Signed-off-by: David Kahurani <k.kahurani@gmail.com>
2022-10-10 11:07:46 +02:00
Marcus Meissner b402ce8944 ntdll: Fix GetTempPathW() call passing wrong unit for the buffer size.
Signed-off-by: Marcus Meissner <marcus@jet.franken.de>
2022-10-10 11:06:46 +02:00
Zebediah Figura ec6b6f38be d3d8: Use a separate draw texture for managed resources. 2022-10-10 11:03:57 +02:00
Zebediah Figura 520daf8630 d3d8: Add reference counting helpers for textures. 2022-10-10 11:03:57 +02:00
Zebediah Figura 99cee90c19 d3d8: Introduce a d3d8_texture_preload() helper. 2022-10-10 11:03:57 +02:00