Commit graph

910 commits

Author SHA1 Message Date
Hugh McMaster b8b87e55a6 regedit: Limit REG_DWORD/REG_QWORD input length by value type and format. 2022-07-28 17:34:03 +02:00
Hugh McMaster e604f3e2ef regedit: Use zero as a REG_DWORD/REG_QWORD default if edit control is empty. 2022-07-28 17:34:03 +02:00
Hugh McMaster 93199da8c3 regedit: Use zero as a default for REG_DWORD and REG_QWORD values. 2022-07-27 23:07:06 +02:00
Hugh McMaster 57f45013d8 regedit: Free temporary buffer when working with REG_DWORD and REG_QWORD values. 2022-07-26 22:37:48 +02:00
Hugh McMaster 6901f3ccfc regedit: Update the listview item without reloading the value data. 2022-07-25 17:01:33 +02:00
Hugh McMaster d1bc3623e8 regedit: Set the dlgproc value name via a function, not a global. 2022-07-25 17:01:33 +02:00
Hugh McMaster 5e2c3dd537 regedit: Update binary data via update_registry_value(). 2022-07-25 17:01:33 +02:00
Hugh McMaster 97f10736db regedit: Use 'struct edit_params' with read_value().
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-21 23:03:29 +02:00
Hugh McMaster becf11084f regedit: Pass updated REG_MULTI_SZ data via 'struct edit_params'.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-21 23:03:29 +02:00
Hugh McMaster 72fced0236 regedit: Pass updated REG_SZ and REG_EXPAND_SZ data via 'struct edit_params'.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-21 23:03:29 +02:00
Hugh McMaster b00a4b66b9 regedit: Use a separate dialog proc function for string data types.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-21 23:03:29 +02:00
Hugh McMaster a6063f8367 regedit: Replace heap_x*() functions with malloc(), realloc() and free().
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-07 19:11:38 +02:00
Hugh McMaster 97a3802093 regedit: Directly use RegQueryValueExW() instead of a helper function.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-07-06 20:32:39 +02:00
Hugh McMaster 101fe51b25 regedit: Correctly calculate REG_MULTI_SZ size before reading from the buffer.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-06 20:32:39 +02:00
Hugh McMaster 159f3699ec regedit: Remove unneeded valueDataLen override for DWORD values.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-06 20:32:39 +02:00
Hugh McMaster ab03ecf7bc regedit: Allow renaming of values in root keys.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-06-30 19:02:17 +02:00
Hugh McMaster e06a62049e regedit: Use correct printf specifier for UINT64 (QWORD) values.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-06-29 23:23:41 +02:00
Hugh McMaster 9c30f3d97a regedit: Pass correct data size when adding a new value via the GUI.
This bug was exposed by 3b1faf59f6

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-06-29 23:23:41 +02:00
Nikolay Sivov 208f631cee regedit: Remove unnecessary string conversion when modifying REG_DWORD value.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2022-06-24 10:41:27 +02:00
Nikolay Sivov 3b1faf59f6 regedit: Add support for REG_QWORD type.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2022-06-24 10:41:27 +02:00
Eric Pouech b111fab953 regedit: Use OEM code page for output.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-05-02 11:47:32 +02:00
Hugh McMaster 498e0da095 regedit: Remove unused WCHAR szHexEditClass from main header.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-04-19 17:39:37 +02:00
Hugh McMaster 4b964b8210 regedit: Mark WCHAR szTitle static.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-04-19 17:39:34 +02:00
Hugh McMaster a6a92b66c7 regedit: Mark WCHAR szFrameClass static.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-04-19 17:39:29 +02:00
Hugh McMaster f55131db39 regedit: Use wide character string literals in regproc.c.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-04-19 17:39:23 +02:00
Hugh McMaster 379c90a0eb regedit: Use wide character string literals in main.c.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-04-19 17:39:17 +02:00
Hugh McMaster 85fb14ff28 regedit: Use wide character string literals in treeview.c.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-04-19 17:38:57 +02:00
Hugh McMaster 039fc87827 regedit: Use wide character string literals in regedit.c.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-04-19 17:38:50 +02:00
Hugh McMaster 49df6ad509 regedit: Use wide character string literals in listview.c.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-04-19 17:38:44 +02:00
Hugh McMaster f0d9999581 regedit: Use wide character string literals in hexedit.c.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-04-19 17:38:39 +02:00
Hugh McMaster 5cc628e2be regedit: Use wide character string literals in framewnd.c.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-04-19 17:38:34 +02:00
Hugh McMaster 789cf28375 regedit: Use wide character string literals in edit.c.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-04-19 17:38:29 +02:00
Hugh McMaster 6b6d084bd4 regedit: Use wide character string literals in childwnd.c.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-04-19 17:38:23 +02:00
Eric Pouech f158558d19 regedit: Enable compilation with long types.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-02-04 11:20:33 +01:00
Eric Pouech acdbe6c296 regedit/tests: Enable compilation with long types.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-02-03 17:19:41 +01:00
Alexandre Julliard f0cd33c69e include: Add support for defining Win32 types as 'long' where possible.
Add -DWINE_NO_LONG_TYPES to modules that still have compilation
warnings with long types.

Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-01-27 20:38:22 +01:00
Alexandre Julliard 8667b8d124 regedit: Use the standard va_list instead of __ms_va_list.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-10-25 11:01:38 +02:00
Alexandre Julliard 088a787a2c makefiles: Make -mno-cygwin the default.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-09-20 22:45:48 +02:00
Zhiyi Zhang 190467d6af regedit: Add system DPI awareness settings to the application manifest.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-09-07 10:16:56 +02:00
Zhiyi Zhang f623608f9f regedit: Enable visual styles.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-06-10 23:04:03 +02:00
Hugh McMaster c1733540d6 regedit: Allow deletion of selected values without focus.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-06-08 22:28:44 +02:00
Alexandre Julliard 8f2f59eee1 regedit: 64-bit regedit.exe is in c:\windows.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50933
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-04-06 12:39:28 +02:00
Hugh McMaster b8b7979f9c regedit: Stop parsing REG_SZ values containing NUL character sequences.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-03-12 12:49:39 +01:00
Hugh McMaster 7eb77bef05 regedit/tests: Add tests for escaped null characters.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-03-11 13:13:35 +01:00
Hugh McMaster d1fbb6b999 regedit/tests: Remove elevated user checks from the Windows 3.1 test sequences.
The tests only run if regedit.exe is started with elevated privileges.
This is determined when the test suite is invoked.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-25 08:57:02 +01:00
Hugh McMaster bedd54c968 regedit/tests: Comprehensively check for elevated privileges before starting tests.
Calls to regedit.exe on user accounts with standard privileges trigger a UAC
prompt. Not responding to the prompt eventually causes a test timeout, so
use registry API calls to determine if the tests are running with elevated
privileges.

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-25 08:56:59 +01:00
Hugh McMaster ee579a0f1d regedit/tests: Add tests for forward and back slashes in key and value names.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-23 10:03:58 +01:00
Hugh McMaster 704bd45da5 regedit/tests: Add additional tests with embedded NUL characters.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-23 10:03:56 +01:00
Hugh McMaster 294be8b7a2 regedit/tests: Use delete_key() and delete_tree() where possible.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-23 10:03:53 +01:00
Hugh McMaster a3b1743ced regedit/tests: Replace RegCloseKey() with the helper function close_key().
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-02-23 10:03:49 +01:00