Commit graph

96 commits

Author SHA1 Message Date
Alex Henrie
3d383c468b regedit: Fix memory leak on error path in RenameKey (scan-build).
parentPath is allocated before parentKey.
2023-06-29 13:57:39 +02:00
Hugh McMaster
b8b87e55a6 regedit: Limit REG_DWORD/REG_QWORD input length by value type and format. 2022-07-28 17:34:03 +02:00
Hugh McMaster
e604f3e2ef regedit: Use zero as a REG_DWORD/REG_QWORD default if edit control is empty. 2022-07-28 17:34:03 +02:00
Hugh McMaster
93199da8c3 regedit: Use zero as a default for REG_DWORD and REG_QWORD values. 2022-07-27 23:07:06 +02:00
Hugh McMaster
57f45013d8 regedit: Free temporary buffer when working with REG_DWORD and REG_QWORD values. 2022-07-26 22:37:48 +02:00
Hugh McMaster
6901f3ccfc regedit: Update the listview item without reloading the value data. 2022-07-25 17:01:33 +02:00
Hugh McMaster
d1bc3623e8 regedit: Set the dlgproc value name via a function, not a global. 2022-07-25 17:01:33 +02:00
Hugh McMaster
5e2c3dd537 regedit: Update binary data via update_registry_value(). 2022-07-25 17:01:33 +02:00
Hugh McMaster
97f10736db regedit: Use 'struct edit_params' with read_value().
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-21 23:03:29 +02:00
Hugh McMaster
becf11084f regedit: Pass updated REG_MULTI_SZ data via 'struct edit_params'.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-21 23:03:29 +02:00
Hugh McMaster
72fced0236 regedit: Pass updated REG_SZ and REG_EXPAND_SZ data via 'struct edit_params'.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-21 23:03:29 +02:00
Hugh McMaster
b00a4b66b9 regedit: Use a separate dialog proc function for string data types.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-21 23:03:29 +02:00
Hugh McMaster
a6063f8367 regedit: Replace heap_x*() functions with malloc(), realloc() and free().
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-07 19:11:38 +02:00
Hugh McMaster
97a3802093 regedit: Directly use RegQueryValueExW() instead of a helper function.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-07-06 20:32:39 +02:00
Hugh McMaster
101fe51b25 regedit: Correctly calculate REG_MULTI_SZ size before reading from the buffer.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-06 20:32:39 +02:00
Hugh McMaster
159f3699ec regedit: Remove unneeded valueDataLen override for DWORD values.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-07-06 20:32:39 +02:00
Hugh McMaster
9c30f3d97a regedit: Pass correct data size when adding a new value via the GUI.
This bug was exposed by 3b1faf59f6

Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
2022-06-29 23:23:41 +02:00
Nikolay Sivov
208f631cee regedit: Remove unnecessary string conversion when modifying REG_DWORD value.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2022-06-24 10:41:27 +02:00
Nikolay Sivov
3b1faf59f6 regedit: Add support for REG_QWORD type.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
2022-06-24 10:41:27 +02:00
Hugh McMaster
789cf28375 regedit: Use wide character string literals in edit.c.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-04-19 17:38:29 +02:00
Eric Pouech
f158558d19 regedit: Enable compilation with long types.
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-02-04 11:20:33 +01:00
Alexandre Julliard
8667b8d124 regedit: Use the standard va_list instead of __ms_va_list.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2021-10-25 11:01:38 +02:00
Alexandre Julliard
0b18409cfc regedit: Use C runtime wchar functions instead of wine/unicode.h.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-04-01 11:48:30 +02:00
Alistair Leslie-Hughes
75d8081dc6 regedit: Grow the buffer when modifying a DWORD value.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=19098
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2019-03-21 08:23:57 +01:00
Hugh McMaster
6b620e6d61 regedit: Do not overwrite a hex data type with REG_BINARY when modifying a value.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 21:28:45 +02:00
Hugh McMaster
a131cff7a8 regedit: Replace Hungarian notation used with struct edit_params members.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 21:28:45 +02:00
Hugh McMaster
32f487bdb2 regedit: Always display DWORD values in hexadecimal when initializing the editor dialog.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 21:28:45 +02:00
Hugh McMaster
1291c6ded4 regedit: Don't check if heap_xalloc() succeeded in the caller.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-07-16 21:28:44 +02:00
Hugh McMaster
c7718d31c7 regedit: Pass NULL instead of the address of an empty WCHAR.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-28 22:08:23 +02:00
Hugh McMaster
cc200d0a50 regedit: Confirm whether to delete a registry value from framewnd.c.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-28 22:08:23 +02:00
Hugh McMaster
5bc81188fe regedit: Do not directly include resource.h anymore.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-23 17:33:57 +02:00
Hugh McMaster
a926e05446 regedit: Do not directly include stdio.h any longer.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:28:07 +02:00
Hugh McMaster
20e5b9e82f regedit: Simplify boolean comparisons in edit.c.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:27:58 +02:00
Hugh McMaster
b24ee836bd regedit: Simplify the detection of existing registry values.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:27:19 +02:00
Hugh McMaster
73220a3d6f regedit: Remove regproc.h.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:26:01 +02:00
Hugh McMaster
78732a6d46 regedit: Replace the COUNT_OF macro with ARRAY_SIZE.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-05-21 16:22:34 +02:00
Zebediah Figura
31e41a942e regedit: Use monospace font for hex edit dialog.
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-03-12 18:02:45 +01:00
Michael Stefaniuc
505a9e0283 regedit: Use the global HeapAlloc() wrappers.
Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2018-02-07 10:06:12 +01:00
Alexandre Julliard
7344ac9b72 regedit: Use WINAPIV calling convention for variadic functions.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-11-02 10:21:53 +01:00
Hugh McMaster
efb8d0b497 regedit: Allow editing of all hex data types.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-08-08 20:13:56 +09:00
Hugh McMaster
6238cd46f2 regedit: Use the heap_*() functions in edit.c where possible.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-27 17:04:04 +02:00
Hugh McMaster
c4a06a3034 regedit: Update string resources associated with key deletion.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-07-12 19:51:54 +02:00
Hugh McMaster
b25337e6d6 regedit: Free the binary data buffer after saving the new value (Coverity).
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-28 18:23:04 +02:00
Hugh McMaster
cb563dbac6 regedit: Re-insert the default value item after deleting its data.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-16 15:25:38 +02:00
Hugh McMaster
b1e48fb469 regedit: Free the stringValueData buffer before using it again (Coverity).
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-06-15 15:02:14 +02:00
Hugh McMaster
9cd1fc3fc4 regedit: Update the data in a listview subitem without refreshing the listview.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-30 21:49:50 +02:00
Hugh McMaster
f3c4cca7bf regedit: Add listview entries without refreshing the listview.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-05-30 21:49:50 +02:00
Nikolay Sivov
71a6eeb732 regedit: Make it clear whether it is a key or a value that is about to be removed.
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-17 20:54:05 +01:00
Hugh McMaster
8ce48b9fcd regedit: Update some comments in edit.c.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-01 16:40:17 +01:00
Hugh McMaster
93b08c6289 regedit: Update dialog messages related to key and value renaming.
Signed-off-by: Hugh McMaster <hugh.mcmaster@outlook.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2017-02-01 16:40:12 +01:00