system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-10-04 21:17:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

msxml3: createProcessingInstruction: Check arguments are valid.

Browse source
This commit is contained in:
Alistair Leslie-Hughes 2008-01-08 11:07:12 +11:00 committed by Alexandre Julliard
parent 91ad27ea25
commit f31cd30841
2 changed files with 32 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
dlls/msxml3/domdoc.c
View file

@ -958,6 +958,12 @@ static HRESULT WINAPI domdoc_createProcessingInstruction(
TRACE("%p->(%s %s %p)\n", iface, debugstr_w(target), debugstr_w(data), pi);
if(!pi)
return E_INVALIDARG;
if(!target || lstrlenW(target) == 0)
return E_FAIL;
xml_target = xmlChar_from_wchar((WCHAR*)target);
xml_content = xmlChar_from_wchar((WCHAR*)data);

26
dlls/msxml3/tests/domdoc.c
View file

@ -348,6 +348,7 @@ static void test_domdoc( void )
IXMLDOMComment *node_comment = NULL;
IXMLDOMAttribute *node_attr = NULL;
IXMLDOMNode *nodeChild = NULL;
IXMLDOMProcessingInstruction *nodePI = NULL;
VARIANT_BOOL b;
VARIANT var;
BSTR str;
@ -548,6 +549,31 @@ static void test_domdoc( void )
ok( r == S_OK, "returns %08x\n", r );
IXMLDOMText_Release( node_attr);
/* test Processing Instruction */
str = SysAllocStringLen(NULL, 0);
r = IXMLDOMDocument_createProcessingInstruction(doc, str, str, NULL);
ok( r == E_INVALIDARG, "returns %08x\n", r );
r = IXMLDOMDocument_createProcessingInstruction(doc, NULL, str, &nodePI);
ok( r == E_FAIL, "returns %08x\n", r );
r = IXMLDOMDocument_createProcessingInstruction(doc, str, str, &nodePI);
ok( r == E_FAIL, "returns %08x\n", r );
SysFreeString(str);
r = IXMLDOMDocument_createProcessingInstruction(doc, _bstr_("xml"), _bstr_("version=\"1.0\""), &nodePI);
ok( r == S_OK, "returns %08x\n", r );
if(nodePI)
{
/* Last Child Checks */
r = IXMLDOMProcessingInstruction_get_lastChild(nodePI, NULL);
ok(r == E_INVALIDARG, "ret %08x\n", r );
nodeChild = (IXMLDOMNode*)0x1;
r = IXMLDOMProcessingInstruction_get_lastChild(nodePI, &nodeChild);
ok(r == S_FALSE, "ret %08x\n", r );
ok(nodeChild == NULL, "nodeChild not NULL\n");
}
IXMLDOMProcessingInstruction_Release(nodePI);
r = IXMLDOMDocument_Release( doc );
ok( r == 0, "document ref count incorrect\n");