system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-10-06 16:45:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

oleview: Use standard APIs in SaveIdl and avoid overflows.

Browse source
This commit is contained in:
Alexandre Julliard 2007-03-13 21:17:03 +01:00
parent ea8e860903
commit f0ddaedc29
1 changed files with 9 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
programs/oleview/typelib.c
View file

@ -117,8 +117,9 @@ static void SaveIdl(WCHAR *wszFileName)
HTREEITEM hIDL;
TVITEM tvi;
HANDLE hFile;
DWORD dwNumWrite;
DWORD len, dwNumWrite;
char *wszIdl;
TYPELIB_DATA *data;
hIDL = TreeView_GetChild(typelib.hTree, TVI_ROOT);
@ -126,31 +127,24 @@ static void SaveIdl(WCHAR *wszFileName)
tvi.hItem = hIDL;
SendMessage(typelib.hTree, TVM_GETITEM, 0, (LPARAM)&tvi);
data = (TYPELIB_DATA *)tvi.lParam;
hFile = CreateFile(wszFileName, GENERIC_WRITE, FILE_SHARE_WRITE,
NULL, OPEN_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);
NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL);
if(hFile == INVALID_HANDLE_VALUE)
{
ShowLastError();
return;
}
wszIdl = HeapAlloc(GetProcessHeap(), 0,
sizeof(WCHAR)*((TYPELIB_DATA *)(tvi.lParam))->idlLen);
wine_utf8_wcstombs(((TYPELIB_DATA *)(tvi.lParam))->idl,
((TYPELIB_DATA *)(tvi.lParam))->idlLen, wszIdl,
((TYPELIB_DATA *)(tvi.lParam))->idlLen);
len = WideCharToMultiByte( CP_UTF8, 0, data->idl, data->idlLen, NULL, 0, NULL, NULL );
wszIdl = HeapAlloc(GetProcessHeap(), 0, len);
WideCharToMultiByte( CP_UTF8, 0, data->idl, data->idlLen, wszIdl, len, NULL, NULL );
if(!WriteFile(hFile, wszIdl, ((TYPELIB_DATA *)(tvi.lParam))->idlLen,
&dwNumWrite, NULL))
{
ShowLastError();
HeapFree(GetProcessHeap(), 0, wszIdl);
return;
}
if(!WriteFile(hFile, wszIdl, len, &dwNumWrite, NULL))
ShowLastError();
HeapFree(GetProcessHeap(), 0, wszIdl);
SetEndOfFile(hFile);
CloseHandle(hFile);
}