system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-10-01 19:52:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

appwiz: Fix memory leak on realloc failure in install_from_registered_dir (cppcheck).

Browse source
This commit is contained in:
Alex Henrie 2022-11-28 22:05:13 -07:00 committed by Alexandre Julliard
parent 9c5e380cfe
commit e7ba00c7ca
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
dlls/appwiz.cpl/addons.c
View file

@ -255,7 +255,7 @@ static HKEY open_config_key(void)
static enum install_res install_from_registered_dir(void)
{
char *package_dir;
char *package_dir, *new_package_dir;
HKEY hkey;
DWORD res, type, size = MAX_PATH;
enum install_res ret;
@ -267,8 +267,11 @@ static enum install_res install_from_registered_dir(void)
package_dir = malloc(size);
res = RegGetValueA(hkey, NULL, addon->dir_config_key, RRF_RT_ANY, &type, (PBYTE)package_dir, &size);
if(res == ERROR_MORE_DATA) {
package_dir = realloc(package_dir, size);
res = RegGetValueA(hkey, NULL, addon->dir_config_key, RRF_RT_ANY, &type, (PBYTE)package_dir, &size);
new_package_dir = realloc(package_dir, size);
if(new_package_dir) {
package_dir = new_package_dir;
res = RegGetValueA(hkey, NULL, addon->dir_config_key, RRF_RT_ANY, &type, (PBYTE)package_dir, &size);
}
}
RegCloseKey(hkey);
if(res == ERROR_FILE_NOT_FOUND) {