system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-09-01 15:53:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

d3d11/tests: Move the is_warp_device() call out of the loop in check_format_support().

Browse source 
There's no point in querying this multiple times, it's not going to change.

Perhaps more importantly, calling is_warp_device() inside a todo_wine block
will cause "Test succeeded inside todo block: ..." messages from
get_device_adapter_desc(). These appear to have been introduced by commit
fcc276ecb1. Arguably get_device_adapter_desc()
shouldn't use ok() in the first place.
This commit is contained in:
Henri Verbeet 2022-09-14 11:34:27 +02:00 committed by Alexandre Julliard
parent 7d20333faf
commit e5f5bea390
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
dlls/d3d11/tests/d3d11.c
View file

@ -20961,6 +20961,7 @@ static void check_format_support(ID3D11Device *device, const unsigned int *forma
D3D_FEATURE_LEVEL feature_level, const struct format_support *formats,
unsigned int format_count, unsigned int feature_flag, const char *feature_name)
{
BOOL warp = is_warp_device(device);
unsigned int i;
for (i = 0; i < format_count; ++i)
@ -20971,7 +20972,7 @@ static void check_format_support(ID3D11Device *device, const unsigned int *forma
if (formats[i].fl_required <= feature_level)
{
todo_wine_if (feature_flag == D3D11_FORMAT_SUPPORT_DISPLAY)
ok(supported || broken(is_warp_device(device)),
ok(supported || broken(warp),
"Format %#x - %s not supported, format support %#x.\n",
format, feature_name, format_support[format]);
continue;