system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-09-19 13:10:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

d3d8: Avoid calling wined3d_device_process_vertices() with unmappable source buffers.

Browse source 
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Henri Verbeet 2019-01-08 21:57:43 +03:30 committed by Alexandre Julliard
parent 36180aa195
commit dc3221a9c8
2 changed files with 42 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
dlls/d3d8/device.c
View file

@ -2592,14 +2592,54 @@ static HRESULT WINAPI d3d8_device_ProcessVertices(IDirect3DDevice8 *iface, UINT
{
struct d3d8_device *device = impl_from_IDirect3DDevice8(iface);
struct d3d8_vertexbuffer *dst = unsafe_impl_from_IDirect3DVertexBuffer8(dst_buffer);
struct d3d8_vertexbuffer *d3d8_buffer;
struct wined3d_buffer *wined3d_buffer;
unsigned int i, offset, stride, map;
HRESULT hr;
TRACE("iface %p, src_start_idx %u, dst_idx %u, vertex_count %u, dst_buffer %p, flags %#x.\n",
iface, src_start_idx, dst_idx, vertex_count, dst_buffer, flags);
wined3d_mutex_lock();
/* Note that an alternative approach would be to simply create these
* buffers with WINED3D_RESOURCE_ACCESS_MAP_R and update them here like we
* do for draws. In some regards that would be easier, but it seems less
* than optimal to upload data to the GPU only to subsequently download it
* again. */
map = device->sysmem_vb;
while (map)
{
i = ffs(map) - 1;
map ^= 1u << i;
if (FAILED(wined3d_device_get_stream_source(device->wined3d_device,
i, &wined3d_buffer, &offset, &stride)))
ERR("Failed to get stream source.\n");
d3d8_buffer = wined3d_buffer_get_parent(wined3d_buffer);
if (FAILED(wined3d_device_set_stream_source(device->wined3d_device,
i, d3d8_buffer->wined3d_buffer, offset, stride)))
ERR("Failed to set stream source.\n");
}
hr = wined3d_device_process_vertices(device->wined3d_device, src_start_idx, dst_idx,
vertex_count, dst->wined3d_buffer, NULL, flags, dst->fvf);
map = device->sysmem_vb;
while (map)
{
i = ffs(map) - 1;
map ^= 1u << i;
if (FAILED(wined3d_device_get_stream_source(device->wined3d_device,
i, &wined3d_buffer, &offset, &stride)))
ERR("Failed to get stream source.\n");
d3d8_buffer = wined3d_buffer_get_parent(wined3d_buffer);
if (FAILED(wined3d_device_set_stream_source(device->wined3d_device,
i, d3d8_buffer->draw_buffer, offset, stride)))
ERR("Failed to set stream source.\n");
}
wined3d_mutex_unlock();
return hr;

4
dlls/d3d8/tests/visual.c
View file

@ -10596,12 +10596,12 @@ static void test_sysmem_draw(void)
ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr);
hr = IDirect3DDevice8_ProcessVertices(device, 0, 0, ARRAY_SIZE(quad), dst_vb, 0);
todo_wine ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr);
ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr);
hr = IDirect3DVertexBuffer8_Lock(dst_vb, 0, 0, (BYTE **)&dst_data, 0);
ok(hr == D3D_OK, "Got unexpected hr %#x.\n", hr);
for (i = 0; i < ARRAY_SIZE(quad); ++i)
{
todo_wine ok(compare_vec4(&dst_data[i], quad[i].position.x * 320.0f + 320.0f,
ok(compare_vec4(&dst_data[i], quad[i].position.x * 320.0f + 320.0f,
-quad[i].position.y * 240.0f + 240.0f, 0.0f, 1.0f, 4),
"Got unexpected vertex %u {%.8e, %.8e, %.8e, %.8e}.\n",
i, dst_data[i].x, dst_data[i].y, dst_data[i].z, dst_data[i].w);