system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-07-23 21:26:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

vbscript: Avoid double frees on error path (Coverity).

Browse source 
Signed-off-by: Sven Baars <sbaars@codeweavers.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Sven Baars 2020-10-04 22:35:31 +02:00 committed by Alexandre Julliard
parent 4ca80c2f9e
commit da6a18ecb5
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
dlls/vbscript/global.c
View file

@ -2423,7 +2423,6 @@ static HRESULT Global_Split(BuiltinDisp *This, VARIANT *args, unsigned args_cnt,
}
hres = SafeArrayAccessData(sa, (void**)&data);
if(FAILED(hres)) {
SafeArrayDestroy(sa);
goto error;
}
@ -2440,7 +2439,6 @@ static HRESULT Global_Split(BuiltinDisp *This, VARIANT *args, unsigned args_cnt,
hres = VariantCopyInd(data+i, &var);
if(FAILED(hres)) {
SafeArrayUnaccessData(sa);
SafeArrayDestroy(sa);
goto error;
}
start = indices[i]+delimiterlen;
@ -2452,7 +2450,7 @@ error:
V_VT(res) = VT_ARRAY|VT_VARIANT;
V_ARRAY(res) = sa;
}else {
if (sa) SafeArrayDestroy(sa);
SafeArrayDestroy(sa);
}
heap_free(indices);