system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-10-06 08:54:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

rtworkq: Release thread pool work object when work_item is destroyed (Valgrind).

Browse source
This commit is contained in:
Rémi Bernon 2023-05-12 09:38:47 +02:00 committed by Alexandre Julliard
parent f85c5f1c3a
commit cfff330604
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
dlls/rtworkq/queue.c
View file

@ -131,6 +131,7 @@ struct work_item
RTWQWORKITEM_KEY key; RTWQWORKITEM_KEY key;
LONG priority; LONG priority;
DWORD flags; DWORD flags;
TP_WORK *work_object;
PTP_SIMPLE_CALLBACK finalization_callback; PTP_SIMPLE_CALLBACK finalization_callback;
union union
{ {
@ -374,7 +375,6 @@ static void pool_queue_submit(struct queue *queue, struct work_item *item)
{ {
TP_CALLBACK_PRIORITY callback_priority; TP_CALLBACK_PRIORITY callback_priority;
TP_CALLBACK_ENVIRON_V3 env; TP_CALLBACK_ENVIRON_V3 env;
TP_WORK *work_object;
if (item->priority == 0) if (item->priority == 0)
callback_priority = TP_CALLBACK_PRIORITY_NORMAL; callback_priority = TP_CALLBACK_PRIORITY_NORMAL;
@ -389,8 +389,8 @@ static void pool_queue_submit(struct queue *queue, struct work_item *item)
we need finalization callback. */ we need finalization callback. */
if (item->finalization_callback) if (item->finalization_callback)
IUnknown_AddRef(&item->IUnknown_iface); IUnknown_AddRef(&item->IUnknown_iface);
work_object = CreateThreadpoolWork(standard_queue_worker, item, (TP_CALLBACK_ENVIRON *)&env); item->work_object = CreateThreadpoolWork(standard_queue_worker, item, (TP_CALLBACK_ENVIRON *)&env);
SubmitThreadpoolWork(work_object); SubmitThreadpoolWork(item->work_object);
TRACE("dispatched %p.\n", item->result); TRACE("dispatched %p.\n", item->result);
} }
@ -551,6 +551,8 @@ static ULONG WINAPI work_item_Release(IUnknown *iface)
if (!refcount) if (!refcount)
{ {
if (item->work_object)
CloseThreadpoolWork(item->work_object);
if (item->reply_result) if (item->reply_result)
IRtwqAsyncResult_Release(item->reply_result); IRtwqAsyncResult_Release(item->reply_result);
IRtwqAsyncResult_Release(item->result); IRtwqAsyncResult_Release(item->result);