system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-09-14 21:05:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

evr/sample: Avoid a race condition when releasing a tracked sample.

Browse source 
Same as b180775121.

Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Nikolay Sivov 2022-05-10 19:16:17 +03:00 committed by Alexandre Julliard
parent 1d7d3f58d6
commit ce71f5a05f
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
dlls/evr/sample.c
View file

@ -920,19 +920,21 @@ static ULONG WINAPI video_sample_AddRef(IMFSample *iface)
static ULONG WINAPI video_sample_Release(IMFSample *iface)
{
struct video_sample *sample = impl_from_IMFSample(iface);
ULONG refcount;
ULONG refcount = InterlockedDecrement(&sample->refcount);
IMFAsyncResult *tracked_result = NULL;
IMFSample_LockStore(sample->sample);
if (sample->tracked_result && sample->tracked_refcount == (sample->refcount - 1))
if (sample->tracked_result && sample->tracked_refcount == refcount)
{
video_sample_tracking_thread_invoke(sample->tracked_result);
IMFAsyncResult_Release(sample->tracked_result);
tracked_result = sample->tracked_result;
video_sample_tracking_thread_invoke(tracked_result);
sample->tracked_result = NULL;
sample->tracked_refcount = 0;
}
IMFSample_UnlockStore(sample->sample);
refcount = InterlockedDecrement(&sample->refcount);
if (tracked_result)
IMFAsyncResult_Release(tracked_result);
TRACE("%p, refcount %lu.\n", iface, refcount);