system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-09-15 08:04:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fusion: Fix a number of leaks in assembly_create.

Browse source
This commit is contained in:
Alexandre Julliard 2008-04-16 13:51:17 +02:00
parent a0bbf8477c
commit c889716979
1 changed files with 24 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
dlls/fusion/assembly.c
View file

@ -343,40 +343,52 @@ HRESULT assembly_create(ASSEMBLY **out, LPCWSTR file)
*out = NULL;
assembly = HeapAlloc(GetProcessHeap(), 0, sizeof(ASSEMBLY));
assembly = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(ASSEMBLY));
if (!assembly)
return E_OUTOFMEMORY;
ZeroMemory(assembly, sizeof(ASSEMBLY));
assembly->path = strdupWtoA(file);
if (!assembly->path)
return E_OUTOFMEMORY;
{
hr = E_OUTOFMEMORY;
goto failed;
}
assembly->hfile = CreateFileW(file, GENERIC_READ, FILE_SHARE_READ,
NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL);
if (!assembly->hfile)
return HRESULT_FROM_WIN32(GetLastError());
if (assembly->hfile == INVALID_HANDLE_VALUE)
{
hr = HRESULT_FROM_WIN32(GetLastError());
goto failed;
}
assembly->hmap = CreateFileMappingW(assembly->hfile, NULL, PAGE_READONLY,
0, 0, NULL);
if (!assembly->hmap)
return HRESULT_FROM_WIN32(GetLastError());
{
hr = HRESULT_FROM_WIN32(GetLastError());
goto failed;
}
assembly->data = MapViewOfFile(assembly->hmap, FILE_MAP_READ, 0, 0, 0);
if (!assembly->data)
return HRESULT_FROM_WIN32(GetLastError());
{
hr = HRESULT_FROM_WIN32(GetLastError());
goto failed;
}
hr = parse_pe_header(assembly);
if (FAILED(hr))
return hr;
if (FAILED(hr)) goto failed;
hr = parse_clr_metadata(assembly);
if (FAILED(hr))
return hr;
if (FAILED(hr)) goto failed;
*out = assembly;
return S_OK;
failed:
assembly_release( assembly );
return hr;
}
HRESULT assembly_release(ASSEMBLY *assembly)