system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-11-05 18:01:34 +00:00
Code Issues Projects Releases Packages Wiki Activity

quartz: Don't hold an extra reference in async_run_cb().

Browse source 
We don't actually need to, because we'll wait for the callback when stopping the graph.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49907
Signed-off-by: Zebediah Figura <z.figura12@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Zebediah Figura 2020-11-06 13:46:05 -06:00 committed by Alexandre Julliard
parent c837215382
commit c44173dd49
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
dlls/quartz/filtergraph.c
View file

@ -1837,7 +1837,6 @@ static void CALLBACK async_run_cb(TP_CALLBACK_INSTANCE *instance, void *context,
} }
LeaveCriticalSection(&graph->cs); LeaveCriticalSection(&graph->cs);
IUnknown_Release(graph->outer_unk);
} }
static HRESULT WINAPI MediaControl_Run(IMediaControl *iface) static HRESULT WINAPI MediaControl_Run(IMediaControl *iface)
@ -1897,7 +1896,6 @@ static HRESULT WINAPI MediaControl_Run(IMediaControl *iface)
if (!graph->async_run_work) if (!graph->async_run_work)
graph->async_run_work = CreateThreadpoolWork(async_run_cb, graph, NULL); graph->async_run_work = CreateThreadpoolWork(async_run_cb, graph, NULL);
graph->needs_async_run = 1; graph->needs_async_run = 1;
IUnknown_AddRef(graph->outer_unk);
SubmitThreadpoolWork(graph->async_run_work); SubmitThreadpoolWork(graph->async_run_work);
} }
else else
@ -5008,9 +5006,8 @@ static HRESULT WINAPI MediaFilter_Stop(IMediaFilter *iface)
LeaveCriticalSection(&graph->cs); LeaveCriticalSection(&graph->cs);
/* Don't cancel the callback; it's holding a reference to the graph. */
if (work) if (work)
WaitForThreadpoolWorkCallbacks(work, FALSE); WaitForThreadpoolWorkCallbacks(work, TRUE);
return hr; return hr;
} }
@ -5059,9 +5056,8 @@ static HRESULT WINAPI MediaFilter_Pause(IMediaFilter *iface)
LeaveCriticalSection(&graph->cs); LeaveCriticalSection(&graph->cs);
/* Don't cancel the callback; it's holding a reference to the graph. */
if (work) if (work)
WaitForThreadpoolWorkCallbacks(work, FALSE); WaitForThreadpoolWorkCallbacks(work, TRUE);
return hr; return hr;
} }