winecrt0: Remove free_delay_imports.

MSVC's delayimp.lib does not actually free delayload dependencies.
winecrt0's attempt to do so from ELF __attribute__((destructor))
is unnecessary and potentially harmful:

- When triggered naturally via LdrUnloadDll, this leads to recursive calls
  to FreeLibrary, violating free_lib_count and missing DLL_PROCESS_DETACH
- when triggered by glibc's _dl_fini (at process exit), it leads to
  use-after-free of the TEB (GetCurrentThreadID after the main thread is no longer Win32)
  via  FreeLibrary -> LdrLdrUnloadDll -> RtlEnterCriticalSection( &loader_section )
- double-free of the library itself, since the DLL_PROCESS_DETACH has
  already been handled by LdrShutdownProcess
- Race against wineserver sending a SIGKILL from process_killed,
  since all Win32 threads of the process have exited

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53032
This commit is contained in:
Kevin Puetz 2022-08-31 09:53:17 -05:00 committed by Alexandre Julliard
parent aeb9737388
commit b5d3759fc5

View file

@ -69,14 +69,4 @@ FARPROC WINAPI DECLSPEC_HIDDEN __wine_spec_delay_load( unsigned int id )
return proc;
}
#if defined(__GNUC__) && !defined(__APPLE__) /* we can't support destructors properly on Mac OS */
static void free_delay_imports(void) __attribute__((destructor));
static void free_delay_imports(void)
{
struct ImgDelayDescr *descr;
for (descr = __wine_spec_delay_imports; descr->szName; descr++)
if (*descr->phmod) FreeLibrary( *descr->phmod );
}
#endif
#endif /* __WINE_PE_BUILD */