diff --git a/documentation/patches.sgml b/documentation/patches.sgml index d0d03258b77..cfb8d6135eb 100644 --- a/documentation/patches.sgml +++ b/documentation/patches.sgml @@ -1,14 +1,12 @@ Submitting Patches - - Written by &name-albert-den-haan; &email-albert-den-haan; - Patch Format - Your patch should include: + Patches are submitted via email to the Wine patches mailing list, + wine-patches@winehq.org. Your patch should include: @@ -20,26 +18,25 @@ A long (paragraph) description of what was wrong and what is now - better (and now broken :). (recommended) + better. (recommended) - Change Log: A short description of what was changed. + A change log entry (short description of what was changed). - Your contact information ( Name/Handle and e-mail ) - - - - - The patch in diff -u format (it happens...) + The patch in diff -u format + + + + cvs diff -u works great for the common case where a file is edited. However, if you add or remove a file @@ -47,15 +44,14 @@ make sure you explicitly take care of this rare case. - For additions: mention that you have some new files and - include them by appending the + For additions simply include them by appending the diff -u /dev/null /my/new/file output of them to any cvs diff -u output you may have. Alternatively, use diff -Nu olddir/ newdir/ in case of multiple new files to add. - For removals, list the files. + For removals, clearly list the files in the description of the patch. Since wine is constantly changing due to development it is strongly @@ -182,7 +178,7 @@ code The basic rules are: no attachments, no mime crap, no line wrapping, a single patch per mail. Basically if I can't - do "cat raw_mail | patch -p0" it's in the + do "cat raw_mail | patch -p0" it's in the wrong format.