system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-10-06 09:17:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

localspl: Fix parameters validation in FILE StartDocPort.

Browse source
This commit is contained in:
Piotr Caban 2022-11-28 16:14:17 +01:00 committed by Alexandre Julliard
parent 604e7b4e77
commit aa4e9c39d2
2 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
dlls/localspl/localmon.c
View file

@ -509,7 +509,7 @@ static BOOL WINAPI localmon_StartDocPort(HANDLE hport, WCHAR *printer_name,
if (!doc_info || !doc_info->pOutputFile)
{
FIXME("set error\n");
SetLastError(ERROR_INVALID_PARAMETER);
return FALSE;
}

13
dlls/localspl/tests/localmon.c
View file

@ -914,9 +914,18 @@ static void test_file_port(void)
ok(!res, "WritePort succeeded\n");
ok(GetLastError() == ERROR_INVALID_HANDLE, "GetLastError() = %lu\n", GetLastError());
doc_info.pDocName = (WCHAR *)L"not used";
SetLastError(0xdeadbeef);
res = pStartDocPort(hport, printer_name, 1, 1, NULL);
ok(!res, "StartDocPort succeeded\n");
ok(GetLastError() == ERROR_INVALID_PARAMETER, "GetLastError() = %lu\n", GetLastError());
memset(&doc_info, 0, sizeof(doc_info));
SetLastError(0xdeadbeef);
res = pStartDocPort(hport, printer_name, 1, 1, (BYTE *)&doc_info);
ok(!res, "StartDocPort succeeded\n");
ok(GetLastError() == ERROR_INVALID_PARAMETER, "GetLastError() = %lu\n", GetLastError());
doc_info.pOutputFile = tempfileW;
doc_info.pDatatype = (WCHAR *)L"not used";
res = pStartDocPort(hport, printer_name, 1, 1, (BYTE *)&doc_info);
ok(res, "StartDocPort failed (%lu)\n", GetLastError());