system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-11-02 20:18:28 +00:00
Code Issues Projects Releases Packages Wiki Activity

oleaut32: Fix accessing beyond end of buffer and memory leak in test_DispCallFunc.

Browse source 
The parameter isn't automatically converted by DispCallFunc, so make
sure we pass in the correct size of memory for the function to store
its BSTR in.
This commit is contained in:
Rob Shearman 2009-11-29 10:21:35 +00:00 committed by Alexandre Julliard
parent db33e8fdd9
commit a94265e5a9
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
dlls/oleaut32/tests/tmarshal.c
View file

@ -1388,7 +1388,7 @@ static void test_DispCallFunc(void)
V_VT(&vararg[0]) = VT_R8;
V_R8(&vararg[0]) = 3.141;
V_VT(&vararg[1]) = VT_BSTR;
V_BSTR(&vararg[1]) = SysAllocString(szEmpty);
V_BSTRREF(&vararg[1]) = CoTaskMemAlloc(sizeof(BSTR));
V_VT(&vararg[2]) = VT_BSTR;
V_BSTR(&vararg[2]) = SysAllocString(szEmpty);
V_VT(&vararg[3]) = VT_VARIANT|VT_BYREF;
@ -1399,7 +1399,8 @@ static void test_DispCallFunc(void)
hr = DispCallFunc(pWidget, 9*sizeof(void*), CC_STDCALL, VT_UI4, 4, rgvt, rgpvarg, &varresult);
ok_ole_success(hr, DispCallFunc);
VariantClear(&varresult);
VariantClear(&vararg[1]);
SysFreeString(*V_BSTRREF(&vararg[1]));
CoTaskMemFree(V_BSTRREF(&vararg[1]));
VariantClear(&vararg[2]);
IWidget_Release(pWidget);
}