From a6e4c094d0002e35f9a70902565c4896d2a6ab83 Mon Sep 17 00:00:00 2001 From: Marcus Meissner Date: Mon, 7 Jan 2013 22:17:36 +0100 Subject: [PATCH] advpack: Avoid using sessions uninitialized (Coverity). --- dlls/advpack/files.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/advpack/files.c b/dlls/advpack/files.c index c34f6d566cc..a1d52f8ace4 100644 --- a/dlls/advpack/files.c +++ b/dlls/advpack/files.c @@ -708,6 +708,8 @@ HRESULT WINAPI ExtractFilesA(LPCSTR CabName, LPCSTR ExpandDir, DWORD Flags, if (!hCabinet) return E_FAIL; + ZeroMemory(&session, sizeof(SESSION)); + pExtract = (void *)GetProcAddress(hCabinet, "Extract"); if (!pExtract) { @@ -715,7 +717,6 @@ HRESULT WINAPI ExtractFilesA(LPCSTR CabName, LPCSTR ExpandDir, DWORD Flags, goto done; } - ZeroMemory(&session, sizeof(SESSION)); lstrcpyA(session.Destination, ExpandDir); if (FileList)