system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-07-20 20:54:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

wbemprox: Fix a memory leak (Coverity).

Browse source 
When LsaLookupSids() fails with STATUS_NONE_MAPPED or STATUS_SOME_NOT_MAPPED, the memory returned by
the domain parameter should be freed.
This commit is contained in:
Zhiyi Zhang 2023-11-25 23:07:41 +08:00 committed by Alexandre Julliard
parent 1ab1c97087
commit a2fdae65a1
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
dlls/wbemprox/builtin.c
View file

@ -3982,6 +3982,7 @@ static enum fill_status fill_sid( struct table *table, const struct expr *cond )
const WCHAR *str;
struct record_sid *rec;
UINT len;
NTSTATUS status;
if (!(str = find_sid_str( cond ))) return FILL_STATUS_FAILED;
if (!resize_table( table, 1, sizeof(*rec) )) return FILL_STATUS_FAILED;
@ -3996,10 +3997,12 @@ static enum fill_status fill_sid( struct table *table, const struct expr *cond )
LocalFree( sid );
return FILL_STATUS_FAILED;
}
if (LsaLookupSids( handle, 1, &sid, &domain, &name ))
if ((status = LsaLookupSids( handle, 1, &sid, &domain, &name )))
{
LocalFree( sid );
LsaClose( handle );
if (status == STATUS_NONE_MAPPED || status == STATUS_SOME_NOT_MAPPED)
LsaFreeMemory( domain );
return FILL_STATUS_FAILED;
}