system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-09-15 02:59:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

hidclass.sys: Return STATUS_INVALID_USER_BUFFER when appropriate.

Browse source 
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Rémi Bernon 2021-08-03 18:55:19 +02:00 committed by Alexandre Julliard
parent 6f4ccd04cd
commit 9c5ab964e9
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
dlls/hidclass.sys/device.c
View file

@ -499,7 +499,12 @@ NTSTATUS WINAPI pdo_ioctl(DEVICE_OBJECT *device, IRP *irp)
BYTE *buffer = MmGetSystemAddressForMdlSafe(irp->MdlAddress, NormalPagePriority);
ULONG out_length;
if (!irpsp->Parameters.DeviceIoControl.OutputBufferLength || !buffer)
if (!buffer)
{
irp->IoStatus.Status = STATUS_INVALID_USER_BUFFER;
break;
}
if (!irpsp->Parameters.DeviceIoControl.OutputBufferLength)
{
irp->IoStatus.Status = STATUS_BUFFER_TOO_SMALL;
break;

2
dlls/ntoskrnl.exe/tests/ntoskrnl.c
View file

@ -2441,7 +2441,7 @@ static void test_hidp(HANDLE file, HANDLE async_file, int report_id, BOOL polled
SetLastError(0xdeadbeef);
ret = HidD_GetInputReport(file, report, 0);
ok(!ret, "HidD_GetInputReport succeeded\n");
todo_wine ok(GetLastError() == ERROR_INVALID_USER_BUFFER, "HidD_GetInputReport returned error %u\n", GetLastError());
ok(GetLastError() == ERROR_INVALID_USER_BUFFER, "HidD_GetInputReport returned error %u\n", GetLastError());
SetLastError(0xdeadbeef);
ret = HidD_GetInputReport(file, report, caps.InputReportByteLength - 1);