system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-10-14 19:27:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

msvcrt: Use memmove() instead of memcpy() puts_clbk_str().

Browse source 
memcpy() must not be used here, because results are undefined if the
memory areas overlap. This can cause problems, particularly if
particular compiler optimisations are enabled.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47918
Signed-off-by: Felix Hädicke <felixhaedicke@web.de>
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Felix Hädicke 2019-10-10 23:39:35 +02:00 committed by Alexandre Julliard
parent 8d6183c832
commit 90e520b418
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
dlls/msvcrt/printf.h
View file

@ -52,13 +52,13 @@ static int FUNC_NAME(puts_clbk_str)(void *ctx, int len, const APICHAR *str)
return len;
if(out->len < len) {
memcpy(out->buf, str, out->len*sizeof(APICHAR));
memmove(out->buf, str, out->len*sizeof(APICHAR));
out->buf += out->len;
out->len = 0;
return -1;
}
memcpy(out->buf, str, len*sizeof(APICHAR));
memmove(out->buf, str, len*sizeof(APICHAR));
out->buf += len;
out->len -= len;
return len;

4
dlls/msvcrt/wcs.c
View file

@ -781,13 +781,13 @@ static int puts_clbk_str_c99_a(void *ctx, int len, const char *str)
return len;
if(out->len < len) {
memcpy(out->buf, str, out->len);
memmove(out->buf, str, out->len);
out->buf += out->len;
out->len = 0;
return len;
}
memcpy(out->buf, str, len);
memmove(out->buf, str, len);
out->buf += len;
out->len -= len;
return len;