system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-07-22 11:54:10 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

dbghelp: Don't include global & static variables from S_LOCAL* records.

Browse source 
PDB supports description of a global or static variable:
- accessed from a register
- stored as a local variable record inside a function

This likely describes access to a global/static variable where
intermediate computation is kept in a register.

We cannot store this kind of entries in local variable lists
(builtin dbghelp and winedbg are not prepared to handle a global variable)

Note: the global or static Codeview data record is still present (with a
relocatable address), so the variable should still be available from global
access (but could be not up-to-date if temporarly stored in a register).

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
This commit is contained in:
Eric Pouech 2022-07-12 09:28:57 +02:00 committed by Alexandre Julliard
parent 437e73883b
commit 87e2b00774
1 changed files with 26 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
dlls/dbghelp/msc.c
View file

@ -1821,6 +1821,17 @@ static void codeview_xform_range(const struct msc_debug_info* msc_dbg,
locinfo->rangelen = adrange->cbRange;
}
static unsigned codeview_defrange_length(const union codeview_symbol* sym)
{
const union codeview_symbol* first_symrange = get_next_sym(sym);
const union codeview_symbol* symrange;
for (symrange = first_symrange;
symrange->generic.id >= S_DEFRANGE && symrange->generic.id <= S_DEFRANGE_REGISTER_REL;
symrange = get_next_sym(symrange)) {}
return (const char*)symrange - (const char*)first_symrange;
}
static unsigned codeview_transform_defrange(const struct msc_debug_info* msc_dbg,
struct symt_function* curr_func,
const union codeview_symbol* sym,
@ -2567,12 +2578,21 @@ static BOOL codeview_snarf(const struct msc_debug_info* msc_dbg,
}
break;
case S_LOCAL:
length += codeview_transform_defrange(msc_dbg, curr_func, sym, &loc);
symt_add_func_local(msc_dbg->module, curr_func,
sym->local_v3.varflags.is_param ? DataIsParam : DataIsLocal,
&loc, block,
codeview_get_type(sym->local_v3.symtype, FALSE),
sym->local_v3.name);
/* FIXME: don't store global/static variables accessed through registers... we don't support that
* in locals... anyway, global data record should be present as well (so variable will be avaible
* through global defintion, but potentially not updated)
*/
if (!sym->local_v3.varflags.enreg_global && !sym->local_v3.varflags.enreg_static)
{
length += codeview_transform_defrange(msc_dbg, curr_func, sym, &loc);
symt_add_func_local(msc_dbg->module, curr_func,
sym->local_v3.varflags.is_param ? DataIsParam : DataIsLocal,
&loc, block,
codeview_get_type(sym->local_v3.symtype, FALSE),
sym->local_v3.name);
}
else
length += codeview_defrange_length(sym);
break;
case S_INLINESITE:
{