system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-10-14 17:27:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

mscoree: Avoid using isdigit() for WCHARs.

Browse source 
Found with Coccinelle.

Signed-off-by: Akihiro Sagawa <sagawa.aki@gmail.com>
Signed-off-by: Vincent Povirk <vincent@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
This commit is contained in:
Akihiro Sagawa 2017-05-17 00:00:13 +09:00 committed by Alexandre Julliard
parent 373604f253
commit 83aca41eb5
1 changed files with 11 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
dlls/mscoree/metahost.c
View file

@ -818,6 +818,11 @@ static ULONG WINAPI CLRMetaHost_Release(ICLRMetaHost* iface)
return 1;
}
static inline BOOL isDigit(WCHAR c)
{
return c >= '0' && c <= '9';
}
static BOOL parse_runtime_version(LPCWSTR version, DWORD *major, DWORD *minor, DWORD *build)
{
*major = 0;
@ -827,28 +832,28 @@ static BOOL parse_runtime_version(LPCWSTR version, DWORD *major, DWORD *minor, D
if (version[0] == 'v' || version[0] == 'V')
{
version++;
if (!isdigit(*version))
if (!isDigit(*version))
return FALSE;
while (isdigit(*version))
while (isDigit(*version))
*major = *major * 10 + (*version++ - '0');
if (*version == 0)
return TRUE;
if (*version++ != '.' || !isdigit(*version))
if (*version++ != '.' || !isDigit(*version))
return FALSE;
while (isdigit(*version))
while (isDigit(*version))
*minor = *minor * 10 + (*version++ - '0');
if (*version == 0)
return TRUE;
if (*version++ != '.' || !isdigit(*version))
if (*version++ != '.' || !isDigit(*version))
return FALSE;
while (isdigit(*version))
while (isDigit(*version))
*build = *build * 10 + (*version++ - '0');
return *version == 0;