system/wine
system/wine
1
0
Fork 0
mirror of https://github.com/wine-mirror/wine synced 2024-07-08 20:06:18 +00:00
Code Issues Projects Releases Wiki Activity

Make FIXMEs more grep-able.

Browse Source
This commit is contained in:
Dimitrie O. Paun 2002-01-29 03:12:19 +00:00 committed by Alexandre Julliard
parent 3dbbb0b297
commit 693cca5d4d
26 changed files with 41 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
controls/button.c
View File

@ -617,7 +617,7 @@ static void BUTTON_DrawLabel(HWND hwnd, HDC hdc, UINT dtFlags, RECT *rc)
LONG style = GetWindowLongA( hwnd, GWL_STYLE );
WCHAR *text = NULL;
/* Fixme: To draw disabled label in Win31 look-and-feel, we probably
/* FIXME: To draw disabled label in Win31 look-and-feel, we probably
* must use DSS_MONO flag and COLOR_GRAYTEXT brush (or maybe DSS_UNION).
* I don't have Win31 on hand to verify that, so I leave it as is.
*/

2
controls/edit.c
View File

@ -365,7 +365,7 @@ static DWORD get_app_version(void)
info.dwOSVersionInfoSize = sizeof(OSVERSIONINFOW);
GetVersionExW( &info );
dwEmulatedVersion = MAKELONG( info.dwMinorVersion, info.dwMajorVersion );
/* fixme: this may not be 100% correct; see discussion on the
/* FIXME: this may not be 100% correct; see discussion on the
* wine developer list in Nov 1999 */
version = dwProcVersion < dwEmulatedVersion ? dwProcVersion : dwEmulatedVersion;
}

2
controls/menu.c
View File

@ -4382,7 +4382,7 @@ static BOOL SetMenuItemInfo_common(MENUITEM * menu,
if (lpmii->fMask & MIIM_STATE)
{
/* fixme: MFS_DEFAULT do we have to reset the other menu items? */
/* FIXME: MFS_DEFAULT do we have to reset the other menu items? */
menu->fState = lpmii->fState;
}

2
debugger/winedbg.c
View File

@ -780,7 +780,7 @@ static BOOL DEBUG_HandleDebugEvent(DEBUG_EVENT* de, LPDWORD cont)
DEBUG_CurrThread->process->handle,
de->u.DebugString.lpDebugStringData);
/* fixme unicode de->u.DebugString.fUnicode ? */
/* FIXME unicode de->u.DebugString.fUnicode ? */
DEBUG_Printf(DBG_CHN_TRACE, "%08lx:%08lx: output debug string (%s)\n",
de->dwProcessId, de->dwThreadId, buffer);
break;

2
dlls/advapi32/service.c
View File

@ -460,7 +460,7 @@ CreateServiceA( SC_HANDLE hSCManager, LPCSTR lpServiceName,
len += (strlen(&lpDependencies[len])+1);
} while (lpDependencies[len++]);
/* fixme: this should be unicode */
/* FIXME: this should be unicode */
r = RegSetValueExA(hKey, "Dependencies", 0, REG_MULTI_SZ,
lpDependencies, len );
if (r!=ERROR_SUCCESS)

2
dlls/comctl32/updown.c
View File

@ -815,7 +815,7 @@ static LRESULT WINAPI UpDownWindowProc(HWND hwnd, UINT message, WPARAM wParam,
case VK_UP:
case VK_DOWN:
UPDOWN_GetBuddyInt (hwnd);
/* Fixme: Paint the according button pressed for some time, like win95 does*/
/* FIXME: Paint the according button pressed for some time, like win95 does*/
UPDOWN_DoAction (hwnd, 1, wParam==VK_UP);
break;
}

2
dlls/commdlg/filedlg95.c
View File

@ -960,7 +960,7 @@ static LRESULT FILEDLG95_InitControls(HWND hwnd)
SendMessageA(fodInfos->DlgInfos.hwndTB, TB_BUTTONSTRUCTSIZE, (WPARAM) sizeof(TBBUTTON), 0);
/* fixme: use TB_LOADIMAGES when implemented */
/* FIXME: use TB_LOADIMAGES when implemented */
/* SendMessageA(fodInfos->DlgInfos.hwndTB, TB_LOADIMAGES, (WPARAM) IDB_VIEW_SMALL_COLOR, HINST_COMMCTRL);*/
SendMessageA(fodInfos->DlgInfos.hwndTB, TB_ADDBITMAP, (WPARAM) 12, (LPARAM) &tba[0]);
SendMessageA(fodInfos->DlgInfos.hwndTB, TB_ADDBITMAP, (WPARAM) 1, (LPARAM) &tba[1]);

2
dlls/msvcrt/file.c
View File

@ -960,7 +960,7 @@ int _stat(const char* path, struct _stat * buf)
memset(buf,0,sizeof(struct _stat));
/* FIXME: rdev isnt drive num,despite what the docs say-what is it?
Bon 011120: This fixme seems incorrect
Bon 011120: This FIXME seems incorrect
Also a letter as first char isn't enough to be classify
as drive letter
*/

2
dlls/msvideo/drawdib.c
View File

@ -1,7 +1,7 @@
/*
* Copyright 2000 Bradley Baetz
*
* Fixme: Some flags are ignored
* FIXME: Some flags are ignored
*
* Handle palettes
*/

6
dlls/oleaut32/typelib.c
View File

@ -687,7 +687,7 @@ typedef struct tagTLBVarDesc
VARDESC vardesc; /* lots of info on the variable and its attributes. */
BSTR Name; /* the name of this variable */
int HelpContext;
int HelpStringContext; /* fixme: where? */
int HelpStringContext; /* FIXME: where? */
BSTR HelpString;
int ctCustData;
TLBCustData * pCustData;/* linked list to cust data; */
@ -1635,7 +1635,7 @@ static void MSFT_DoVars(TLBContext *pcx, ITypeInfoImpl *pTI, int cFuncs,
(*pptvd)->vardesc.wVarFlags = pVarRec->Flags;
MSFT_GetTdesc(pcx, pVarRec->DataType,
&(*pptvd)->vardesc.elemdescVar.tdesc, pTI);
/* (*pptvd)->vardesc.lpstrSchema; is reserved (SDK) fixme?? */
/* (*pptvd)->vardesc.lpstrSchema; is reserved (SDK) FIXME?? */
if(pVarRec->VarKind == VAR_CONST ){
(*pptvd)->vardesc.u.lpvarValue=TLB_Alloc(sizeof(VARIANT));
MSFT_ReadValue((*pptvd)->vardesc.u.lpvarValue,
@ -2995,7 +2995,7 @@ static ULONG WINAPI ITypeLib2_fnRelease( ITypeLib2 *iface)
if (!This->ref)
{
/* fixme destroy child objects */
/* FIXME destroy child objects */
TRACE(" destroying ITypeLib(%p)\n",This);

2
dlls/oleaut32/typelib.h
View File

@ -127,7 +127,7 @@ typedef struct tagMSFT_TypeInfoBase {
INT16 cImplTypes; /* nr of implemented interfaces */
INT16 cbSizeVft; /* virtual table size, not including inherits */
/*050*/ INT size; /* size in bytes, at least for structures */
/* fixme: name of this field */
/* FIXME: name of this field */
INT datatype1; /* position in type description table */
/* or in base intefaces */
/* if coclass: offset in reftable */

2
dlls/quartz/avidec.c
View File

@ -247,7 +247,7 @@ static HRESULT AVIDec_GetOutputTypes( CTransformBaseImpl* pImpl, const AM_MEDIA_
TRACE("(%p) - use the input palette\n",This);
if ( pbiIn->bmiHeader.biBitCount != pbiOut->bmiHeader.biBitCount )
{
FIXME( "no palette...fixme?\n" );
FIXME( "no palette...FIXME?\n" );
return E_FAIL;
}
if ( pbiOut->bmiHeader.biClrUsed == 0 )

5
dlls/shell32/shell32_main.c
View File

@ -358,7 +358,7 @@ DWORD WINAPI SHGetFileInfoA(LPCSTR path,DWORD dwFileAttributes,
if (SUCCEEDED(hr))
{
hr = IExtractIconA_GetIconLocation(pei, (flags & SHGFI_OPENICON)? GIL_OPENICON : 0,szLoaction, MAX_PATH, &iIndex, &uFlags);
/* fixme what to do with the index? */
/* FIXME what to do with the index? */
if(uFlags != GIL_NOTFILENAME)
strcpy (psfi->szDisplayName, szLoaction);
@ -530,8 +530,7 @@ HICON WINAPI ExtractIconA( HINSTANCE hInstance, LPCSTR lpszExeFileName,
/*************************************************************************
* ExtractIconW [SHELL32.@]
*
* fixme
* is the filename is not a file return 1
* FIXME: if the filename is not a file return 1
*/
HICON WINAPI ExtractIconW( HINSTANCE hInstance, LPCWSTR lpszExeFileName,
UINT nIconIndex )

4
dlls/shell32/shell32_main.h
View File

@ -98,11 +98,11 @@ LPENUMIDLIST IEnumIDList_Constructor(LPCSTR,DWORD,DWORD);
LPEXTRACTICONA IExtractIconA_Constructor(LPITEMIDLIST);
HRESULT CreateStreamOnFile (LPCSTR pszFilename, IStream ** ppstm);
/* fixme: rename the functions when the shell32.dll has it's own exports namespace */
/* FIXME: rename the functions when the shell32.dll has it's own exports namespace */
HRESULT WINAPI SHELL32_DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID * ppv);
HRESULT WINAPI SHELL32_DllCanUnloadNow(void);
/* fixme: move away */
/* FIXME: move away */
#define ResultFromShort(i) MAKE_SCODE(SEVERITY_SUCCESS, 0, (USHORT)(i))
/* menu merging */

2
dlls/shell32/shellord.c
View File

@ -1001,7 +1001,7 @@ BOOL WINAPI ShellExecuteExA (LPSHELLEXECUTEINFOA sei)
/* FIXME: szCommandline should not be of a fixed size. Plus MAX_PATH is way too short! */
/* the commandline contains 'c:\Path\wordpad.exe "%1"' */
HCR_GetExecuteCommand(sei->lpClass, (sei->lpVerb) ? sei->lpVerb : "open", szCommandline, sizeof(szCommandline));
/* fixme: get the extension of lpFile, check if it fits to the lpClass */
/* FIXME: get the extension of lpFile, check if it fits to the lpClass */
TRACE("SEE_MASK_CLASSNAME->'%s'\n", szCommandline);
}

4
dlls/shell32/shlfolder.c
View File

@ -1718,7 +1718,7 @@ static HRESULT WINAPI ISF_Desktop_fnParseDisplayName(
*ppidl = 0;
if (pchEaten) *pchEaten = 0; /* strange but like the original */
/* fixme no real parsing implemented */
/* FIXME no real parsing implemented */
pidlTemp = _ILCreateMyComputer();
szNext = lpszDisplayName;
@ -2467,7 +2467,7 @@ static HRESULT WINAPI ISF_MyComputer_fnGetDetailsEx(
return E_NOTIMPL;
}
/* fixme: drive size >4GB is rolling over */
/* FIXME: drive size >4GB is rolling over */
static HRESULT WINAPI ISF_MyComputer_fnGetDetailsOf(
IShellFolder2 * iface,
LPCITEMIDLIST pidl,

2
dlls/shell32/shlmenu.c
View File

@ -770,7 +770,7 @@ DWORD WINAPI FileMenu_GetItemExtent (HMENU hMenu, UINT uPos)
rect.right, rect.left, rect.top, rect.bottom);
return ((rect.right-rect.left)<<16) + (rect.top-rect.bottom);
}
return 0x00100010; /*fixme*/
return 0x00100010; /*FIXME*/
}
/*************************************************************************

2
dlls/shell32/shlview.c
View File

@ -531,7 +531,7 @@ static BOOLEAN LV_RenameItem(IShellViewImpl * This, LPCITEMIDLIST pidlOld, LPCIT
lvItem.lParam = (LPARAM) ILClone(ILFindLastID(pidlNew)); /* set the item's data */
ListView_SetItemA(This->hWndList, &lvItem);
ListView_Update(This->hWndList, nItem);
return TRUE; /* fixme: better handling */
return TRUE; /* FIXME: better handling */
}
return FALSE;
}

2
dlls/shell32/shv_bg_cmenu.c
View File

@ -235,7 +235,7 @@ static BOOL DoPaste(
if (psfhlpdst && psfhlpsrc)
{
ISFHelper_CopyItems(psfhlpdst, psfFrom, lpcida->cidl, apidl);
/* fixme handle move
/* FIXME handle move
ISFHelper_DeleteItems(psfhlpsrc, lpcida->cidl, apidl);
*/
}

2
dlls/winmm/mciseq/mcimidi.c
View File

@ -1602,7 +1602,7 @@ static DWORD MIDI_mciSeek(UINT wDevID, DWORD dwFlags, LPMCI_SEEK_PARMS lpParms)
if (dwFlags & MCI_SEEK_TO_START) {
wmm->dwPositionMS = 0;
} else if (dwFlags & MCI_SEEK_TO_END) {
wmm->dwPositionMS = 0xFFFFFFFF; /* fixme */
wmm->dwPositionMS = 0xFFFFFFFF; /* FIXME */
} else if (dwFlags & MCI_TO) {
wmm->dwPositionMS = MIDI_ConvertTimeFormatToMS(wmm, lpParms->dwTo);
} else {

2
dlls/winmm/mmsystem.c
View File

@ -4921,7 +4921,7 @@ void mmTaskEntryPoint16(LPSTR cmdLine, WORD di, WORD si)
DWORD dwPmt = *((DWORD*)(cmdLine + 5));
#if 0
InitTask16(); /* fixme: pmts / from context ? */
InitTask16(); /* FIXME: pmts / from context ? */
InitApp(di);
#endif
if (SetMessageQueue16(0x40)) {

8
graphics/win16drv/prtdrv.c
View File

@ -330,7 +330,7 @@ BOOL16 PRTDRV_EnumObj(LPPDEVICE lpDestDev, WORD iStyle,
WORD wRet = 0;
LOADED_PRINTER_DRIVER *pLPD = NULL;
TRACE("(some params - fixme)\n");
TRACE("(some params - FIXME)\n");
if ((pLPD = FindPrinterDriverFromPDEVICE(lpDestDev)) != NULL)
{
@ -510,7 +510,7 @@ DWORD PRTDRV_StretchBlt(LPPDEVICE lpDestDev,
WORD wRet = 0;
LOADED_PRINTER_DRIVER *pLPD = NULL;
TRACE("(lots of params - fixme)\n");
TRACE("(lots of params - FIXME)\n");
if ((pLPD = FindPrinterDriverFromPDEVICE(lpDestDev)) != NULL)
{
@ -557,7 +557,7 @@ DWORD PRTDRV_ExtTextOut(LPPDEVICE lpDestDev, WORD wDestXOrg, WORD wDestYOrg,
DWORD dwRet = 0;
LOADED_PRINTER_DRIVER *pLPD = NULL;
TRACE("(lots of params - fixme)\n");
TRACE("(lots of params - FIXME)\n");
if ((pLPD = FindPrinterDriverFromPDEVICE(lpDestDev)) != NULL)
{
@ -703,7 +703,7 @@ WORD PRTDRV_GetCharWidth(LPPDEVICE lpDestDev, LPINT lpBuffer,
WORD wRet = 0;
LOADED_PRINTER_DRIVER *pLPD = NULL;
TRACE("(lots of params - fixme)\n");
TRACE("(lots of params - FIXME)\n");
if ((pLPD = FindPrinterDriverFromPDEVICE(lpDestDev)) != NULL)
{

2
include/ntddk.h
View File

@ -9,7 +9,7 @@
#include "ntdef.h"
#include "winnt.h"
#include "winreg.h"
#include "winbase.h" /* fixme: should be taken out sometimes */
#include "winbase.h" /* FIXME: should be taken out sometimes */
#ifdef __cplusplus
extern "C" {

8
include/wine/obj_shellview.h
View File

@ -68,9 +68,9 @@ typedef struct IShellView IShellView, *LPSHELLVIEW;
#define FCIDM_SHVIEW_NEWLINK 0x7052
#define FCIDM_SHVIEW_NEWFOLDER 0x7053
#define FCIDM_SHVIEW_REFRESH 0x7100 /* fixme */
#define FCIDM_SHVIEW_EXPLORE 0x7101 /* fixme */
#define FCIDM_SHVIEW_OPEN 0x7102 /* fixme */
#define FCIDM_SHVIEW_REFRESH 0x7100 /* FIXME */
#define FCIDM_SHVIEW_EXPLORE 0x7101 /* FIXME */
#define FCIDM_SHVIEW_OPEN 0x7102 /* FIXME */
#define FCIDM_SHVIEWLAST 0x7fff
#define FCIDM_BROWSERFIRST 0xA000
@ -79,7 +79,7 @@ typedef struct IShellView IShellView, *LPSHELLVIEW;
#define FCIDM_TB_NEWFOLDER 0xA002
#define FCIDM_TB_SMALLICON 0xA003
#define FCIDM_TB_REPORTVIEW 0xA004
#define FCIDM_TB_DESKTOP 0xA005 /* fixme */
#define FCIDM_TB_DESKTOP 0xA005 /* FIXME */
#define FCIDM_BROWSERLAST 0xbf00
#define FCIDM_GLOBALFIRST 0x8000

2
msdos/dosmem.c
View File

@ -404,7 +404,7 @@ static void DOSMEM_InitErrorTable()
memset(call, 0, SIZE_TO_ALLOCATE);
#endif
/* Fixme - Copy assembly into buffer here */
/* FIXME - Copy assembly into buffer here */
}
/***********************************************************************

10
windows/winproc.c
View File

@ -627,7 +627,7 @@ INT WINPROC_MapMsg32ATo32W( HWND hwnd, UINT msg, WPARAM *pwparam, LPARAM *plpara
*plparam = (LPARAM)HEAP_strdupAtoW( GetProcessHeap(), 0, (LPCSTR)*plparam );
return (*plparam ? 1 : -1);
case LB_GETTEXT: /* fixme: fixed sized buffer */
case LB_GETTEXT: /* FIXME: fixed sized buffer */
{ if ( WINPROC_TestLBForStr( hwnd ))
{ LPARAM *ptr = (LPARAM *)HeapAlloc( GetProcessHeap(), 0, 256 * sizeof(WCHAR) + sizeof(LPARAM) );
if (!ptr) return -1;
@ -645,7 +645,7 @@ INT WINPROC_MapMsg32ATo32W( HWND hwnd, UINT msg, WPARAM *pwparam, LPARAM *plpara
*plparam = (LPARAM)HEAP_strdupAtoW( GetProcessHeap(), 0, (LPCSTR)*plparam );
return (*plparam ? 1 : -1);
case CB_GETLBTEXT: /* fixme: fixed sized buffer */
case CB_GETLBTEXT: /* FIXME: fixed sized buffer */
{ if ( WINPROC_TestCBForStr( hwnd ))
{ LPARAM *ptr = (LPARAM *)HeapAlloc( GetProcessHeap(), 0, 256 * sizeof(WCHAR) + sizeof(LPARAM) );
if (!ptr) return -1;
@ -883,7 +883,7 @@ INT WINPROC_MapMsg32WTo32A( HWND hwnd, UINT msg, WPARAM *pwparam, LPARAM *plpara
*plparam = (LPARAM)HEAP_strdupWtoA( GetProcessHeap(), 0, (LPCWSTR)*plparam );
return (*plparam ? 1 : -1);
case LB_GETTEXT: /* fixme: fixed sized buffer */
case LB_GETTEXT: /* FIXME: fixed sized buffer */
{ if ( WINPROC_TestLBForStr( hwnd ))
{ LPARAM *ptr = (LPARAM *)HeapAlloc( GetProcessHeap(), 0, 256 + sizeof(LPARAM) );
if (!ptr) return -1;
@ -901,7 +901,7 @@ INT WINPROC_MapMsg32WTo32A( HWND hwnd, UINT msg, WPARAM *pwparam, LPARAM *plpara
*plparam = (LPARAM)HEAP_strdupWtoA( GetProcessHeap(), 0, (LPCWSTR)*plparam );
return (*plparam ? 1 : -1);
case CB_GETLBTEXT: /* fixme: fixed sized buffer */
case CB_GETLBTEXT: /* FIXME: fixed sized buffer */
{ if ( WINPROC_TestCBForStr( hwnd ))
{ LPARAM *ptr = (LPARAM *)HeapAlloc( GetProcessHeap(), 0, 256 + sizeof(LPARAM) );
if (!ptr) return -1;
@ -2286,7 +2286,7 @@ INT WINPROC_MapMsg32WTo16( HWND hwnd, UINT msg32, WPARAM wParam32,
case CB_GETLBTEXT:
if ( WINPROC_TestLBForStr( hwnd ))
{
LPSTR str = HeapAlloc( GetProcessHeap(), 0, 256 ); /* fixme: fixed sized buffer */
LPSTR str = HeapAlloc( GetProcessHeap(), 0, 256 ); /* FIXME: fixed sized buffer */
if (!str) return -1;
*pmsg16 = (msg32 == LB_GETTEXT)? LB_GETTEXT16 : CB_GETLBTEXT16;
*plparam = (LPARAM)MapLS(str);