From 68e8eaa4b70e2687b50e278ee0b84d03e10ed27b Mon Sep 17 00:00:00 2001 From: Alistair Leslie-Hughes Date: Tue, 18 Jun 2024 14:54:30 +1000 Subject: [PATCH] oledb32: When creating a Data Source, handle non fatal errors. The Jet4 driver doesn't handle the DBPROP_AUTH_PERSIST_SENSITIVE_AUTHINFO property which is passed in SetProperties. On return that property is marked as DBPROPSTATUS_NOTSUPPORTED and returns DB_S_ERRORSOCCURRED. In this case, we dont care that isn't not supported and should allow the DataSource to succeed. --- dlls/oledb32/datainit.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/dlls/oledb32/datainit.c b/dlls/oledb32/datainit.c index 12544dea0b5..01e8f5c1b57 100644 --- a/dlls/oledb32/datainit.c +++ b/dlls/oledb32/datainit.c @@ -783,6 +783,11 @@ HRESULT get_data_source(IUnknown *outer, DWORD clsctx, LPCOLESTR initstring, REF } hr = IDBProperties_SetProperties(dbprops, 1, propset); + /* Return S_OK for any successful code. */ + if (SUCCEEDED(hr)) + { + hr = S_OK; + } IDBProperties_Release(dbprops); free_dbpropset(1, propset); if (FAILED(hr))