system/wine
system/wine
1
0
Fork 0
mirror of git://source.winehq.org/git/wine.git synced 2024-09-15 05:34:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

msi: Handle memory allocation failure in get_link_file (cppcheck).

Browse source
This commit is contained in:
Alex Henrie 2023-02-03 22:52:07 -07:00 committed by Alexandre Julliard
parent b0e65dbe50
commit 687c4f5c8d
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
dlls/msi/action.c
View file

@ -3655,7 +3655,7 @@ static UINT ACTION_UnregisterTypeLibraries( MSIPACKAGE *package )
static WCHAR *get_link_file( MSIPACKAGE *package, MSIRECORD *row ) static WCHAR *get_link_file( MSIPACKAGE *package, MSIRECORD *row )
{ {
LPCWSTR directory, extension, link_folder; LPCWSTR directory, extension, link_folder;
LPWSTR link_file, filename; WCHAR *link_file = NULL, *filename, *new_filename;
directory = MSI_RecordGetString( row, 2 ); directory = MSI_RecordGetString( row, 2 );
link_folder = msi_get_target_folder( package, directory ); link_folder = msi_get_target_folder( package, directory );
@ -3668,18 +3668,22 @@ static WCHAR *get_link_file( MSIPACKAGE *package, MSIRECORD *row )
msi_create_full_path( package, link_folder ); msi_create_full_path( package, link_folder );
filename = msi_dup_record_field( row, 3 ); filename = msi_dup_record_field( row, 3 );
if (!filename) return NULL;
msi_reduce_to_long_filename( filename ); msi_reduce_to_long_filename( filename );
extension = wcsrchr( filename, '.' ); extension = wcsrchr( filename, '.' );
if (!extension || wcsicmp( extension, L".lnk" )) if (!extension || wcsicmp( extension, L".lnk" ))
{ {
int len = lstrlenW( filename ); int len = lstrlenW( filename );
filename = realloc( filename, len * sizeof(WCHAR) + sizeof(L".lnk") ); new_filename = realloc( filename, len * sizeof(WCHAR) + sizeof(L".lnk") );
if (!new_filename) goto done;
filename = new_filename;
memcpy( filename + len, L".lnk", sizeof(L".lnk") ); memcpy( filename + len, L".lnk", sizeof(L".lnk") );
} }
link_file = msi_build_directory_name( 2, link_folder, filename ); link_file = msi_build_directory_name( 2, link_folder, filename );
free( filename );
done:
free( filename );
return link_file; return link_file;
} }